mediatek: update pending SoC Ethernet PHY driver
authorDaniel Golle <daniel@makrotopia.org>
Sun, 30 Apr 2023 16:34:55 +0000 (17:34 +0100)
committerDaniel Golle <daniel@makrotopia.org>
Tue, 23 May 2023 14:53:22 +0000 (15:53 +0100)
Update driver for MediaTek's built-in Gigabit Ethernet PHYs which can be
found in the MT7981 and MT7988 SoCs.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>
target/linux/bcm27xx/patches-5.15/950-0281-media-i2c-Add-driver-for-Sony-IMX477-sensor.patch
target/linux/bcm27xx/patches-5.15/950-0413-Documentation-devicetree-Add-documentation-for-imx37.patch
target/linux/bcm27xx/patches-5.15/950-0520-dt-bindings-media-i2c-Add-IMX519-CMOS-sensor-binding.patch
target/linux/mediatek/files-5.15/drivers/net/phy/mediatek-ge-soc.c [new file with mode: 0644]
target/linux/mediatek/filogic/config-5.15
target/linux/mediatek/mt7622/config-5.15
target/linux/mediatek/patches-5.15/730-net-phy-add-driver-for-MediaTek-SoC-built-in-GE-PHYs.patch

index e756fa2fff6605fa9c23f25dd825d96b4c497113..bb0afb1a2a352e0c557f399033cd62ef22f8c876 100644 (file)
@@ -25,7 +25,7 @@ Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
 
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
-@@ -17538,6 +17538,14 @@ T:    git git://linuxtv.org/media_tree.git
+@@ -17541,6 +17541,14 @@ T:    git git://linuxtv.org/media_tree.git
  F:    Documentation/devicetree/bindings/media/i2c/sony,imx412.yaml
  F:    drivers/media/i2c/imx412.c
  
index 27fd0e57938bada839972424fdece77f4053a086..f9021eea55f1daef15c6b057829d6dd78588477e 100644 (file)
@@ -132,7 +132,7 @@ Signed-off-by: David Plowman <david.plowman@raspberrypi.com>
 +...
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
-@@ -17552,6 +17552,7 @@ M:     Raspberry Pi Kernel Maintenance <kern
+@@ -17555,6 +17555,7 @@ M:     Raspberry Pi Kernel Maintenance <kern
  L:    linux-media@vger.kernel.org
  S:    Maintained
  T:    git git://linuxtv.org/media_tree.git
index 25e6555fdb5a402da412e024d9650d325e0ebe62..bfee0d1544789c090f383bae8e21803271230f9b 100644 (file)
@@ -132,7 +132,7 @@ Signed-off-by: Lee Jackson <info@arducam.com>
 +...
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
-@@ -17556,6 +17556,14 @@ F:    Documentation/devicetree/bindings/med
+@@ -17559,6 +17559,14 @@ F:    Documentation/devicetree/bindings/med
  F:    Documentation/devicetree/bindings/media/i2c/imx477.yaml
  F:    drivers/media/i2c/imx477.c
  
diff --git a/target/linux/mediatek/files-5.15/drivers/net/phy/mediatek-ge-soc.c b/target/linux/mediatek/files-5.15/drivers/net/phy/mediatek-ge-soc.c
new file mode 100644 (file)
index 0000000..e48502a
--- /dev/null
@@ -0,0 +1,1263 @@
+// SPDX-License-Identifier: GPL-2.0+
+#include <linux/bitfield.h>
+#include <linux/module.h>
+#include <linux/nvmem-consumer.h>
+#include <linux/of_address.h>
+#include <linux/of_platform.h>
+#include <linux/pinctrl/consumer.h>
+#include <linux/phy.h>
+
+#define MTK_GPHY_ID_MT7981                     0x03a29461
+#define MTK_GPHY_ID_MT7988                     0x03a29481
+
+#define MTK_EXT_PAGE_ACCESS                    0x1f
+#define MTK_PHY_PAGE_STANDARD                  0x0000
+#define MTK_PHY_PAGE_EXTENDED_3                        0x0003
+
+#define MTK_PHY_LPI_REG_14                     0x14
+#define MTK_PHY_LPI_WAKE_TIMER_1000_MASK       GENMASK(8, 0)
+
+#define MTK_PHY_LPI_REG_1c                     0x1c
+#define MTK_PHY_SMI_DET_ON_THRESH_MASK         GENMASK(13, 8)
+
+#define MTK_PHY_PAGE_EXTENDED_2A30             0x2a30
+#define MTK_PHY_PAGE_EXTENDED_52B5             0x52b5
+
+#define ANALOG_INTERNAL_OPERATION_MAX_US       20
+#define TXRESERVE_MIN                          0
+#define TXRESERVE_MAX                          7
+
+#define MTK_PHY_ANARG_RG                       0x10
+#define   MTK_PHY_TCLKOFFSET_MASK              GENMASK(12, 8)
+
+/* Registers on MDIO_MMD_VEND1 */
+#define MTK_PHY_TXVLD_DA_RG                    0x12
+#define   MTK_PHY_DA_TX_I2MPB_A_GBE_MASK       GENMASK(15, 10)
+#define   MTK_PHY_DA_TX_I2MPB_A_TBT_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_A2          0x16
+#define   MTK_PHY_DA_TX_I2MPB_A_HBT_MASK       GENMASK(15, 10)
+#define   MTK_PHY_DA_TX_I2MPB_A_TST_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_B1          0x17
+#define   MTK_PHY_DA_TX_I2MPB_B_GBE_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_B_TBT_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_B2          0x18
+#define   MTK_PHY_DA_TX_I2MPB_B_HBT_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_B_TST_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_C1          0x19
+#define   MTK_PHY_DA_TX_I2MPB_C_GBE_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_C_TBT_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_C2          0x20
+#define   MTK_PHY_DA_TX_I2MPB_C_HBT_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_C_TST_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_D1          0x21
+#define   MTK_PHY_DA_TX_I2MPB_D_GBE_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_D_TBT_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_TX_I2MPB_TEST_MODE_D2          0x22
+#define   MTK_PHY_DA_TX_I2MPB_D_HBT_MASK       GENMASK(13, 8)
+#define   MTK_PHY_DA_TX_I2MPB_D_TST_MASK       GENMASK(5, 0)
+
+#define MTK_PHY_RXADC_CTRL_RG7                 0xc6
+#define   MTK_PHY_DA_AD_BUF_BIAS_LP_MASK       GENMASK(9, 8)
+
+#define MTK_PHY_RXADC_CTRL_RG9                 0xc8
+#define   MTK_PHY_DA_RX_PSBN_TBT_MASK          GENMASK(14, 12)
+#define   MTK_PHY_DA_RX_PSBN_HBT_MASK          GENMASK(10, 8)
+#define   MTK_PHY_DA_RX_PSBN_GBE_MASK          GENMASK(6, 4)
+#define   MTK_PHY_DA_RX_PSBN_LP_MASK           GENMASK(2, 0)
+
+#define MTK_PHY_LDO_OUTPUT_V                   0xd7
+
+#define MTK_PHY_RG_ANA_CAL_RG0                 0xdb
+#define   MTK_PHY_RG_CAL_CKINV                 BIT(12)
+#define   MTK_PHY_RG_ANA_CALEN                 BIT(8)
+#define   MTK_PHY_RG_ZCALEN_A                  BIT(0)
+
+#define MTK_PHY_RG_ANA_CAL_RG1                 0xdc
+#define   MTK_PHY_RG_ZCALEN_B                  BIT(12)
+#define   MTK_PHY_RG_ZCALEN_C                  BIT(8)
+#define   MTK_PHY_RG_ZCALEN_D                  BIT(4)
+#define   MTK_PHY_RG_TXVOS_CALEN               BIT(0)
+
+#define MTK_PHY_RG_ANA_CAL_RG5                 0xe0
+#define   MTK_PHY_RG_REXT_TRIM_MASK            GENMASK(13, 8)
+
+#define MTK_PHY_RG_TX_FILTER                   0xfe
+
+#define MTK_PHY_RG_LPI_PCS_DSP_CTRL_REG120     0x120
+#define   MTK_PHY_LPI_SIG_EN_LO_THRESH1000_MASK        GENMASK(12, 8)
+#define   MTK_PHY_LPI_SIG_EN_HI_THRESH1000_MASK        GENMASK(4, 0)
+
+#define MTK_PHY_RG_LPI_PCS_DSP_CTRL_REG122     0x122
+#define   MTK_PHY_LPI_NORM_MSE_HI_THRESH1000_MASK      GENMASK(7, 0)
+
+#define MTK_PHY_RG_TESTMUX_ADC_CTRL            0x144
+#define   MTK_PHY_RG_TXEN_DIG_MASK             GENMASK(5, 5)
+
+#define MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B                0x172
+#define   MTK_PHY_CR_TX_AMP_OFFSET_A_MASK      GENMASK(13, 8)
+#define   MTK_PHY_CR_TX_AMP_OFFSET_B_MASK      GENMASK(6, 0)
+
+#define MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D                0x173
+#define   MTK_PHY_CR_TX_AMP_OFFSET_C_MASK      GENMASK(13, 8)
+#define   MTK_PHY_CR_TX_AMP_OFFSET_D_MASK      GENMASK(6, 0)
+
+#define MTK_PHY_RG_AD_CAL_COMP                 0x17a
+#define   MTK_PHY_AD_CAL_COMP_OUT_SHIFT                (8)
+
+#define MTK_PHY_RG_AD_CAL_CLK                  0x17b
+#define   MTK_PHY_DA_CAL_CLK                   BIT(0)
+
+#define MTK_PHY_RG_AD_CALIN                    0x17c
+#define   MTK_PHY_DA_CALIN_FLAG                        BIT(0)
+
+#define MTK_PHY_RG_DASN_DAC_IN0_A              0x17d
+#define   MTK_PHY_DASN_DAC_IN0_A_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN0_B              0x17e
+#define   MTK_PHY_DASN_DAC_IN0_B_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN0_C              0x17f
+#define   MTK_PHY_DASN_DAC_IN0_C_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN0_D              0x180
+#define   MTK_PHY_DASN_DAC_IN0_D_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN1_A              0x181
+#define   MTK_PHY_DASN_DAC_IN1_A_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN1_B              0x182
+#define   MTK_PHY_DASN_DAC_IN1_B_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN1_C              0x183
+#define   MTK_PHY_DASN_DAC_IN1_C_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DASN_DAC_IN1_D              0x184
+#define   MTK_PHY_DASN_DAC_IN1_D_MASK          GENMASK(9, 0)
+
+#define MTK_PHY_RG_DEV1E_REG19b                        0x19b
+#define   MTK_PHY_BYPASS_DSP_LPI_READY         BIT(8)
+
+#define MTK_PHY_RG_LP_IIR2_K1_L                        0x22a
+#define MTK_PHY_RG_LP_IIR2_K1_U                        0x22b
+#define MTK_PHY_RG_LP_IIR2_K2_L                        0x22c
+#define MTK_PHY_RG_LP_IIR2_K2_U                        0x22d
+#define MTK_PHY_RG_LP_IIR2_K3_L                        0x22e
+#define MTK_PHY_RG_LP_IIR2_K3_U                        0x22f
+#define MTK_PHY_RG_LP_IIR2_K4_L                        0x230
+#define MTK_PHY_RG_LP_IIR2_K4_U                        0x231
+#define MTK_PHY_RG_LP_IIR2_K5_L                        0x232
+#define MTK_PHY_RG_LP_IIR2_K5_U                        0x233
+
+#define MTK_PHY_RG_DEV1E_REG234                        0x234
+#define   MTK_PHY_TR_OPEN_LOOP_EN_MASK         GENMASK(0, 0)
+#define   MTK_PHY_LPF_X_AVERAGE_MASK           GENMASK(7, 4)
+#define   MTK_PHY_TR_LP_IIR_EEE_EN             BIT(12)
+
+#define MTK_PHY_RG_LPF_CNT_VAL                 0x235
+
+#define MTK_PHY_RG_DEV1E_REG238                        0x238
+#define   MTK_PHY_LPI_SLV_SEND_TX_TIMER_MASK   GENMASK(8, 0)
+#define   MTK_PHY_LPI_SLV_SEND_TX_EN           BIT(12)
+
+#define MTK_PHY_RG_DEV1E_REG239                        0x239
+#define   MTK_PHY_LPI_SEND_LOC_TIMER_MASK      GENMASK(8, 0)
+#define   MTK_PHY_LPI_TXPCS_LOC_RCV            BIT(12)
+
+#define MTK_PHY_RG_DEV1E_REG27C                        0x27c
+#define   MTK_PHY_VGASTATE_FFE_THR_ST1_MASK    GENMASK(12, 8)
+#define MTK_PHY_RG_DEV1E_REG27D                        0x27d
+#define   MTK_PHY_VGASTATE_FFE_THR_ST2_MASK    GENMASK(4, 0)
+
+#define MTK_PHY_RG_DEV1E_REG2C7                        0x2c7
+#define   MTK_PHY_MAX_GAIN_MASK                        GENMASK(4, 0)
+#define   MTK_PHY_MIN_GAIN_MASK                        GENMASK(12, 8)
+
+#define MTK_PHY_RG_DEV1E_REG2D1                        0x2d1
+#define   MTK_PHY_VCO_SLICER_THRESH_BITS_HIGH_EEE_MASK GENMASK(7, 0)
+#define   MTK_PHY_LPI_SKIP_SD_SLV_TR           BIT(8)
+#define   MTK_PHY_LPI_TR_READY                 BIT(9)
+#define   MTK_PHY_LPI_VCO_EEE_STG0_EN          BIT(10)
+
+#define MTK_PHY_RG_DEV1E_REG323                        0x323
+#define   MTK_PHY_EEE_WAKE_MAS_INT_DC          BIT(0)
+#define   MTK_PHY_EEE_WAKE_SLV_INT_DC          BIT(4)
+
+#define MTK_PHY_RG_DEV1E_REG324                        0x324
+#define   MTK_PHY_SMI_DETCNT_MAX_MASK          GENMASK(5, 0)
+#define   MTK_PHY_SMI_DET_MAX_EN               BIT(8)
+
+#define MTK_PHY_RG_DEV1E_REG326                        0x326
+#define   MTK_PHY_LPI_MODE_SD_ON               BIT(0)
+#define   MTK_PHY_RESET_RANDUPD_CNT            BIT(1)
+#define   MTK_PHY_TREC_UPDATE_ENAB_CLR         BIT(2)
+#define   MTK_PHY_LPI_QUIT_WAIT_DFE_SIG_DET_OFF        BIT(4)
+#define   MTK_PHY_TR_READY_SKIP_AFE_WAKEUP     BIT(5)
+
+#define MTK_PHY_LDO_PUMP_EN_PAIRAB             0x502
+#define MTK_PHY_LDO_PUMP_EN_PAIRCD             0x503
+
+#define MTK_PHY_DA_TX_R50_PAIR_A               0x53d
+#define MTK_PHY_DA_TX_R50_PAIR_B               0x53e
+#define MTK_PHY_DA_TX_R50_PAIR_C               0x53f
+#define MTK_PHY_DA_TX_R50_PAIR_D               0x540
+
+/* Registers on MDIO_MMD_VEND2 */
+#define MTK_PHY_LED0_ON_CTRL                   0x24
+#define   MTK_PHY_LED0_ON_MASK                 GENMASK(6, 0)
+#define   MTK_PHY_LED0_ON_LINK1000             BIT(0)
+#define   MTK_PHY_LED0_ON_LINK100              BIT(1)
+#define   MTK_PHY_LED0_ON_LINK10               BIT(2)
+#define   MTK_PHY_LED0_ON_LINKDOWN             BIT(3)
+#define   MTK_PHY_LED0_ON_FDX                  BIT(4) /* Full duplex */
+#define   MTK_PHY_LED0_ON_HDX                  BIT(5) /* Half duplex */
+#define   MTK_PHY_LED0_FORCE_ON                        BIT(6)
+#define   MTK_PHY_LED0_POLARITY                        BIT(14)
+#define   MTK_PHY_LED0_ENABLE                  BIT(15)
+
+#define MTK_PHY_LED0_BLINK_CTRL                        0x25
+#define   MTK_PHY_LED0_1000TX                  BIT(0)
+#define   MTK_PHY_LED0_1000RX                  BIT(1)
+#define   MTK_PHY_LED0_100TX                   BIT(2)
+#define   MTK_PHY_LED0_100RX                   BIT(3)
+#define   MTK_PHY_LED0_10TX                    BIT(4)
+#define   MTK_PHY_LED0_10RX                    BIT(5)
+#define   MTK_PHY_LED0_COLLISION               BIT(6)
+#define   MTK_PHY_LED0_RX_CRC_ERR              BIT(7)
+#define   MTK_PHY_LED0_RX_IDLE_ERR             BIT(8)
+#define   MTK_PHY_LED0_FORCE_BLINK             BIT(9)
+
+#define MTK_PHY_LED1_ON_CTRL                   0x26
+#define   MTK_PHY_LED1_ON_MASK                 GENMASK(6, 0)
+#define   MTK_PHY_LED1_ON_LINK1000             BIT(0)
+#define   MTK_PHY_LED1_ON_LINK100              BIT(1)
+#define   MTK_PHY_LED1_ON_LINK10               BIT(2)
+#define   MTK_PHY_LED1_ON_LINKDOWN             BIT(3)
+#define   MTK_PHY_LED1_ON_FDX                  BIT(4) /* Full duplex */
+#define   MTK_PHY_LED1_ON_HDX                  BIT(5) /* Half duplex */
+#define   MTK_PHY_LED1_FORCE_ON                        BIT(6)
+#define   MTK_PHY_LED1_POLARITY                        BIT(14)
+#define   MTK_PHY_LED1_ENABLE                  BIT(15)
+
+#define MTK_PHY_LED1_BLINK_CTRL                        0x27
+#define   MTK_PHY_LED1_1000TX                  BIT(0)
+#define   MTK_PHY_LED1_1000RX                  BIT(1)
+#define   MTK_PHY_LED1_100TX                   BIT(2)
+#define   MTK_PHY_LED1_100RX                   BIT(3)
+#define   MTK_PHY_LED1_10TX                    BIT(4)
+#define   MTK_PHY_LED1_10RX                    BIT(5)
+#define   MTK_PHY_LED1_COLLISION               BIT(6)
+#define   MTK_PHY_LED1_RX_CRC_ERR              BIT(7)
+#define   MTK_PHY_LED1_RX_IDLE_ERR             BIT(8)
+#define   MTK_PHY_LED1_FORCE_BLINK             BIT(9)
+
+#define MTK_PHY_RG_BG_RASEL                    0x115
+#define   MTK_PHY_RG_BG_RASEL_MASK             GENMASK(2, 0)
+
+/* These macro privides efuse parsing for internal phy. */
+#define EFS_DA_TX_I2MPB_A(x)                   (((x) >> 0) & GENMASK(5, 0))
+#define EFS_DA_TX_I2MPB_B(x)                   (((x) >> 6) & GENMASK(5, 0))
+#define EFS_DA_TX_I2MPB_C(x)                   (((x) >> 12) & GENMASK(5, 0))
+#define EFS_DA_TX_I2MPB_D(x)                   (((x) >> 18) & GENMASK(5, 0))
+#define EFS_DA_TX_AMP_OFFSET_A(x)              (((x) >> 24) & GENMASK(5, 0))
+
+#define EFS_DA_TX_AMP_OFFSET_B(x)              (((x) >> 0) & GENMASK(5, 0))
+#define EFS_DA_TX_AMP_OFFSET_C(x)              (((x) >> 6) & GENMASK(5, 0))
+#define EFS_DA_TX_AMP_OFFSET_D(x)              (((x) >> 12) & GENMASK(5, 0))
+#define EFS_DA_TX_R50_A(x)                     (((x) >> 18) & GENMASK(5, 0))
+#define EFS_DA_TX_R50_B(x)                     (((x) >> 24) & GENMASK(5, 0))
+
+#define EFS_DA_TX_R50_C(x)                     (((x) >> 0) & GENMASK(5, 0))
+#define EFS_DA_TX_R50_D(x)                     (((x) >> 6) & GENMASK(5, 0))
+
+#define EFS_RG_BG_RASEL(x)                     (((x) >> 4) & GENMASK(2, 0))
+#define EFS_RG_REXT_TRIM(x)                    (((x) >> 7) & GENMASK(5, 0))
+
+enum {
+       NO_PAIR,
+       PAIR_A,
+       PAIR_B,
+       PAIR_C,
+       PAIR_D,
+};
+
+enum {
+       GPHY_PORT0,
+       GPHY_PORT1,
+       GPHY_PORT2,
+       GPHY_PORT3,
+};
+
+enum calibration_mode {
+       EFUSE_K,
+       SW_K
+};
+
+enum CAL_ITEM {
+       REXT,
+       TX_OFFSET,
+       TX_AMP,
+       TX_R50,
+       TX_VCM
+};
+
+enum CAL_MODE {
+       EFUSE_M,
+       SW_M
+};
+
+struct mtk_socphy_shared_priv {
+       u32                     boottrap;
+};
+
+static int mtk_socphy_read_page(struct phy_device *phydev)
+{
+       return __phy_read(phydev, MTK_EXT_PAGE_ACCESS);
+}
+
+static int mtk_socphy_write_page(struct phy_device *phydev, int page)
+{
+       return __phy_write(phydev, MTK_EXT_PAGE_ACCESS, page);
+}
+
+/* One calibration cycle consists of:
+ * 1.Set DA_CALIN_FLAG high to start calibration. Keep it high
+ *   until AD_CAL_COMP is ready to output calibration result.
+ * 2.Wait until DA_CAL_CLK is available.
+ * 3.Fetch AD_CAL_COMP_OUT.
+ */
+static int cal_cycle(struct phy_device *phydev, int devad,
+                    u32 regnum, u16 mask, u16 cal_val)
+{
+       int reg_val;
+       int ret;
+
+       phy_modify_mmd(phydev, devad, regnum,
+                      mask, cal_val);
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CALIN,
+                        MTK_PHY_DA_CALIN_FLAG);
+
+       ret = phy_read_mmd_poll_timeout(phydev, MDIO_MMD_VEND1,
+                                       MTK_PHY_RG_AD_CAL_CLK, reg_val,
+                                       reg_val & MTK_PHY_DA_CAL_CLK, 500,
+                                       ANALOG_INTERNAL_OPERATION_MAX_US, false);
+       if (ret) {
+               phydev_err(phydev, "Calibration cycle timeout\n");
+               return ret;
+       }
+
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CALIN,
+                          MTK_PHY_DA_CALIN_FLAG);
+       ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CAL_COMP) >>
+                          MTK_PHY_AD_CAL_COMP_OUT_SHIFT;
+       phydev_dbg(phydev, "cal_val: 0x%x, ret: %d\n", cal_val, ret);
+
+       return ret;
+}
+
+static int rext_fill_result(struct phy_device *phydev, u16 *buf)
+{
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
+                      MTK_PHY_RG_REXT_TRIM_MASK, buf[0] << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_BG_RASEL,
+                      MTK_PHY_RG_BG_RASEL_MASK, buf[1]);
+
+       return 0;
+}
+
+static int rext_cal_efuse(struct phy_device *phydev, u32 *buf)
+{
+       u16 rext_cal_val[2];
+
+       rext_cal_val[0] = EFS_RG_REXT_TRIM(buf[3]);
+       rext_cal_val[1] = EFS_RG_BG_RASEL(buf[3]);
+       rext_fill_result(phydev, rext_cal_val);
+
+       return 0;
+}
+
+static int tx_offset_fill_result(struct phy_device *phydev, u16 *buf)
+{
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B,
+                      MTK_PHY_CR_TX_AMP_OFFSET_A_MASK, buf[0] << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B,
+                      MTK_PHY_CR_TX_AMP_OFFSET_B_MASK, buf[1]);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D,
+                      MTK_PHY_CR_TX_AMP_OFFSET_C_MASK, buf[2] << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D,
+                      MTK_PHY_CR_TX_AMP_OFFSET_D_MASK, buf[3]);
+
+       return 0;
+}
+
+static int tx_offset_cal_efuse(struct phy_device *phydev, u32 *buf)
+{
+       u16 tx_offset_cal_val[4];
+
+       tx_offset_cal_val[0] = EFS_DA_TX_AMP_OFFSET_A(buf[0]);
+       tx_offset_cal_val[1] = EFS_DA_TX_AMP_OFFSET_B(buf[1]);
+       tx_offset_cal_val[2] = EFS_DA_TX_AMP_OFFSET_C(buf[1]);
+       tx_offset_cal_val[3] = EFS_DA_TX_AMP_OFFSET_D(buf[1]);
+
+       tx_offset_fill_result(phydev, tx_offset_cal_val);
+
+       return 0;
+}
+
+static int tx_amp_fill_result(struct phy_device *phydev, u16 *buf)
+{
+       int i;
+       int bias[16] = {};
+       const int vals_9461[16] = { 7, 1, 4, 7,
+                                   7, 1, 4, 7,
+                                   7, 1, 4, 7,
+                                   7, 1, 4, 7 };
+       const int vals_9481[16] = { 10, 6, 6, 10,
+                                   10, 6, 6, 10,
+                                   10, 6, 6, 10,
+                                   10, 6, 6, 10 };
+       switch (phydev->drv->phy_id) {
+       case MTK_GPHY_ID_MT7981:
+               /* We add some calibration to efuse values
+                * due to board level influence.
+                * GBE: +7, TBT: +1, HBT: +4, TST: +7
+                */
+               memcpy(bias, (const void *)vals_9461, sizeof(bias));
+               break;
+       case MTK_GPHY_ID_MT7988:
+               memcpy(bias, (const void *)vals_9481, sizeof(bias));
+               break;
+       }
+
+       /* Prevent overflow */
+       for (i = 0; i < 12; i++) {
+               if (buf[i >> 2] + bias[i] > 63) {
+                       buf[i >> 2] = 63;
+                       bias[i] = 0;
+               }
+       }
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TXVLD_DA_RG,
+                      MTK_PHY_DA_TX_I2MPB_A_GBE_MASK, (buf[0] + bias[0]) << 10);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TXVLD_DA_RG,
+                      MTK_PHY_DA_TX_I2MPB_A_TBT_MASK, buf[0] + bias[1]);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_A2,
+                      MTK_PHY_DA_TX_I2MPB_A_HBT_MASK, (buf[0] + bias[2]) << 10);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_A2,
+                      MTK_PHY_DA_TX_I2MPB_A_TST_MASK, buf[0] + bias[3]);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B1,
+                      MTK_PHY_DA_TX_I2MPB_B_GBE_MASK, (buf[1] + bias[4]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B1,
+                      MTK_PHY_DA_TX_I2MPB_B_TBT_MASK, buf[1] + bias[5]);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B2,
+                      MTK_PHY_DA_TX_I2MPB_B_HBT_MASK, (buf[1] + bias[6]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B2,
+                      MTK_PHY_DA_TX_I2MPB_B_TST_MASK, buf[1] + bias[7]);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C1,
+                      MTK_PHY_DA_TX_I2MPB_C_GBE_MASK, (buf[2] + bias[8]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C1,
+                      MTK_PHY_DA_TX_I2MPB_C_TBT_MASK, buf[2] + bias[9]);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C2,
+                      MTK_PHY_DA_TX_I2MPB_C_HBT_MASK, (buf[2] + bias[10]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C2,
+                      MTK_PHY_DA_TX_I2MPB_C_TST_MASK, buf[2] + bias[11]);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D1,
+                      MTK_PHY_DA_TX_I2MPB_D_GBE_MASK, (buf[3] + bias[12]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D1,
+                      MTK_PHY_DA_TX_I2MPB_D_TBT_MASK, buf[3] + bias[13]);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D2,
+                      MTK_PHY_DA_TX_I2MPB_D_HBT_MASK, (buf[3] + bias[14]) << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D2,
+                      MTK_PHY_DA_TX_I2MPB_D_TST_MASK, buf[3] + bias[15]);
+
+       return 0;
+}
+
+static int tx_amp_cal_efuse(struct phy_device *phydev, u32 *buf)
+{
+       u16 tx_amp_cal_val[4];
+
+       tx_amp_cal_val[0] = EFS_DA_TX_I2MPB_A(buf[0]);
+       tx_amp_cal_val[1] = EFS_DA_TX_I2MPB_B(buf[0]);
+       tx_amp_cal_val[2] = EFS_DA_TX_I2MPB_C(buf[0]);
+       tx_amp_cal_val[3] = EFS_DA_TX_I2MPB_D(buf[0]);
+       tx_amp_fill_result(phydev, tx_amp_cal_val);
+
+       return 0;
+}
+
+static int tx_r50_fill_result(struct phy_device *phydev, u16 tx_r50_cal_val,
+                             u8 txg_calen_x)
+{
+       int bias = 0;
+       u16 reg, val;
+
+       if (phydev->drv->phy_id == MTK_GPHY_ID_MT7988)
+               bias = -2;
+
+       val = clamp_val(bias + tx_r50_cal_val, 0, 63);
+
+       switch (txg_calen_x) {
+       case PAIR_A:
+               reg = MTK_PHY_DA_TX_R50_PAIR_A;
+               break;
+       case PAIR_B:
+               reg = MTK_PHY_DA_TX_R50_PAIR_B;
+               break;
+       case PAIR_C:
+               reg = MTK_PHY_DA_TX_R50_PAIR_C;
+               break;
+       case PAIR_D:
+               reg = MTK_PHY_DA_TX_R50_PAIR_D;
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, reg, val | val << 8);
+
+       return 0;
+}
+
+static int tx_r50_cal_efuse(struct phy_device *phydev, u32 *buf,
+                           u8 txg_calen_x)
+{
+       u16 tx_r50_cal_val;
+
+       switch (txg_calen_x) {
+       case PAIR_A:
+               tx_r50_cal_val = EFS_DA_TX_R50_A(buf[1]);
+               break;
+       case PAIR_B:
+               tx_r50_cal_val = EFS_DA_TX_R50_B(buf[1]);
+               break;
+       case PAIR_C:
+               tx_r50_cal_val = EFS_DA_TX_R50_C(buf[2]);
+               break;
+       case PAIR_D:
+               tx_r50_cal_val = EFS_DA_TX_R50_D(buf[2]);
+               break;
+       default:
+               return -EINVAL;
+       }
+       tx_r50_fill_result(phydev, tx_r50_cal_val, txg_calen_x);
+
+       return 0;
+}
+
+static int tx_vcm_cal_sw(struct phy_device *phydev, u8 rg_txreserve_x)
+{
+       u8 lower_idx, upper_idx, txreserve_val;
+       u8 lower_ret, upper_ret;
+       int ret;
+
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
+                        MTK_PHY_RG_ANA_CALEN);
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
+                          MTK_PHY_RG_CAL_CKINV);
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
+                        MTK_PHY_RG_TXVOS_CALEN);
+
+       switch (rg_txreserve_x) {
+       case PAIR_A:
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN0_A,
+                                  MTK_PHY_DASN_DAC_IN0_A_MASK);
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN1_A,
+                                  MTK_PHY_DASN_DAC_IN1_A_MASK);
+               phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                MTK_PHY_RG_ANA_CAL_RG0,
+                                MTK_PHY_RG_ZCALEN_A);
+               break;
+       case PAIR_B:
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN0_B,
+                                  MTK_PHY_DASN_DAC_IN0_B_MASK);
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN1_B,
+                                  MTK_PHY_DASN_DAC_IN1_B_MASK);
+               phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                MTK_PHY_RG_ANA_CAL_RG1,
+                                MTK_PHY_RG_ZCALEN_B);
+               break;
+       case PAIR_C:
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN0_C,
+                                  MTK_PHY_DASN_DAC_IN0_C_MASK);
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN1_C,
+                                  MTK_PHY_DASN_DAC_IN1_C_MASK);
+               phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                MTK_PHY_RG_ANA_CAL_RG1,
+                                MTK_PHY_RG_ZCALEN_C);
+               break;
+       case PAIR_D:
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN0_D,
+                                  MTK_PHY_DASN_DAC_IN0_D_MASK);
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                  MTK_PHY_RG_DASN_DAC_IN1_D,
+                                  MTK_PHY_DASN_DAC_IN1_D_MASK);
+               phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+                                MTK_PHY_RG_ANA_CAL_RG1,
+                                MTK_PHY_RG_ZCALEN_D);
+               break;
+       default:
+               ret = -EINVAL;
+               goto restore;
+       }
+
+       lower_idx = TXRESERVE_MIN;
+       upper_idx = TXRESERVE_MAX;
+
+       phydev_dbg(phydev, "Start TX-VCM SW cal.\n");
+       while ((upper_idx - lower_idx) > 1) {
+               txreserve_val = DIV_ROUND_CLOSEST(lower_idx + upper_idx, 2);
+               ret = cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
+                               MTK_PHY_DA_RX_PSBN_TBT_MASK |
+                               MTK_PHY_DA_RX_PSBN_HBT_MASK |
+                               MTK_PHY_DA_RX_PSBN_GBE_MASK |
+                               MTK_PHY_DA_RX_PSBN_LP_MASK,
+                               txreserve_val << 12 | txreserve_val << 8 |
+                               txreserve_val << 4 | txreserve_val);
+               if (ret == 1) {
+                       upper_idx = txreserve_val;
+                       upper_ret = ret;
+               } else if (ret == 0) {
+                       lower_idx = txreserve_val;
+                       lower_ret = ret;
+               } else {
+                       goto restore;
+               }
+       }
+
+       if (lower_idx == TXRESERVE_MIN) {
+               lower_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
+                                     MTK_PHY_RXADC_CTRL_RG9,
+                                     MTK_PHY_DA_RX_PSBN_TBT_MASK |
+                                     MTK_PHY_DA_RX_PSBN_HBT_MASK |
+                                     MTK_PHY_DA_RX_PSBN_GBE_MASK |
+                                     MTK_PHY_DA_RX_PSBN_LP_MASK,
+                                     lower_idx << 12 | lower_idx << 8 |
+                                     lower_idx << 4 | lower_idx);
+               ret = lower_ret;
+       } else if (upper_idx == TXRESERVE_MAX) {
+               upper_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
+                                     MTK_PHY_RXADC_CTRL_RG9,
+                                     MTK_PHY_DA_RX_PSBN_TBT_MASK |
+                                     MTK_PHY_DA_RX_PSBN_HBT_MASK |
+                                     MTK_PHY_DA_RX_PSBN_GBE_MASK |
+                                     MTK_PHY_DA_RX_PSBN_LP_MASK,
+                                     upper_idx << 12 | upper_idx << 8 |
+                                     upper_idx << 4 | upper_idx);
+               ret = upper_ret;
+       }
+       if (ret < 0)
+               goto restore;
+
+       /* We calibrate TX-VCM in different logic. Check upper index and then
+        * lower index. If this calibration is valid, apply lower index's result.
+        */
+       ret = upper_ret - lower_ret;
+       if (ret == 1) {
+               ret = 0;
+               /* Make sure we use upper_idx in our calibration system */
+               cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
+                         MTK_PHY_DA_RX_PSBN_TBT_MASK |
+                         MTK_PHY_DA_RX_PSBN_HBT_MASK |
+                         MTK_PHY_DA_RX_PSBN_GBE_MASK |
+                         MTK_PHY_DA_RX_PSBN_LP_MASK,
+                         upper_idx << 12 | upper_idx << 8 |
+                         upper_idx << 4 | upper_idx);
+               phydev_dbg(phydev, "TX-VCM SW cal result: 0x%x\n", upper_idx);
+       } else if (lower_idx == TXRESERVE_MIN && upper_ret == 1 &&
+                  lower_ret == 1) {
+               ret = 0;
+               cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
+                         MTK_PHY_DA_RX_PSBN_TBT_MASK |
+                         MTK_PHY_DA_RX_PSBN_HBT_MASK |
+                         MTK_PHY_DA_RX_PSBN_GBE_MASK |
+                         MTK_PHY_DA_RX_PSBN_LP_MASK,
+                         lower_idx << 12 | lower_idx << 8 |
+                         lower_idx << 4 | lower_idx);
+               phydev_warn(phydev, "TX-VCM SW cal result at low margin 0x%x\n",
+                           lower_idx);
+       } else if (upper_idx == TXRESERVE_MAX && upper_ret == 0 &&
+                  lower_ret == 0) {
+               ret = 0;
+               phydev_warn(phydev, "TX-VCM SW cal result at high margin 0x%x\n",
+                           upper_idx);
+       } else {
+               ret = -EINVAL;
+       }
+
+restore:
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
+                          MTK_PHY_RG_ANA_CALEN);
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
+                          MTK_PHY_RG_TXVOS_CALEN);
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
+                          MTK_PHY_RG_ZCALEN_A);
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
+                          MTK_PHY_RG_ZCALEN_B | MTK_PHY_RG_ZCALEN_C |
+                          MTK_PHY_RG_ZCALEN_D);
+
+       return ret;
+}
+
+static void mt798x_phy_common_finetune(struct phy_device *phydev)
+{
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
+       /* EnabRandUpdTrig = 1 */
+       __phy_write(phydev, 0x11, 0x2f00);
+       __phy_write(phydev, 0x12, 0xe);
+       __phy_write(phydev, 0x10, 0x8fb0);
+
+       /* NormMseLoThresh = 85 */
+       __phy_write(phydev, 0x11, 0x55a0);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x83aa);
+
+       /* TrFreeze = 0 */
+       __phy_write(phydev, 0x11, 0x0);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x9686);
+
+       /* SSTrKp1000Slv = 5 */
+       __phy_write(phydev, 0x11, 0xbaef);
+       __phy_write(phydev, 0x12, 0x2e);
+       __phy_write(phydev, 0x10, 0x968c);
+
+       /* MrvlTrFix100Kp = 3, MrvlTrFix100Kf = 2,
+        * MrvlTrFix1000Kp = 3, MrvlTrFix1000Kf = 2
+        */
+       __phy_write(phydev, 0x11, 0xd10a);
+       __phy_write(phydev, 0x12, 0x34);
+       __phy_write(phydev, 0x10, 0x8f82);
+
+       /* VcoSlicerThreshBitsHigh */
+       __phy_write(phydev, 0x11, 0x5555);
+       __phy_write(phydev, 0x12, 0x55);
+       __phy_write(phydev, 0x10, 0x8ec0);
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+
+       /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 9*/
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG234,
+                      MTK_PHY_TR_OPEN_LOOP_EN_MASK | MTK_PHY_LPF_X_AVERAGE_MASK,
+                      BIT(0) | FIELD_PREP(MTK_PHY_LPF_X_AVERAGE_MASK, 0x9));
+
+       /* rg_tr_lpf_cnt_val = 512 */
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LPF_CNT_VAL, 0x200);
+
+       /* IIR2 related */
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_L, 0x82);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_U, 0x0);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_L, 0x103);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_U, 0x0);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_L, 0x82);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_U, 0x0);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_L, 0xd177);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_U, 0x3);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_L, 0x2c82);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_U, 0xe);
+
+       /* FFE peaking */
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27C,
+                      MTK_PHY_VGASTATE_FFE_THR_ST1_MASK, 0x1b << 8);
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27D,
+                      MTK_PHY_VGASTATE_FFE_THR_ST2_MASK, 0x1e);
+
+       /* Disable LDO pump */
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_PUMP_EN_PAIRAB, 0x0);
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_PUMP_EN_PAIRCD, 0x0);
+       /* Adjust LDO output voltage */
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_OUTPUT_V, 0x2222);
+}
+
+static void mt7981_phy_finetune(struct phy_device *phydev)
+{
+       u16 val[8] = { 0x01ce, 0x01c1,
+                      0x020f, 0x0202,
+                      0x03d0, 0x03c0,
+                      0x0013, 0x0005 };
+       int i, k;
+
+       /* 100M eye finetune:
+        * Keep middle level of TX MLT3 shapper as default.
+        * Only change TX MLT3 overshoot level here.
+        */
+       for (k = 0, i = 1; i < 12; i++) {
+               if (i % 3 == 0)
+                       continue;
+               phy_write_mmd(phydev, MDIO_MMD_VEND1, i, val[k++]);
+       }
+
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
+       /* SlvDSPreadyTime = 24, MasDSPreadyTime = 24 */
+       __phy_write(phydev, 0x11, 0xc71);
+       __phy_write(phydev, 0x12, 0xc);
+       __phy_write(phydev, 0x10, 0x8fae);
+
+       /* ResetSyncOffset = 6 */
+       __phy_write(phydev, 0x11, 0x600);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x8fc0);
+
+       /* VgaDecRate = 1 */
+       __phy_write(phydev, 0x11, 0x4c2a);
+       __phy_write(phydev, 0x12, 0x3e);
+       __phy_write(phydev, 0x10, 0x8fa4);
+
+       /* FfeUpdGainForce = 4 */
+       __phy_write(phydev, 0x11, 0x240);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x9680);
+
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+}
+
+static void mt7988_phy_finetune(struct phy_device *phydev)
+{
+       u16 val[12] = { 0x0187, 0x01cd, 0x01c8, 0x0182,
+                       0x020d, 0x0206, 0x0384, 0x03d0,
+                       0x03c6, 0x030a, 0x0011, 0x0005 };
+       int i;
+
+       /* Set default MLT3 shaper first */
+       for (i = 0; i < 12; i++)
+               phy_write_mmd(phydev, MDIO_MMD_VEND1, i, val[i]);
+
+       /* TCT finetune */
+       phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_TX_FILTER, 0x5);
+
+       /* Disable TX power saving */
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG7,
+                      MTK_PHY_DA_AD_BUF_BIAS_LP_MASK, 0x3 << 8);
+
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
+
+       /* SlvDSPreadyTime = 24, MasDSPreadyTime = 12 */
+       __phy_write(phydev, 0x11, 0x671);
+       __phy_write(phydev, 0x12, 0xc);
+       __phy_write(phydev, 0x10, 0x8fae);
+
+       /* ResetSyncOffset = 5 */
+       __phy_write(phydev, 0x11, 0x500);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x8fc0);
+
+       /* VgaDecRate is 1 at default on mt7988 */
+
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_2A30);
+       /* TxClkOffset = 2 */
+       __phy_modify(phydev, MTK_PHY_ANARG_RG, MTK_PHY_TCLKOFFSET_MASK,
+                    FIELD_PREP(MTK_PHY_TCLKOFFSET_MASK, 0x2));
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+}
+
+static void mt798x_phy_eee(struct phy_device *phydev)
+{
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+                      MTK_PHY_RG_LPI_PCS_DSP_CTRL_REG120,
+                      MTK_PHY_LPI_SIG_EN_LO_THRESH1000_MASK |
+                      MTK_PHY_LPI_SIG_EN_HI_THRESH1000_MASK,
+                      FIELD_PREP(MTK_PHY_LPI_SIG_EN_LO_THRESH1000_MASK, 0x0) |
+                      FIELD_PREP(MTK_PHY_LPI_SIG_EN_HI_THRESH1000_MASK, 0x14));
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+                      MTK_PHY_RG_LPI_PCS_DSP_CTRL_REG122,
+                      MTK_PHY_LPI_NORM_MSE_HI_THRESH1000_MASK,
+                      FIELD_PREP(MTK_PHY_LPI_NORM_MSE_HI_THRESH1000_MASK,
+                                 0xff));
+
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                          MTK_PHY_RG_TESTMUX_ADC_CTRL,
+                          MTK_PHY_RG_TXEN_DIG_MASK);
+
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
+                        MTK_PHY_RG_DEV1E_REG19b, MTK_PHY_BYPASS_DSP_LPI_READY);
+
+       phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
+                          MTK_PHY_RG_DEV1E_REG234, MTK_PHY_TR_LP_IIR_EEE_EN);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG238,
+                      MTK_PHY_LPI_SLV_SEND_TX_TIMER_MASK |
+                      MTK_PHY_LPI_SLV_SEND_TX_EN,
+                      FIELD_PREP(MTK_PHY_LPI_SLV_SEND_TX_TIMER_MASK, 0x120));
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG239,
+                      MTK_PHY_LPI_SEND_LOC_TIMER_MASK |
+                      MTK_PHY_LPI_TXPCS_LOC_RCV,
+                      FIELD_PREP(MTK_PHY_LPI_SEND_LOC_TIMER_MASK, 0x117));
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG2C7,
+                      MTK_PHY_MAX_GAIN_MASK | MTK_PHY_MIN_GAIN_MASK,
+                      FIELD_PREP(MTK_PHY_MAX_GAIN_MASK, 0x8) |
+                      FIELD_PREP(MTK_PHY_MIN_GAIN_MASK, 0x13));
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG2D1,
+                      MTK_PHY_VCO_SLICER_THRESH_BITS_HIGH_EEE_MASK,
+                      FIELD_PREP(MTK_PHY_VCO_SLICER_THRESH_BITS_HIGH_EEE_MASK,
+                                 0x33) |
+                      MTK_PHY_LPI_SKIP_SD_SLV_TR | MTK_PHY_LPI_TR_READY |
+                      MTK_PHY_LPI_VCO_EEE_STG0_EN);
+
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG323,
+                        MTK_PHY_EEE_WAKE_MAS_INT_DC |
+                        MTK_PHY_EEE_WAKE_SLV_INT_DC);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG324,
+                      MTK_PHY_SMI_DETCNT_MAX_MASK,
+                      FIELD_PREP(MTK_PHY_SMI_DETCNT_MAX_MASK, 0x3f) |
+                      MTK_PHY_SMI_DET_MAX_EN);
+
+       phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG326,
+                        MTK_PHY_LPI_MODE_SD_ON | MTK_PHY_RESET_RANDUPD_CNT |
+                        MTK_PHY_TREC_UPDATE_ENAB_CLR |
+                        MTK_PHY_LPI_QUIT_WAIT_DFE_SIG_DET_OFF |
+                        MTK_PHY_TR_READY_SKIP_AFE_WAKEUP);
+
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
+       /* Regsigdet_sel_1000 = 0 */
+       __phy_write(phydev, 0x11, 0xb);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x9690);
+
+       /* REG_EEE_st2TrKf1000 = 3 */
+       __phy_write(phydev, 0x11, 0x114f);
+       __phy_write(phydev, 0x12, 0x2);
+       __phy_write(phydev, 0x10, 0x969a);
+
+       /* RegEEE_slv_wake_tr_timer_tar = 6, RegEEE_slv_remtx_timer_tar = 20 */
+       __phy_write(phydev, 0x11, 0x3028);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x969e);
+
+       /* RegEEE_slv_wake_int_timer_tar = 8 */
+       __phy_write(phydev, 0x11, 0x5010);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x96a0);
+
+       /* RegEEE_trfreeze_timer2 = 586 */
+       __phy_write(phydev, 0x11, 0x24a);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x96a8);
+
+       /* RegEEE100Stg1_tar = 16 */
+       __phy_write(phydev, 0x11, 0x3210);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x96b8);
+
+       /* REGEEE_wake_slv_tr_wait_dfesigdet_en = 1 */
+       __phy_write(phydev, 0x11, 0x1463);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x96ca);
+
+       /* DfeTailEnableVgaThresh1000 = 27 */
+       __phy_write(phydev, 0x11, 0x36);
+       __phy_write(phydev, 0x12, 0x0);
+       __phy_write(phydev, 0x10, 0x8f80);
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+
+       phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_3);
+       __phy_modify(phydev, MTK_PHY_LPI_REG_14, MTK_PHY_LPI_WAKE_TIMER_1000_MASK,
+                    FIELD_PREP(MTK_PHY_LPI_WAKE_TIMER_1000_MASK, 0x19c));
+
+       __phy_modify(phydev, MTK_PHY_LPI_REG_1c, MTK_PHY_SMI_DET_ON_THRESH_MASK,
+                    FIELD_PREP(MTK_PHY_SMI_DET_ON_THRESH_MASK, 0xc));
+       phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
+
+       phy_modify_mmd(phydev, MDIO_MMD_VEND1,
+                      MTK_PHY_RG_LPI_PCS_DSP_CTRL_REG122,
+                      MTK_PHY_LPI_NORM_MSE_HI_THRESH1000_MASK,
+                      FIELD_PREP(MTK_PHY_LPI_NORM_MSE_HI_THRESH1000_MASK, 0xff));
+}
+
+static int cal_sw(struct phy_device *phydev, enum CAL_ITEM cal_item,
+                 u8 start_pair, u8 end_pair)
+{
+       u8 pair_n;
+       int ret;
+
+       for (pair_n = start_pair; pair_n <= end_pair; pair_n++) {
+               /* TX_OFFSET & TX_AMP have no SW calibration. */
+               switch (cal_item) {
+               case TX_VCM:
+                       ret = tx_vcm_cal_sw(phydev, pair_n);
+                       break;
+               default:
+                       return -EINVAL;
+               }
+               if (ret)
+                       return ret;
+       }
+       return 0;
+}
+
+static int cal_efuse(struct phy_device *phydev, enum CAL_ITEM cal_item,
+                    u8 start_pair, u8 end_pair, u32 *buf)
+{
+       u8 pair_n;
+       int ret;
+
+       for (pair_n = start_pair; pair_n <= end_pair; pair_n++) {
+               /* TX_VCM has no efuse calibration. */
+               switch (cal_item) {
+               case REXT:
+                       ret = rext_cal_efuse(phydev, buf);
+                       break;
+               case TX_OFFSET:
+                       ret = tx_offset_cal_efuse(phydev, buf);
+                       break;
+               case TX_AMP:
+                       ret = tx_amp_cal_efuse(phydev, buf);
+                       break;
+               case TX_R50:
+                       ret = tx_r50_cal_efuse(phydev, buf, pair_n);
+                       break;
+               default:
+                       return -EINVAL;
+               }
+               if (ret)
+                       return ret;
+       }
+
+       return 0;
+}
+
+static int start_cal(struct phy_device *phydev, enum CAL_ITEM cal_item,
+                    enum CAL_MODE cal_mode, u8 start_pair,
+                    u8 end_pair, u32 *buf)
+{
+       int ret;
+
+       switch (cal_mode) {
+       case EFUSE_M:
+               ret = cal_efuse(phydev, cal_item, start_pair,
+                               end_pair, buf);
+               break;
+       case SW_M:
+               ret = cal_sw(phydev, cal_item, start_pair, end_pair);
+               break;
+       default:
+               return -EINVAL;
+       }
+
+       if (ret) {
+               phydev_err(phydev, "cal %d failed\n", cal_item);
+               return -EIO;
+       }
+
+       return 0;
+}
+
+static int mt798x_phy_calibration(struct phy_device *phydev)
+{
+       int ret = 0;
+       u32 *buf;
+       size_t len;
+       struct nvmem_cell *cell;
+
+       cell = nvmem_cell_get(&phydev->mdio.dev, "phy-cal-data");
+       if (IS_ERR(cell)) {
+               if (PTR_ERR(cell) == -EPROBE_DEFER)
+                       return PTR_ERR(cell);
+               return 0;
+       }
+
+       buf = (u32 *)nvmem_cell_read(cell, &len);
+       if (IS_ERR(buf))
+               return PTR_ERR(buf);
+       nvmem_cell_put(cell);
+
+       if (!buf[0] || !buf[1] || !buf[2] || !buf[3] || len < 4 * sizeof(u32)) {
+               phydev_err(phydev, "invalid efuse data\n");
+               ret = -EINVAL;
+               goto out;
+       }
+
+       ret = start_cal(phydev, REXT, EFUSE_M, NO_PAIR, NO_PAIR, buf);
+       if (ret)
+               goto out;
+       ret = start_cal(phydev, TX_OFFSET, EFUSE_M, NO_PAIR, NO_PAIR, buf);
+       if (ret)
+               goto out;
+       ret = start_cal(phydev, TX_AMP, EFUSE_M, NO_PAIR, NO_PAIR, buf);
+       if (ret)
+               goto out;
+       ret = start_cal(phydev, TX_R50, EFUSE_M, PAIR_A, PAIR_D, buf);
+       if (ret)
+               goto out;
+       ret = start_cal(phydev, TX_VCM, SW_M, PAIR_A, PAIR_A, buf);
+       if (ret)
+               goto out;
+
+out:
+       kfree(buf);
+       return ret;
+}
+
+static int mt798x_phy_config_init(struct phy_device *phydev)
+{
+       switch (phydev->drv->phy_id) {
+       case MTK_GPHY_ID_MT7981:
+               mt7981_phy_finetune(phydev);
+               break;
+       case MTK_GPHY_ID_MT7988:
+               mt7988_phy_finetune(phydev);
+               break;
+       }
+
+       mt798x_phy_common_finetune(phydev);
+       mt798x_phy_eee(phydev);
+
+       return mt798x_phy_calibration(phydev);
+}
+
+static int mt7988_phy_setup_led(struct phy_device *phydev)
+{
+       struct mtk_socphy_shared_priv *priv = phydev->shared->priv;
+       int port = phydev->mdio.addr;
+       u32 reg = priv->boottrap;
+       struct pinctrl *pinctrl;
+
+       phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_ON_CTRL,
+                     MTK_PHY_LED0_ENABLE | MTK_PHY_LED0_POLARITY |
+                     MTK_PHY_LED0_ON_LINK10 |
+                     MTK_PHY_LED0_ON_LINK100 |
+                     MTK_PHY_LED0_ON_LINK1000);
+       phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED1_ON_CTRL,
+                     MTK_PHY_LED1_ENABLE | MTK_PHY_LED1_POLARITY |
+                     MTK_PHY_LED1_ON_LINK10 |
+                     MTK_PHY_LED1_ON_LINK100 |
+                     MTK_PHY_LED1_ON_LINK1000);
+
+       if ((port == GPHY_PORT0 && reg & BIT(8)) ||
+           (port == GPHY_PORT1 && reg & BIT(9)) ||
+           (port == GPHY_PORT2 && reg & BIT(10)) ||
+           (port == GPHY_PORT3 && reg & BIT(11))) {
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_ON_CTRL,
+                                  MTK_PHY_LED0_POLARITY);
+               phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED1_ON_CTRL,
+                                  MTK_PHY_LED1_POLARITY);
+       }
+
+       phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_BLINK_CTRL,
+                     MTK_PHY_LED0_1000TX | MTK_PHY_LED0_1000RX |
+                     MTK_PHY_LED0_100TX  | MTK_PHY_LED0_100RX  |
+                     MTK_PHY_LED0_10TX   | MTK_PHY_LED0_10RX);
+       phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED1_BLINK_CTRL,
+                     MTK_PHY_LED1_1000TX | MTK_PHY_LED1_1000RX |
+                     MTK_PHY_LED1_100TX  | MTK_PHY_LED1_100RX  |
+                     MTK_PHY_LED1_10TX   | MTK_PHY_LED1_10RX);
+
+       pinctrl = devm_pinctrl_get_select(&phydev->mdio.dev, "gbe-led");
+       if (IS_ERR(pinctrl)) {
+               dev_err(&phydev->mdio.bus->dev, "Failed to setup LED pins\n");
+               return PTR_ERR(pinctrl);
+       }
+
+       return 0;
+}
+
+static int mt7988_phy_probe_shared(struct phy_device *phydev)
+{
+       struct mtk_socphy_shared_priv *priv = phydev->shared->priv;
+       void __iomem *boottrap;
+       struct device_node *np;
+       u32 reg;
+
+       np = of_find_compatible_node(NULL, NULL, "mediatek,boottrap");
+       if (!np)
+               return -ENOENT;
+
+       boottrap = of_iomap(np, 0);
+       if (!boottrap)
+               return -ENOMEM;
+
+       reg = readl(boottrap);
+       iounmap(boottrap);
+
+       priv->boottrap = reg;
+
+       return 0;
+}
+
+static int mt7981_phy_probe(struct phy_device *phydev)
+{
+       return mt798x_phy_calibration(phydev);
+}
+
+static int mt7988_phy_probe(struct phy_device *phydev)
+{
+       int err;
+
+       err = devm_phy_package_join(&phydev->mdio.dev, phydev, 0,
+                                   sizeof(struct mtk_socphy_shared_priv));
+       if (err)
+               return err;
+
+       if (phy_package_probe_once(phydev)) {
+               err = mt7988_phy_probe_shared(phydev);
+               if (err)
+                       return err;
+       }
+
+       mt7988_phy_setup_led(phydev);
+
+       return mt798x_phy_calibration(phydev);
+}
+
+static struct phy_driver mtk_socphy_driver[] = {
+       {
+               PHY_ID_MATCH_EXACT(MTK_GPHY_ID_MT7981),
+               .name           = "MediaTek MT7981 PHY",
+               .config_init    = mt798x_phy_config_init,
+               .config_intr    = genphy_no_config_intr,
+               .handle_interrupt = genphy_handle_interrupt_no_ack,
+               .probe          = mt7981_phy_probe,
+               .suspend        = genphy_suspend,
+               .resume         = genphy_resume,
+               .read_page      = mtk_socphy_read_page,
+               .write_page     = mtk_socphy_write_page,
+       },
+       {
+               PHY_ID_MATCH_EXACT(MTK_GPHY_ID_MT7988),
+               .name           = "MediaTek MT7988 PHY",
+               .config_init    = mt798x_phy_config_init,
+               .config_intr    = genphy_no_config_intr,
+               .handle_interrupt = genphy_handle_interrupt_no_ack,
+               .probe          = mt7988_phy_probe,
+               .suspend        = genphy_suspend,
+               .resume         = genphy_resume,
+               .read_page      = mtk_socphy_read_page,
+               .write_page     = mtk_socphy_write_page,
+       },
+};
+
+module_phy_driver(mtk_socphy_driver);
+
+static struct mdio_device_id __maybe_unused mtk_socphy_tbl[] = {
+       { PHY_ID_MATCH_EXACT(MTK_GPHY_ID_MT7981) },
+       { PHY_ID_MATCH_EXACT(MTK_GPHY_ID_MT7988) },
+       { }
+};
+
+MODULE_DESCRIPTION("MediaTek SoC Gigabit Ethernet PHY driver");
+MODULE_AUTHOR("Daniel Golle <daniel@makrotopia.org>");
+MODULE_AUTHOR("SkyLake Huang <SkyLake.Huang@mediatek.com>");
+MODULE_LICENSE("GPL");
+
+MODULE_DEVICE_TABLE(mdio, mtk_socphy_tbl);
index 134afb63f9e83b16bcc4987f18db5a3f62195bc1..e6ab85fb5d149b6e4b15900551628c2b710f1795 100644 (file)
@@ -205,7 +205,7 @@ CONFIG_MDIO_BUS=y
 CONFIG_MDIO_DEVICE=y
 CONFIG_MDIO_DEVRES=y
 CONFIG_MEDIATEK_GE_PHY=y
-CONFIG_MEDIATEK_GE_PHY_SOC=y
+CONFIG_MEDIATEK_GE_SOC_PHY=y
 CONFIG_MEDIATEK_WATCHDOG=y
 CONFIG_MEMFD_CREATE=y
 CONFIG_MESSAGE_LOGLEVEL_DEFAULT=7
index 2de14752b4679fb8fb5868acae0576e55cabc33f..d584497ec19df4c0bef03e97c0a79628c7a6949f 100644 (file)
@@ -226,7 +226,7 @@ CONFIG_MDIO_BUS=y
 CONFIG_MDIO_DEVICE=y
 CONFIG_MDIO_DEVRES=y
 CONFIG_MEDIATEK_GE_PHY=y
-# CONFIG_MEDIATEK_GE_PHY_SOC is not set
+# CONFIG_MEDIATEK_GE_SOC_PHY is not set
 CONFIG_MEDIATEK_WATCHDOG=y
 CONFIG_MEMFD_CREATE=y
 CONFIG_MESSAGE_LOGLEVEL_DEFAULT=7
index 4e462881c2a2a63f98649e26bda4c8b8e7df0894..b8d1a6061917f232a74d5fd9994f10b0ce659875 100644 (file)
@@ -1,23 +1,27 @@
-From a6f143af419bfc3f52d82e88ac033d9833e720af Mon Sep 17 00:00:00 2001
+From 60ed9eb9605656c19ca402b7bd3f47552e901601 Mon Sep 17 00:00:00 2001
 From: Daniel Golle <daniel@makrotopia.org>
 Date: Mon, 13 Feb 2023 02:33:14 +0000
 Subject: [PATCH] net: phy: add driver for MediaTek SoC built-in GE PHYs
 
 Some of MediaTek's Filogic SoCs come with built-in gigabit Ethernet
 PHYs which require calibration data from the SoC's efuse.
-Add support for these PHYs to the mediatek-ge driver if built for
-MediaTek's ARM64 SoCs.
+Despite the similar design the driver doesn't share any code with the
+existing mediatek-ge.c, so add support for these PHYs by introducing a
+new driver for only MediaTek's ARM64 SoCs.
 
 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 ---
- MAINTAINERS                   |    8 +
- drivers/net/phy/Kconfig       |   12 +
- drivers/net/phy/mediatek-ge.c | 1351 +++++++++++++++++++++++++++++++++
- 3 files changed, 1371 insertions(+)
+ MAINTAINERS                       |    9 +
+ drivers/net/phy/Kconfig           |   12 +
+ drivers/net/phy/Makefile          |    1 +
+ drivers/net/phy/mediatek-ge-soc.c | 1263 +++++++++++++++++++++++++++++
+ drivers/net/phy/mediatek-ge.c     |    3 +-
+ 5 files changed, 1287 insertions(+), 1 deletion(-)
+ create mode 100644 drivers/net/phy/mediatek-ge-soc.c
 
 --- a/MAINTAINERS
 +++ b/MAINTAINERS
-@@ -11797,6 +11797,14 @@ S:    Maintained
+@@ -11797,6 +11797,15 @@ S:    Maintained
  F:    drivers/net/pcs/pcs-mtk-lynxi.c
  F:    include/linux/pcs/pcs-mtk-lynxi.h
  
@@ -27,6 +31,7 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
 +M:    SkyLake Huang <SkyLake.Huang@mediatek.com>
 +L:    netdev@vger.kernel.org
 +S:    Maintained
++F:    drivers/net/phy/mediatek-ge-soc.c
 +F:    drivers/net/phy/mediatek-ge.c
 +
  MEDIATEK I2C CONTROLLER DRIVER
@@ -38,9 +43,9 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
        help
          Supports the MediaTek Gigabit Ethernet PHYs.
  
-+config MEDIATEK_GE_PHY_SOC
-+      bool "MediaTek SoC Ethernet PHYs"
-+      depends on (ARM64 && ARCH_MEDIATEK && MEDIATEK_GE_PHY) || COMPILE_TEST
++config MEDIATEK_GE_SOC_PHY
++      tristate "MediaTek SoC Ethernet PHYs"
++      depends on (ARM64 && ARCH_MEDIATEK) || COMPILE_TEST
 +      select NVMEM_MTK_EFUSE
 +      help
 +        Supports MediaTek SoC built-in Gigabit Ethernet PHYs.
@@ -53,1391 +58,25 @@ Signed-off-by: Daniel Golle <daniel@makrotopia.org>
  config MICREL_PHY
        tristate "Micrel PHYs"
        help
+--- a/drivers/net/phy/Makefile
++++ b/drivers/net/phy/Makefile
+@@ -81,6 +81,7 @@ obj-$(CONFIG_MARVELL_PHY)    += marvell.o
+ obj-$(CONFIG_MARVELL_88X2222_PHY)     += marvell-88x2222.o
+ obj-$(CONFIG_MAXLINEAR_GPHY)  += mxl-gpy.o
+ obj-$(CONFIG_MEDIATEK_GE_PHY) += mediatek-ge.o
++obj-$(CONFIG_MEDIATEK_GE_SOC_PHY)     += mediatek-ge-soc.o
+ obj-$(CONFIG_MESON_GXL_PHY)   += meson-gxl.o
+ obj-$(CONFIG_MICREL_KS8995MA) += spi_ks8995.o
+ obj-$(CONFIG_MICREL_PHY)      += micrel.o
 --- a/drivers/net/phy/mediatek-ge.c
 +++ b/drivers/net/phy/mediatek-ge.c
-@@ -2,6 +2,9 @@
- #include <linux/of.h>
- #include <linux/bitfield.h>
- #include <linux/module.h>
-+#include <linux/nvmem-consumer.h>
-+#include <linux/of_address.h>
-+#include <linux/of_platform.h>
- #include <linux/phy.h>
- #define MTK_EXT_PAGE_ACCESS           0x1f
-@@ -12,6 +15,275 @@
- #define MTK_PHY_PAGE_EXTENDED_2A30    0x2a30
- #define MTK_PHY_PAGE_EXTENDED_52B5    0x52b5
-+#define ANALOG_INTERNAL_OPERATION_MAX_US      (20)
-+#define ZCAL_CTRL_MIN                         (0)
-+#define ZCAL_CTRL_MAX                         (63)
-+#define TXRESERVE_MIN                         (0)
-+#define TXRESERVE_MAX                         (7)
-+
-+#define MTK_PHY_ANARG_RG                      (0x10)
-+#define   MTK_PHY_TCLKOFFSET_MASK             GENMASK(12, 8)
-+
-+/* Registers on MDIO_MMD_VEND1 */
-+enum {
-+      MTK_PHY_MIDDLE_LEVEL_SHAPPER_0TO1 = 0,
-+      MTK_PHY_1st_OVERSHOOT_LEVEL_0TO1,
-+      MTK_PHY_2nd_OVERSHOOT_LEVEL_0TO1,
-+      MTK_PHY_MIDDLE_LEVEL_SHAPPER_1TO0,
-+      MTK_PHY_1st_OVERSHOOT_LEVEL_1TO0,
-+      MTK_PHY_2nd_OVERSHOOT_LEVEL_1TO0,
-+      MTK_PHY_MIDDLE_LEVEL_SHAPPER_0TON1, /* N means negative */
-+      MTK_PHY_1st_OVERSHOOT_LEVEL_0TON1,
-+      MTK_PHY_2nd_OVERSHOOT_LEVEL_0TON1,
-+      MTK_PHY_MIDDLE_LEVEL_SHAPPER_N1TO0,
-+      MTK_PHY_1st_OVERSHOOT_LEVEL_N1TO0,
-+      MTK_PHY_2nd_OVERSHOOT_LEVEL_N1TO0,
-+      MTK_PHY_TX_MLT3_END,
-+};
-+
-+#define MTK_PHY_TXVLD_DA_RG                   (0x12)
-+#define   MTK_PHY_DA_TX_I2MPB_A_GBE_MASK      GENMASK(15, 10)
-+#define   MTK_PHY_DA_TX_I2MPB_A_TBT_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_A2         (0x16)
-+#define   MTK_PHY_DA_TX_I2MPB_A_HBT_MASK      GENMASK(15, 10)
-+#define   MTK_PHY_DA_TX_I2MPB_A_TST_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_B1         (0x17)
-+#define   MTK_PHY_DA_TX_I2MPB_B_GBE_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_B_TBT_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_B2         (0x18)
-+#define   MTK_PHY_DA_TX_I2MPB_B_HBT_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_B_TST_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_C1         (0x19)
-+#define   MTK_PHY_DA_TX_I2MPB_C_GBE_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_C_TBT_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_C2         (0x20)
-+#define   MTK_PHY_DA_TX_I2MPB_C_HBT_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_C_TST_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_D1         (0x21)
-+#define   MTK_PHY_DA_TX_I2MPB_D_GBE_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_D_TBT_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TX_I2MPB_TEST_MODE_D2         (0x22)
-+#define   MTK_PHY_DA_TX_I2MPB_D_HBT_MASK      GENMASK(13, 8)
-+#define   MTK_PHY_DA_TX_I2MPB_D_TST_MASK      GENMASK(5, 0)
-+
-+#define MTK_PHY_TANA_CAL_MODE                 (0xc1)
-+#define MTK_PHY_TANA_CAL_MODE_SHIFT           (8)
-+
-+#define MTK_PHY_RXADC_CTRL_RG7                        (0xc6)
-+#define   MTK_PHY_DA_AD_BUF_BIAS_LP_MASK      GENMASK(9, 8)
-+
-+#define MTK_PHY_RXADC_CTRL_RG9                        (0xc8)
-+#define   MTK_PHY_DA_RX_PSBN_TBT_MASK         GENMASK(14, 12)
-+#define   MTK_PHY_DA_RX_PSBN_HBT_MASK         GENMASK(10, 8)
-+#define   MTK_PHY_DA_RX_PSBN_GBE_MASK         GENMASK(6, 4)
-+#define   MTK_PHY_DA_RX_PSBN_LP_MASK          GENMASK(2, 0)
-+
-+#define MTK_PHY_LDO_OUTPUT_V                  (0xd7)
-+
-+#define MTK_PHY_RG_ANA_CAL_RG0                        (0xdb)
-+#define   MTK_PHY_RG_CAL_CKINV                        BIT(12)
-+#define   MTK_PHY_RG_ANA_CALEN                        BIT(8)
-+#define   MTK_PHY_RG_REXT_CALEN                       BIT(4)
-+#define   MTK_PHY_RG_ZCALEN_A                 BIT(0)
-+
-+#define MTK_PHY_RG_ANA_CAL_RG1                        (0xdc)
-+#define   MTK_PHY_RG_ZCALEN_B                 BIT(12)
-+#define   MTK_PHY_RG_ZCALEN_C                 BIT(8)
-+#define   MTK_PHY_RG_ZCALEN_D                 BIT(4)
-+#define   MTK_PHY_RG_TXVOS_CALEN              BIT(0)
-+
-+#define MTK_PHY_RG_ANA_CAL_RG2                        (0xdd)
-+#define   MTK_PHY_RG_TXG_CALEN_A              BIT(12)
-+#define   MTK_PHY_RG_TXG_CALEN_B              BIT(8)
-+#define   MTK_PHY_RG_TXG_CALEN_C              BIT(4)
-+#define   MTK_PHY_RG_TXG_CALEN_D              BIT(0)
-+
-+#define MTK_PHY_RG_ANA_CAL_RG5                        (0xe0)
-+#define   MTK_PHY_RG_REXT_TRIM_MASK           GENMASK(13, 8)
-+#define   MTK_PHY_RG_ZCAL_CTRL_MASK           GENMASK(5, 0)
-+
-+#define MTK_PHY_RG_TX_FILTER                  (0xfe)
-+
-+#define MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B               (0x172)
-+#define   MTK_PHY_CR_TX_AMP_OFFSET_A_MASK     GENMASK(13, 8)
-+#define   MTK_PHY_CR_TX_AMP_OFFSET_B_MASK     GENMASK(6, 0)
-+
-+#define MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D               (0x173)
-+#define   MTK_PHY_CR_TX_AMP_OFFSET_C_MASK     GENMASK(13, 8)
-+#define   MTK_PHY_CR_TX_AMP_OFFSET_D_MASK     GENMASK(6, 0)
-+
-+#define MTK_PHY_RG_AD_CAL_COMP                        (0x17a)
-+#define   MTK_PHY_AD_CAL_COMP_OUT_SHIFT               (8)
-+
-+#define MTK_PHY_RG_AD_CAL_CLK                 (0x17b)
-+#define   MTK_PHY_DA_CAL_CLK                  BIT(0)
-+
-+#define MTK_PHY_RG_AD_CALIN                   (0x17c)
-+#define   MTK_PHY_DA_CALIN_FLAG                       BIT(0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN0_A             (0x17d)
-+#define   MTK_PHY_DASN_DAC_IN0_A_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN0_B             (0x17e)
-+#define   MTK_PHY_DASN_DAC_IN0_B_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN0_C             (0x17f)
-+#define   MTK_PHY_DASN_DAC_IN0_C_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN0_D                     (0x180)
-+#define   MTK_PHY_DASN_DAC_IN0_D_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN1_A                     (0x181)
-+#define   MTK_PHY_DASN_DAC_IN1_A_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN1_B                     (0x182)
-+#define   MTK_PHY_DASN_DAC_IN1_B_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN1_C                     (0x183)
-+#define   MTK_PHY_DASN_DAC_IN1_C_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_DASN_DAC_IN1_D                     (0x180)
-+#define   MTK_PHY_DASN_DAC_IN1_D_MASK         GENMASK(9, 0)
-+
-+#define MTK_PHY_RG_LP_IIR2_K1_L                       (0x22a)
-+#define MTK_PHY_RG_LP_IIR2_K1_U                       (0x22b)
-+#define MTK_PHY_RG_LP_IIR2_K2_L                       (0x22c)
-+#define MTK_PHY_RG_LP_IIR2_K2_U                       (0x22d)
-+#define MTK_PHY_RG_LP_IIR2_K3_L                       (0x22e)
-+#define MTK_PHY_RG_LP_IIR2_K3_U                       (0x22f)
-+#define MTK_PHY_RG_LP_IIR2_K4_L                       (0x230)
-+#define MTK_PHY_RG_LP_IIR2_K4_U                       (0x231)
-+#define MTK_PHY_RG_LP_IIR2_K5_L                       (0x232)
-+#define MTK_PHY_RG_LP_IIR2_K5_U                       (0x233)
-+
-+#define MTK_PHY_RG_DEV1E_REG234                       (0x234)
-+#define   MTK_PHY_TR_OPEN_LOOP_EN_MASK                GENMASK(0, 0)
-+#define   MTK_PHY_LPF_X_AVERAGE_MASK          GENMASK(7, 4)
-+
-+#define MTK_PHY_RG_LPF_CNT_VAL                        (0x235)
-+
-+#define MTK_PHY_RG_DEV1E_REG27C                       (0x27c)
-+#define   MTK_PHY_VGASTATE_FFE_THR_ST1_MASK   GENMASK(12, 8)
-+#define MTK_PHY_RG_DEV1E_REG27D                       (0x27d)
-+#define   MTK_PHY_VGASTATE_FFE_THR_ST2_MASK   GENMASK(4, 0)
-+
-+#define MTK_PHY_LDO_PUMP_EN_PAIRAB            (0x502)
-+#define MTK_PHY_LDO_PUMP_EN_PAIRCD            (0x503)
-+
-+#define MTK_PHY_DA_TX_R50_PAIR_A              (0x53d)
-+#define MTK_PHY_DA_TX_R50_PAIR_B              (0x53e)
-+#define MTK_PHY_DA_TX_R50_PAIR_C              (0x53f)
-+#define MTK_PHY_DA_TX_R50_PAIR_D              (0x540)
-+
-+/* Registers on MDIO_MMD_VEND2 */
-+#define MTK_PHY_LED0_ON_CTRL                  (0x24)
-+#define   MTK_PHY_LED0_ON_MASK                        GENMASK(6, 0)
-+#define   MTK_PHY_LED0_ON_LINK1000            BIT(0)
-+#define   MTK_PHY_LED0_ON_LINK100             BIT(1)
-+#define   MTK_PHY_LED0_ON_LINK10              BIT(2)
-+#define   MTK_PHY_LED0_ON_LINKDOWN            BIT(3)
-+#define   MTK_PHY_LED0_ON_FDX                 BIT(4) /* Full duplex */
-+#define   MTK_PHY_LED0_ON_HDX                 BIT(5) /* Half duplex */
-+#define   MTK_PHY_LED0_FORCE_ON                       BIT(6)
-+#define   MTK_PHY_LED0_POLARITY                       BIT(14)
-+#define   MTK_PHY_LED0_ENABLE                 BIT(15)
-+
-+#define MTK_PHY_LED0_BLINK_CTRL                       (0x25)
-+#define   MTK_PHY_LED0_1000TX                 BIT(0)
-+#define   MTK_PHY_LED0_1000RX                 BIT(1)
-+#define   MTK_PHY_LED0_100TX                  BIT(2)
-+#define   MTK_PHY_LED0_100RX                  BIT(3)
-+#define   MTK_PHY_LED0_10TX                   BIT(4)
-+#define   MTK_PHY_LED0_10RX                   BIT(5)
-+#define   MTK_PHY_LED0_COLLISION              BIT(6)
-+#define   MTK_PHY_LED0_RX_CRC_ERR             BIT(7)
-+#define   MTK_PHY_LED0_RX_IDLE_ERR            BIT(8)
-+#define   MTK_PHY_LED0_FORCE_BLINK            BIT(9)
-+
-+#define MTK_PHY_ANA_TEST_BUS_CTRL_RG          (0x100)
-+#define   MTK_PHY_ANA_TEST_MODE_MASK          GENMASK(15, 8)
-+
-+#define MTK_PHY_RG_DASN_TXT_DMY2              (0x110)
-+#define   MTK_PHY_TST_DMY2_MASK                       GENMASK(5, 0)
-+
-+#define MTK_PHY_RG_BG_RASEL                   (0x115)
-+#define   MTK_PHY_RG_BG_RASEL_MASK            GENMASK(2, 0)
-+
-+/* These macro privides efuse parsing for internal phy. */
-+#define EFS_DA_TX_I2MPB_A(x)                  (((x) >> 0) & GENMASK(5, 0))
-+#define EFS_DA_TX_I2MPB_B(x)                  (((x) >> 6) & GENMASK(5, 0))
-+#define EFS_DA_TX_I2MPB_C(x)                  (((x) >> 12) & GENMASK(5, 0))
-+#define EFS_DA_TX_I2MPB_D(x)                  (((x) >> 18) & GENMASK(5, 0))
-+#define EFS_DA_TX_AMP_OFFSET_A(x)             (((x) >> 24) & GENMASK(5, 0))
-+
-+#define EFS_DA_TX_AMP_OFFSET_B(x)             (((x) >> 0) & GENMASK(5, 0))
-+#define EFS_DA_TX_AMP_OFFSET_C(x)             (((x) >> 6) & GENMASK(5, 0))
-+#define EFS_DA_TX_AMP_OFFSET_D(x)             (((x) >> 12) & GENMASK(5, 0))
-+#define EFS_DA_TX_R50_A(x)                    (((x) >> 18) & GENMASK(5, 0))
-+#define EFS_DA_TX_R50_B(x)                    (((x) >> 24) & GENMASK(5, 0))
-+
-+#define EFS_DA_TX_R50_C(x)                    (((x) >> 0) & GENMASK(5, 0))
-+#define EFS_DA_TX_R50_D(x)                    (((x) >> 6) & GENMASK(5, 0))
-+#define EFS_DA_TX_R50_A_10M(x)                        (((x) >> 12) & GENMASK(5, 0))
-+#define EFS_DA_TX_R50_B_10M(x)                        (((x) >> 18) & GENMASK(5, 0))
-+
-+#define EFS_RG_BG_RASEL(x)                    (((x) >> 4) & GENMASK(2, 0))
-+#define EFS_RG_REXT_TRIM(x)                   (((x) >> 7) & GENMASK(5, 0))
-+
-+enum {
-+      NO_PAIR,
-+      PAIR_A,
-+      PAIR_B,
-+      PAIR_C,
-+      PAIR_D,
-+};
-+
-+enum {
-+      GPHY_PORT0,
-+      GPHY_PORT1,
-+      GPHY_PORT2,
-+      GPHY_PORT3,
-+};
-+
-+enum calibration_mode {
-+      EFUSE_K,
-+      SW_K
-+};
-+
-+enum CAL_ITEM {
-+      REXT,
-+      TX_OFFSET,
-+      TX_AMP,
-+      TX_R50,
-+      TX_VCM
-+};
-+
-+enum CAL_MODE {
-+      SW_EFUSE_M,
-+      EFUSE_M,
-+      SW_M
-+};
-+
-+const u8 mt798x_zcal_to_r50[64] = {
-+      7, 8, 9, 9, 10, 10, 11, 11,
-+      12, 13, 13, 14, 14, 15, 16, 16,
-+      17, 18, 18, 19, 20, 21, 21, 22,
-+      23, 24, 24, 25, 26, 27, 28, 29,
-+      30, 31, 32, 33, 34, 35, 36, 37,
-+      38, 40, 41, 42, 43, 45, 46, 48,
-+      49, 51, 52, 54, 55, 57, 59, 61,
-+      62, 63, 63, 63, 63, 63, 63, 63
-+};
-+
-+const char pair[4] = {'A', 'B', 'C', 'D'};
-+
- static int mtk_gephy_read_page(struct phy_device *phydev)
- {
-       return __phy_read(phydev, MTK_EXT_PAGE_ACCESS);
-@@ -102,6 +374,1059 @@ static int mt7531_phy_config_init(struct
-       return 0;
- }
-+#ifdef CONFIG_MEDIATEK_GE_PHY_SOC
-+/* One calibration cycle consists of:
-+ * 1.Set DA_CALIN_FLAG high to start calibration. Keep it high
-+ *   until AD_CAL_COMP is ready to output calibration result.
-+ * 2.Wait until DA_CAL_CLK is available.
-+ * 3.Fetch AD_CAL_COMP_OUT.
-+ */
-+static int cal_cycle(struct phy_device *phydev, int devad,
-+                   u32 regnum, u16 mask, u16 cal_val)
-+{
-+      unsigned long timeout;
-+      int reg_val;
-+      int ret;
-+
-+      phy_modify_mmd(phydev, devad, regnum,
-+                     mask, cal_val);
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CALIN,
-+                       MTK_PHY_DA_CALIN_FLAG);
-+
-+      timeout = jiffies + usecs_to_jiffies(ANALOG_INTERNAL_OPERATION_MAX_US);
-+      do {
-+              reg_val = phy_read_mmd(phydev, MDIO_MMD_VEND1,
-+                                     MTK_PHY_RG_AD_CAL_CLK);
-+      } while (time_before(jiffies, timeout) && !(reg_val & BIT(0)));
-+
-+      if (!(reg_val & BIT(0))) {
-+              dev_err(&phydev->mdio.dev, "Calibration cycle timeout\n");
-+              return -ETIMEDOUT;
-+      }
-+
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CALIN,
-+                         MTK_PHY_DA_CALIN_FLAG);
-+      ret = phy_read_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_AD_CAL_COMP) >>
-+                         MTK_PHY_AD_CAL_COMP_OUT_SHIFT;
-+      dev_dbg(&phydev->mdio.dev, "cal_val: 0x%x, ret: %d\n", cal_val, ret);
-+
-+      return ret;
-+}
-+
-+static int rext_fill_result(struct phy_device *phydev, u16 *buf)
-+{
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
-+                     MTK_PHY_RG_REXT_TRIM_MASK, buf[0] << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_BG_RASEL,
-+                     MTK_PHY_RG_BG_RASEL_MASK, buf[1]);
-+
-+      return 0;
-+}
-+
-+static int rext_cal_efuse(struct phy_device *phydev, u32 *buf)
-+{
-+      u16 rext_cal_val[2];
-+
-+      rext_cal_val[0] = EFS_RG_REXT_TRIM(buf[3]);
-+      rext_cal_val[1] = EFS_RG_BG_RASEL(buf[3]);
-+      rext_fill_result(phydev, rext_cal_val);
-+
-+      return 0;
-+}
-+
-+static int rext_cal_sw(struct phy_device *phydev)
-+{
-+      u8 rg_zcal_ctrl_def;
-+      u8 zcal_lower, zcal_upper, rg_zcal_ctrl;
-+      u8 lower_ret, upper_ret;
-+      u16 rext_cal_val[2];
-+      int ret;
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_ANA_TEST_BUS_CTRL_RG,
-+                     MTK_PHY_ANA_TEST_MODE_MASK, MTK_PHY_TANA_CAL_MODE << 8);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
-+                         MTK_PHY_RG_TXVOS_CALEN);
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                       MTK_PHY_RG_CAL_CKINV | MTK_PHY_RG_ANA_CALEN |
-+                       MTK_PHY_RG_REXT_CALEN);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_DASN_TXT_DMY2,
-+                     MTK_PHY_TST_DMY2_MASK, 0x1);
-+
-+      rg_zcal_ctrl_def = phy_read_mmd(phydev, MDIO_MMD_VEND1,
-+                                      MTK_PHY_RG_ANA_CAL_RG5) &
-+                                      MTK_PHY_RG_ZCAL_CTRL_MASK;
-+      zcal_lower = ZCAL_CTRL_MIN;
-+      zcal_upper = ZCAL_CTRL_MAX;
-+
-+      dev_dbg(&phydev->mdio.dev, "Start REXT SW cal.\n");
-+      while ((zcal_upper - zcal_lower) > 1) {
-+              rg_zcal_ctrl = DIV_ROUND_CLOSEST(zcal_lower + zcal_upper, 2);
-+              ret = cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
-+                              MTK_PHY_RG_ZCAL_CTRL_MASK, rg_zcal_ctrl);
-+              if (ret == 1) {
-+                      zcal_upper = rg_zcal_ctrl;
-+                      upper_ret = ret;
-+              } else if (ret == 0) {
-+                      zcal_lower = rg_zcal_ctrl;
-+                      lower_ret = ret;
-+              } else {
-+                      goto restore;
-+              }
-+      }
-+
-+      if (zcal_lower == ZCAL_CTRL_MIN) {
-+              lower_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RG_ANA_CAL_RG5,
-+                                    MTK_PHY_RG_ZCAL_CTRL_MASK, zcal_lower);
-+              ret = lower_ret;
-+      } else if (zcal_upper == ZCAL_CTRL_MAX) {
-+              upper_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RG_ANA_CAL_RG5,
-+                                    MTK_PHY_RG_ZCAL_CTRL_MASK, zcal_upper);
-+              ret = upper_ret;
-+      }
-+      if (ret < 0)
-+              goto restore;
-+
-+      ret = upper_ret - lower_ret;
-+      if (ret == 1) {
-+              rext_cal_val[0] = zcal_upper;
-+              rext_cal_val[1] = zcal_upper >> 3;
-+              rext_fill_result(phydev, rext_cal_val);
-+              dev_info(&phydev->mdio.dev, "REXT SW cal result: 0x%x\n",
-+                       zcal_upper);
-+              ret = 0;
-+      } else {
-+              ret = -EINVAL;
-+      }
-+
-+restore:
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2,
-+                         MTK_PHY_ANA_TEST_BUS_CTRL_RG,
-+                         MTK_PHY_ANA_TEST_MODE_MASK);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                         MTK_PHY_RG_CAL_CKINV | MTK_PHY_RG_ANA_CALEN |
-+                         MTK_PHY_RG_REXT_CALEN);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_DASN_TXT_DMY2,
-+                         MTK_PHY_TST_DMY2_MASK);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
-+                     MTK_PHY_RG_ZCAL_CTRL_MASK, rg_zcal_ctrl_def);
-+
-+      return ret;
-+}
-+
-+static int tx_offset_fill_result(struct phy_device *phydev, u16 *buf)
-+{
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B,
-+                     MTK_PHY_CR_TX_AMP_OFFSET_A_MASK, buf[0] << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_A_B,
-+                     MTK_PHY_CR_TX_AMP_OFFSET_B_MASK, buf[1]);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D,
-+                     MTK_PHY_CR_TX_AMP_OFFSET_C_MASK, buf[2] << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_CR_TX_AMP_OFFSET_C_D,
-+                     MTK_PHY_CR_TX_AMP_OFFSET_D_MASK, buf[3]);
-+
-+      return 0;
-+}
-+
-+static int tx_offset_cal_efuse(struct phy_device *phydev, u32 *buf)
-+{
-+      u16 tx_offset_cal_val[4];
-+
-+      tx_offset_cal_val[0] = EFS_DA_TX_AMP_OFFSET_A(buf[0]);
-+      tx_offset_cal_val[1] = EFS_DA_TX_AMP_OFFSET_B(buf[1]);
-+      tx_offset_cal_val[2] = EFS_DA_TX_AMP_OFFSET_C(buf[1]);
-+      tx_offset_cal_val[3] = EFS_DA_TX_AMP_OFFSET_D(buf[1]);
-+
-+      tx_offset_fill_result(phydev, tx_offset_cal_val);
-+
-+      return 0;
-+}
-+
-+static int tx_amp_fill_result(struct phy_device *phydev, u16 *buf)
-+{
-+      int i;
-+      int bias[16] = {0};
-+      const int vals_9461[16] = { 7, 1, 4, 7,
-+                                  7, 1, 4, 7,
-+                                  7, 1, 4, 7,
-+                                  7, 1, 4, 7 };
-+      const int vals_9481[16] = { 10, 6, 6, 10,
-+                                  10, 6, 6, 10,
-+                                  10, 6, 6, 10,
-+                                  10, 6, 6, 10 };
-+
-+      switch (phydev->drv->phy_id) {
-+      case 0x03a29461:
-+              /* We add some calibration to efuse values
-+               * due to board level influence.
-+               * GBE: +7, TBT: +1, HBT: +4, TST: +7
-+               */
-+              memcpy(bias, (const void *)vals_9461, sizeof(bias));
-+              for (i = 0; i <= 12; i += 4) {
-+                      if (likely(buf[i >> 2] + bias[i] >= 32)) {
-+                              bias[i] -= 13;
-+                      } else {
-+                              phy_modify_mmd(phydev, MDIO_MMD_VEND1,
-+                                             0x5c, 0x7 << i, bias[i] << i);
-+                              bias[i + 1] += 13;
-+                              bias[i + 2] += 13;
-+                              bias[i + 3] += 13;
-+                      }
-+              }
-+              break;
-+      case 0x03a29481:
-+              memcpy(bias, (const void *)vals_9481, sizeof(bias));
-+              break;
-+      default:
-+              break;
-+      }
-+
-+      /* Prevent overflow */
-+      for (i = 0; i < 12; i++) {
-+              if (buf[i >> 2] + bias[i] > 63) {
-+                      buf[i >> 2] = 63;
-+                      bias[i] = 0;
-+              } else if (buf[i >> 2] + bias[i] < 0) {
-+                      /* Bias caused by board design may change in the future.
-+                       * So check negative cases, too.
-+                       */
-+                      buf[i >> 2] = 0;
-+                      bias[i] = 0;
-+              }
-+      }
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TXVLD_DA_RG,
-+                     MTK_PHY_DA_TX_I2MPB_A_GBE_MASK, (buf[0] + bias[0]) << 10);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TXVLD_DA_RG,
-+                     MTK_PHY_DA_TX_I2MPB_A_TBT_MASK, buf[0] + bias[1]);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_A2,
-+                     MTK_PHY_DA_TX_I2MPB_A_HBT_MASK, (buf[0] + bias[2]) << 10);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_A2,
-+                     MTK_PHY_DA_TX_I2MPB_A_TST_MASK, buf[0] + bias[3]);
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B1,
-+                     MTK_PHY_DA_TX_I2MPB_B_GBE_MASK, (buf[1] + bias[4]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B1,
-+                     MTK_PHY_DA_TX_I2MPB_B_TBT_MASK, buf[1] + bias[5]);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B2,
-+                     MTK_PHY_DA_TX_I2MPB_B_HBT_MASK, (buf[1] + bias[6]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B2,
-+                     MTK_PHY_DA_TX_I2MPB_B_TST_MASK, buf[1] + bias[7]);
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C1,
-+                     MTK_PHY_DA_TX_I2MPB_C_GBE_MASK, (buf[2] + bias[8]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C1,
-+                     MTK_PHY_DA_TX_I2MPB_C_TBT_MASK, buf[2] + bias[9]);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C2,
-+                     MTK_PHY_DA_TX_I2MPB_C_HBT_MASK, (buf[2] + bias[10]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C2,
-+                     MTK_PHY_DA_TX_I2MPB_C_TST_MASK, buf[2] + bias[11]);
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D1,
-+                     MTK_PHY_DA_TX_I2MPB_D_GBE_MASK, (buf[3] + bias[12]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D1,
-+                     MTK_PHY_DA_TX_I2MPB_D_TBT_MASK, buf[3] + bias[13]);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D2,
-+                     MTK_PHY_DA_TX_I2MPB_D_HBT_MASK, (buf[3] + bias[14]) << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D2,
-+                     MTK_PHY_DA_TX_I2MPB_D_TST_MASK, buf[3] + bias[15]);
-+
-+      return 0;
-+}
-+
-+static int tx_amp_cal_efuse(struct phy_device *phydev, u32 *buf)
-+{
-+      u16 tx_amp_cal_val[4];
-+
-+      tx_amp_cal_val[0] = EFS_DA_TX_I2MPB_A(buf[0]);
-+      tx_amp_cal_val[1] = EFS_DA_TX_I2MPB_B(buf[0]);
-+      tx_amp_cal_val[2] = EFS_DA_TX_I2MPB_C(buf[0]);
-+      tx_amp_cal_val[3] = EFS_DA_TX_I2MPB_D(buf[0]);
-+      tx_amp_fill_result(phydev, tx_amp_cal_val);
-+
-+      return 0;
-+}
-+
-+static int tx_r50_fill_result(struct phy_device *phydev, u16 tx_r50_cal_val,
-+                            u8 txg_calen_x)
-+{
-+      int bias = 0;
-+      u16 reg, val;
-+
-+      switch (phydev->drv->phy_id) {
-+      case 0x03a29481:
-+      {
-+              bias = -2;
-+              break;
-+      }
-+      /* 0x03a29461 enters default case */
-+      default:
-+              break;
-+      }
-+
-+      val = clamp_val(bias + tx_r50_cal_val, 0, 63);
-+
-+      switch (txg_calen_x) {
-+      case PAIR_A:
-+              reg = MTK_PHY_DA_TX_R50_PAIR_A;
-+              break;
-+      case PAIR_B:
-+              reg = MTK_PHY_DA_TX_R50_PAIR_B;
-+              break;
-+      case PAIR_C:
-+              reg = MTK_PHY_DA_TX_R50_PAIR_C;
-+              break;
-+      case PAIR_D:
-+              reg = MTK_PHY_DA_TX_R50_PAIR_D;
-+              break;
-+      }
-+
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, reg, val | val << 8);
-+
-+      return 0;
-+}
-+
-+static int tx_r50_cal_efuse(struct phy_device *phydev, u32 *buf,
-+                          u8 txg_calen_x)
-+{
-+      u16 tx_r50_cal_val;
-+
-+      switch (txg_calen_x) {
-+      case PAIR_A:
-+              tx_r50_cal_val = EFS_DA_TX_R50_A(buf[1]);
-+              break;
-+      case PAIR_B:
-+              tx_r50_cal_val = EFS_DA_TX_R50_B(buf[1]);
-+              break;
-+      case PAIR_C:
-+              tx_r50_cal_val = EFS_DA_TX_R50_C(buf[2]);
-+              break;
-+      case PAIR_D:
-+              tx_r50_cal_val = EFS_DA_TX_R50_D(buf[2]);
-+              break;
-+      }
-+      tx_r50_fill_result(phydev, tx_r50_cal_val, txg_calen_x);
-+
-+      return 0;
-+}
-+
-+static int tx_r50_cal_sw(struct phy_device *phydev, u8 txg_calen_x)
-+{
-+      u8 zcal_lower, zcal_upper, rg_zcal_ctrl;
-+      u8 lower_ret, upper_ret;
-+      u8 rg_zcal_ctrl_def;
-+      u16 tx_r50_cal_val;
-+      int ret;
-+
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_ANA_TEST_BUS_CTRL_RG,
-+                     MTK_PHY_ANA_TEST_MODE_MASK, MTK_PHY_TANA_CAL_MODE << 8);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
-+                         MTK_PHY_RG_TXVOS_CALEN);
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                       MTK_PHY_RG_CAL_CKINV | MTK_PHY_RG_ANA_CALEN);
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG2,
-+                       BIT(txg_calen_x * 4));
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_DASN_TXT_DMY2,
-+                     MTK_PHY_TST_DMY2_MASK, 0x1);
-+
-+      rg_zcal_ctrl_def = phy_read_mmd(phydev, MDIO_MMD_VEND1,
-+                                      MTK_PHY_RG_ANA_CAL_RG5) &
-+                         MTK_PHY_RG_ZCAL_CTRL_MASK;
-+      zcal_lower = ZCAL_CTRL_MIN;
-+      zcal_upper = ZCAL_CTRL_MAX;
-+
-+      dev_dbg(&phydev->mdio.dev, "Start TX-R50 Pair%c SW cal.\n",
-+              pair[txg_calen_x]);
-+      while ((zcal_upper - zcal_lower) > 1) {
-+              rg_zcal_ctrl = DIV_ROUND_CLOSEST(zcal_lower + zcal_upper, 2);
-+              ret = cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
-+                              MTK_PHY_RG_ZCAL_CTRL_MASK, rg_zcal_ctrl);
-+              if (ret == 1) {
-+                      zcal_upper = rg_zcal_ctrl;
-+                      upper_ret = ret;
-+              } else if (ret == 0) {
-+                      zcal_lower = rg_zcal_ctrl;
-+                      lower_ret = ret;
-+              } else {
-+                      goto restore;
-+              }
-+      }
-+
-+      if (zcal_lower == ZCAL_CTRL_MIN) {
-+              lower_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RG_ANA_CAL_RG5,
-+                                    MTK_PHY_RG_ZCAL_CTRL_MASK, zcal_lower);
-+              ret = lower_ret;
-+      } else if (zcal_upper == ZCAL_CTRL_MAX) {
-+              upper_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RG_ANA_CAL_RG5,
-+                                    MTK_PHY_RG_ZCAL_CTRL_MASK, zcal_upper);
-+              ret = upper_ret;
-+      }
-+      if (ret < 0)
-+              goto restore;
-+
-+      ret = upper_ret - lower_ret;
-+      if (ret == 1) {
-+              tx_r50_cal_val = mt798x_zcal_to_r50[zcal_upper];
-+              tx_r50_fill_result(phydev, tx_r50_cal_val, txg_calen_x);
-+              dev_info(&phydev->mdio.dev,
-+                       "TX-R50 Pair%c SW cal result: 0x%x\n",
-+                       pair[txg_calen_x], zcal_lower);
-+              ret = 0;
-+      } else {
-+              ret = -EINVAL;
-+      }
-+
-+restore:
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_ANA_TEST_BUS_CTRL_RG,
-+                         MTK_PHY_ANA_TEST_MODE_MASK);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                         MTK_PHY_RG_CAL_CKINV | MTK_PHY_RG_ANA_CALEN);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG2,
-+                         BIT(txg_calen_x * 4));
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_RG_DASN_TXT_DMY2,
-+                         MTK_PHY_TST_DMY2_MASK);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG5,
-+                     MTK_PHY_RG_ZCAL_CTRL_MASK, rg_zcal_ctrl_def);
-+
-+      return ret;
-+}
-+
-+static int tx_vcm_cal_sw(struct phy_device *phydev, u8 rg_txreserve_x)
-+{
-+      u8 lower_idx, upper_idx, txreserve_val;
-+      u8 lower_ret, upper_ret;
-+      int ret;
-+
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                       MTK_PHY_RG_ANA_CALEN);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                         MTK_PHY_RG_CAL_CKINV);
-+      phy_set_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
-+                       MTK_PHY_RG_TXVOS_CALEN);
-+
-+      switch (rg_txreserve_x) {
-+      case PAIR_A:
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN0_A,
-+                                 MTK_PHY_DASN_DAC_IN0_A_MASK);
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN1_A,
-+                                 MTK_PHY_DASN_DAC_IN1_A_MASK);
-+              phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                               MTK_PHY_RG_ANA_CAL_RG0,
-+                               MTK_PHY_RG_ZCALEN_A);
-+              break;
-+      case PAIR_B:
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN0_B,
-+                                 MTK_PHY_DASN_DAC_IN0_B_MASK);
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN1_B,
-+                                 MTK_PHY_DASN_DAC_IN1_B_MASK);
-+              phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                               MTK_PHY_RG_ANA_CAL_RG1,
-+                               MTK_PHY_RG_ZCALEN_B);
-+              break;
-+      case PAIR_C:
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN0_C,
-+                                 MTK_PHY_DASN_DAC_IN0_C_MASK);
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN1_C,
-+                                 MTK_PHY_DASN_DAC_IN1_C_MASK);
-+              phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                               MTK_PHY_RG_ANA_CAL_RG1,
-+                               MTK_PHY_RG_ZCALEN_C);
-+              break;
-+      case PAIR_D:
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN0_D,
-+                                 MTK_PHY_DASN_DAC_IN0_D_MASK);
-+              phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                                 MTK_PHY_RG_DASN_DAC_IN1_D,
-+                                 MTK_PHY_DASN_DAC_IN1_D_MASK);
-+              phy_set_bits_mmd(phydev, MDIO_MMD_VEND1,
-+                               MTK_PHY_RG_ANA_CAL_RG1,
-+                               MTK_PHY_RG_ZCALEN_D);
-+              break;
-+      default:
-+              ret = -EINVAL;
-+              goto restore;
-+      }
-+
-+      lower_idx = TXRESERVE_MIN;
-+      upper_idx = TXRESERVE_MAX;
-+
-+      dev_dbg(&phydev->mdio.dev, "Start TX-VCM SW cal.\n");
-+      while ((upper_idx - lower_idx) > 1) {
-+              txreserve_val = DIV_ROUND_CLOSEST(lower_idx + upper_idx, 2);
-+              ret = cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
-+                              MTK_PHY_DA_RX_PSBN_TBT_MASK |
-+                              MTK_PHY_DA_RX_PSBN_HBT_MASK |
-+                              MTK_PHY_DA_RX_PSBN_GBE_MASK |
-+                              MTK_PHY_DA_RX_PSBN_LP_MASK,
-+                              txreserve_val << 12 | txreserve_val << 8 |
-+                              txreserve_val << 4 | txreserve_val);
-+              if (ret == 1) {
-+                      upper_idx = txreserve_val;
-+                      upper_ret = ret;
-+              } else if (ret == 0) {
-+                      lower_idx = txreserve_val;
-+                      lower_ret = ret;
-+              } else {
-+                      goto restore;
-+              }
-+      }
-+
-+      if (lower_idx == TXRESERVE_MIN) {
-+              lower_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RXADC_CTRL_RG9,
-+                                    MTK_PHY_DA_RX_PSBN_TBT_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_HBT_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_GBE_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_LP_MASK,
-+                                    lower_idx << 12 | lower_idx << 8 |
-+                                    lower_idx << 4 | lower_idx);
-+              ret = lower_ret;
-+      } else if (upper_idx == TXRESERVE_MAX) {
-+              upper_ret = cal_cycle(phydev, MDIO_MMD_VEND1,
-+                                    MTK_PHY_RXADC_CTRL_RG9,
-+                                    MTK_PHY_DA_RX_PSBN_TBT_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_HBT_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_GBE_MASK |
-+                                    MTK_PHY_DA_RX_PSBN_LP_MASK,
-+                                    upper_idx << 12 | upper_idx << 8 |
-+                                    upper_idx << 4 | upper_idx);
-+              ret = upper_ret;
-+      }
-+      if (ret < 0)
-+              goto restore;
-+
-+      /* We calibrate TX-VCM in different logic. Check upper index and then
-+       * lower index. If this calibration is valid, apply lower index's result.
-+       */
-+      ret = upper_ret - lower_ret;
-+      if (ret == 1) {
-+              ret = 0;
-+              /* Make sure we use upper_idx in our calibration system */
-+              cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
-+                        MTK_PHY_DA_RX_PSBN_TBT_MASK |
-+                        MTK_PHY_DA_RX_PSBN_HBT_MASK |
-+                        MTK_PHY_DA_RX_PSBN_GBE_MASK |
-+                        MTK_PHY_DA_RX_PSBN_LP_MASK,
-+                        upper_idx << 12 | upper_idx << 8 |
-+                        upper_idx << 4 | upper_idx);
-+              dev_info(&phydev->mdio.dev, "TX-VCM SW cal result: 0x%x\n",
-+                       upper_idx);
-+      } else if (lower_idx == TXRESERVE_MIN && upper_ret == 1 &&
-+                 lower_ret == 1) {
-+              ret = 0;
-+              cal_cycle(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG9,
-+                        MTK_PHY_DA_RX_PSBN_TBT_MASK |
-+                        MTK_PHY_DA_RX_PSBN_HBT_MASK |
-+                        MTK_PHY_DA_RX_PSBN_GBE_MASK |
-+                        MTK_PHY_DA_RX_PSBN_LP_MASK,
-+                        lower_idx << 12 | lower_idx << 8 |
-+                        lower_idx << 4 | lower_idx);
-+              dev_warn(&phydev->mdio.dev,
-+                       "TX-VCM SW cal result at low margin 0x%x\n",
-+                       lower_idx);
-+      } else if (upper_idx == TXRESERVE_MAX && upper_ret == 0 &&
-+                 lower_ret == 0) {
-+              ret = 0;
-+              dev_warn(&phydev->mdio.dev,
-+                       "TX-VCM SW cal result at high margin 0x%x\n",
-+                       upper_idx);
-+      } else {
-+              ret = -EINVAL;
-+      }
-+
-+restore:
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                         MTK_PHY_RG_ANA_CALEN);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
-+                         MTK_PHY_RG_TXVOS_CALEN);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG0,
-+                         MTK_PHY_RG_ZCALEN_A);
-+      phy_clear_bits_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_ANA_CAL_RG1,
-+                         MTK_PHY_RG_ZCALEN_B | MTK_PHY_RG_ZCALEN_C |
-+                         MTK_PHY_RG_ZCALEN_D);
-+
-+      return ret;
-+}
-+
-+static inline void mt7981_phy_finetune(struct phy_device *phydev)
-+{
-+      u32 i;
-+
-+      /* 100M eye finetune:
-+       * Keep middle level of TX MLT3 shapper as default.
-+       * Only change TX MLT3 overshoot level here.
-+       */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_1st_OVERSHOOT_LEVEL_0TO1,
-+                    0x1ce);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_2nd_OVERSHOOT_LEVEL_0TO1,
-+                    0x1c1);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_1st_OVERSHOOT_LEVEL_1TO0,
-+                    0x20f);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_2nd_OVERSHOOT_LEVEL_1TO0,
-+                    0x202);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_1st_OVERSHOOT_LEVEL_0TON1,
-+                    0x3d0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_2nd_OVERSHOOT_LEVEL_0TON1,
-+                    0x3c0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_1st_OVERSHOOT_LEVEL_N1TO0,
-+                    0x13);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_2nd_OVERSHOOT_LEVEL_N1TO0,
-+                    0x5);
-+
-+      /* TX-AMP finetune:
-+       * 100M +4, 1000M +6 to default value.
-+       * If efuse values aren't valid, TX-AMP uses the below values.
-+       */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TXVLD_DA_RG, 0x9824);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_A2,
-+                    0x9026);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B1,
-+                    0x2624);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_B2,
-+                    0x2426);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C1,
-+                    0x2624);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_C2,
-+                    0x2426);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D1,
-+                    0x2624);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_TX_I2MPB_TEST_MODE_D2,
-+                    0x2426);
-+
-+      phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
-+      /* EnabRandUpdTrig = 1 */
-+      __phy_write(phydev, 0x11, 0x2f00);
-+      __phy_write(phydev, 0x12, 0xe);
-+      __phy_write(phydev, 0x10, 0x8fb0);
-+
-+      /* SlvDSPreadyTime = 0xc */
-+      __phy_write(phydev, 0x11, 0x671);
-+      __phy_write(phydev, 0x12, 0xc);
-+      __phy_write(phydev, 0x10, 0x8fae);
-+
-+      /* NormMseLoThresh = 85 */
-+      __phy_write(phydev, 0x11, 0x55a0);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x83aa);
-+
-+      /* InhibitDisableDfeTail1000 = 1 */
-+      __phy_write(phydev, 0x11, 0x2b);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x8f80);
-+
-+      /* SSTr related */
-+      __phy_write(phydev, 0x11, 0xbaef);
-+      __phy_write(phydev, 0x12, 0x2e);
-+      __phy_write(phydev, 0x10, 0x968c);
-+
-+      /* VcoSlicerThreshBitsHigh */
-+      __phy_write(phydev, 0x11, 0x5555);
-+      __phy_write(phydev, 0x12, 0x55);
-+      __phy_write(phydev, 0x10, 0x8ec0);
-+
-+      /* ResetSyncOffset = 6 */
-+      __phy_write(phydev, 0x11, 0x600);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x8fc0);
-+
-+      /* VgaDecRate = 1 */
-+      __phy_write(phydev, 0x11, 0x4c2a);
-+      __phy_write(phydev, 0x12, 0x3e);
-+      __phy_write(phydev, 0x10, 0x8fa4);
-+
-+      phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
-+      /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 9*/
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG234,
-+                     MTK_PHY_TR_OPEN_LOOP_EN_MASK | MTK_PHY_LPF_X_AVERAGE_MASK,
-+                     BIT(0) | FIELD_PREP(MTK_PHY_LPF_X_AVERAGE_MASK, 0x9));
-+
-+      /* rg_tr_lpf_cnt_val = 512 */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LPF_CNT_VAL, 0x200);
-+
-+      /* IIR2 related */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_L, 0x82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_L, 0x103);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_L, 0x82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_L, 0xd177);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_U, 0x3);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_L, 0x2c82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_U, 0xe);
-+
-+      /* FFE peaking */
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27C,
-+                     MTK_PHY_VGASTATE_FFE_THR_ST1_MASK, 0x1b << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27D,
-+                     MTK_PHY_VGASTATE_FFE_THR_ST2_MASK, 0x1e);
-+
-+      /* TX shape */
-+      /* 10/100/1000 TX shaper is enabled by default */
-+      for (i = 0x202; i < 0x230; i += 2) {
-+              if (i == 0x20c || i == 0x218 || i == 0x224)
-+                      continue;
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, i, 0x2219);
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, i + 1, 0x23);
-+      }
-+}
-+
-+static inline void mt7988_phy_finetune(struct phy_device *phydev)
-+{
-+      u16 val[12] = { 0x0187, 0x01cd, 0x01c8, 0x0182,
-+                      0x020d, 0x0206, 0x0384, 0x03d0,
-+                      0x03c6, 0x030a, 0x0011, 0x0005 };
-+      int i;
-+
-+      for (i = 0; i < MTK_PHY_TX_MLT3_END; i++)
-+              phy_write_mmd(phydev, MDIO_MMD_VEND1, i, val[i]);
-+
-+      /* TCT finetune */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_TX_FILTER, 0x5);
-+
-+      /* Disable TX power saving */
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RXADC_CTRL_RG7,
-+                     MTK_PHY_DA_AD_BUF_BIAS_LP_MASK, 0x3 << 8);
-+
-+      phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_52B5);
-+      /* EnabRandUpdTrig = 1 */
-+      __phy_write(phydev, 0x11, 0x2f00);
-+      __phy_write(phydev, 0x12, 0xe);
-+      __phy_write(phydev, 0x10, 0x8fb0);
-+
-+      /* SlvDSPreadyTime = 0xc */
-+      __phy_write(phydev, 0x11, 0x671);
-+      __phy_write(phydev, 0x12, 0xc);
-+      __phy_write(phydev, 0x10, 0x8fae);
-+
-+      /* NormMseLoThresh = 85 */
-+      __phy_write(phydev, 0x11, 0x55a0);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x83aa);
-+
-+      /* InhibitDisableDfeTail1000 = 1 */
-+      __phy_write(phydev, 0x11, 0x2b);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x8f80);
-+
-+      /* SSTr related */
-+      __phy_write(phydev, 0x11, 0xbaef);
-+      __phy_write(phydev, 0x12, 0x2e);
-+      __phy_write(phydev, 0x10, 0x968c);
-+
-+      /* MrvlTrFix100Kp = 3, MrvlTrFix100Kf = 2,
-+       * MrvlTrFix1000Kp = 3, MrvlTrFix1000Kf = 2
-+       */
-+      __phy_write(phydev, 0x11, 0xd10a);
-+      __phy_write(phydev, 0x12, 0x34);
-+      __phy_write(phydev, 0x10, 0x8f82);
-+
-+      /* VcoSlicerThreshBitsHigh */
-+      __phy_write(phydev, 0x11, 0x5555);
-+      __phy_write(phydev, 0x12, 0x55);
-+      __phy_write(phydev, 0x10, 0x8ec0);
-+
-+      /* ResetSyncOffset = 5 */
-+      __phy_write(phydev, 0x11, 0x500);
-+      __phy_write(phydev, 0x12, 0x0);
-+      __phy_write(phydev, 0x10, 0x8fc0);
-+      phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
-+
-+      phy_select_page(phydev, MTK_PHY_PAGE_EXTENDED_2A30);
-+      /* TxClkOffset = 2 */
-+      __phy_modify(phydev, MTK_PHY_ANARG_RG, MTK_PHY_TCLKOFFSET_MASK,
-+                   FIELD_PREP(MTK_PHY_TCLKOFFSET_MASK, 0x2));
-+      phy_restore_page(phydev, MTK_PHY_PAGE_STANDARD, 0);
-+
-+      /* TR_OPEN_LOOP_EN = 1, lpf_x_average = 9*/
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG234,
-+                     MTK_PHY_TR_OPEN_LOOP_EN_MASK | MTK_PHY_LPF_X_AVERAGE_MASK,
-+                     BIT(0) | FIELD_PREP(MTK_PHY_LPF_X_AVERAGE_MASK, 0x9));
-+
-+      /* rg_tr_lpf_cnt_val = 512 */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LPF_CNT_VAL, 0x200);
-+
-+      /* IIR2 related */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_L, 0x82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K1_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_L, 0x103);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K2_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_L, 0x82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K3_U, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_L, 0xd177);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K4_U, 0x3);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_L, 0x2c82);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_LP_IIR2_K5_U, 0xe);
-+
-+      /* FFE peaking */
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27C,
-+                     MTK_PHY_VGASTATE_FFE_THR_ST1_MASK, 0x1b << 8);
-+      phy_modify_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_RG_DEV1E_REG27D,
-+                     MTK_PHY_VGASTATE_FFE_THR_ST2_MASK, 0x1e);
-+
-+      /* TX shape */
-+      /* 10/100/1000 TX shaper is enabled by default */
-+      for (i = 0x202; i < 0x230; i += 2) {
-+              if (i == 0x20c || i == 0x218 || i == 0x224)
-+                      continue;
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, i, 0x2219);
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, i + 1, 0x23);
-+      }
-+
-+      /* Disable LDO pump */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_PUMP_EN_PAIRAB, 0x0);
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_PUMP_EN_PAIRCD, 0x0);
-+
-+      /* Adjust LDO output voltage */
-+      phy_write_mmd(phydev, MDIO_MMD_VEND1, MTK_PHY_LDO_OUTPUT_V, 0x2222);
-+}
-+
-+static inline int cal_sw(struct phy_device *phydev, enum CAL_ITEM cal_item,
-+                       u8 start_pair, u8 end_pair)
-+{
-+      u8 pair_n;
-+      int ret;
-+
-+      for (pair_n = start_pair; pair_n <= end_pair; pair_n++) {
-+              /* TX_OFFSET & TX_AMP have no SW calibration. */
-+              switch (cal_item) {
-+              case REXT:
-+                      ret = rext_cal_sw(phydev);
-+                      break;
-+              case TX_R50:
-+                      ret = tx_r50_cal_sw(phydev, pair_n);
-+                      break;
-+              case TX_VCM:
-+                      ret = tx_vcm_cal_sw(phydev, pair_n);
-+                      break;
-+              default:
-+                      return -EINVAL;
-+              }
-+              if (ret)
-+                      return ret;
-+      }
-+      return 0;
-+}
-+
-+static inline int cal_efuse(struct phy_device *phydev, enum CAL_ITEM cal_item,
-+                          u8 start_pair, u8 end_pair, u32 *buf)
-+{
-+      u8 pair_n;
-+      int ret;
-+
-+      for (pair_n = start_pair; pair_n <= end_pair; pair_n++) {
-+              /* TX_VCM has no efuse calibration. */
-+              switch (cal_item) {
-+              case REXT:
-+                      ret = rext_cal_efuse(phydev, buf);
-+                      break;
-+              case TX_OFFSET:
-+                      ret = tx_offset_cal_efuse(phydev, buf);
-+                      break;
-+              case TX_AMP:
-+                      ret = tx_amp_cal_efuse(phydev, buf);
-+                      break;
-+              case TX_R50:
-+                      ret = tx_r50_cal_efuse(phydev, buf, pair_n);
-+                      break;
-+              default:
-+                      return -EINVAL;
-+              }
-+              if (ret)
-+                      return ret;
-+      }
-+
-+      return 0;
-+}
-+
-+static int start_cal(struct phy_device *phydev, enum CAL_ITEM cal_item,
-+                   bool efs_valid, enum CAL_MODE cal_mode, u8 start_pair,
-+                   u8 end_pair, u32 *buf)
-+{
-+      char cal_prop[5][20] = { "mediatek,rext", "mediatek,tx_offset",
-+                               "mediatek,tx_amp", "mediatek,tx_r50",
-+                               "mediatek,tx_vcm" };
-+      const char *dts_cal_mode;
-+      u8 final_cal_mode = 0;
-+      bool is_cal = true;
-+      int ret, cal_ret;
-+
-+      ret = of_property_read_string(phydev->mdio.dev.of_node,
-+                                    cal_prop[cal_item], &dts_cal_mode);
-+
-+      switch (cal_mode) {
-+      case SW_EFUSE_M:
-+              if ((efs_valid && ret) ||
-+                  (efs_valid && !ret && strcmp("efuse", dts_cal_mode) == 0)) {
-+                      cal_ret = cal_efuse(phydev, cal_item, start_pair,
-+                                          end_pair, buf);
-+                      final_cal_mode = EFUSE_K;
-+              } else if ((!efs_valid && ret) ||
-+                      (!ret && strcmp("sw", dts_cal_mode) == 0)) {
-+                      cal_ret = cal_sw(phydev, cal_item, start_pair, end_pair);
-+                      final_cal_mode = SW_K;
-+              } else {
-+                      is_cal = false;
-+              }
-+              break;
-+      case EFUSE_M:
-+              if ((efs_valid && ret) ||
-+                  (efs_valid && !ret && strcmp("efuse", dts_cal_mode) == 0)) {
-+                      cal_ret = cal_efuse(phydev, cal_item, start_pair,
-+                                          end_pair, buf);
-+                      final_cal_mode = EFUSE_K;
-+              } else {
-+                      is_cal = false;
-+              }
-+              break;
-+      case SW_M:
-+              if (ret || (!ret && strcmp("sw", dts_cal_mode) == 0)) {
-+                      cal_ret = cal_sw(phydev, cal_item, start_pair, end_pair);
-+                      final_cal_mode = SW_K;
-+              } else {
-+                      is_cal = false;
-+              }
-+              break;
-+      default:
-+              return -EINVAL;
-+      }
-+
-+      if (cal_ret) {
-+              dev_err(&phydev->mdio.dev, "[%s]cal failed\n", cal_prop[cal_item]);
-+              return -EIO;
-+      }
-+
-+      if (!is_cal) {
-+              dev_dbg(&phydev->mdio.dev, "[%s]K mode: %s(not supported)\n",
-+                      cal_prop[cal_item], dts_cal_mode);
-+              return -EIO;
-+      }
-+
-+      dev_dbg(&phydev->mdio.dev, "[%s]K mode: %s(dts: %s), efs-valid: %s\n",
-+              cal_prop[cal_item],
-+              final_cal_mode ? "SW" : "EFUSE",
-+              ret ? "not set" : dts_cal_mode,
-+              efs_valid ? "yes" : "no");
-+      return 0;
-+}
-+
-+static int mt798x_phy_calibration(struct phy_device *phydev)
-+{
-+      int ret = 0;
-+      u32 *buf;
-+      bool efs_valid = true;
-+      size_t len;
-+      struct nvmem_cell *cell;
-+
-+      if (phydev->interface != PHY_INTERFACE_MODE_GMII)
-+              return -EINVAL;
-+
-+      cell = nvmem_cell_get(&phydev->mdio.dev, "phy-cal-data");
-+      if (IS_ERR(cell)) {
-+              if (PTR_ERR(cell) == -EPROBE_DEFER)
-+                      return PTR_ERR(cell);
-+              return 0;
-+      }
-+
-+      buf = (u32 *)nvmem_cell_read(cell, &len);
-+      if (IS_ERR(buf))
-+              return PTR_ERR(buf);
-+      nvmem_cell_put(cell);
-+
-+      if (!buf[0] || !buf[1] || !buf[2] || !buf[3])
-+              efs_valid = false;
-+
-+      if (len < 4 * sizeof(u32)) {
-+              dev_err(&phydev->mdio.dev, "invalid calibration data\n");
-+              ret = -EINVAL;
-+              goto out;
-+      }
-+
-+      ret = start_cal(phydev, REXT, efs_valid, SW_EFUSE_M,
-+                      NO_PAIR, NO_PAIR, buf);
-+      if (ret)
-+              goto out;
-+      ret = start_cal(phydev, TX_OFFSET, efs_valid, EFUSE_M,
-+                      NO_PAIR, NO_PAIR, buf);
-+      if (ret)
-+              goto out;
-+      ret = start_cal(phydev, TX_AMP, efs_valid, EFUSE_M,
-+                      NO_PAIR, NO_PAIR, buf);
-+      if (ret)
-+              goto out;
-+      ret = start_cal(phydev, TX_R50, efs_valid, EFUSE_M,
-+                      PAIR_A, PAIR_D, buf);
-+      if (ret)
-+              goto out;
-+      ret = start_cal(phydev, TX_VCM, efs_valid, SW_M,
-+                      PAIR_A, PAIR_A, buf);
-+      if (ret)
-+              goto out;
-+
-+out:
-+      kfree(buf);
-+      return ret;
-+}
-+
-+static int mt7981_phy_probe(struct phy_device *phydev)
-+{
-+      mt7981_phy_finetune(phydev);
-+
-+      return mt798x_phy_calibration(phydev);
-+}
-+
-+static int mt7988_phy_probe(struct phy_device *phydev)
-+{
-+      struct device_node *np;
-+      void __iomem *boottrap;
-+      u32 reg;
-+      int port;
-+
-+      /* Setup LED polarity according to boottrap's polarity */
-+      np = of_find_compatible_node(NULL, NULL, "mediatek,boottrap");
-+      if (!np)
-+              return -ENOENT;
-+      boottrap = of_iomap(np, 0);
-+      if (!boottrap)
-+              return -ENOMEM;
-+      reg = readl(boottrap);
-+      port = phydev->mdio.addr;
-+      if ((port == GPHY_PORT0 && reg & BIT(8)) ||
-+          (port == GPHY_PORT1 && reg & BIT(9)) ||
-+          (port == GPHY_PORT2 && reg & BIT(10)) ||
-+          (port == GPHY_PORT3 && reg & BIT(11))) {
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_ON_CTRL,
-+                            MTK_PHY_LED0_ENABLE | MTK_PHY_LED0_ON_LINK10 |
-+                            MTK_PHY_LED0_ON_LINK100 |
-+                            MTK_PHY_LED0_ON_LINK1000);
-+      } else {
-+              phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_ON_CTRL,
-+                            MTK_PHY_LED0_ENABLE | MTK_PHY_LED0_POLARITY |
-+                            MTK_PHY_LED0_ON_LINK10 |
-+                            MTK_PHY_LED0_ON_LINK100 |
-+                            MTK_PHY_LED0_ON_LINK1000);
-+      }
-+      phy_write_mmd(phydev, MDIO_MMD_VEND2, MTK_PHY_LED0_BLINK_CTRL,
-+                    MTK_PHY_LED0_1000TX | MTK_PHY_LED0_1000RX |
-+                    MTK_PHY_LED0_100TX  | MTK_PHY_LED0_100RX  |
-+                    MTK_PHY_LED0_10TX   | MTK_PHY_LED0_10RX);
-+
-+      mt7988_phy_finetune(phydev);
-+
-+      return mt798x_phy_calibration(phydev);
-+}
-+#endif
-+
- static struct phy_driver mtk_gephy_driver[] = {
-       {
-               PHY_ID_MATCH_EXACT(0x03a29412),
-@@ -131,6 +1456,30 @@ static struct phy_driver mtk_gephy_drive
-               .read_page      = mtk_gephy_read_page,
-               .write_page     = mtk_gephy_write_page,
-       },
-+#ifdef CONFIG_MEDIATEK_GE_PHY_SOC
-+      {
-+              PHY_ID_MATCH_EXACT(0x03a29461),
-+              .name           = "MediaTek MT7981 PHY",
-+              .probe          = mt7981_phy_probe,
-+              .config_intr    = genphy_no_config_intr,
-+              .handle_interrupt = genphy_handle_interrupt_no_ack,
-+              .suspend        = genphy_suspend,
-+              .resume         = genphy_resume,
-+              .read_page      = mtk_gephy_read_page,
-+              .write_page     = mtk_gephy_write_page,
-+      },
-+      {
-+              PHY_ID_MATCH_EXACT(0x03a29481),
-+              .name           = "MediaTek MT7988 PHY",
-+              .probe          = mt7988_phy_probe,
-+              .config_intr    = genphy_no_config_intr,
-+              .handle_interrupt = genphy_handle_interrupt_no_ack,
-+              .suspend        = genphy_suspend,
-+              .resume         = genphy_resume,
-+              .read_page      = mtk_gephy_read_page,
-+              .write_page     = mtk_gephy_write_page,
-+      },
-+#endif
- };
+@@ -136,7 +136,8 @@ static struct phy_driver mtk_gephy_drive
  module_phy_driver(mtk_gephy_driver);
-@@ -141,6 +1490,8 @@ static struct mdio_device_id __maybe_unu
- };
  
- MODULE_DESCRIPTION("MediaTek Gigabit Ethernet PHY driver");
-+MODULE_AUTHOR("Daniel Golle <daniel@makrotopia.org>");
-+MODULE_AUTHOR("SkyLake Huang <SkyLake.Huang@mediatek.com>");
- MODULE_AUTHOR("DENG, Qingfang <dqfext@gmail.com>");
- MODULE_LICENSE("GPL");
+ static struct mdio_device_id __maybe_unused mtk_gephy_tbl[] = {
+-      { PHY_ID_MATCH_VENDOR(0x03a29400) },
++      { PHY_ID_MATCH_EXACT(0x03a29441) },
++      { PHY_ID_MATCH_EXACT(0x03a29412) },
+       { }
+ };