squid: fix compilation with libxml (refs #19099)
authorMichael Heimpold <mhei@heimpold.de>
Thu, 25 Aug 2022 06:20:45 +0000 (08:20 +0200)
committerJosef Schlehofer <pepe.schlehofer@gmail.com>
Tue, 13 Feb 2024 13:54:57 +0000 (14:54 +0100)
Add a patch which removes a call in Libxml2Parser.cc to 'xmlSetFeature'.
This function belongs to the 'depreciated' API part and is not
available in OpenWrt builds.

According to my understanding, this call can be removed safely since
it disables the feature "substitute entities" which is disabled by default.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>
(cherry picked from commit 3ec47dc85cc4b191be1b2fee3195680343f770e1)

net/squid/patches/020-libxml-drop-xmlSetFeature.patch [new file with mode: 0644]

diff --git a/net/squid/patches/020-libxml-drop-xmlSetFeature.patch b/net/squid/patches/020-libxml-drop-xmlSetFeature.patch
new file mode 100644 (file)
index 0000000..02be06a
--- /dev/null
@@ -0,0 +1,10 @@
+--- a/src/esi/Libxml2Parser.cc
++++ b/src/esi/Libxml2Parser.cc
+@@ -91,7 +91,6 @@ ESILibxml2Parser::ESILibxml2Parser(ESIPa
+     /* TODO: grab the document encoding from the headers */
+     parser = xmlCreatePushParserCtxt(&sax, static_cast<void *>(this), NULL, 0, NULL);
+-    xmlSetFeature(parser, "substitute entities", 0);
+     if (entity_doc == NULL)
+         entity_doc = htmlNewDoc(NULL, NULL);