Update patch instructions and architecture discovery process.
[web.git] / development.txt
1 ---
2 ---
3 Development
4 ===========
5
6 == The Source Code
7
8 The LEDE project source code starts off with OpenWrt revision r49258. The code
9 is stored inside a git tree which contains all branches and releases ever made
10 by OpenWrt. While importing the sources the tree was normalised and some
11 minor tweaks were made to committer names and mail addresses.
12
13 All repositories can be browsed online through
14 https://git.lede-project.org/[Gitweb] as well.
15
16 === Getting The _LEDE_ Code
17
18 Any _LEDE_ development happens in the main +source.git+ repository which is
19 accessible via both HTTP and HTTPS:
20
21 ----
22 git clone https://git.lede-project.org/source.git
23 ----
24
25 You can find a mirror of the repository on Github:
26
27 ----
28 git clone https://github.com/lede-project/source.git
29 ----
30
31 === Getting the OpenWrt Code
32
33 We keep the original OpenWrt source code up to
34 https://git.lede-project.org/?p=openwrt/source.git;a=commit;h=ee53a240ac902dc83209008a2671e7fdcf55957a[r49258]
35 available, mostly as reference and for historic interest.
36
37 The original OpenWrt Subversion repository has been split up into several Git
38 repositories mapping the various SVN directories and tags to proper Git
39 branches.
40
41 ----
42 git clone https://git.lede-project.org/openwrt/source.git
43 git clone https://git.lede-project.org/openwrt/packages.git
44 git clone https://git.lede-project.org/openwrt/feeds.git
45 git clone https://git.lede-project.org/openwrt/docs.git
46 ----
47
48 === The Web Presence
49
50 The pages you're reading are generated from text files using the
51 http://www.methods.co.nz/asciidoc/[AsciiDoc] suite. Any changes made to the
52 projects web site will be reflected in our +web.git+ repository:
53
54 ----
55 git clone https://git.lede-project.org/web.git
56 ----
57
58 === Submitting Patches
59
60 The biggest difference is that we now accept pull requests. Patches can be submitted as either a pull request on Github or small fixes and minor patches can also be submitted via the mailing list. Submissions should follow these rules:
61
62 . A `Signed-off-by` line must be added to your commit / patch in accordance with Section 1.1 of the https://www.kernel.org/doc/Documentation/SubmittingPatches[Linux Kernel patches guide].
63 .. Git: `git commit --signoff`
64 .. Email: Just add line like `Signed-off-by: Random J Developer <random@developer.example.org>` to the top patch.
65 . TBD
66
67 ==== Github
68
69 There are Github mirrors of the https://github.com/lede-project/source[source] and https://github.com/lede-project/web[web] repos. Simply fork the project to a public repo and submit a pull request.
70
71 ==== Email
72
73 Send an email to the https://lists.infradead.org/mailman/listinfo/lede-dev[development mailing list]. All patches need to be sent in the same format as those that are listed on https://patchwork.ozlabs.org/project/lede/list/[patchwork]. If the patch does not get listed in patchwork then it won't get processed. For example, to print a patch for the most recent commit, `git format-patch -1 --stdout`. Double check that your output conforms before sending.
74
75 === Staging Trees
76
77 To create yourself a staging tree on git.lede-project.org:
78 ----
79 ssh git@git.lede-project.org "create lede/yournick/staging"
80 ssh git@git.lede-project.org "desc lede/yournick/staging Staging tree of Your Name"
81 ----
82
83
84 === Reporting Bugs
85
86 . Please report your bugs using our https://bugs.lede-project.org/[issue tracker]
87 . When reporting bugs please make sure to
88 .. Name the tree/revision
89 .. Name the affected device
90 .. What does it do that it should not do / what does it not do that it should do
91 .. Steps to reproduce
92 .. What you have already done to fix the problem
93 .. Any additional info you thinks is important
94 . Reporting a bug means that you reported a bug. It does not constitute a claim that
95 anyone has to work on fixing it.
96 . Pointless/vague/silly/... bugs reports will be ignored
97 . The better your bug report, the more likely it is that it will be worked on.
98
99
100 === Patch Merging And Tree Life Cycle
101
102 We encourage committers to host their own staging trees where they aggregate patches
103 that they feel responsible for and/or ones that they created themselves. Once the tree
104 has been reviewed and tested it can be proposed for inclusion in the master branch.
105
106 . Trees will be merged into master at any time
107 . Bug fixes can be merged into master directly
108 . PRs can be sent to the patches mailing list from any source and will always be considered
109 for inclusion if the quality of the tree is good and format of submission is correct
110 . Staging trees can be hosted as part of the projects git infrastucture, private servers, ...
111
112 === Kernel updates
113
114 It has proven impractical and a time killer to always be on the very latest kernel within
115 2 days of its release. It has caused these issues.
116
117 . diversification of kernel versions
118 . pressure on maintainers to constantly upgrade rather than stabilise
119 . huge effort invested to upgrade 3-4 times between releases
120 . huge workload to maintain kmod-* packaging
121 . Upgrade to kernels that might not be fully tested
122
123 This is obviously not an invite to sit on ancient and dusty kernels. A sane path in between
124 should be taken that give the community recent kernels without causing unnecessary workload
125 and stability issues.
126
127 There should be a max of three concurrent kernel version. Having only two concurrent versions
128 is better than three.
129
130 In Short - stability should be valued higher than bleeding edge, although bleeding edge is
131 also important, but not as a trade-off to stability.
132
133
134 === Releases
135
136 Generating Releases has already been vastly automated. The remaining parts of the process need
137 to also be automated before the first _LEDE_ release. We will introduce a TESTERS file that is
138 formatted similarly to the MAINTAINERS file of the kernel. Community members can list themselves
139 as testers for a target/profile/device. Once a release has been generated testers should receive
140 an email informing them of the requirement for images to be tested. It needs to be decided if only
141 tested images should be included in the binary release.
142
143 Releases should
144
145 . Happen at least once a year
146 . Have at least one maintenance update
147 . Provide CVE/critical/... fixes for at least one year after the release
148 . Only include maintained targets
149 . Only include targets that have seen on device testing
150 . Be ready when they are ready
151
152 See the TODO page for more info.