bridge.c

   1 /*
   2  * netifd - network interface daemon
   3  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License version 2
   7  * as published by the Free Software Foundation
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14 #include <string.h>
  15 #include <stdlib.h>
  16 #include <stdio.h>
  17 #include <assert.h>
  18 #include <errno.h>
  19
  20 #include "netifd.h"
  21 #include "device.h"
  22 #include "interface.h"
  23 #include "system.h"
  24 #include "ubus.h"
  25
  26 enum {
  27         BRIDGE_ATTR_PORTS,
  28         BRIDGE_ATTR_STP,
  29         BRIDGE_ATTR_FORWARD_DELAY,
  30         BRIDGE_ATTR_PRIORITY,
  31         BRIDGE_ATTR_IGMP_SNOOP,
  32         BRIDGE_ATTR_AGEING_TIME,
  33         BRIDGE_ATTR_HELLO_TIME,
  34         BRIDGE_ATTR_MAX_AGE,
  35         BRIDGE_ATTR_BRIDGE_EMPTY,
  36         BRIDGE_ATTR_MULTICAST_QUERIER,
  37         BRIDGE_ATTR_HASH_MAX,
  38         BRIDGE_ATTR_ROBUSTNESS,
  39         BRIDGE_ATTR_QUERY_INTERVAL,
  40         BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
  41         BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
  42         BRIDGE_ATTR_VLAN_FILTERING,
  43         BRIDGE_ATTR_HAS_VLANS,
  44         BRIDGE_ATTR_STP_KERNEL,
  45         BRIDGE_ATTR_STP_PROTO,
  46         __BRIDGE_ATTR_MAX
  47 };
  48
  49 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
  50         [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
  51         [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
  52         [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
  53         [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
  54         [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
  55         [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
  56         [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
  57         [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
  58         [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
  59         [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
  60         [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
  61         [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
  62         [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
  63         [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
  64         [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
  65         [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
  66         [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
  67         [BRIDGE_ATTR_STP_KERNEL] = { "stp_kernel", BLOBMSG_TYPE_BOOL },
  68         [BRIDGE_ATTR_STP_PROTO] = { "stp_proto", BLOBMSG_TYPE_STRING },
  69 };
  70
  71 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
  72         [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
  73 };
  74
  75 static const struct uci_blob_param_list bridge_attr_list = {
  76         .n_params = __BRIDGE_ATTR_MAX,
  77         .params = bridge_attrs,
  78         .info = bridge_attr_info,
  79
  80         .n_next = 1,
  81         .next = { &device_attr_list },
  82 };
  83
  84 static struct blob_buf b;
  85 static struct device *bridge_create(const char *name, struct device_type *devtype,
  86         struct blob_attr *attr);
  87 static void bridge_config_init(struct device *dev);
  88 static void bridge_dev_vlan_update(struct device *dev);
  89 static void bridge_free(struct device *dev);
  90 static void bridge_stp_init(struct device *dev);
  91 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
  92 static enum dev_change_type
  93 bridge_reload(struct device *dev, struct blob_attr *attr);
  94
  95 static struct device_type bridge_device_type = {
  96         .name = "bridge",
  97         .config_params = &bridge_attr_list,
  98
  99         .bridge_capability = true,
 100         .name_prefix = "br",
 101
 102         .create = bridge_create,
 103         .config_init = bridge_config_init,
 104         .vlan_update = bridge_dev_vlan_update,
 105         .reload = bridge_reload,
 106         .free = bridge_free,
 107         .dump_info = bridge_dump_info,
 108         .stp_init = bridge_stp_init,
 109 };
 110
 111 struct bridge_state {
 112         struct device dev;
 113         device_state_cb set_state;
 114
 115         struct blob_attr *config_data;
 116         struct bridge_config config;
 117         struct blob_attr *ports;
 118         bool active;
 119         bool force_active;
 120         bool has_vlans;
 121
 122         struct uloop_timeout retry;
 123         struct bridge_member *primary_port;
 124         struct vlist_tree members;
 125         int n_present;
 126         int n_failed;
 127 };
 128
 129 struct bridge_member {
 130         struct vlist_node node;
 131         struct bridge_state *bst;
 132         struct device_user dev;
 133         struct uloop_timeout check_timer;
 134         struct device_vlan_range *extra_vlan;
 135         int n_extra_vlan;
 136         uint16_t pvid;
 137         bool present;
 138         bool active;
 139         char name[];
 140 };
 141
 142 static void
 143 bridge_reset_primary(struct bridge_state *bst)
 144 {
 145         struct bridge_member *bm;
 146
 147         if (!bst->primary_port &&
 148             (bst->dev.settings.flags & DEV_OPT_MACADDR))
 149                 return;
 150
 151         bst->primary_port = NULL;
 152         bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
 153         vlist_for_each_element(&bst->members, bm, node) {
 154                 uint8_t *macaddr;
 155
 156                 if (!bm->present)
 157                         continue;
 158
 159                 bst->primary_port = bm;
 160                 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
 161                         macaddr = bm->dev.dev->settings.macaddr;
 162                 else
 163                         macaddr = bm->dev.dev->orig_settings.macaddr;
 164                 memcpy(bst->dev.settings.macaddr, macaddr, 6);
 165                 bst->dev.settings.flags |= DEV_OPT_MACADDR;
 166                 return;
 167         }
 168 }
 169
 170 static struct bridge_vlan_port *
 171 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
 172 {
 173         struct bridge_vlan_hotplug_port *port;
 174         const char *ifname = bm->dev.dev->ifname;
 175         int i;
 176
 177         for (i = 0; i < vlan->n_ports; i++) {
 178                 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
 179                         continue;
 180
 181                 return &vlan->ports[i];
 182         }
 183
 184         list_for_each_entry(port, &vlan->hotplug_ports, list) {
 185                 if (strcmp(port->port.ifname, ifname) != 0)
 186                         continue;
 187
 188                 return &port->port;
 189         }
 190
 191         return NULL;
 192 }
 193
 194 static bool
 195 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
 196 {
 197         return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
 198                (port->flags & BRVLAN_F_PVID);
 199 }
 200
 201 static void
 202 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
 203                          struct bridge_vlan_port *port, bool add)
 204 {
 205         uint16_t flags;
 206
 207         flags = port->flags;
 208         if (bm->pvid == vlan->vid)
 209                 flags |= BRVLAN_F_PVID;
 210
 211         system_bridge_vlan(port->ifname, vlan->vid, -1, add, flags);
 212 }
 213
 214 static void
 215 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
 216 {
 217         struct bridge_vlan_port *port;
 218
 219         if (!bm->present)
 220                 return;
 221
 222         port = bridge_find_vlan_member_port(bm, vlan);
 223         if (!port)
 224                 return;
 225
 226         if (bridge_member_vlan_is_pvid(bm, port))
 227                 bm->pvid = vlan->vid;
 228
 229         __bridge_set_member_vlan(bm, vlan, port, add);
 230 }
 231
 232 static void
 233 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 234 {
 235         if (!vlan->local && add)
 236                 return;
 237
 238         system_bridge_vlan(bst->dev.ifname, vlan->vid, -1, add, BRVLAN_F_SELF);
 239 }
 240
 241 static void
 242 bridge_set_local_vlans(struct bridge_state *bst, bool add)
 243 {
 244         struct bridge_vlan *vlan;
 245
 246         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 247                 bridge_set_local_vlan(bst, vlan, add);
 248 }
 249
 250 static struct bridge_vlan *
 251 bridge_recalc_member_pvid(struct bridge_member *bm)
 252 {
 253         struct bridge_state *bst = bm->bst;
 254         struct bridge_vlan_port *port;
 255         struct bridge_vlan *vlan, *ret = NULL;
 256
 257         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 258                 port = bridge_find_vlan_member_port(bm, vlan);
 259                 if (!port)
 260                         continue;
 261
 262                 if (!bridge_member_vlan_is_pvid(bm, port))
 263                         continue;
 264
 265                 ret = vlan;
 266                 if (port->flags & BRVLAN_F_PVID)
 267                         break;
 268         }
 269
 270         return ret;
 271 }
 272
 273 static void
 274 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 275 {
 276         struct bridge_member *bm;
 277         struct bridge_vlan *vlan2;
 278
 279         bridge_set_local_vlan(bst, vlan, add);
 280
 281         vlist_for_each_element(&bst->members, bm, node) {
 282                 struct bridge_vlan_port *port;
 283                 int new_pvid = -1;
 284
 285                 port = bridge_find_vlan_member_port(bm, vlan);
 286                 if (!port)
 287                         continue;
 288
 289                 if (add) {
 290                         if (bridge_member_vlan_is_pvid(bm, port))
 291                                 bm->pvid = vlan->vid;
 292                 } else if (bm->pvid == vlan->vid) {
 293                         vlan2 = bridge_recalc_member_pvid(bm);
 294                         if (vlan2 && vlan2->vid != vlan->vid) {
 295                                 bridge_set_member_vlan(bm, vlan2, false);
 296                                 bridge_set_member_vlan(bm, vlan2, true);
 297                         }
 298                         new_pvid = vlan2 ? vlan2->vid : 0;
 299                 }
 300
 301                 if (!bm->present)
 302                         continue;
 303
 304                 __bridge_set_member_vlan(bm, vlan, port, add);
 305                 if (new_pvid >= 0)
 306                         bm->pvid = new_pvid;
 307         }
 308 }
 309
 310 static int
 311 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
 312 {
 313         struct bridge_state *bst = bm->bst;
 314         struct bridge_vlan *vlan;
 315
 316         if (!bm->present || !bm->active)
 317                 return 0;
 318
 319         bm->active = false;
 320         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 321                 bridge_set_member_vlan(bm, vlan, false);
 322
 323         system_bridge_delif(&bst->dev, bm->dev.dev);
 324         if (!keep_dev)
 325                 device_release(&bm->dev);
 326
 327         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 328
 329         return 0;
 330 }
 331
 332 static void bridge_stp_notify(struct bridge_state *bst)
 333 {
 334         struct bridge_config *cfg = &bst->config;
 335
 336         if (!cfg->stp || cfg->stp_kernel)
 337                 return;
 338
 339         blob_buf_init(&b, 0);
 340         blobmsg_add_string(&b, "name", bst->dev.ifname);
 341         if (cfg->stp_proto)
 342                 blobmsg_add_string(&b, "proto", cfg->stp_proto);
 343         blobmsg_add_u32(&b, "forward_delay", cfg->forward_delay);
 344         blobmsg_add_u32(&b, "hello_time", cfg->hello_time);
 345         blobmsg_add_u32(&b, "max_age", cfg->max_age);
 346         if (cfg->flags & BRIDGE_OPT_AGEING_TIME)
 347                 blobmsg_add_u32(&b, "ageing_time", cfg->ageing_time);
 348         netifd_ubus_device_notify("stp_init", b.head, 1000);
 349 }
 350
 351 static int
 352 bridge_enable_interface(struct bridge_state *bst)
 353 {
 354         struct device *dev = &bst->dev;
 355         int i, ret;
 356
 357         if (bst->active)
 358                 return 0;
 359
 360         bridge_stp_notify(bst);
 361         ret = system_bridge_addbr(dev, &bst->config);
 362         if (ret < 0)
 363                 return ret;
 364
 365         if (bst->has_vlans) {
 366                 /* delete default VLAN 1 */
 367                 system_bridge_vlan(bst->dev.ifname, 1, -1, false, BRVLAN_F_SELF);
 368
 369                 bridge_set_local_vlans(bst, true);
 370         }
 371
 372         for (i = 0; i < dev->n_extra_vlan; i++)
 373                 system_bridge_vlan(dev->ifname, dev->extra_vlan[i].start,
 374                                    dev->extra_vlan[i].end, true, BRVLAN_F_SELF);
 375
 376         bst->active = true;
 377         return 0;
 378 }
 379
 380 static void
 381 bridge_stp_init(struct device *dev)
 382 {
 383         struct bridge_state *bst;
 384
 385         bst = container_of(dev, struct bridge_state, dev);
 386         if (!bst->config.stp || !bst->active)
 387                 return;
 388
 389         bridge_stp_notify(bst);
 390         system_bridge_set_stp_state(&bst->dev, false);
 391         system_bridge_set_stp_state(&bst->dev, true);
 392 }
 393
 394 static void
 395 bridge_disable_interface(struct bridge_state *bst)
 396 {
 397         if (!bst->active)
 398                 return;
 399
 400         system_bridge_delbr(&bst->dev);
 401         bst->active = false;
 402 }
 403
 404 static struct bridge_vlan *
 405 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid, bool create)
 406 {
 407         struct bridge_vlan *vlan;
 408
 409         vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
 410         if (vlan || !create)
 411                 return vlan;
 412
 413         vlan = calloc(1, sizeof(*vlan));
 414         vlan->vid = vid;
 415         vlan->local = true;
 416         INIT_LIST_HEAD(&vlan->hotplug_ports);
 417         vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
 418         vlan->node.version = -1;
 419
 420         return vlan;
 421 }
 422
 423 static struct bridge_vlan_hotplug_port *
 424 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
 425 {
 426         struct bridge_vlan_hotplug_port *port;
 427
 428         list_for_each_entry(port, &vlan->hotplug_ports, list)
 429                 if (!strcmp(port->port.ifname, ifname))
 430                         return port;
 431
 432         return NULL;
 433 }
 434
 435 static void
 436 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
 437                                 struct bridge_member *bm, bool add, bool untracked)
 438 {
 439         const char *ifname = bm->name;
 440         struct device_vlan_range *r;
 441         struct bridge_vlan *vlan;
 442         struct blob_attr *cur;
 443         int n_vlans;
 444         size_t rem;
 445
 446         if (!vlans)
 447                 return;
 448
 449         if (add) {
 450                 bm->n_extra_vlan = 0;
 451                 n_vlans = blobmsg_check_array(vlans, BLOBMSG_TYPE_STRING);
 452                 if (n_vlans < 1)
 453                         return;
 454
 455                 bm->extra_vlan = realloc(bm->extra_vlan, n_vlans * sizeof(*bm->extra_vlan));
 456         }
 457
 458         blobmsg_for_each_attr(cur, vlans, rem) {
 459                 struct bridge_vlan_hotplug_port *port;
 460                 unsigned int vid, vid_end;
 461                 uint16_t flags = 0;
 462                 char *name_buf;
 463                 char *end;
 464
 465                 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
 466                         continue;
 467
 468                 vid = strtoul(blobmsg_get_string(cur), &end, 0);
 469                 vid_end = vid;
 470                 if (!vid || vid > 4095)
 471                         continue;
 472
 473                 if (*end == '-') {
 474                         vid_end = strtoul(end + 1, &end, 0);
 475                         if (vid_end < vid)
 476                                 continue;
 477                 }
 478
 479                 if (end && *end) {
 480                         if (*end != ':')
 481                                 continue;
 482
 483                         for (end++; *end; end++) {
 484                                 switch (*end) {
 485                                 case 'u':
 486                                         flags |= BRVLAN_F_UNTAGGED;
 487                                         fallthrough;
 488                                 case '*':
 489                                         flags |= BRVLAN_F_PVID;
 490                                         break;
 491                                 }
 492                         }
 493                 }
 494
 495                 vlan = bridge_hotplug_get_vlan(bst, vid, !!flags);
 496                 if (!vlan || vid_end > vid || untracked) {
 497                         if (add) {
 498                                 if (!untracked) {
 499                                         r = &bm->extra_vlan[bm->n_extra_vlan++];
 500                                         r->start = vid;
 501                                         r->end = vid_end;
 502                                 }
 503                                 if (bm->active)
 504                                         system_bridge_vlan(ifname, vid, vid_end, true, flags);
 505                         } else if (bm->active) {
 506                                 system_bridge_vlan(ifname, vid, vid_end, false, 0);
 507                         }
 508                         continue;
 509                 }
 510
 511                 if (vlan->pending) {
 512                         vlan->pending = false;
 513                         bridge_set_vlan_state(bst, vlan, true);
 514                 }
 515
 516                 port = bridge_hotplug_get_vlan_port(vlan, ifname);
 517                 if (!add) {
 518                         if (!port)
 519                                 continue;
 520
 521                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 522                         list_del(&port->list);
 523                         free(port);
 524                         continue;
 525                 }
 526
 527                 if (port) {
 528                         if (port->port.flags == flags)
 529                                 continue;
 530
 531                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 532                         port->port.flags = flags;
 533                         __bridge_set_member_vlan(bm, vlan, &port->port, true);
 534                         continue;
 535                 }
 536
 537                 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
 538                 if (!port)
 539                         continue;
 540
 541                 port->port.flags = flags;
 542                 port->port.ifname = strcpy(name_buf, ifname);
 543                 list_add_tail(&port->list, &vlan->hotplug_ports);
 544
 545                 if (!bm)
 546                         continue;
 547
 548                 __bridge_set_member_vlan(bm, vlan, &port->port, true);
 549         }
 550 }
 551
 552
 553 static void
 554 bridge_member_add_extra_vlans(struct bridge_member *bm)
 555 {
 556         struct device *dev = bm->dev.dev;
 557         int i;
 558
 559         for (i = 0; i < dev->n_extra_vlan; i++)
 560                 system_bridge_vlan(dev->ifname, dev->extra_vlan[i].start,
 561                                    dev->extra_vlan[i].end, true, 0);
 562         for (i = 0; i < bm->n_extra_vlan; i++)
 563                 system_bridge_vlan(dev->ifname, bm->extra_vlan[i].start,
 564                                    bm->extra_vlan[i].end, true, 0);
 565 }
 566
 567 static int
 568 bridge_enable_member(struct bridge_member *bm)
 569 {
 570         struct bridge_state *bst = bm->bst;
 571         struct bridge_vlan *vlan;
 572         struct device *dev;
 573         int ret;
 574
 575         if (!bm->present)
 576                 return 0;
 577
 578         ret = bridge_enable_interface(bst);
 579         if (ret)
 580                 goto error;
 581
 582         /* Disable IPv6 for bridge members */
 583         if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
 584                 bm->dev.dev->settings.ipv6 = 0;
 585                 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
 586         }
 587
 588         ret = device_claim(&bm->dev);
 589         if (ret < 0)
 590                 goto error;
 591
 592         dev = bm->dev.dev;
 593         if (dev->settings.auth && !dev->auth_status)
 594                 return -1;
 595
 596         if (bm->active)
 597                 return 0;
 598
 599         ret = system_bridge_addif(&bst->dev, bm->dev.dev);
 600         if (ret < 0) {
 601                 D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
 602                 goto error;
 603         }
 604
 605         bm->active = true;
 606         if (bst->has_vlans) {
 607                 /* delete default VLAN 1 */
 608                 system_bridge_vlan(bm->dev.dev->ifname, 1, -1, false, 0);
 609
 610                 bridge_member_add_extra_vlans(bm);
 611                 vlist_for_each_element(&bst->dev.vlans, vlan, node)
 612                         bridge_set_member_vlan(bm, vlan, true);
 613                 if (dev->settings.auth && dev->auth_vlans)
 614                         bridge_hotplug_set_member_vlans(bst, dev->auth_vlans, bm, true, true);
 615         }
 616
 617         device_set_present(&bst->dev, true);
 618         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 619
 620         return 0;
 621
 622 error:
 623         bst->n_failed++;
 624         bm->present = false;
 625         bst->n_present--;
 626         device_release(&bm->dev);
 627
 628         return ret;
 629 }
 630
 631 static void
 632 bridge_remove_member(struct bridge_member *bm)
 633 {
 634         struct bridge_state *bst = bm->bst;
 635
 636         if (!bm->present)
 637                 return;
 638
 639         if (bst->dev.active)
 640                 bridge_disable_member(bm, false);
 641
 642         bm->present = false;
 643         bm->bst->n_present--;
 644
 645         if (bm == bst->primary_port)
 646                 bridge_reset_primary(bst);
 647
 648         if (bst->config.bridge_empty)
 649                 return;
 650
 651         bst->force_active = false;
 652         if (bst->n_present == 0)
 653                 device_set_present(&bst->dev, false);
 654 }
 655
 656 static void
 657 bridge_free_member(struct bridge_member *bm)
 658 {
 659         struct bridge_state *bst = bm->bst;
 660         struct device *dev = bm->dev.dev;
 661         const char *ifname = dev->ifname;
 662         struct bridge_vlan *vlan;
 663
 664         bridge_remove_member(bm);
 665
 666 restart:
 667         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 668                 struct bridge_vlan_hotplug_port *port, *tmp;
 669                 bool free_port = false;
 670
 671                 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
 672                         if (strcmp(port->port.ifname, ifname) != 0)
 673                                 continue;
 674
 675                         list_del(&port->list);
 676                         free(port);
 677                         free_port = true;
 678                 }
 679
 680                 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
 681                     vlan->n_ports || vlan->node.version != -1)
 682                         continue;
 683
 684                 vlist_delete(&bst->dev.vlans, &vlan->node);
 685                 goto restart;
 686         }
 687
 688         device_remove_user(&bm->dev);
 689         uloop_timeout_cancel(&bm->check_timer);
 690
 691         /*
 692          * When reloading the config and moving a device from one bridge to
 693          * another, the other bridge may have tried to claim this device
 694          * before it was removed here.
 695          * Ensure that claiming the device is retried by toggling its present
 696          * state
 697          */
 698         if (dev->present) {
 699                 device_set_present(dev, false);
 700                 device_set_present(dev, true);
 701         }
 702
 703         free(bm);
 704 }
 705
 706 static void
 707 bridge_check_retry(struct bridge_state *bst)
 708 {
 709         if (!bst->n_failed)
 710                 return;
 711
 712         uloop_timeout_set(&bst->retry, 100);
 713 }
 714
 715 static void
 716 bridge_member_check_cb(struct uloop_timeout *t)
 717 {
 718         struct bridge_member *bm;
 719         struct bridge_state *bst;
 720
 721         bm = container_of(t, struct bridge_member, check_timer);
 722         bst = bm->bst;
 723
 724         if (system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname) <= 0)
 725                 return;
 726
 727         bridge_disable_member(bm, true);
 728         bridge_enable_member(bm);
 729 }
 730
 731 static void
 732 bridge_member_cb(struct device_user *dep, enum device_event ev)
 733 {
 734         struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
 735         struct bridge_state *bst = bm->bst;
 736         struct device *dev = dep->dev;
 737
 738         switch (ev) {
 739         case DEV_EVENT_ADD:
 740                 assert(!bm->present);
 741
 742                 bm->present = true;
 743                 bst->n_present++;
 744
 745                 if (bst->n_present == 1)
 746                         device_set_present(&bst->dev, true);
 747                 fallthrough;
 748         case DEV_EVENT_AUTH_UP:
 749                 if (!bst->dev.active)
 750                         break;
 751
 752                 if (bridge_enable_member(bm))
 753                         break;
 754
 755                 /*
 756                  * Adding a bridge member can overwrite the bridge mtu
 757                  * in the kernel, apply the bridge settings in case the
 758                  * bridge mtu is set
 759                  */
 760                 system_if_apply_settings(&bst->dev, &bst->dev.settings,
 761                                          DEV_OPT_MTU | DEV_OPT_MTU6);
 762                 break;
 763         case DEV_EVENT_LINK_UP:
 764                 if (bst->has_vlans)
 765                         uloop_timeout_set(&bm->check_timer, 1000);
 766                 break;
 767         case DEV_EVENT_LINK_DOWN:
 768                 if (!dev->settings.auth)
 769                         break;
 770
 771                 bridge_disable_member(bm, true);
 772                 break;
 773         case DEV_EVENT_REMOVE:
 774                 if (dep->hotplug) {
 775                         vlist_delete(&bst->members, &bm->node);
 776                         return;
 777                 }
 778
 779                 if (bm->present)
 780                         bridge_remove_member(bm);
 781
 782                 break;
 783         default:
 784                 return;
 785         }
 786 }
 787
 788 static int
 789 bridge_set_down(struct bridge_state *bst)
 790 {
 791         struct bridge_member *bm;
 792
 793         bst->set_state(&bst->dev, false);
 794
 795         vlist_for_each_element(&bst->members, bm, node)
 796                 bridge_disable_member(bm, false);
 797
 798         bridge_disable_interface(bst);
 799
 800         return 0;
 801 }
 802
 803 static int
 804 bridge_set_up(struct bridge_state *bst)
 805 {
 806         struct bridge_member *bm;
 807         int ret;
 808
 809         bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
 810         if (!bst->n_present) {
 811                 if (!bst->force_active)
 812                         return -ENOENT;
 813
 814                 ret = bridge_enable_interface(bst);
 815                 if (ret)
 816                         return ret;
 817         }
 818
 819         bst->n_failed = 0;
 820         vlist_for_each_element(&bst->members, bm, node)
 821                 bridge_enable_member(bm);
 822         bridge_check_retry(bst);
 823
 824         if (!bst->force_active && !bst->n_present) {
 825                 /* initialization of all member interfaces failed */
 826                 bridge_disable_interface(bst);
 827                 device_set_present(&bst->dev, false);
 828                 return -ENOENT;
 829         }
 830
 831         bridge_reset_primary(bst);
 832         ret = bst->set_state(&bst->dev, true);
 833         if (ret < 0)
 834                 bridge_set_down(bst);
 835
 836         return ret;
 837 }
 838
 839 static int
 840 bridge_set_state(struct device *dev, bool up)
 841 {
 842         struct bridge_state *bst;
 843
 844         bst = container_of(dev, struct bridge_state, dev);
 845
 846         if (up)
 847                 return bridge_set_up(bst);
 848         else
 849                 return bridge_set_down(bst);
 850 }
 851
 852 static struct bridge_member *
 853 bridge_alloc_member(struct bridge_state *bst, const char *name,
 854                     struct device *dev, bool hotplug)
 855 {
 856         struct bridge_member *bm;
 857
 858         bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
 859         if (!bm)
 860                 return NULL;
 861
 862         bm->bst = bst;
 863         bm->dev.cb = bridge_member_cb;
 864         bm->dev.hotplug = hotplug;
 865         bm->check_timer.cb = bridge_member_check_cb;
 866         strcpy(bm->name, name);
 867         bm->dev.dev = dev;
 868
 869         return bm;
 870 }
 871
 872 static void bridge_insert_member(struct bridge_member *bm, const char *name)
 873 {
 874         struct bridge_state *bst = bm->bst;
 875         bool hotplug = bm->dev.hotplug;
 876
 877         vlist_add(&bst->members, &bm->node, bm->name);
 878         /*
 879          * Need to look up the bridge member again as the above
 880          * created pointer will be freed in case the bridge member
 881          * already existed
 882          */
 883         bm = vlist_find(&bst->members, name, bm, node);
 884         if (hotplug && bm)
 885                 bm->node.version = -1;
 886 }
 887
 888 static void
 889 bridge_create_member(struct bridge_state *bst, const char *name,
 890                      struct device *dev, bool hotplug)
 891 {
 892         struct bridge_member *bm;
 893
 894         bm = bridge_alloc_member(bst, name, dev, hotplug);
 895         if (bm)
 896                 bridge_insert_member(bm, name);
 897 }
 898
 899 static void
 900 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
 901                      struct vlist_node *node_old)
 902 {
 903         struct bridge_member *bm;
 904         struct device *dev;
 905
 906         if (node_new) {
 907                 bm = container_of(node_new, struct bridge_member, node);
 908
 909                 if (node_old) {
 910                         free(bm);
 911                         return;
 912                 }
 913
 914                 dev = bm->dev.dev;
 915                 bm->dev.dev = NULL;
 916                 device_add_user(&bm->dev, dev);
 917         }
 918
 919
 920         if (node_old) {
 921                 bm = container_of(node_old, struct bridge_member, node);
 922                 bridge_free_member(bm);
 923         }
 924 }
 925
 926
 927 static void
 928 bridge_add_member(struct bridge_state *bst, const char *name)
 929 {
 930         struct device *dev;
 931
 932         dev = device_get(name, true);
 933         if (!dev)
 934                 return;
 935
 936         bridge_create_member(bst, name, dev, false);
 937 }
 938
 939 static int
 940 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
 941 {
 942         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 943         struct bridge_member *bm;
 944         bool new_entry = false;
 945
 946         bm = vlist_find(&bst->members, member->ifname, bm, node);
 947         if (!bm) {
 948             new_entry = true;
 949             bm = bridge_alloc_member(bst, member->ifname, member, true);
 950         }
 951         bridge_hotplug_set_member_vlans(bst, vlan, bm, true, false);
 952         if (new_entry)
 953                 bridge_insert_member(bm, member->ifname);
 954
 955         return 0;
 956 }
 957
 958 static int
 959 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
 960 {
 961         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 962         struct bridge_member *bm;
 963
 964         bm = vlist_find(&bst->members, member->ifname, bm, node);
 965         if (!bm)
 966                 return UBUS_STATUS_NOT_FOUND;
 967
 968         bridge_hotplug_set_member_vlans(bst, vlan, bm, false, false);
 969         if (!bm->dev.hotplug)
 970                 return 0;
 971
 972         vlist_delete(&bst->members, &bm->node);
 973         return 0;
 974 }
 975
 976 static int
 977 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
 978 {
 979         struct bridge_state *bst;
 980
 981         if (bridge_dev)
 982                 *bridge_dev = dev;
 983
 984         bst = container_of(dev, struct bridge_state, dev);
 985         bst->force_active = true;
 986         device_set_present(&bst->dev, true);
 987
 988         return 0;
 989 }
 990
 991 static const struct device_hotplug_ops bridge_ops = {
 992         .prepare = bridge_hotplug_prepare,
 993         .add = bridge_hotplug_add,
 994         .del = bridge_hotplug_del
 995 };
 996
 997 static void
 998 bridge_free(struct device *dev)
 999 {
1000         struct bridge_state *bst;
1001
1002         bst = container_of(dev, struct bridge_state, dev);
1003         vlist_flush_all(&bst->members);
1004         vlist_flush_all(&dev->vlans);
1005         kvlist_free(&dev->vlan_aliases);
1006         free(bst->config_data);
1007         free(bst);
1008 }
1009
1010 static void
1011 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
1012 {
1013         bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
1014         bool pvid = (port->flags & BRVLAN_F_PVID);
1015
1016         blobmsg_printf(b, NULL, "%s%s%s%s", port->ifname,
1017                 tagged || pvid ? ":" : "",
1018                 tagged ? "t" : "",
1019                 pvid ? "*" : "");
1020 }
1021
1022 static void
1023 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
1024 {
1025         struct bridge_vlan_hotplug_port *port;
1026         void *c, *p;
1027         int i;
1028
1029         c = blobmsg_open_table(b, NULL);
1030
1031         blobmsg_add_u32(b, "id", vlan->vid);
1032         blobmsg_add_u8(b, "local", vlan->local);
1033
1034         p = blobmsg_open_array(b, "ports");
1035
1036         for (i = 0; i < vlan->n_ports; i++)
1037             bridge_dump_port(b, &vlan->ports[i]);
1038
1039         list_for_each_entry(port, &vlan->hotplug_ports, list)
1040                 bridge_dump_port(b, &port->port);
1041
1042         blobmsg_close_array(b, p);
1043
1044         blobmsg_close_table(b, c);
1045 }
1046
1047 static void
1048 bridge_dump_info(struct device *dev, struct blob_buf *b)
1049 {
1050         struct bridge_config *cfg;
1051         struct bridge_state *bst;
1052         struct bridge_member *bm;
1053         struct bridge_vlan *vlan;
1054         void *list;
1055         void *c;
1056
1057         bst = container_of(dev, struct bridge_state, dev);
1058         cfg = &bst->config;
1059
1060         system_if_dump_info(dev, b);
1061         list = blobmsg_open_array(b, "bridge-members");
1062
1063         vlist_for_each_element(&bst->members, bm, node) {
1064                 if (bm->dev.dev->hidden)
1065                         continue;
1066
1067                 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
1068         }
1069
1070         blobmsg_close_array(b, list);
1071
1072         c = blobmsg_open_table(b, "bridge-attributes");
1073
1074         blobmsg_add_u8(b, "stp", cfg->stp);
1075         blobmsg_add_u32(b, "forward_delay", cfg->forward_delay);
1076         blobmsg_add_u32(b, "priority", cfg->priority);
1077         blobmsg_add_u32(b, "ageing_time", cfg->ageing_time);
1078         blobmsg_add_u32(b, "hello_time", cfg->hello_time);
1079         blobmsg_add_u32(b, "max_age", cfg->max_age);
1080         blobmsg_add_u8(b, "igmp_snooping", cfg->igmp_snoop);
1081         blobmsg_add_u8(b, "bridge_empty", cfg->bridge_empty);
1082         blobmsg_add_u8(b, "multicast_querier", cfg->multicast_querier);
1083         blobmsg_add_u32(b, "hash_max", cfg->hash_max);
1084         blobmsg_add_u32(b, "robustness", cfg->robustness);
1085         blobmsg_add_u32(b, "query_interval", cfg->query_interval);
1086         blobmsg_add_u32(b, "query_response_interval", cfg->query_response_interval);
1087         blobmsg_add_u32(b, "last_member_interval", cfg->last_member_interval);
1088         blobmsg_add_u8(b, "vlan_filtering", cfg->vlan_filtering);
1089         blobmsg_add_u8(b, "stp_kernel", cfg->stp_kernel);
1090         if (cfg->stp_proto)
1091                 blobmsg_add_string(b, "stp_proto", cfg->stp_proto);
1092
1093         blobmsg_close_table(b, c);
1094
1095         if (avl_is_empty(&dev->vlans.avl))
1096                 return;
1097
1098         list = blobmsg_open_array(b, "bridge-vlans");
1099
1100         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1101                 bridge_dump_vlan(b, vlan);
1102
1103         blobmsg_close_array(b, list);
1104 }
1105
1106 static void
1107 bridge_config_init(struct device *dev)
1108 {
1109         struct bridge_state *bst;
1110         struct bridge_vlan *vlan;
1111         struct blob_attr *cur;
1112         size_t rem;
1113         int i;
1114
1115         bst = container_of(dev, struct bridge_state, dev);
1116
1117         if (bst->config.bridge_empty) {
1118                 bst->force_active = true;
1119                 device_set_present(&bst->dev, true);
1120         }
1121
1122         bst->n_failed = 0;
1123         vlist_update(&bst->members);
1124         if (bst->ports) {
1125                 blobmsg_for_each_attr(cur, bst->ports, rem) {
1126                         bridge_add_member(bst, blobmsg_data(cur));
1127                 }
1128         }
1129
1130         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1131                 for (i = 0; i < vlan->n_ports; i++)
1132                         bridge_add_member(bst, vlan->ports[i].ifname);
1133
1134         vlist_flush(&bst->members);
1135         bridge_check_retry(bst);
1136 }
1137
1138 static void
1139 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
1140 {
1141         struct bridge_config *cfg = &bst->config;
1142         struct blob_attr *cur;
1143
1144         /* defaults */
1145         memset(cfg, 0, sizeof(*cfg));
1146         cfg->stp = false;
1147         cfg->stp_kernel = false;
1148         cfg->robustness = 2;
1149         cfg->igmp_snoop = false;
1150         cfg->multicast_querier = false;
1151         cfg->query_interval = 12500;
1152         cfg->query_response_interval = 1000;
1153         cfg->last_member_interval = 100;
1154         cfg->hash_max = 512;
1155         cfg->bridge_empty = false;
1156         cfg->priority = 0x7FFF;
1157         cfg->vlan_filtering = false;
1158
1159         cfg->forward_delay = 8;
1160         cfg->max_age = 10;
1161         cfg->hello_time = 1;
1162
1163         if ((cur = tb[BRIDGE_ATTR_STP]))
1164                 cfg->stp = blobmsg_get_bool(cur);
1165
1166         if ((cur = tb[BRIDGE_ATTR_STP_KERNEL]))
1167                 cfg->stp = blobmsg_get_bool(cur);
1168
1169         if ((cur = tb[BRIDGE_ATTR_STP_PROTO]))
1170                 cfg->stp_proto = blobmsg_get_string(cur);
1171
1172         if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1173                 cfg->forward_delay = blobmsg_get_u32(cur);
1174
1175         if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1176                 cfg->priority = blobmsg_get_u32(cur);
1177
1178         if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1179                 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1180
1181         if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1182                 cfg->multicast_querier = blobmsg_get_bool(cur);
1183
1184         if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1185                 cfg->hash_max = blobmsg_get_u32(cur);
1186
1187         if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1188                 cfg->robustness = blobmsg_get_u32(cur);
1189                 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1190         }
1191
1192         if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1193                 cfg->query_interval = blobmsg_get_u32(cur);
1194                 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1195         }
1196
1197         if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1198                 cfg->query_response_interval = blobmsg_get_u32(cur);
1199                 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1200         }
1201
1202         if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1203                 cfg->last_member_interval = blobmsg_get_u32(cur);
1204                 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1205         }
1206
1207         if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1208                 cfg->ageing_time = blobmsg_get_u32(cur);
1209                 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1210         }
1211
1212         if ((cur = tb[BRIDGE_ATTR_HELLO_TIME]))
1213                 cfg->hello_time = blobmsg_get_u32(cur);
1214
1215         if ((cur = tb[BRIDGE_ATTR_MAX_AGE]))
1216                 cfg->max_age = blobmsg_get_u32(cur);
1217
1218         if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1219                 cfg->bridge_empty = blobmsg_get_bool(cur);
1220
1221         if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1222                 cfg->vlan_filtering = blobmsg_get_bool(cur);
1223 }
1224
1225 static enum dev_change_type
1226 bridge_reload(struct device *dev, struct blob_attr *attr)
1227 {
1228         struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1229         struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1230         enum dev_change_type ret = DEV_CONFIG_APPLIED;
1231         struct bridge_state *bst;
1232         unsigned long diff[2];
1233
1234         BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / BITS_PER_LONG);
1235         BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / BITS_PER_LONG);
1236
1237         bst = container_of(dev, struct bridge_state, dev);
1238         attr = blob_memdup(attr);
1239
1240         blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1241                 blob_data(attr), blob_len(attr));
1242         blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1243                 blob_data(attr), blob_len(attr));
1244
1245         if (tb_dev[DEV_ATTR_MACADDR])
1246                 bst->primary_port = NULL;
1247
1248         bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1249         device_init_settings(dev, tb_dev);
1250         bridge_apply_settings(bst, tb_br);
1251
1252         if (bst->config_data) {
1253                 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1254                 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1255
1256                 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1257                         blob_data(bst->config_data), blob_len(bst->config_data));
1258
1259                 diff[0] = diff[1] = 0;
1260                 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, diff);
1261                 if (diff[0] | diff[1]) {
1262                         ret = DEV_CONFIG_RESTART;
1263                         D(DEVICE, "Bridge %s device attributes have changed, diff=[%lx %lx]\n",
1264                           dev->ifname, diff[1], diff[0]);
1265                 }
1266
1267                 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1268                         blob_data(bst->config_data), blob_len(bst->config_data));
1269
1270                 diff[0] = diff[1] = 0;
1271                 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, diff);
1272                 if (diff[0] & ~(1 << BRIDGE_ATTR_PORTS)) {
1273                         ret = DEV_CONFIG_RESTART;
1274                         D(DEVICE, "Bridge %s attributes have changed, diff=[%lx %lx]\n",
1275                           dev->ifname, diff[1], diff[0]);
1276                 }
1277
1278                 bridge_config_init(dev);
1279         }
1280
1281         free(bst->config_data);
1282         bst->config_data = attr;
1283         return ret;
1284 }
1285
1286 static void
1287 bridge_retry_members(struct uloop_timeout *timeout)
1288 {
1289         struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1290         struct bridge_member *bm;
1291
1292         bst->n_failed = 0;
1293         vlist_for_each_element(&bst->members, bm, node) {
1294                 if (bm->present)
1295                         continue;
1296
1297                 if (!bm->dev.dev->present)
1298                         continue;
1299
1300                 bm->present = true;
1301                 bst->n_present++;
1302                 bridge_enable_member(bm);
1303         }
1304 }
1305
1306 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1307 {
1308         const uint16_t *i1 = k1, *i2 = k2;
1309
1310         return *i1 - *i2;
1311 }
1312
1313 static bool
1314 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1315 {
1316         int i;
1317
1318         if (v1->n_ports != v2->n_ports)
1319                 return false;
1320
1321         for (i = 0; i < v1->n_ports; i++)
1322                 if (v1->ports[i].flags != v2->ports[i].flags ||
1323                     strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1324                         return false;
1325
1326         return true;
1327 }
1328
1329 static void
1330 bridge_vlan_free(struct bridge_vlan *vlan)
1331 {
1332         struct bridge_vlan_hotplug_port *port, *tmp;
1333
1334         if (!vlan)
1335                 return;
1336
1337         list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1338                 free(port);
1339
1340         free(vlan);
1341 }
1342
1343 static void
1344 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1345                    struct vlist_node *node_old)
1346 {
1347         struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1348         struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1349
1350         if (!bst->has_vlans || !bst->active)
1351                 goto out;
1352
1353         if (node_old)
1354                 vlan_old = container_of(node_old, struct bridge_vlan, node);
1355         if (node_new)
1356                 vlan_new = container_of(node_new, struct bridge_vlan, node);
1357
1358         if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1359                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1360                 goto out;
1361         }
1362
1363         if (node_old)
1364                 bridge_set_vlan_state(bst, vlan_old, false);
1365
1366         if (node_old && node_new)
1367                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1368
1369         if (node_new)
1370                 vlan_new->pending = true;
1371
1372         bst->dev.config_pending = true;
1373
1374 out:
1375         bridge_vlan_free(vlan_old);
1376 }
1377
1378 static void
1379 bridge_dev_vlan_update(struct device *dev)
1380 {
1381         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1382         struct bridge_vlan *vlan;
1383
1384         vlist_for_each_element(&dev->vlans, vlan, node) {
1385                 if (!vlan->pending)
1386                         continue;
1387
1388                 vlan->pending = false;
1389                 bridge_set_vlan_state(bst, vlan, true);
1390         }
1391 }
1392
1393 static struct device *
1394 bridge_create(const char *name, struct device_type *devtype,
1395         struct blob_attr *attr)
1396 {
1397         struct bridge_state *bst;
1398         struct device *dev = NULL;
1399
1400         bst = calloc(1, sizeof(*bst));
1401         if (!bst)
1402                 return NULL;
1403
1404         dev = &bst->dev;
1405
1406         if (device_init(dev, devtype, name) < 0) {
1407                 device_cleanup(dev);
1408                 free(bst);
1409                 return NULL;
1410         }
1411
1412         dev->config_pending = true;
1413         bst->retry.cb = bridge_retry_members;
1414
1415         bst->set_state = dev->set_state;
1416         dev->set_state = bridge_set_state;
1417
1418         dev->hotplug_ops = &bridge_ops;
1419
1420         vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1421         bst->members.keep_old = true;
1422
1423         vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1424
1425         bridge_reload(dev, attr);
1426
1427         return dev;
1428 }
1429
1430 static void __init bridge_device_type_init(void)
1431 {
1432         device_type_add(&bridge_device_type);
1433 }