bridge.c

   1 /*
   2  * netifd - network interface daemon
   3  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License version 2
   7  * as published by the Free Software Foundation
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14 #include <string.h>
  15 #include <stdlib.h>
  16 #include <stdio.h>
  17 #include <assert.h>
  18 #include <errno.h>
  19
  20 #include "netifd.h"
  21 #include "device.h"
  22 #include "interface.h"
  23 #include "system.h"
  24 #include "ubus.h"
  25
  26 enum {
  27         BRIDGE_ATTR_PORTS,
  28         BRIDGE_ATTR_STP,
  29         BRIDGE_ATTR_FORWARD_DELAY,
  30         BRIDGE_ATTR_PRIORITY,
  31         BRIDGE_ATTR_IGMP_SNOOP,
  32         BRIDGE_ATTR_AGEING_TIME,
  33         BRIDGE_ATTR_HELLO_TIME,
  34         BRIDGE_ATTR_MAX_AGE,
  35         BRIDGE_ATTR_BRIDGE_EMPTY,
  36         BRIDGE_ATTR_MULTICAST_QUERIER,
  37         BRIDGE_ATTR_HASH_MAX,
  38         BRIDGE_ATTR_ROBUSTNESS,
  39         BRIDGE_ATTR_QUERY_INTERVAL,
  40         BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
  41         BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
  42         BRIDGE_ATTR_VLAN_FILTERING,
  43         BRIDGE_ATTR_HAS_VLANS,
  44         BRIDGE_ATTR_STP_KERNEL,
  45         BRIDGE_ATTR_STP_PROTO,
  46         __BRIDGE_ATTR_MAX
  47 };
  48
  49 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
  50         [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
  51         [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
  52         [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
  53         [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
  54         [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
  55         [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
  56         [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
  57         [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
  58         [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
  59         [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
  60         [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
  61         [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
  62         [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
  63         [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
  64         [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
  65         [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
  66         [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
  67         [BRIDGE_ATTR_STP_KERNEL] = { "stp_kernel", BLOBMSG_TYPE_BOOL },
  68         [BRIDGE_ATTR_STP_PROTO] = { "stp_proto", BLOBMSG_TYPE_STRING },
  69 };
  70
  71 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
  72         [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
  73 };
  74
  75 static const struct uci_blob_param_list bridge_attr_list = {
  76         .n_params = __BRIDGE_ATTR_MAX,
  77         .params = bridge_attrs,
  78         .info = bridge_attr_info,
  79
  80         .n_next = 1,
  81         .next = { &device_attr_list },
  82 };
  83
  84 static struct blob_buf b;
  85 static struct device *bridge_create(const char *name, struct device_type *devtype,
  86         struct blob_attr *attr);
  87 static void bridge_config_init(struct device *dev);
  88 static void bridge_dev_vlan_update(struct device *dev);
  89 static void bridge_free(struct device *dev);
  90 static void bridge_stp_init(struct device *dev);
  91 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
  92 static enum dev_change_type
  93 bridge_reload(struct device *dev, struct blob_attr *attr);
  94
  95 static struct device_type bridge_device_type = {
  96         .name = "bridge",
  97         .config_params = &bridge_attr_list,
  98
  99         .bridge_capability = true,
 100         .name_prefix = "br",
 101
 102         .create = bridge_create,
 103         .config_init = bridge_config_init,
 104         .vlan_update = bridge_dev_vlan_update,
 105         .reload = bridge_reload,
 106         .free = bridge_free,
 107         .dump_info = bridge_dump_info,
 108         .stp_init = bridge_stp_init,
 109 };
 110
 111 struct bridge_state {
 112         struct device dev;
 113         device_state_cb set_state;
 114
 115         struct blob_attr *config_data;
 116         struct bridge_config config;
 117         struct blob_attr *ports;
 118         bool active;
 119         bool force_active;
 120         bool has_vlans;
 121
 122         struct uloop_timeout retry;
 123         struct bridge_member *primary_port;
 124         struct vlist_tree members;
 125         int n_present;
 126         int n_failed;
 127 };
 128
 129 struct bridge_member {
 130         struct vlist_node node;
 131         struct bridge_state *bst;
 132         struct device_user dev;
 133         struct uloop_timeout check_timer;
 134         struct device_vlan_range *extra_vlan;
 135         int n_extra_vlan;
 136         uint16_t pvid;
 137         bool present;
 138         bool active;
 139         char name[];
 140 };
 141
 142 static void
 143 bridge_reset_primary(struct bridge_state *bst)
 144 {
 145         struct bridge_member *bm;
 146
 147         if (!bst->primary_port &&
 148             (bst->dev.settings.flags & DEV_OPT_MACADDR))
 149                 return;
 150
 151         bst->primary_port = NULL;
 152         bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
 153         vlist_for_each_element(&bst->members, bm, node) {
 154                 uint8_t *macaddr;
 155
 156                 if (!bm->present)
 157                         continue;
 158
 159                 bst->primary_port = bm;
 160                 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
 161                         macaddr = bm->dev.dev->settings.macaddr;
 162                 else
 163                         macaddr = bm->dev.dev->orig_settings.macaddr;
 164                 memcpy(bst->dev.settings.macaddr, macaddr, 6);
 165                 bst->dev.settings.flags |= DEV_OPT_MACADDR;
 166                 return;
 167         }
 168 }
 169
 170 static struct bridge_vlan_port *
 171 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
 172 {
 173         struct bridge_vlan_hotplug_port *port;
 174         const char *ifname = bm->dev.dev->ifname;
 175         int i;
 176
 177         for (i = 0; i < vlan->n_ports; i++) {
 178                 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
 179                         continue;
 180
 181                 return &vlan->ports[i];
 182         }
 183
 184         list_for_each_entry(port, &vlan->hotplug_ports, list) {
 185                 if (strcmp(port->port.ifname, ifname) != 0)
 186                         continue;
 187
 188                 return &port->port;
 189         }
 190
 191         return NULL;
 192 }
 193
 194 static bool
 195 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
 196 {
 197         return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
 198                (port->flags & BRVLAN_F_PVID);
 199 }
 200
 201 static void
 202 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
 203                          struct bridge_vlan_port *port, bool add)
 204 {
 205         uint16_t flags;
 206
 207         flags = port->flags;
 208         if (bm->pvid == vlan->vid)
 209                 flags |= BRVLAN_F_PVID;
 210
 211         system_bridge_vlan(port->ifname, vlan->vid, -1, add, flags);
 212 }
 213
 214 static void
 215 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
 216 {
 217         struct bridge_vlan_port *port;
 218
 219         if (!bm->present)
 220                 return;
 221
 222         port = bridge_find_vlan_member_port(bm, vlan);
 223         if (!port)
 224                 return;
 225
 226         if (bridge_member_vlan_is_pvid(bm, port))
 227                 bm->pvid = vlan->vid;
 228
 229         __bridge_set_member_vlan(bm, vlan, port, add);
 230 }
 231
 232 static void
 233 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 234 {
 235         if (!vlan->local && add)
 236                 return;
 237
 238         system_bridge_vlan(bst->dev.ifname, vlan->vid, -1, add, BRVLAN_F_SELF);
 239 }
 240
 241 static void
 242 bridge_set_local_vlans(struct bridge_state *bst, bool add)
 243 {
 244         struct bridge_vlan *vlan;
 245
 246         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 247                 bridge_set_local_vlan(bst, vlan, add);
 248 }
 249
 250 static struct bridge_vlan *
 251 bridge_recalc_member_pvid(struct bridge_member *bm)
 252 {
 253         struct bridge_state *bst = bm->bst;
 254         struct bridge_vlan_port *port;
 255         struct bridge_vlan *vlan, *ret = NULL;
 256
 257         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 258                 port = bridge_find_vlan_member_port(bm, vlan);
 259                 if (!port)
 260                         continue;
 261
 262                 if (!bridge_member_vlan_is_pvid(bm, port))
 263                         continue;
 264
 265                 ret = vlan;
 266                 if (port->flags & BRVLAN_F_PVID)
 267                         break;
 268         }
 269
 270         return ret;
 271 }
 272
 273 static void
 274 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 275 {
 276         struct bridge_member *bm;
 277         struct bridge_vlan *vlan2;
 278
 279         bridge_set_local_vlan(bst, vlan, add);
 280
 281         vlist_for_each_element(&bst->members, bm, node) {
 282                 struct bridge_vlan_port *port;
 283                 int new_pvid = -1;
 284
 285                 port = bridge_find_vlan_member_port(bm, vlan);
 286                 if (!port)
 287                         continue;
 288
 289                 if (add) {
 290                         if (bridge_member_vlan_is_pvid(bm, port))
 291                                 bm->pvid = vlan->vid;
 292                 } else if (bm->pvid == vlan->vid) {
 293                         vlan2 = bridge_recalc_member_pvid(bm);
 294                         if (vlan2 && vlan2->vid != vlan->vid) {
 295                                 bridge_set_member_vlan(bm, vlan2, false);
 296                                 bridge_set_member_vlan(bm, vlan2, true);
 297                         }
 298                         new_pvid = vlan2 ? vlan2->vid : 0;
 299                 }
 300
 301                 if (!bm->present)
 302                         continue;
 303
 304                 __bridge_set_member_vlan(bm, vlan, port, add);
 305                 if (new_pvid >= 0)
 306                         bm->pvid = new_pvid;
 307         }
 308 }
 309
 310 static int
 311 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
 312 {
 313         struct bridge_state *bst = bm->bst;
 314         struct bridge_vlan *vlan;
 315
 316         if (!bm->present || !bm->active)
 317                 return 0;
 318
 319         bm->active = false;
 320         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 321                 bridge_set_member_vlan(bm, vlan, false);
 322
 323         system_bridge_delif(&bst->dev, bm->dev.dev);
 324         if (!keep_dev)
 325                 device_release(&bm->dev);
 326
 327         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 328
 329         return 0;
 330 }
 331
 332 static void bridge_stp_notify(struct bridge_state *bst)
 333 {
 334         struct bridge_config *cfg = &bst->config;
 335
 336         if (!cfg->stp || cfg->stp_kernel)
 337                 return;
 338
 339         blob_buf_init(&b, 0);
 340         blobmsg_add_string(&b, "name", bst->dev.ifname);
 341         if (cfg->stp_proto)
 342                 blobmsg_add_string(&b, "proto", cfg->stp_proto);
 343         blobmsg_add_u32(&b, "forward_delay", cfg->forward_delay);
 344         blobmsg_add_u32(&b, "hello_time", cfg->hello_time);
 345         blobmsg_add_u32(&b, "max_age", cfg->max_age);
 346         if (cfg->flags & BRIDGE_OPT_AGEING_TIME)
 347                 blobmsg_add_u32(&b, "ageing_time", cfg->ageing_time);
 348         netifd_ubus_device_notify("stp_init", b.head, 1000);
 349 }
 350
 351 static int
 352 bridge_enable_interface(struct bridge_state *bst)
 353 {
 354         int ret;
 355
 356         if (bst->active)
 357                 return 0;
 358
 359         bridge_stp_notify(bst);
 360         ret = system_bridge_addbr(&bst->dev, &bst->config);
 361         if (ret < 0)
 362                 return ret;
 363
 364         if (bst->has_vlans) {
 365                 /* delete default VLAN 1 */
 366                 system_bridge_vlan(bst->dev.ifname, 1, -1, false, BRVLAN_F_SELF);
 367
 368                 bridge_set_local_vlans(bst, true);
 369         }
 370
 371         bst->active = true;
 372         return 0;
 373 }
 374
 375 static void
 376 bridge_stp_init(struct device *dev)
 377 {
 378         struct bridge_state *bst;
 379
 380         bst = container_of(dev, struct bridge_state, dev);
 381         if (!bst->config.stp || !bst->active)
 382                 return;
 383
 384         bridge_stp_notify(bst);
 385         system_bridge_set_stp_state(&bst->dev, false);
 386         system_bridge_set_stp_state(&bst->dev, true);
 387 }
 388
 389 static void
 390 bridge_disable_interface(struct bridge_state *bst)
 391 {
 392         if (!bst->active)
 393                 return;
 394
 395         system_bridge_delbr(&bst->dev);
 396         bst->active = false;
 397 }
 398
 399 static void
 400 bridge_member_add_extra_vlans(struct bridge_member *bm)
 401 {
 402         struct device *dev = bm->dev.dev;
 403         int i;
 404
 405         for (i = 0; i < dev->n_extra_vlan; i++)
 406                 system_bridge_vlan(dev->ifname, dev->extra_vlan[i].start,
 407                                    dev->extra_vlan[i].end, true, 0);
 408         for (i = 0; i < bm->n_extra_vlan; i++)
 409                 system_bridge_vlan(dev->ifname, bm->extra_vlan[i].start,
 410                                    bm->extra_vlan[i].end, true, 0);
 411 }
 412
 413 static int
 414 bridge_enable_member(struct bridge_member *bm)
 415 {
 416         struct bridge_state *bst = bm->bst;
 417         struct bridge_vlan *vlan;
 418         struct device *dev;
 419         int ret;
 420
 421         if (!bm->present)
 422                 return 0;
 423
 424         ret = bridge_enable_interface(bst);
 425         if (ret)
 426                 goto error;
 427
 428         /* Disable IPv6 for bridge members */
 429         if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
 430                 bm->dev.dev->settings.ipv6 = 0;
 431                 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
 432         }
 433
 434         ret = device_claim(&bm->dev);
 435         if (ret < 0)
 436                 goto error;
 437
 438         dev = bm->dev.dev;
 439         if (dev->settings.auth && !dev->auth_status)
 440                 return -1;
 441
 442         if (bm->active)
 443                 return 0;
 444
 445         ret = system_bridge_addif(&bst->dev, bm->dev.dev);
 446         if (ret < 0) {
 447                 D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
 448                 goto error;
 449         }
 450
 451         bm->active = true;
 452         if (bst->has_vlans) {
 453                 /* delete default VLAN 1 */
 454                 system_bridge_vlan(bm->dev.dev->ifname, 1, -1, false, 0);
 455
 456                 bridge_member_add_extra_vlans(bm);
 457                 vlist_for_each_element(&bst->dev.vlans, vlan, node)
 458                         bridge_set_member_vlan(bm, vlan, true);
 459         }
 460
 461         device_set_present(&bst->dev, true);
 462         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 463
 464         return 0;
 465
 466 error:
 467         bst->n_failed++;
 468         bm->present = false;
 469         bst->n_present--;
 470         device_release(&bm->dev);
 471
 472         return ret;
 473 }
 474
 475 static void
 476 bridge_remove_member(struct bridge_member *bm)
 477 {
 478         struct bridge_state *bst = bm->bst;
 479
 480         if (!bm->present)
 481                 return;
 482
 483         if (bst->dev.active)
 484                 bridge_disable_member(bm, false);
 485
 486         bm->present = false;
 487         bm->bst->n_present--;
 488
 489         if (bm == bst->primary_port)
 490                 bridge_reset_primary(bst);
 491
 492         if (bst->config.bridge_empty)
 493                 return;
 494
 495         bst->force_active = false;
 496         if (bst->n_present == 0)
 497                 device_set_present(&bst->dev, false);
 498 }
 499
 500 static void
 501 bridge_free_member(struct bridge_member *bm)
 502 {
 503         struct bridge_state *bst = bm->bst;
 504         struct device *dev = bm->dev.dev;
 505         const char *ifname = dev->ifname;
 506         struct bridge_vlan *vlan;
 507
 508         bridge_remove_member(bm);
 509
 510 restart:
 511         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 512                 struct bridge_vlan_hotplug_port *port, *tmp;
 513                 bool free_port = false;
 514
 515                 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
 516                         if (strcmp(port->port.ifname, ifname) != 0)
 517                                 continue;
 518
 519                         list_del(&port->list);
 520                         free(port);
 521                         free_port = true;
 522                 }
 523
 524                 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
 525                     vlan->n_ports || vlan->node.version != -1)
 526                         continue;
 527
 528                 vlist_delete(&bst->dev.vlans, &vlan->node);
 529                 goto restart;
 530         }
 531
 532         device_remove_user(&bm->dev);
 533         uloop_timeout_cancel(&bm->check_timer);
 534
 535         /*
 536          * When reloading the config and moving a device from one bridge to
 537          * another, the other bridge may have tried to claim this device
 538          * before it was removed here.
 539          * Ensure that claiming the device is retried by toggling its present
 540          * state
 541          */
 542         if (dev->present) {
 543                 device_set_present(dev, false);
 544                 device_set_present(dev, true);
 545         }
 546
 547         free(bm);
 548 }
 549
 550 static void
 551 bridge_check_retry(struct bridge_state *bst)
 552 {
 553         if (!bst->n_failed)
 554                 return;
 555
 556         uloop_timeout_set(&bst->retry, 100);
 557 }
 558
 559 static void
 560 bridge_member_check_cb(struct uloop_timeout *t)
 561 {
 562         struct bridge_member *bm;
 563         struct bridge_state *bst;
 564
 565         bm = container_of(t, struct bridge_member, check_timer);
 566         bst = bm->bst;
 567
 568         if (system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname) <= 0)
 569                 return;
 570
 571         bridge_disable_member(bm, true);
 572         bridge_enable_member(bm);
 573 }
 574
 575 static void
 576 bridge_member_cb(struct device_user *dep, enum device_event ev)
 577 {
 578         struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
 579         struct bridge_state *bst = bm->bst;
 580         struct device *dev = dep->dev;
 581
 582         switch (ev) {
 583         case DEV_EVENT_ADD:
 584                 assert(!bm->present);
 585
 586                 bm->present = true;
 587                 bst->n_present++;
 588
 589                 if (bst->n_present == 1)
 590                         device_set_present(&bst->dev, true);
 591                 fallthrough;
 592         case DEV_EVENT_AUTH_UP:
 593                 if (!bst->dev.active)
 594                         break;
 595
 596                 if (bridge_enable_member(bm))
 597                         break;
 598
 599                 /*
 600                  * Adding a bridge member can overwrite the bridge mtu
 601                  * in the kernel, apply the bridge settings in case the
 602                  * bridge mtu is set
 603                  */
 604                 system_if_apply_settings(&bst->dev, &bst->dev.settings,
 605                                          DEV_OPT_MTU | DEV_OPT_MTU6);
 606                 break;
 607         case DEV_EVENT_LINK_UP:
 608                 if (bst->has_vlans)
 609                         uloop_timeout_set(&bm->check_timer, 1000);
 610                 break;
 611         case DEV_EVENT_LINK_DOWN:
 612                 if (!dev->settings.auth)
 613                         break;
 614
 615                 bridge_disable_member(bm, true);
 616                 break;
 617         case DEV_EVENT_REMOVE:
 618                 if (dep->hotplug) {
 619                         vlist_delete(&bst->members, &bm->node);
 620                         return;
 621                 }
 622
 623                 if (bm->present)
 624                         bridge_remove_member(bm);
 625
 626                 break;
 627         default:
 628                 return;
 629         }
 630 }
 631
 632 static int
 633 bridge_set_down(struct bridge_state *bst)
 634 {
 635         struct bridge_member *bm;
 636
 637         bst->set_state(&bst->dev, false);
 638
 639         vlist_for_each_element(&bst->members, bm, node)
 640                 bridge_disable_member(bm, false);
 641
 642         bridge_disable_interface(bst);
 643
 644         return 0;
 645 }
 646
 647 static int
 648 bridge_set_up(struct bridge_state *bst)
 649 {
 650         struct bridge_member *bm;
 651         int ret;
 652
 653         bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
 654         if (!bst->n_present) {
 655                 if (!bst->force_active)
 656                         return -ENOENT;
 657
 658                 ret = bridge_enable_interface(bst);
 659                 if (ret)
 660                         return ret;
 661         }
 662
 663         bst->n_failed = 0;
 664         vlist_for_each_element(&bst->members, bm, node)
 665                 bridge_enable_member(bm);
 666         bridge_check_retry(bst);
 667
 668         if (!bst->force_active && !bst->n_present) {
 669                 /* initialization of all member interfaces failed */
 670                 bridge_disable_interface(bst);
 671                 device_set_present(&bst->dev, false);
 672                 return -ENOENT;
 673         }
 674
 675         bridge_reset_primary(bst);
 676         ret = bst->set_state(&bst->dev, true);
 677         if (ret < 0)
 678                 bridge_set_down(bst);
 679
 680         return ret;
 681 }
 682
 683 static int
 684 bridge_set_state(struct device *dev, bool up)
 685 {
 686         struct bridge_state *bst;
 687
 688         bst = container_of(dev, struct bridge_state, dev);
 689
 690         if (up)
 691                 return bridge_set_up(bst);
 692         else
 693                 return bridge_set_down(bst);
 694 }
 695
 696 static struct bridge_member *
 697 bridge_alloc_member(struct bridge_state *bst, const char *name,
 698                     struct device *dev, bool hotplug)
 699 {
 700         struct bridge_member *bm;
 701
 702         bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
 703         if (!bm)
 704                 return NULL;
 705
 706         bm->bst = bst;
 707         bm->dev.cb = bridge_member_cb;
 708         bm->dev.hotplug = hotplug;
 709         bm->check_timer.cb = bridge_member_check_cb;
 710         strcpy(bm->name, name);
 711         bm->dev.dev = dev;
 712
 713         return bm;
 714 }
 715
 716 static void bridge_insert_member(struct bridge_member *bm, const char *name)
 717 {
 718         struct bridge_state *bst = bm->bst;
 719         bool hotplug = bm->dev.hotplug;
 720
 721         vlist_add(&bst->members, &bm->node, bm->name);
 722         /*
 723          * Need to look up the bridge member again as the above
 724          * created pointer will be freed in case the bridge member
 725          * already existed
 726          */
 727         bm = vlist_find(&bst->members, name, bm, node);
 728         if (hotplug && bm)
 729                 bm->node.version = -1;
 730 }
 731
 732 static void
 733 bridge_create_member(struct bridge_state *bst, const char *name,
 734                      struct device *dev, bool hotplug)
 735 {
 736         struct bridge_member *bm;
 737
 738         bm = bridge_alloc_member(bst, name, dev, hotplug);
 739         if (bm)
 740                 bridge_insert_member(bm, name);
 741 }
 742
 743 static void
 744 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
 745                      struct vlist_node *node_old)
 746 {
 747         struct bridge_member *bm;
 748         struct device *dev;
 749
 750         if (node_new) {
 751                 bm = container_of(node_new, struct bridge_member, node);
 752
 753                 if (node_old) {
 754                         free(bm);
 755                         return;
 756                 }
 757
 758                 dev = bm->dev.dev;
 759                 bm->dev.dev = NULL;
 760                 device_add_user(&bm->dev, dev);
 761         }
 762
 763
 764         if (node_old) {
 765                 bm = container_of(node_old, struct bridge_member, node);
 766                 bridge_free_member(bm);
 767         }
 768 }
 769
 770
 771 static void
 772 bridge_add_member(struct bridge_state *bst, const char *name)
 773 {
 774         struct device *dev;
 775
 776         dev = device_get(name, true);
 777         if (!dev)
 778                 return;
 779
 780         bridge_create_member(bst, name, dev, false);
 781 }
 782
 783 static struct bridge_vlan *
 784 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid, bool create)
 785 {
 786         struct bridge_vlan *vlan;
 787
 788         vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
 789         if (vlan || !create)
 790                 return vlan;
 791
 792         vlan = calloc(1, sizeof(*vlan));
 793         vlan->vid = vid;
 794         vlan->local = true;
 795         INIT_LIST_HEAD(&vlan->hotplug_ports);
 796         vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
 797         vlan->node.version = -1;
 798
 799         return vlan;
 800 }
 801
 802 static struct bridge_vlan_hotplug_port *
 803 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
 804 {
 805         struct bridge_vlan_hotplug_port *port;
 806
 807         list_for_each_entry(port, &vlan->hotplug_ports, list)
 808                 if (!strcmp(port->port.ifname, ifname))
 809                         return port;
 810
 811         return NULL;
 812 }
 813
 814 static void
 815 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
 816                                 const char *ifname, struct bridge_member *bm, bool add)
 817 {
 818         struct device_vlan_range *r;
 819         struct bridge_vlan *vlan;
 820         struct blob_attr *cur;
 821         int n_vlans;
 822         size_t rem;
 823
 824         if (!vlans)
 825                 return;
 826
 827         if (add) {
 828                 bm->n_extra_vlan = 0;
 829                 n_vlans = blobmsg_check_array(vlans, BLOBMSG_TYPE_STRING);
 830                 if (n_vlans < 1)
 831                         return;
 832
 833                 bm->extra_vlan = realloc(bm->extra_vlan, n_vlans * sizeof(*bm->extra_vlan));
 834         }
 835
 836         blobmsg_for_each_attr(cur, vlans, rem) {
 837                 struct bridge_vlan_hotplug_port *port;
 838                 unsigned int vid, vid_end;
 839                 uint16_t flags = 0;
 840                 char *name_buf;
 841                 char *end;
 842
 843                 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
 844                         continue;
 845
 846                 vid = strtoul(blobmsg_get_string(cur), &end, 0);
 847                 vid_end = vid;
 848                 if (!vid || vid > 4095)
 849                         continue;
 850
 851                 if (*end == '-') {
 852                         vid_end = strtoul(end + 1, &end, 0);
 853                         if (vid_end < vid)
 854                                 continue;
 855                 }
 856
 857                 if (end && *end) {
 858                         if (*end != ':')
 859                                 continue;
 860
 861                         for (end++; *end; end++) {
 862                                 switch (*end) {
 863                                 case 'u':
 864                                         flags |= BRVLAN_F_UNTAGGED;
 865                                         break;
 866                                 case '*':
 867                                         flags |= BRVLAN_F_PVID;
 868                                         break;
 869                                 }
 870                         }
 871                 }
 872
 873                 vlan = bridge_hotplug_get_vlan(bst, vid, !!flags);
 874                 if (!vlan || vid_end > vid) {
 875                         if (add) {
 876                                 r = &bm->extra_vlan[bm->n_extra_vlan++];
 877                                 r->start = vid;
 878                                 r->end = vid_end;
 879                                 if (bm->active)
 880                                         system_bridge_vlan(ifname, vid, vid_end, true, 0);
 881                         } else if (bm->active) {
 882                                 system_bridge_vlan(ifname, vid, vid_end, false, 0);
 883                         }
 884                         continue;
 885                 }
 886
 887                 if (vlan->pending) {
 888                         vlan->pending = false;
 889                         bridge_set_vlan_state(bst, vlan, true);
 890                 }
 891
 892                 port = bridge_hotplug_get_vlan_port(vlan, ifname);
 893                 if (!add) {
 894                         if (!port)
 895                                 continue;
 896
 897                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 898                         list_del(&port->list);
 899                         free(port);
 900                         continue;
 901                 }
 902
 903                 if (port) {
 904                         if (port->port.flags == flags)
 905                                 continue;
 906
 907                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 908                         port->port.flags = flags;
 909                         __bridge_set_member_vlan(bm, vlan, &port->port, true);
 910                         continue;
 911                 }
 912
 913                 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
 914                 if (!port)
 915                         continue;
 916
 917                 port->port.flags = flags;
 918                 port->port.ifname = strcpy(name_buf, ifname);
 919                 list_add_tail(&port->list, &vlan->hotplug_ports);
 920
 921                 if (!bm)
 922                         continue;
 923
 924                 __bridge_set_member_vlan(bm, vlan, &port->port, true);
 925         }
 926 }
 927
 928 static int
 929 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
 930 {
 931         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 932         struct bridge_member *bm;
 933
 934         bm = vlist_find(&bst->members, member->ifname, bm, node);
 935         if (!bm)
 936             bm = bridge_alloc_member(bst, member->ifname, member, true);
 937         bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, true);
 938         if (!bm->node.avl.key)
 939                 bridge_insert_member(bm, member->ifname);
 940
 941         return 0;
 942 }
 943
 944 static int
 945 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
 946 {
 947         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 948         struct bridge_member *bm;
 949
 950         bm = vlist_find(&bst->members, member->ifname, bm, node);
 951         if (!bm)
 952                 return UBUS_STATUS_NOT_FOUND;
 953
 954         bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, false);
 955         if (!bm->dev.hotplug)
 956                 return 0;
 957
 958         vlist_delete(&bst->members, &bm->node);
 959         return 0;
 960 }
 961
 962 static int
 963 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
 964 {
 965         struct bridge_state *bst;
 966
 967         if (bridge_dev)
 968                 *bridge_dev = dev;
 969
 970         bst = container_of(dev, struct bridge_state, dev);
 971         bst->force_active = true;
 972         device_set_present(&bst->dev, true);
 973
 974         return 0;
 975 }
 976
 977 static const struct device_hotplug_ops bridge_ops = {
 978         .prepare = bridge_hotplug_prepare,
 979         .add = bridge_hotplug_add,
 980         .del = bridge_hotplug_del
 981 };
 982
 983 static void
 984 bridge_free(struct device *dev)
 985 {
 986         struct bridge_state *bst;
 987
 988         bst = container_of(dev, struct bridge_state, dev);
 989         vlist_flush_all(&bst->members);
 990         vlist_flush_all(&dev->vlans);
 991         kvlist_free(&dev->vlan_aliases);
 992         free(bst->config_data);
 993         free(bst);
 994 }
 995
 996 static void
 997 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
 998 {
 999         bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
1000         bool pvid = (port->flags & BRVLAN_F_PVID);
1001
1002         blobmsg_printf(b, NULL, "%s%s%s%s", port->ifname,
1003                 tagged || pvid ? ":" : "",
1004                 tagged ? "t" : "",
1005                 pvid ? "*" : "");
1006 }
1007
1008 static void
1009 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
1010 {
1011         struct bridge_vlan_hotplug_port *port;
1012         void *c, *p;
1013         int i;
1014
1015         c = blobmsg_open_table(b, NULL);
1016
1017         blobmsg_add_u32(b, "id", vlan->vid);
1018         blobmsg_add_u8(b, "local", vlan->local);
1019
1020         p = blobmsg_open_array(b, "ports");
1021
1022         for (i = 0; i < vlan->n_ports; i++)
1023             bridge_dump_port(b, &vlan->ports[i]);
1024
1025         list_for_each_entry(port, &vlan->hotplug_ports, list)
1026                 bridge_dump_port(b, &port->port);
1027
1028         blobmsg_close_array(b, p);
1029
1030         blobmsg_close_table(b, c);
1031 }
1032
1033 static void
1034 bridge_dump_info(struct device *dev, struct blob_buf *b)
1035 {
1036         struct bridge_config *cfg;
1037         struct bridge_state *bst;
1038         struct bridge_member *bm;
1039         struct bridge_vlan *vlan;
1040         void *list;
1041         void *c;
1042
1043         bst = container_of(dev, struct bridge_state, dev);
1044         cfg = &bst->config;
1045
1046         system_if_dump_info(dev, b);
1047         list = blobmsg_open_array(b, "bridge-members");
1048
1049         vlist_for_each_element(&bst->members, bm, node) {
1050                 if (bm->dev.dev->hidden)
1051                         continue;
1052
1053                 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
1054         }
1055
1056         blobmsg_close_array(b, list);
1057
1058         c = blobmsg_open_table(b, "bridge-attributes");
1059
1060         blobmsg_add_u8(b, "stp", cfg->stp);
1061         blobmsg_add_u32(b, "forward_delay", cfg->forward_delay);
1062         blobmsg_add_u32(b, "priority", cfg->priority);
1063         blobmsg_add_u32(b, "ageing_time", cfg->ageing_time);
1064         blobmsg_add_u32(b, "hello_time", cfg->hello_time);
1065         blobmsg_add_u32(b, "max_age", cfg->max_age);
1066         blobmsg_add_u8(b, "igmp_snooping", cfg->igmp_snoop);
1067         blobmsg_add_u8(b, "bridge_empty", cfg->bridge_empty);
1068         blobmsg_add_u8(b, "multicast_querier", cfg->multicast_querier);
1069         blobmsg_add_u32(b, "hash_max", cfg->hash_max);
1070         blobmsg_add_u32(b, "robustness", cfg->robustness);
1071         blobmsg_add_u32(b, "query_interval", cfg->query_interval);
1072         blobmsg_add_u32(b, "query_response_interval", cfg->query_response_interval);
1073         blobmsg_add_u32(b, "last_member_interval", cfg->last_member_interval);
1074         blobmsg_add_u8(b, "vlan_filtering", cfg->vlan_filtering);
1075         blobmsg_add_u8(b, "stp_kernel", cfg->stp_kernel);
1076         if (cfg->stp_proto)
1077                 blobmsg_add_string(b, "stp_proto", cfg->stp_proto);
1078
1079         blobmsg_close_table(b, c);
1080
1081         if (avl_is_empty(&dev->vlans.avl))
1082                 return;
1083
1084         list = blobmsg_open_array(b, "bridge-vlans");
1085
1086         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1087                 bridge_dump_vlan(b, vlan);
1088
1089         blobmsg_close_array(b, list);
1090 }
1091
1092 static void
1093 bridge_config_init(struct device *dev)
1094 {
1095         struct bridge_state *bst;
1096         struct bridge_vlan *vlan;
1097         struct blob_attr *cur;
1098         size_t rem;
1099         int i;
1100
1101         bst = container_of(dev, struct bridge_state, dev);
1102
1103         if (bst->config.bridge_empty) {
1104                 bst->force_active = true;
1105                 device_set_present(&bst->dev, true);
1106         }
1107
1108         bst->n_failed = 0;
1109         vlist_update(&bst->members);
1110         if (bst->ports) {
1111                 blobmsg_for_each_attr(cur, bst->ports, rem) {
1112                         bridge_add_member(bst, blobmsg_data(cur));
1113                 }
1114         }
1115
1116         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1117                 for (i = 0; i < vlan->n_ports; i++)
1118                         bridge_add_member(bst, vlan->ports[i].ifname);
1119
1120         vlist_flush(&bst->members);
1121         bridge_check_retry(bst);
1122 }
1123
1124 static void
1125 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
1126 {
1127         struct bridge_config *cfg = &bst->config;
1128         struct blob_attr *cur;
1129
1130         /* defaults */
1131         memset(cfg, 0, sizeof(*cfg));
1132         cfg->stp = false;
1133         cfg->stp_kernel = false;
1134         cfg->robustness = 2;
1135         cfg->igmp_snoop = false;
1136         cfg->multicast_querier = false;
1137         cfg->query_interval = 12500;
1138         cfg->query_response_interval = 1000;
1139         cfg->last_member_interval = 100;
1140         cfg->hash_max = 512;
1141         cfg->bridge_empty = false;
1142         cfg->priority = 0x7FFF;
1143         cfg->vlan_filtering = false;
1144
1145         cfg->forward_delay = 8;
1146         cfg->max_age = 10;
1147         cfg->hello_time = 1;
1148
1149         if ((cur = tb[BRIDGE_ATTR_STP]))
1150                 cfg->stp = blobmsg_get_bool(cur);
1151
1152         if ((cur = tb[BRIDGE_ATTR_STP_KERNEL]))
1153                 cfg->stp = blobmsg_get_bool(cur);
1154
1155         if ((cur = tb[BRIDGE_ATTR_STP_PROTO]))
1156                 cfg->stp_proto = blobmsg_get_string(cur);
1157
1158         if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1159                 cfg->forward_delay = blobmsg_get_u32(cur);
1160
1161         if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1162                 cfg->priority = blobmsg_get_u32(cur);
1163
1164         if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1165                 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1166
1167         if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1168                 cfg->multicast_querier = blobmsg_get_bool(cur);
1169
1170         if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1171                 cfg->hash_max = blobmsg_get_u32(cur);
1172
1173         if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1174                 cfg->robustness = blobmsg_get_u32(cur);
1175                 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1176         }
1177
1178         if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1179                 cfg->query_interval = blobmsg_get_u32(cur);
1180                 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1181         }
1182
1183         if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1184                 cfg->query_response_interval = blobmsg_get_u32(cur);
1185                 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1186         }
1187
1188         if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1189                 cfg->last_member_interval = blobmsg_get_u32(cur);
1190                 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1191         }
1192
1193         if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1194                 cfg->ageing_time = blobmsg_get_u32(cur);
1195                 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1196         }
1197
1198         if ((cur = tb[BRIDGE_ATTR_HELLO_TIME]))
1199                 cfg->hello_time = blobmsg_get_u32(cur);
1200
1201         if ((cur = tb[BRIDGE_ATTR_MAX_AGE]))
1202                 cfg->max_age = blobmsg_get_u32(cur);
1203
1204         if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1205                 cfg->bridge_empty = blobmsg_get_bool(cur);
1206
1207         if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1208                 cfg->vlan_filtering = blobmsg_get_bool(cur);
1209 }
1210
1211 static enum dev_change_type
1212 bridge_reload(struct device *dev, struct blob_attr *attr)
1213 {
1214         struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1215         struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1216         enum dev_change_type ret = DEV_CONFIG_APPLIED;
1217         unsigned long diff;
1218         struct bridge_state *bst;
1219
1220         BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / 8);
1221         BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / 8);
1222
1223         bst = container_of(dev, struct bridge_state, dev);
1224         attr = blob_memdup(attr);
1225
1226         blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1227                 blob_data(attr), blob_len(attr));
1228         blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1229                 blob_data(attr), blob_len(attr));
1230
1231         if (tb_dev[DEV_ATTR_MACADDR])
1232                 bst->primary_port = NULL;
1233
1234         bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1235         device_init_settings(dev, tb_dev);
1236         bridge_apply_settings(bst, tb_br);
1237
1238         if (bst->config_data) {
1239                 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1240                 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1241
1242                 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1243                         blob_data(bst->config_data), blob_len(bst->config_data));
1244
1245                 diff = 0;
1246                 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, &diff);
1247                 if (diff) {
1248                         ret = DEV_CONFIG_RESTART;
1249                         D(DEVICE, "Bridge %s device attributes have changed, diff=0x%lx\n",
1250                           dev->ifname, diff);
1251                 }
1252
1253                 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1254                         blob_data(bst->config_data), blob_len(bst->config_data));
1255
1256                 diff = 0;
1257                 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, &diff);
1258                 if (diff & ~(1 << BRIDGE_ATTR_PORTS)) {
1259                         ret = DEV_CONFIG_RESTART;
1260                         D(DEVICE, "Bridge %s attributes have changed, diff=0x%lx\n",
1261                           dev->ifname, diff);
1262                 }
1263
1264                 bridge_config_init(dev);
1265         }
1266
1267         free(bst->config_data);
1268         bst->config_data = attr;
1269         return ret;
1270 }
1271
1272 static void
1273 bridge_retry_members(struct uloop_timeout *timeout)
1274 {
1275         struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1276         struct bridge_member *bm;
1277
1278         bst->n_failed = 0;
1279         vlist_for_each_element(&bst->members, bm, node) {
1280                 if (bm->present)
1281                         continue;
1282
1283                 if (!bm->dev.dev->present)
1284                         continue;
1285
1286                 bm->present = true;
1287                 bst->n_present++;
1288                 bridge_enable_member(bm);
1289         }
1290 }
1291
1292 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1293 {
1294         const uint16_t *i1 = k1, *i2 = k2;
1295
1296         return *i1 - *i2;
1297 }
1298
1299 static bool
1300 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1301 {
1302         int i;
1303
1304         if (v1->n_ports != v2->n_ports)
1305                 return false;
1306
1307         for (i = 0; i < v1->n_ports; i++)
1308                 if (v1->ports[i].flags != v2->ports[i].flags ||
1309                     strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1310                         return false;
1311
1312         return true;
1313 }
1314
1315 static void
1316 bridge_vlan_free(struct bridge_vlan *vlan)
1317 {
1318         struct bridge_vlan_hotplug_port *port, *tmp;
1319
1320         if (!vlan)
1321                 return;
1322
1323         list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1324                 free(port);
1325
1326         free(vlan);
1327 }
1328
1329 static void
1330 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1331                    struct vlist_node *node_old)
1332 {
1333         struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1334         struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1335
1336         if (!bst->has_vlans || !bst->active)
1337                 goto out;
1338
1339         if (node_old)
1340                 vlan_old = container_of(node_old, struct bridge_vlan, node);
1341         if (node_new)
1342                 vlan_new = container_of(node_new, struct bridge_vlan, node);
1343
1344         if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1345                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1346                 goto out;
1347         }
1348
1349         if (node_old)
1350                 bridge_set_vlan_state(bst, vlan_old, false);
1351
1352         if (node_old && node_new)
1353                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1354
1355         if (node_new)
1356                 vlan_new->pending = true;
1357
1358         bst->dev.config_pending = true;
1359
1360 out:
1361         bridge_vlan_free(vlan_old);
1362 }
1363
1364 static void
1365 bridge_dev_vlan_update(struct device *dev)
1366 {
1367         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1368         struct bridge_vlan *vlan;
1369
1370         vlist_for_each_element(&dev->vlans, vlan, node) {
1371                 if (!vlan->pending)
1372                         continue;
1373
1374                 vlan->pending = false;
1375                 bridge_set_vlan_state(bst, vlan, true);
1376         }
1377 }
1378
1379 static struct device *
1380 bridge_create(const char *name, struct device_type *devtype,
1381         struct blob_attr *attr)
1382 {
1383         struct bridge_state *bst;
1384         struct device *dev = NULL;
1385
1386         bst = calloc(1, sizeof(*bst));
1387         if (!bst)
1388                 return NULL;
1389
1390         dev = &bst->dev;
1391
1392         if (device_init(dev, devtype, name) < 0) {
1393                 device_cleanup(dev);
1394                 free(bst);
1395                 return NULL;
1396         }
1397
1398         dev->config_pending = true;
1399         bst->retry.cb = bridge_retry_members;
1400
1401         bst->set_state = dev->set_state;
1402         dev->set_state = bridge_set_state;
1403
1404         dev->hotplug_ops = &bridge_ops;
1405
1406         vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1407         bst->members.keep_old = true;
1408
1409         vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1410
1411         bridge_reload(dev, attr);
1412
1413         return dev;
1414 }
1415
1416 static void __init bridge_device_type_init(void)
1417 {
1418         device_type_add(&bridge_device_type);
1419 }