mount: restorecon: guard against execl() errors

In the current implementation, in case of execl("/sbin/restorecon")
failing, the child process will also return and that will lead to
even more disasterous effects.
Though it seems unlikely that execl() would fail given that the file
exists, simply catch that case by exiting in case execl() returns.

Signed-off-by: Daniel Golle <daniel@makrotopia.org>

diff --git a/libfstools/mount.c b/libfstools/mount.c
index b30e5a6d3846639a0522867b5285478a48e2a916..1691ce747f50921423e1ca43709549c612b6d1be 100644 (file)
--- a/libfstools/mount.c
+++ b/libfstools/mount.c
@@ -99,7 +99,7 @@ selinux_restorecon(char *overlaydir)
 
        restorecon_pid = fork();
        if (!restorecon_pid)
-               execl("/sbin/restorecon", "restorecon", overlaydir, (char *) NULL);
+               exit(execl("/sbin/restorecon", "restorecon", overlaydir, (char *) NULL));
        else if (restorecon_pid > 0)
                waitpid(restorecon_pid, &status, 0);
 }