+#define warn_rule(r, e, fmt, ...) \
+ do { \
+ if (e) \
+ warn_elem(e, fmt, ##__VA_ARGS__); \
+ else \
+ warn("Warning: ubus rule (%s) " fmt, \
+ (r && r->name) ? r->name : "?", ##__VA_ARGS__); \
+ } while(0)
+
+static bool
+check_rule(struct fw3_state *state, struct fw3_rule *r, struct uci_element *e)
+{
+ if (!r->enabled)
+ return false;
+
+ if (r->src.invert || r->dest.invert)
+ {
+ warn_rule(r, e, "must not have inverted 'src' or 'dest' options");
+ return false;
+ }
+ else if (r->src.set && !r->src.any &&
+ !(r->_src = fw3_lookup_zone(state, r->src.name)))
+ {
+ warn_rule(r, e, "refers to not existing zone '%s'", r->src.name);
+ return false;
+ }
+ else if (r->dest.set && !r->dest.any &&
+ !(r->_dest = fw3_lookup_zone(state, r->dest.name)))
+ {
+ warn_rule(r, e, "refers to not existing zone '%s'", r->dest.name);
+ return false;
+ }
+ else if (r->ipset.set && state->disable_ipsets)
+ {
+ warn_rule(r, e, "skipped due to disabled ipset support");
+ return false;
+ }
+ else if (r->ipset.set &&
+ !(r->ipset.ptr = fw3_lookup_ipset(state, r->ipset.name)))
+ {
+ warn_rule(r, e, "refers to unknown ipset '%s'", r->ipset.name);
+ return false;
+ }
+
+ if (!r->_src && r->target == FW3_FLAG_NOTRACK)
+ {
+ warn_rule(r, e, "is set to target NOTRACK but has no source assigned");
+ return false;
+ }
+
+ if (!r->set_mark.set && !r->set_xmark.set &&
+ r->target == FW3_FLAG_MARK)
+ {
+ warn_rule(r, e, "is set to target MARK but specifies neither "
+ "'set_mark' nor 'set_xmark' option");
+ return false;
+ }
+
+ if (r->_dest && r->target == FW3_FLAG_MARK)
+ {
+ warn_rule(r, e, "must not specify 'dest' for MARK target");
+ return false;
+ }
+
+ if (r->set_mark.invert || r->set_xmark.invert)
+ {
+ warn_rule(r, e, "must not have inverted 'set_mark' or 'set_xmark'");
+ return false;
+ }
+
+ if (!r->_src && !r->_dest && !r->src.any && !r->dest.any)
+ {
+ warn_rule(r, e, "has neither a source nor a destination zone assigned "
+ "- assuming an output r");
+ }
+
+ if (list_empty(&r->proto))
+ {
+ warn_rule(r, e, "does not specify a protocol, assuming TCP+UDP");
+ fw3_parse_protocol(&r->proto, "tcpudp", true);
+ }
+
+ if (r->target == FW3_FLAG_UNSPEC)
+ {
+ warn_rule(r, e, "has no target specified, defaulting to REJECT");
+ r->target = FW3_FLAG_REJECT;
+ }
+ else if (r->target > FW3_FLAG_MARK)
+ {
+ warn_rule(r, e, "has invalid target specified, defaulting to REJECT");
+ r->target = FW3_FLAG_REJECT;
+ }
+
+ /* NB: r family... */
+ if (r->_dest)
+ {
+ fw3_setbit(r->_dest->flags[0], r->target);
+ fw3_setbit(r->_dest->flags[1], r->target);
+ }
+ else if (need_src_action_chain(r))
+ {
+ fw3_setbit(r->_src->flags[0], fw3_to_src_target(r->target));
+ fw3_setbit(r->_src->flags[1], fw3_to_src_target(r->target));
+ }
+
+ return true;
+}
+