1 From 83bb21c65c73a5250504e6056e29683339fb15d2 Mon Sep 17 00:00:00 2001
2 From: Jes Sorensen <Jes.Sorensen@redhat.com>
3 Date: Mon, 16 May 2016 22:03:04 -0400
4 Subject: [PATCH] rtl8xxxu: Move skb delivery into parse_tx_desc() handler
6 This is another prepatory patch to be able to handle aggregated RX
9 In order to avoid adding a prototype, this also moves the
10 rtl8723bu_handle_c2h() function.
12 Signed-off-by: Jes Sorensen <Jes.Sorensen@redhat.com>
14 .../net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 104 ++++++++++-----------
15 1 file changed, 50 insertions(+), 54 deletions(-)
17 --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
18 +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c
19 @@ -5045,6 +5045,51 @@ static void rtl8xxxu_rx_urb_work(struct
23 +static void rtl8723bu_handle_c2h(struct rtl8xxxu_priv *priv,
24 + struct sk_buff *skb)
26 + struct rtl8723bu_c2h *c2h = (struct rtl8723bu_c2h *)skb->data;
27 + struct device *dev = &priv->udev->dev;
32 + dev_dbg(dev, "C2H ID %02x seq %02x, len %02x source %02x\n",
33 + c2h->id, c2h->seq, len, c2h->bt_info.response_source);
36 + case C2H_8723B_BT_INFO:
37 + if (c2h->bt_info.response_source >
38 + BT_INFO_SRC_8723B_BT_ACTIVE_SEND)
39 + dev_dbg(dev, "C2H_BT_INFO WiFi only firmware\n");
41 + dev_dbg(dev, "C2H_BT_INFO BT/WiFi coexist firmware\n");
43 + if (c2h->bt_info.bt_has_reset)
44 + dev_dbg(dev, "BT has been reset\n");
45 + if (c2h->bt_info.tx_rx_mask)
46 + dev_dbg(dev, "BT TRx mask\n");
49 + case C2H_8723B_BT_MP_INFO:
50 + dev_dbg(dev, "C2H_MP_INFO ext ID %02x, status %02x\n",
51 + c2h->bt_mp_info.ext_id, c2h->bt_mp_info.status);
53 + case C2H_8723B_RA_REPORT:
55 + "C2H RA RPT: rate %02x, unk %i, macid %02x, noise %i\n",
56 + c2h->ra_report.rate, c2h->ra_report.dummy0_0,
57 + c2h->ra_report.macid, c2h->ra_report.noisy_state);
60 + dev_info(dev, "Unhandled C2H event %02x seq %02x\n",
62 + print_hex_dump(KERN_INFO, "C2H content: ", DUMP_PREFIX_NONE,
63 + 16, 1, c2h->raw.payload, len, false);
68 int rtl8xxxu_parse_rxdesc16(struct rtl8xxxu_priv *priv, struct sk_buff *skb,
69 struct ieee80211_rx_status *rx_status)
71 @@ -5094,6 +5139,7 @@ int rtl8xxxu_parse_rxdesc16(struct rtl8x
72 rx_status->freq = hw->conf.chandef.chan->center_freq;
73 rx_status->band = hw->conf.chandef.chan->band;
75 + ieee80211_rx_irqsafe(hw, skb);
76 return RX_TYPE_DATA_PKT;
79 @@ -5125,6 +5171,8 @@ int rtl8xxxu_parse_rxdesc24(struct rtl8x
80 if (rx_desc->rpt_sel) {
81 struct device *dev = &priv->udev->dev;
82 dev_dbg(dev, "%s: C2H packet\n", __func__);
83 + rtl8723bu_handle_c2h(priv, skb);
88 @@ -5152,54 +5200,10 @@ int rtl8xxxu_parse_rxdesc24(struct rtl8x
89 rx_status->freq = hw->conf.chandef.chan->center_freq;
90 rx_status->band = hw->conf.chandef.chan->band;
92 + ieee80211_rx_irqsafe(hw, skb);
93 return RX_TYPE_DATA_PKT;
96 -static void rtl8723bu_handle_c2h(struct rtl8xxxu_priv *priv,
97 - struct sk_buff *skb)
99 - struct rtl8723bu_c2h *c2h = (struct rtl8723bu_c2h *)skb->data;
100 - struct device *dev = &priv->udev->dev;
103 - len = skb->len - 2;
105 - dev_dbg(dev, "C2H ID %02x seq %02x, len %02x source %02x\n",
106 - c2h->id, c2h->seq, len, c2h->bt_info.response_source);
109 - case C2H_8723B_BT_INFO:
110 - if (c2h->bt_info.response_source >
111 - BT_INFO_SRC_8723B_BT_ACTIVE_SEND)
112 - dev_dbg(dev, "C2H_BT_INFO WiFi only firmware\n");
114 - dev_dbg(dev, "C2H_BT_INFO BT/WiFi coexist firmware\n");
116 - if (c2h->bt_info.bt_has_reset)
117 - dev_dbg(dev, "BT has been reset\n");
118 - if (c2h->bt_info.tx_rx_mask)
119 - dev_dbg(dev, "BT TRx mask\n");
122 - case C2H_8723B_BT_MP_INFO:
123 - dev_dbg(dev, "C2H_MP_INFO ext ID %02x, status %02x\n",
124 - c2h->bt_mp_info.ext_id, c2h->bt_mp_info.status);
126 - case C2H_8723B_RA_REPORT:
128 - "C2H RA RPT: rate %02x, unk %i, macid %02x, noise %i\n",
129 - c2h->ra_report.rate, c2h->ra_report.dummy0_0,
130 - c2h->ra_report.macid, c2h->ra_report.noisy_state);
133 - dev_info(dev, "Unhandled C2H event %02x seq %02x\n",
134 - c2h->id, c2h->seq);
135 - print_hex_dump(KERN_INFO, "C2H content: ", DUMP_PREFIX_NONE,
136 - 16, 1, c2h->raw.payload, len, false);
141 static void rtl8xxxu_rx_complete(struct urb *urb)
143 struct rtl8xxxu_rx_urb *rx_urb =
144 @@ -5209,19 +5213,11 @@ static void rtl8xxxu_rx_complete(struct
145 struct sk_buff *skb = (struct sk_buff *)urb->context;
146 struct ieee80211_rx_status *rx_status = IEEE80211_SKB_RXCB(skb);
147 struct device *dev = &priv->udev->dev;
150 skb_put(skb, urb->actual_length);
152 if (urb->status == 0) {
153 - rx_type = priv->fops->parse_rx_desc(priv, skb, rx_status);
155 - if (rx_type == RX_TYPE_DATA_PKT)
156 - ieee80211_rx_irqsafe(hw, skb);
158 - rtl8723bu_handle_c2h(priv, skb);
159 - dev_kfree_skb(skb);
161 + priv->fops->parse_rx_desc(priv, skb, rx_status);
164 rx_urb->urb.context = NULL;