Revert "ar71xx: fix Arduino Yun enabling of level shifters outputs"
authorSungbo Eo <mans0n@gorani.run>
Sun, 12 Jan 2020 12:33:53 +0000 (21:33 +0900)
committerAdrian Schmutzler <freifunk@adrianschmutzler.de>
Sun, 2 Aug 2020 14:34:21 +0000 (16:34 +0200)
This reverts commit 077253dd666a30ae5231c3748222d4b5b138593d.

The output enable pins should be disabled by default, and only enabled when
used. Otherwise unwanted conflicts might occur between MCU and SoC pins.

Signed-off-by: Sungbo Eo <mans0n@gorani.run>
target/linux/ar71xx/files/arch/mips/ath79/mach-arduino-yun.c

index e92f68f490a14b38a0aef9afb6008a1d5fab6275..5873248edf2cc808629d3589170e28aed2675574 100644 (file)
@@ -141,7 +141,7 @@ static void __init ds_setup(void)
 
        // enable OE of level shifter
        if (gpio_request_one(DS_GPIO_OE,
-           GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED, "OE-1") != 0)
+           GPIOF_OUT_INIT_LOW | GPIOF_EXPORT_DIR_FIXED, "OE-1") != 0)
                printk("Error setting GPIO OE\n");
 
        if (gpio_request_one(DS_GPIO_UART_ENA,
@@ -150,7 +150,7 @@ static void __init ds_setup(void)
 
        // enable OE of level shifter
        if (gpio_request_one(DS_GPIO_OE2,
-           GPIOF_OUT_INIT_HIGH | GPIOF_EXPORT_DIR_FIXED, "OE-2") != 0)
+           GPIOF_OUT_INIT_LOW | GPIOF_EXPORT_DIR_FIXED, "OE-2") != 0)
                printk("Error setting GPIO OE2\n");
 }