base-files: fix nand_upgrade_ubinized()
authorRafał Miłecki <rafal@milecki.pl>
Mon, 10 Apr 2023 17:01:35 +0000 (19:01 +0200)
committerDaniel Golle <daniel@makrotopia.org>
Tue, 11 Apr 2023 12:42:47 +0000 (13:42 +0100)
When using "ubiformat" with stdin it requires passing image size using
the -S argument. Provide it just like we do for "ubiupdatevol".

This fixes:
ubiformat: error!: must use '-S' with non-zero value when reading from stdin

This change fixes sysupgrade for bcm53xx and bcm4908 NAND devices
possibly some other targets too.

Cc: Rodrigo Balerdi <lanchon@gmail.com>
Cc: Daniel Golle <daniel@makrotopia.org>
Fixes: 971071212052 ("base-files: accept gzipped nand sysupgrade images")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Acked-by: Daniel Golle <daniel@makrotopia.org>
Tested-by: Koen Vandeputte <koen.vandeputte@citymesh.com>
package/base-files/files/lib/upgrade/nand.sh

index 907945b349bec3c86f0cb8bee7a2543c3f76e824..fa29d575a81dafce4b271586cadf01dc643f5bf2 100644 (file)
@@ -261,10 +261,12 @@ nand_upgrade_ubinized() {
        local ubi_file="$1"
        local gz="$2"
 
+       local ubi_length=$( (${gz}cat "$ubi_file" | wc -c) 2> /dev/null)
+
        nand_detach_ubi "$CI_UBIPART" || return 1
 
        local mtdnum="$( find_mtd_index "$CI_UBIPART" )"
-       ${gz}cat "$ubi_file" | ubiformat "/dev/mtd$mtdnum" -y -f - && ubiattach -m "$mtdnum"
+       ${gz}cat "$ubi_file" | ubiformat "/dev/mtd$mtdnum" -S "$ubi_length" -y -f - && ubiattach -m "$mtdnum"
 }
 
 # Write the UBIFS image to UBI rootfs volume