at91: sama7: fix racy SD card image generation
authorPetr Štetiar <ynezz@true.cz>
Tue, 3 Jan 2023 11:44:51 +0000 (12:44 +0100)
committerPetr Štetiar <ynezz@true.cz>
Wed, 11 Jan 2023 14:16:52 +0000 (15:16 +0100)
We've few low spec (make -j3) build workers attached to the 22.03
buildbot instance which from time to time exhibit following build
failure during image generation:

 + dd bs=512 if=root.ext4 of=openwrt-22.03-snapshot-r20028-43d71ad93e-at91-sama7-microchip_sama7g5-ek-ext4-sdcard.img.gz.img seek=135168 conv=notrunc
 dd: failed to open 'root.ext4': No such file or directory

Thats likely due to the fact, that on buildbots we've
`TARGET_PER_DEVICE_ROOTFS=y` which produces differently named filesystem
image in the SD card image target dependency chain:

 make_ext4fs -L rootfs ... root.ext4+pkg=68b329da

and that hardcoded root.ext4 becomes available from other target in the
later stages. So lets fix this issue by using IMAGE_ROOTFS Make variable
which should contain proper path to the root filesystem image.

Signed-off-by: Petr Štetiar <ynezz@true.cz>
target/linux/at91/image/sama7.mk

index bf1704dfb3371fdc5a3c0af490bd6d0ba0867879..8d6f67d80e63560778db4d3ffca2636eebf20004 100644 (file)
@@ -35,7 +35,7 @@ define Build/at91-sdcard
   ./gen_at91_sdcard_img.sh \
        $@.img \
        $@.boot \
-       $(KDIR)/root.ext4 \
+       $(IMAGE_ROOTFS) \
        $(AT91_SD_BOOT_PARTSIZE) \
        $(CONFIG_TARGET_ROOTFS_PARTSIZE)