Fixes:
plug/hotplug.c:152:10: error: ignoring return value of 'chown', declared with attribute warn_unused_result [-Werror=unused-result]
chown(blobmsg_get_string(tb[0]), 0, g->gr_gid);
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
char *minor = hotplug_msg_find_var(msg, "MINOR");
char *major = hotplug_msg_find_var(msg, "MAJOR");
char *subsystem = hotplug_msg_find_var(msg, "SUBSYSTEM");
char *minor = hotplug_msg_find_var(msg, "MINOR");
char *major = hotplug_msg_find_var(msg, "MAJOR");
char *subsystem = hotplug_msg_find_var(msg, "SUBSYSTEM");
blobmsg_parse_array(mkdev_policy, 3, tb, blobmsg_data(data), blobmsg_data_len(data));
if (tb[0] && tb[1] && minor && major && subsystem) {
blobmsg_parse_array(mkdev_policy, 3, tb, blobmsg_data(data), blobmsg_data_len(data));
if (tb[0] && tb[1] && minor && major && subsystem) {
struct group *g = getgrnam(blobmsg_get_string(tb[2]));
if (g)
struct group *g = getgrnam(blobmsg_get_string(tb[2]));
if (g)
- chown(blobmsg_get_string(tb[0]), 0, g->gr_gid);
- else
+ ret = chown(blobmsg_get_string(tb[0]), 0, g->gr_gid);
+
+ if (!g || ret < 0)
ERROR("cannot set group %s for %s\n",
blobmsg_get_string(tb[2]),
blobmsg_get_string(tb[0]));
ERROR("cannot set group %s for %s\n",
blobmsg_get_string(tb[2]),
blobmsg_get_string(tb[0]));