From: Daniel Golle <daniel@makrotopia.org>
Date: Mon, 30 Aug 2021 21:20:30 +0000 (+0100)
Subject: initd: fix off-by-one error in mkdev.c
X-Git-Url: http://git.openwrt.org/ubox.git?a=commitdiff_plain;h=8eb1d783cca6e0d501dd3a2f94262ffc36ae6482;p=project%2Fprocd.git

initd: fix off-by-one error in mkdev.c

Actually make sure buffer is 0-terminated intead of writing the 0-byte
out of bounds.

Coverity CID: 1330087 Readlink used insecurely
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
---

diff --git a/initd/mkdev.c b/initd/mkdev.c
index 44101aa..1c9c97a 100644
--- a/initd/mkdev.c
+++ b/initd/mkdev.c
@@ -86,7 +86,7 @@ static void find_devs(bool block)
 		if (len <= 0)
 			continue;
 
-		buf[len] = 0;
+		buf[sizeof(buf) - 1] = '\0';
 		if (!find_pattern(buf))
 			continue;