mm/migrate.c: attach_page_private already does the get_page
authorHugh Dickins <hughd@google.com>
Tue, 2 Jun 2020 21:36:32 +0000 (14:36 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 2 Jun 2020 22:19:42 +0000 (15:19 -0700)
Just finished bisecting mmotm, to find why a test which used to take
four minutes now took more than an hour: the __buffer_migrate_page()
cleanup left behind a get_page() which attach_page_private() now does.

Fixes: cd0f37154443 ("mm/migrate.c: call detach_page_private to cleanup code")
Signed-off-by: Hugh Dickins <hughd@google.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/migrate.c

index fb425d86c1151491a12fff4cb140a1aa6702fb34..846af96b84a5392c432944c6a110e727f1134e23 100644 (file)
@@ -798,7 +798,6 @@ recheck_buffers:
                goto unlock_buffers;
 
        attach_page_private(newpage, detach_page_private(page));
-       get_page(newpage);
 
        bh = head;
        do {