ddns-scripts: fix duplication of processes when reloading 23946/head
authorMiguel Angel Mulero Martinez <migmul@gmail.com>
Tue, 16 Apr 2024 13:53:29 +0000 (15:53 +0200)
committerMiguel Angel Mulero Martinez <migmul@gmail.com>
Tue, 14 May 2024 19:18:58 +0000 (21:18 +0200)
When a "service ddns reload" is issued, the ddns processes are being
duplicated.
It seems the culprit is the -1 in the 'killall' command, and removing it
fixes the issue.
The -1 means to use SIGHUP, instead of the default SIGTERM.
In this case, the idea is to kill all other processes, so SIGTERM is
appropriate. In case the processes hang, SIGKILL may be another option.

Signed-off-by: Miguel Angel Mulero Martinez <migmul@gmail.com>
net/ddns-scripts/Makefile
net/ddns-scripts/files/usr/lib/ddns/dynamic_dns_updater.sh

index 9ffc3d2f3b33bfae0de785c877aa466ccd797105..2524188aa926eeb48ebfa26e8644fd89d8fa26c5 100644 (file)
@@ -8,7 +8,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=ddns-scripts
 PKG_VERSION:=2.8.2
-PKG_RELEASE:=43
+PKG_RELEASE:=44
 
 PKG_LICENSE:=GPL-2.0
 
index 71de1a7e01e1d0546ce6d8d882a47a3d5d1c05ce..21b0202d375c7c8796e56693368954f9394b642f 100644 (file)
@@ -89,7 +89,7 @@ case "$1" in
                exit 1
                ;;
        reload)
-               killall -1 dynamic_dns_updater.sh 2>/dev/null
+               killall dynamic_dns_updater.sh 2>/dev/null
                exit $?
                ;;
        *)      usage_err "unknown command - $1";;