kmodloader: fix memory leak in scan_loaded_modules()
[project/ubox.git] / kmodloader.c
index a4d492d42348c2fe3c08e3ed02df0e297ba61c93..0afc79560693e9a67bf0ca74a0dfd934b5387e75 100644 (file)
 #include <libgen.h>
 #include <glob.h>
 #include <elf.h>
+#include <ctype.h>
 
 #include <libubox/avl.h>
 #include <libubox/avl-cmp.h>
 #include <libubox/utils.h>
 #include <libubox/ulog.h>
+#include <libubox/kvlist.h>
 
 #define DEF_MOD_PATH "/modules/%s/"
+/* duplicated from in-kernel include/linux/module.h */
+#define MODULE_NAME_LEN (64 - sizeof(unsigned long))
 
 enum {
        SCANNED,
        PROBE,
        LOADED,
+       BLACKLISTED,
 };
 
 struct module {
@@ -63,6 +68,7 @@ struct module_node {
 };
 
 static struct avl_tree modules;
+static KVLIST(options, kvlist_strlen);
 
 static char **module_folders = NULL;
 
@@ -73,7 +79,7 @@ static int init_module_folders(void)
        int n = 0;
        struct stat st;
        struct utsname ver;
-       char *s, *e, *p, path[256], ldpath[256];
+       char *s, *e, *p, path[330], ldpath[256];
 
        e = ldpath;
        s = getenv("LD_LIBRARY_PATH");
@@ -95,8 +101,10 @@ static int init_module_folders(void)
                if (!stat(path, &st) && S_ISDIR(st.st_mode)) {
                        module_folders = realloc(module_folders, sizeof(p) * (n + 2));
 
-                       if (!module_folders)
+                       if (!module_folders) {
+                               ULOG_ERR("out of memory\n");
                                return -1;
+                       }
 
                        module_folders[n++] = strdup(path);
                }
@@ -104,8 +112,10 @@ static int init_module_folders(void)
                s = p + 1;
        }
 
-       if (!module_folders)
+       if (!module_folders) {
+               ULOG_ERR("no module folders for kernel version %s found\n", ver.release);
                return -1;
+       }
 
        module_folders[n] = NULL;
        return 0;
@@ -155,7 +165,7 @@ static char* get_module_path(char *name)
 
 static char* get_module_name(char *path)
 {
-       static char name[33];
+       static char name[MODULE_NAME_LEN];
        char *t;
 
        strncpy(name, basename(path), sizeof(name) - 1);
@@ -301,12 +311,13 @@ static int scan_loaded_modules(void)
 {
        size_t buf_len = 0;
        char *buf = NULL;
+       int rv = -1;
        FILE *fp;
 
        fp = fopen("/proc/modules", "r");
        if (!fp) {
                ULOG_ERR("failed to open /proc/modules\n");
-               return -1;
+               goto out;
        }
 
        while (getline(&buf, &buf_len, fp) > 0) {
@@ -326,13 +337,20 @@ static int scan_loaded_modules(void)
                        /* possibly a module outside /lib/modules/<ver>/ */
                        n = alloc_module(m.name, NULL, 0, m.depends, m.size);
                }
+               if (!n) {
+                       ULOG_ERR("Failed to allocate memory for module\n");
+                       goto out;
+               }
+
                n->usage = m.usage;
                n->state = LOADED;
        }
+       rv = 0;
+out:
        free(buf);
        fclose(fp);
 
-       return 0;
+       return rv;
 }
 
 static struct module* get_module_info(const char *module, const char *name)
@@ -340,7 +358,8 @@ static struct module* get_module_info(const char *module, const char *name)
        int fd = open(module, O_RDONLY);
        unsigned int offset, size;
        char *map = MAP_FAILED, *strings, *dep = NULL;
-       const char *aliases[32] = { 0 };
+       const char **aliases = NULL;
+       const char **aliasesr;
        int naliases = 0;
        struct module *m = NULL;
        struct stat s;
@@ -383,11 +402,14 @@ static struct module* get_module_info(const char *module, const char *name)
                if (!strncmp(strings, "depends=", len + 1))
                        dep = sep;
                else if (!strncmp(strings, "alias=", len + 1)) {
-                       if (naliases < ARRAY_SIZE(aliases))
-                               aliases[naliases++] = sep;
-                       else
-                               ULOG_WARN("module %s has more than %d aliases: truncated",
-                                               name, ARRAY_SIZE(aliases));
+                       aliasesr = realloc(aliases, sizeof(sep) * (naliases + 1));
+                       if (!aliasesr) {
+                               ULOG_ERR("out of memory\n");
+                               goto out;
+                       }
+
+                       aliases = aliasesr;
+                       aliases[naliases++] = sep;
                }
                strings = &sep[strlen(sep)];
        }
@@ -404,18 +426,18 @@ out:
        if (fd >= 0)
                close(fd);
 
+       free(aliases);
+
        return m;
 }
 
 static int scan_module_folder(const char *dir)
 {
        int gl_flags = GLOB_NOESCAPE | GLOB_MARK;
-       struct utsname ver;
        char *path;
        glob_t gl;
-       int j;
+       int j, rv = 0;
 
-       uname(&ver);
        path = alloca(strlen(dir) + sizeof("*.ko") + 1);
        sprintf(path, "%s*.ko", dir);
 
@@ -425,18 +447,34 @@ static int scan_module_folder(const char *dir)
        for (j = 0; j < gl.gl_pathc; j++) {
                char *name = get_module_name(gl.gl_pathv[j]);
                struct module *m;
+               char *opts;
 
                if (!name)
                        continue;
 
                m = find_module(name);
-               if (!m)
-                       get_module_info(gl.gl_pathv[j], name);
+               if (m)
+                       continue;
+
+               m = get_module_info(gl.gl_pathv[j], name);
+               if (!m) {
+                       rv |= -1;
+                       continue;
+               }
+
+               opts = kvlist_get(&options, name);
+               if (!opts)
+                       continue;
+
+               if (*opts == '\x01')
+                       m->state = BLACKLISTED;
+               else
+                       m->opts = strdup(opts);
        }
 
        globfree(&gl);
 
-       return 0;
+       return rv;
 }
 
 static int scan_module_folders(void)
@@ -551,6 +589,11 @@ static int insert_module(char *path, const char *options)
        struct stat s;
        int fd, ret = -1;
 
+       if (!path) {
+               ULOG_ERR("Path not specified\n");
+               return ret;
+       }
+
        if (stat(path, &s)) {
                ULOG_ERR("missing module %s\n", path);
                return ret;
@@ -563,6 +606,11 @@ static int insert_module(char *path, const char *options)
        }
 
        data = malloc(s.st_size);
+       if (!data) {
+               ULOG_ERR("out of memory\n");
+               goto out;
+       }
+
        if (read(fd, data, s.st_size) == s.st_size) {
                ret = syscall(__NR_init_module, data, (unsigned long) s.st_size, options);
                if (errno == EEXIST)
@@ -571,6 +619,7 @@ static int insert_module(char *path, const char *options)
        else
                ULOG_ERR("failed to read full module %s\n", path);
 
+out:
        close(fd);
        free(data);
 
@@ -601,12 +650,13 @@ static void load_moddeps(struct module *_m)
        }
 }
 
-static int iterations = 0;
-static int load_modprobe(void)
+static int load_modprobe(bool allow_load_retry)
 {
-       int loaded, todo;
+       int loaded, skipped, failed;
        struct module_node *mn;
        struct module *m;
+       bool load_retry = false;
+       static bool first_iteration = true;
 
        avl_for_each_element(&modules, mn, avl) {
                if (mn->is_alias)
@@ -618,28 +668,38 @@ static int load_modprobe(void)
 
        do {
                loaded = 0;
-               todo = 0;
+               skipped = 0;
+               failed = 0;
                avl_for_each_element(&modules, mn, avl) {
                        if (mn->is_alias)
                                continue;
                        m = mn->m;
-                       if ((m->state == PROBE) && (!deps_available(m, 0))) {
+                       if ((m->state == PROBE) && (!deps_available(m, 0)) && (!m->error || load_retry)) {
                                if (!insert_module(get_module_path(m->name), (m->opts) ? (m->opts) : (""))) {
                                        m->state = LOADED;
                                        m->error = 0;
                                        loaded++;
                                        continue;
                                }
+
                                m->error = 1;
                        }
 
-                       if ((m->state == PROBE) || m->error)
-                               todo++;
+                       if (m->error)
+                               failed++;
+                       else if (m->state == PROBE)
+                               skipped++;
+               }
+
+               if (allow_load_retry) {
+                       /* if we can't load anything else let's try to load failed modules */
+                       load_retry = loaded ? (failed && !skipped) : (failed && !load_retry && !first_iteration);
                }
-               iterations++;
-       } while (loaded);
 
-       return todo;
+               first_iteration = false;
+       } while (loaded || load_retry);
+
+       return skipped + failed;
 }
 
 static int print_insmod_usage(void)
@@ -651,7 +711,11 @@ static int print_insmod_usage(void)
 
 static int print_modprobe_usage(void)
 {
-       ULOG_INFO("Usage:\n\tmodprobe [-q] filename\n");
+       ULOG_INFO(
+               "Usage:\n"
+               "\tmodprobe [-q] [-v] filename\n"
+               "\tmodprobe -a [-q] [-v] filename [filename...]\n"
+       );
 
        return -1;
 }
@@ -692,6 +756,12 @@ static int main_insmod(int argc, char **argv)
                len += strlen(argv[i]) + 1;
 
        options = malloc(len);
+       if (!options) {
+               ULOG_ERR("out of memory\n");
+               ret = -1;
+               goto err;
+       }
+
        options[0] = 0;
        cur = options;
        for (i = 2; i < argc; i++) {
@@ -820,16 +890,24 @@ static int main_modprobe(int argc, char **argv)
 {
        struct module_node *mn;
        struct module *m;
-       char *name;
-       char *mod = NULL;
+       int exit_code = 0;
+       int load_fail;
+       int log_level = LOG_WARNING;
        int opt;
        bool quiet = false;
+       bool use_all = false;
 
-       while ((opt = getopt(argc, argv, "q")) != -1 ) {
+       while ((opt = getopt(argc, argv, "aqv")) != -1 ) {
                switch (opt) {
+                       case 'a':
+                               use_all = true;
+                               break;
                        case 'q': /* shhhh! */
                                quiet = true;
                                break;
+                       case 'v':
+                               log_level = LOG_DEBUG;
+                               break;
                        default: /* '?' */
                                return print_modprobe_usage();
                                break;
@@ -839,7 +917,8 @@ static int main_modprobe(int argc, char **argv)
        if (optind >= argc)
                return print_modprobe_usage(); /* expected module after options */
 
-       mod = argv[optind];
+       /* after print_modprobe_usage() so it won't be filtered out */
+       ulog_threshold(log_level);
 
        if (scan_module_folders())
                return -1;
@@ -847,40 +926,48 @@ static int main_modprobe(int argc, char **argv)
        if (scan_loaded_modules())
                return -1;
 
-       name = get_module_name(mod);
-       m = find_module(name);
-       if (m && m->state == LOADED) {
-               if (!quiet)
-                       ULOG_ERR("%s is already loaded\n", name);
-               return 0;
-       } else if (!m) {
-               if (!quiet)
-                       ULOG_ERR("failed to find a module named %s\n", name);
-               return -1;
-       } else {
-               int fail;
+       do {
+               char *name;
 
-               m->state = PROBE;
+               name = get_module_name(argv[optind]);
+               m = find_module(name);
 
-               fail = load_modprobe();
+               if (m && m->state == BLACKLISTED) {
+                       if (!quiet)
+                               ULOG_INFO("%s is blacklisted\n", name);
+               } else if (m && m->state == LOADED) {
+                       if (!quiet)
+                               ULOG_INFO("%s is already loaded\n", name);
+               } else if (!m) {
+                       if (!quiet)
+                               ULOG_ERR("failed to find a module named %s\n", name);
+                       exit_code = -1;
+               } else {
+                       m->state = PROBE;
+               }
 
-               if (fail) {
-                       ULOG_ERR("%d module%s could not be probed\n",
-                                fail, (fail == 1) ? ("") : ("s"));
+               optind++;
+       } while (use_all && optind < argc);
 
-                       avl_for_each_element(&modules, mn, avl) {
-                               if (mn->is_alias)
-                                       continue;
-                               m = mn->m;
-                               if ((m->state == PROBE) || m->error)
-                                       ULOG_ERR("- %s\n", m->name);
-                       }
+       load_fail = load_modprobe(true);
+       if (load_fail) {
+               ULOG_ERR("%d module%s could not be probed\n",
+                        load_fail, (load_fail == 1) ? ("") : ("s"));
+
+               avl_for_each_element(&modules, mn, avl) {
+                       if (mn->is_alias)
+                               continue;
+                       m = mn->m;
+                       if ((m->state == PROBE) || m->error)
+                               ULOG_ERR("- %s\n", m->name);
                }
+
+               exit_code = -1;
        }
 
        free_modules();
 
-       return 0;
+       return exit_code;
 }
 
 static int main_loader(int argc, char **argv)
@@ -891,23 +978,28 @@ static int main_loader(int argc, char **argv)
        struct module *m;
        glob_t gl;
        char *path;
-       int fail, j;
+       int ret = 0, fail, j;
 
        if (argc > 1)
                dir = argv[1];
 
        path = malloc(strlen(dir) + 2);
+       if (!path) {
+               ULOG_ERR("out of memory\n");
+               return -1;
+       }
+
        strcpy(path, dir);
        strcat(path, "*");
 
        if (scan_module_folders()) {
-               free (path);
-               return -1;
+               ret = -1;
+               goto free_path;
        }
 
        if (scan_loaded_modules()) {
-               free (path);
-               return -1;
+               ret = -1;
+               goto free_path;
        }
 
        ULOG_INFO("loading kernel modules from %s\n", path);
@@ -938,21 +1030,36 @@ static int main_loader(int argc, char **argv)
                                *opts++ = '\0';
 
                        m = find_module(get_module_name(mod));
-                       if (!m || (m->state == LOADED))
+                       if (!m || m->state == LOADED || m->state == BLACKLISTED)
                                continue;
 
-                       if (opts)
-                               m->opts = strdup(opts);
+                       if (opts) {
+                               if (m->opts) {
+                                       char *prev = m->opts;
+
+                                       fail = asprintf(&m->opts, "%s %s", prev, opts);
+                                       free(prev);
+                                       if (fail < 0) {
+                                               ULOG_ERR("out of memory for opts %s\n", opts);
+                                               free(mod);
+                                               fclose(fp);
+                                               ret = -1;
+                                               goto out;
+                                       }
+                               } else {
+                                       m->opts = strdup(opts);
+                               }
+                       }
                        m->state = PROBE;
                        if (basename(gl.gl_pathv[j])[0] - '0' <= 9)
-                               load_modprobe();
+                               load_modprobe(false);
 
                }
                free(mod);
                fclose(fp);
        }
 
-       fail = load_modprobe();
+       fail = load_modprobe(true);
 
        if (fail) {
                ULOG_ERR("%d module%s could not be probed\n",
@@ -971,9 +1078,10 @@ static int main_loader(int argc, char **argv)
 
 out:
        globfree(&gl);
+free_path:
        free(path);
 
-       return 0;
+       return ret;
 }
 
 static inline char weight(char c)
@@ -995,6 +1103,82 @@ static int avl_modcmp(const void *k1, const void *k2, void *ptr)
        return (unsigned char)weight(*s1) - (unsigned char)weight(*s2);
 }
 
+static void
+load_options(void)
+{
+       static char buf[512];
+       char *s;
+       FILE *f;
+
+       f = fopen("/etc/modules.conf", "r");
+       if (!f)
+               return;
+
+       while ((s = fgets(buf, sizeof(buf), f)) != NULL) {
+               char *c, *cmd, *mod;
+
+               while (isspace(*s))
+                       s++;
+
+               c = strchr(s, '#');
+               if (c)
+                       *c = 0;
+
+               while (isspace(*s))
+                       s++;
+
+               c = s + strlen(s);
+               while (c > s && isspace(c[-1])) {
+                       c[-1] = 0;
+                       c--;
+               }
+
+               cmd = strsep(&s, " \t");
+               if (!cmd || !*cmd)
+                       continue;
+
+               while (isspace(*s))
+                       s++;
+
+               mod = strsep(&s, " \t");
+               if (!mod || !*mod)
+                       continue;
+
+               if (!strcmp(cmd, "blacklist")) {
+                       kvlist_set(&options, mod, "\x01");
+                       continue;
+               }
+
+               if (!strcmp(cmd, "options")) {
+                       char *prev = kvlist_get(&options, mod);
+                       char *val = NULL;
+
+                       while (isspace(*s))
+                               s++;
+
+                       if (!*s)
+                               continue;
+
+                       if (prev && prev[0] == '\x01')
+                               continue;
+
+                       if (!prev) {
+                               kvlist_set(&options, mod, s);
+                               continue;
+                       }
+
+                       if (asprintf(&val, "%s %s", prev, s) < 0)
+                               continue;
+
+                       kvlist_set(&options, mod, val);
+                       free(val);
+                       continue;
+               }
+       }
+
+       fclose(f);
+}
+
 int main(int argc, char **argv)
 {
        char *exec = basename(*argv);
@@ -1012,6 +1196,8 @@ int main(int argc, char **argv)
        if (!strcmp(exec, "modinfo"))
                return main_modinfo(argc, argv);
 
+       load_options();
+
        if (!strcmp(exec, "modprobe"))
                return main_modprobe(argc, argv);