From cdc18fbb3ea8b5da866e049251d8bad79e4fbd04 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Petr=20=C5=A0tetiar?= Date: Tue, 13 Oct 2020 15:26:01 +0200 Subject: [PATCH] interface: fix possible null pointer dereference MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes following issue reported by clang-12 static analyzer: mdnsd/interface.c:250:6: warning: Access to field 'ipi_ifindex' results in a dereference of a null pointer (loaded from variable 'inp') if (inp->ipi_ifindex != iface->ifindex) ^~~~~~~~~~~~~~~~ mdnsd/interface.c:323:6: warning: Access to field 'ipi6_ifindex' results in a dereference of a null pointer (loaded from variable 'inp') if (inp->ipi6_ifindex != iface->ifindex) ^~~~~~~~~~~~~~~~~ Signed-off-by: Petr Å tetiar --- interface.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/interface.c b/interface.c index 690e857..5fb9bad 100644 --- a/interface.c +++ b/interface.c @@ -233,6 +233,9 @@ read_socket4(struct uloop_fd *u, unsigned int events) } } + if (!inp) + return; + if (debug > 1) { char buf[256]; @@ -308,6 +311,9 @@ read_socket6(struct uloop_fd *u, unsigned int events) } } + if (!inp) + return; + if (debug > 1) { char buf[256]; -- 2.30.2