From: Petr Štetiar <ynezz@true.cz>
Date: Tue, 13 Oct 2020 13:26:01 +0000 (+0200)
Subject: interface: fix possible null pointer dereference
X-Git-Url: http://git.openwrt.org/project/luci.git;master?a=commitdiff_plain;h=cdc18fbb3ea8b5da866e049251d8bad79e4fbd04;p=project%2Fmdnsd.git

interface: fix possible null pointer dereference

Fixes following issue reported by clang-12 static analyzer:

 mdnsd/interface.c:250:6: warning: Access to field 'ipi_ifindex' results in a dereference of a null pointer (loaded from variable 'inp')
         if (inp->ipi_ifindex != iface->ifindex)
             ^~~~~~~~~~~~~~~~

 mdnsd/interface.c:323:6: warning: Access to field 'ipi6_ifindex' results in a dereference of a null pointer (loaded from variable 'inp')
         if (inp->ipi6_ifindex != iface->ifindex)
             ^~~~~~~~~~~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/interface.c b/interface.c
index 690e857..5fb9bad 100644
--- a/interface.c
+++ b/interface.c
@@ -233,6 +233,9 @@ read_socket4(struct uloop_fd *u, unsigned int events)
 		}
 	}
 
+	if (!inp)
+		return;
+
 	if (debug > 1) {
 		char buf[256];
 
@@ -308,6 +311,9 @@ read_socket6(struct uloop_fd *u, unsigned int events)
 		}
 	}
 
+	if (!inp)
+		return;
+
 	if (debug > 1) {
 		char buf[256];