kernel: ksmbd: only v2 leases handle the directory
authorChen Minqiang <ptpt52@gmail.com>
Tue, 16 Jan 2024 09:20:04 +0000 (17:20 +0800)
committerHauke Mehrtens <hauke@hauke-m.de>
Wed, 17 Jan 2024 20:42:31 +0000 (21:42 +0100)
This backport a fix for ksmbd.

Refer: https://github.com/namjaejeon/ksmbd/issues/469

Signed-off-by: Chen Minqiang <ptpt52@gmail.com>
target/linux/generic/pending-5.15/540-ksmbd-only-v2-leases-handle-the-directory.patch [new file with mode: 0644]
target/linux/generic/pending-6.1/540-ksmbd-only-v2-leases-handle-the-directory.patch [new file with mode: 0644]

diff --git a/target/linux/generic/pending-5.15/540-ksmbd-only-v2-leases-handle-the-directory.patch b/target/linux/generic/pending-5.15/540-ksmbd-only-v2-leases-handle-the-directory.patch
new file mode 100644 (file)
index 0000000..1bc0e72
--- /dev/null
@@ -0,0 +1,32 @@
+From cb1d41b99e4afa062f904339666fae2578559718 Mon Sep 17 00:00:00 2001
+From: Namjae Jeon <linkinjeon@kernel.org>
+Date: Mon, 15 Jan 2024 10:24:54 +0900
+Subject: [PATCH] ksmbd: only v2 leases handle the directory
+
+When smb2 leases is disable, ksmbd can send oplock break notification
+and cause wait oplock break ack timeout. It may appear like hang when
+accessing a directory. This patch make only v2 leases handle the
+directory.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
+Signed-off-by: Steve French <stfrench@microsoft.com>
+---
+ fs/ksmbd/oplock.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- a/fs/ksmbd/oplock.c
++++ b/fs/ksmbd/oplock.c
+@@ -1191,6 +1191,12 @@ int smb_grant_oplock(struct ksmbd_work *
+       bool prev_op_has_lease;
+       __le32 prev_op_state = 0;
++      /* Only v2 leases handle the directory */
++      if (S_ISDIR(file_inode(fp->filp)->i_mode)) {
++              if (!lctx || lctx->version != 2)
++                      return 0;
++      }
++
+       opinfo = alloc_opinfo(work, pid, tid);
+       if (!opinfo)
+               return -ENOMEM;
diff --git a/target/linux/generic/pending-6.1/540-ksmbd-only-v2-leases-handle-the-directory.patch b/target/linux/generic/pending-6.1/540-ksmbd-only-v2-leases-handle-the-directory.patch
new file mode 100644 (file)
index 0000000..b565fbd
--- /dev/null
@@ -0,0 +1,32 @@
+From 86b7307af26834415e1ba8597319a8b64846346f Mon Sep 17 00:00:00 2001
+From: Namjae Jeon <linkinjeon@kernel.org>
+Date: Mon, 15 Jan 2024 10:24:54 +0900
+Subject: [PATCH] ksmbd: only v2 leases handle the directory
+
+When smb2 leases is disable, ksmbd can send oplock break notification
+and cause wait oplock break ack timeout. It may appear like hang when
+accessing a directory. This patch make only v2 leases handle the
+directory.
+
+Cc: stable@vger.kernel.org
+Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
+Signed-off-by: Steve French <stfrench@microsoft.com>
+---
+ fs/smb/server/oplock.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+--- a/fs/smb/server/oplock.c
++++ b/fs/smb/server/oplock.c
+@@ -1191,6 +1191,12 @@ int smb_grant_oplock(struct ksmbd_work *
+       bool prev_op_has_lease;
+       __le32 prev_op_state = 0;
++      /* Only v2 leases handle the directory */
++      if (S_ISDIR(file_inode(fp->filp)->i_mode)) {
++              if (!lctx || lctx->version != 2)
++                      return 0;
++      }
++
+       opinfo = alloc_opinfo(work, pid, tid);
+       if (!opinfo)
+               return -ENOMEM;