bridge: memset bst->config by default to avoid stale config values
[project/netifd.git] / bridge.c
1 /*
2 * netifd - network interface daemon
3 * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
4 *
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 2
7 * as published by the Free Software Foundation
8 *
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 */
14 #include <string.h>
15 #include <stdlib.h>
16 #include <stdio.h>
17 #include <assert.h>
18 #include <errno.h>
19
20 #include "netifd.h"
21 #include "device.h"
22 #include "interface.h"
23 #include "system.h"
24
25 enum {
26 BRIDGE_ATTR_PORTS,
27 BRIDGE_ATTR_STP,
28 BRIDGE_ATTR_FORWARD_DELAY,
29 BRIDGE_ATTR_PRIORITY,
30 BRIDGE_ATTR_IGMP_SNOOP,
31 BRIDGE_ATTR_AGEING_TIME,
32 BRIDGE_ATTR_HELLO_TIME,
33 BRIDGE_ATTR_MAX_AGE,
34 BRIDGE_ATTR_BRIDGE_EMPTY,
35 BRIDGE_ATTR_MULTICAST_QUERIER,
36 BRIDGE_ATTR_HASH_MAX,
37 BRIDGE_ATTR_ROBUSTNESS,
38 BRIDGE_ATTR_QUERY_INTERVAL,
39 BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
40 BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
41 BRIDGE_ATTR_VLAN_FILTERING,
42 BRIDGE_ATTR_HAS_VLANS,
43 __BRIDGE_ATTR_MAX
44 };
45
46 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
47 [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
48 [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
49 [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
50 [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
51 [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
52 [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
53 [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
54 [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
55 [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
56 [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
57 [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
58 [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
59 [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
60 [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
61 [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
62 [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
63 [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
64 };
65
66 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
67 [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
68 };
69
70 static const struct uci_blob_param_list bridge_attr_list = {
71 .n_params = __BRIDGE_ATTR_MAX,
72 .params = bridge_attrs,
73 .info = bridge_attr_info,
74
75 .n_next = 1,
76 .next = { &device_attr_list },
77 };
78
79 static struct device *bridge_create(const char *name, struct device_type *devtype,
80 struct blob_attr *attr);
81 static void bridge_config_init(struct device *dev);
82 static void bridge_dev_vlan_update(struct device *dev);
83 static void bridge_free(struct device *dev);
84 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
85 static enum dev_change_type
86 bridge_reload(struct device *dev, struct blob_attr *attr);
87
88 static struct device_type bridge_device_type = {
89 .name = "bridge",
90 .config_params = &bridge_attr_list,
91
92 .bridge_capability = true,
93 .name_prefix = "br",
94
95 .create = bridge_create,
96 .config_init = bridge_config_init,
97 .vlan_update = bridge_dev_vlan_update,
98 .reload = bridge_reload,
99 .free = bridge_free,
100 .dump_info = bridge_dump_info,
101 };
102
103 struct bridge_state {
104 struct device dev;
105 device_state_cb set_state;
106
107 struct blob_attr *config_data;
108 struct bridge_config config;
109 struct blob_attr *ports;
110 bool active;
111 bool force_active;
112 bool has_vlans;
113
114 struct uloop_timeout retry;
115 struct bridge_member *primary_port;
116 struct vlist_tree members;
117 int n_present;
118 int n_failed;
119 };
120
121 struct bridge_member {
122 struct vlist_node node;
123 struct bridge_state *bst;
124 struct device_user dev;
125 struct uloop_timeout check_timer;
126 uint16_t pvid;
127 bool present;
128 bool active;
129 char name[];
130 };
131
132 static void
133 bridge_reset_primary(struct bridge_state *bst)
134 {
135 struct bridge_member *bm;
136
137 if (!bst->primary_port &&
138 (bst->dev.settings.flags & DEV_OPT_MACADDR))
139 return;
140
141 bst->primary_port = NULL;
142 bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
143 vlist_for_each_element(&bst->members, bm, node) {
144 uint8_t *macaddr;
145
146 if (!bm->present)
147 continue;
148
149 bst->primary_port = bm;
150 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
151 macaddr = bm->dev.dev->settings.macaddr;
152 else
153 macaddr = bm->dev.dev->orig_settings.macaddr;
154 memcpy(bst->dev.settings.macaddr, macaddr, 6);
155 bst->dev.settings.flags |= DEV_OPT_MACADDR;
156 return;
157 }
158 }
159
160 static struct bridge_vlan_port *
161 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
162 {
163 struct bridge_vlan_hotplug_port *port;
164 const char *ifname = bm->dev.dev->ifname;
165 int i;
166
167 for (i = 0; i < vlan->n_ports; i++) {
168 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
169 continue;
170
171 return &vlan->ports[i];
172 }
173
174 list_for_each_entry(port, &vlan->hotplug_ports, list) {
175 if (strcmp(port->port.ifname, ifname) != 0)
176 continue;
177
178 return &port->port;
179 }
180
181 return NULL;
182 }
183
184 static bool
185 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
186 {
187 return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
188 (port->flags & BRVLAN_F_PVID);
189 }
190
191 static void
192 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
193 struct bridge_vlan_port *port, bool add)
194 {
195 uint16_t flags;
196
197 flags = port->flags;
198 if (bm->pvid == vlan->vid)
199 flags |= BRVLAN_F_PVID;
200
201 system_bridge_vlan(port->ifname, vlan->vid, add, flags);
202 }
203
204 static void
205 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
206 {
207 struct bridge_vlan_port *port;
208
209 if (!bm->present)
210 return;
211
212 port = bridge_find_vlan_member_port(bm, vlan);
213 if (!port)
214 return;
215
216 if (bridge_member_vlan_is_pvid(bm, port))
217 bm->pvid = vlan->vid;
218
219 __bridge_set_member_vlan(bm, vlan, port, add);
220 }
221
222 static void
223 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
224 {
225 if (!vlan->local && add)
226 return;
227
228 system_bridge_vlan(bst->dev.ifname, vlan->vid, add, BRVLAN_F_SELF);
229 }
230
231 static void
232 bridge_set_local_vlans(struct bridge_state *bst, bool add)
233 {
234 struct bridge_vlan *vlan;
235
236 vlist_for_each_element(&bst->dev.vlans, vlan, node)
237 bridge_set_local_vlan(bst, vlan, add);
238 }
239
240 static struct bridge_vlan *
241 bridge_recalc_member_pvid(struct bridge_member *bm)
242 {
243 struct bridge_state *bst = bm->bst;
244 struct bridge_vlan_port *port;
245 struct bridge_vlan *vlan, *ret = NULL;
246
247 vlist_for_each_element(&bst->dev.vlans, vlan, node) {
248 port = bridge_find_vlan_member_port(bm, vlan);
249 if (!port)
250 continue;
251
252 if (!bridge_member_vlan_is_pvid(bm, port))
253 continue;
254
255 ret = vlan;
256 if (port->flags & BRVLAN_F_PVID)
257 break;
258 }
259
260 return ret;
261 }
262
263 static void
264 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
265 {
266 struct bridge_member *bm;
267 struct bridge_vlan *vlan2;
268
269 bridge_set_local_vlan(bst, vlan, add);
270
271 vlist_for_each_element(&bst->members, bm, node) {
272 struct bridge_vlan_port *port;
273 int new_pvid = -1;
274
275 port = bridge_find_vlan_member_port(bm, vlan);
276 if (!port)
277 continue;
278
279 if (add) {
280 if (bridge_member_vlan_is_pvid(bm, port))
281 bm->pvid = vlan->vid;
282 } else if (bm->pvid == vlan->vid) {
283 vlan2 = bridge_recalc_member_pvid(bm);
284 if (vlan2 && vlan2->vid != vlan->vid) {
285 bridge_set_member_vlan(bm, vlan2, false);
286 bridge_set_member_vlan(bm, vlan2, true);
287 }
288 new_pvid = vlan2 ? vlan2->vid : 0;
289 }
290
291 if (!bm->present)
292 continue;
293
294 __bridge_set_member_vlan(bm, vlan, port, add);
295 if (new_pvid >= 0)
296 bm->pvid = new_pvid;
297 }
298 }
299
300 static int
301 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
302 {
303 struct bridge_state *bst = bm->bst;
304 struct bridge_vlan *vlan;
305
306 if (!bm->present || !bm->active)
307 return 0;
308
309 bm->active = false;
310 vlist_for_each_element(&bst->dev.vlans, vlan, node)
311 bridge_set_member_vlan(bm, vlan, false);
312
313 system_bridge_delif(&bst->dev, bm->dev.dev);
314 if (!keep_dev)
315 device_release(&bm->dev);
316
317 device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
318
319 return 0;
320 }
321
322 static int
323 bridge_enable_interface(struct bridge_state *bst)
324 {
325 int ret;
326
327 if (bst->active)
328 return 0;
329
330 ret = system_bridge_addbr(&bst->dev, &bst->config);
331 if (ret < 0)
332 return ret;
333
334 if (bst->has_vlans) {
335 /* delete default VLAN 1 */
336 system_bridge_vlan(bst->dev.ifname, 1, false, BRVLAN_F_SELF);
337
338 bridge_set_local_vlans(bst, true);
339 }
340
341 bst->active = true;
342 return 0;
343 }
344
345 static void
346 bridge_disable_interface(struct bridge_state *bst)
347 {
348 if (!bst->active)
349 return;
350
351 system_bridge_delbr(&bst->dev);
352 bst->active = false;
353 }
354
355 static int
356 bridge_enable_member(struct bridge_member *bm)
357 {
358 struct bridge_state *bst = bm->bst;
359 struct bridge_vlan *vlan;
360 struct device *dev;
361 int ret;
362
363 if (!bm->present)
364 return 0;
365
366 ret = bridge_enable_interface(bst);
367 if (ret)
368 goto error;
369
370 /* Disable IPv6 for bridge members */
371 if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
372 bm->dev.dev->settings.ipv6 = 0;
373 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
374 }
375
376 ret = device_claim(&bm->dev);
377 if (ret < 0)
378 goto error;
379
380 dev = bm->dev.dev;
381 if (dev->settings.auth && !dev->auth_status)
382 return -1;
383
384 if (bm->active)
385 return 0;
386
387 ret = system_bridge_addif(&bst->dev, bm->dev.dev);
388 if (ret < 0) {
389 D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
390 goto error;
391 }
392
393 bm->active = true;
394 if (bst->has_vlans) {
395 /* delete default VLAN 1 */
396 system_bridge_vlan(bm->dev.dev->ifname, 1, false, 0);
397
398 vlist_for_each_element(&bst->dev.vlans, vlan, node)
399 bridge_set_member_vlan(bm, vlan, true);
400 }
401
402 device_set_present(&bst->dev, true);
403 device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
404
405 return 0;
406
407 error:
408 bst->n_failed++;
409 bm->present = false;
410 bst->n_present--;
411 device_release(&bm->dev);
412
413 return ret;
414 }
415
416 static void
417 bridge_remove_member(struct bridge_member *bm)
418 {
419 struct bridge_state *bst = bm->bst;
420
421 if (!bm->present)
422 return;
423
424 if (bst->dev.active)
425 bridge_disable_member(bm, false);
426
427 bm->present = false;
428 bm->bst->n_present--;
429
430 if (bm == bst->primary_port)
431 bridge_reset_primary(bst);
432
433 if (bst->config.bridge_empty)
434 return;
435
436 bst->force_active = false;
437 if (bst->n_present == 0)
438 device_set_present(&bst->dev, false);
439 }
440
441 static void
442 bridge_free_member(struct bridge_member *bm)
443 {
444 struct bridge_state *bst = bm->bst;
445 struct device *dev = bm->dev.dev;
446 const char *ifname = dev->ifname;
447 struct bridge_vlan *vlan;
448
449 bridge_remove_member(bm);
450
451 restart:
452 vlist_for_each_element(&bst->dev.vlans, vlan, node) {
453 struct bridge_vlan_hotplug_port *port, *tmp;
454 bool free_port = false;
455
456 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
457 if (strcmp(port->port.ifname, ifname) != 0)
458 continue;
459
460 list_del(&port->list);
461 free(port);
462 free_port = true;
463 }
464
465 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
466 vlan->n_ports || vlan->node.version != -1)
467 continue;
468
469 vlist_delete(&bst->dev.vlans, &vlan->node);
470 goto restart;
471 }
472
473 device_lock();
474
475 device_remove_user(&bm->dev);
476 uloop_timeout_cancel(&bm->check_timer);
477
478 /*
479 * When reloading the config and moving a device from one bridge to
480 * another, the other bridge may have tried to claim this device
481 * before it was removed here.
482 * Ensure that claiming the device is retried by toggling its present
483 * state
484 */
485 if (dev->present) {
486 device_set_present(dev, false);
487 device_set_present(dev, true);
488 }
489
490 device_unlock();
491
492 free(bm);
493 }
494
495 static void
496 bridge_check_retry(struct bridge_state *bst)
497 {
498 if (!bst->n_failed)
499 return;
500
501 uloop_timeout_set(&bst->retry, 100);
502 }
503
504 static void
505 bridge_member_check_cb(struct uloop_timeout *t)
506 {
507 struct bridge_member *bm;
508 struct bridge_state *bst;
509
510 bm = container_of(t, struct bridge_member, check_timer);
511 bst = bm->bst;
512
513 if (system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname) <= 0)
514 return;
515
516 bridge_disable_member(bm, true);
517 bridge_enable_member(bm);
518 }
519
520 static void
521 bridge_member_cb(struct device_user *dep, enum device_event ev)
522 {
523 struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
524 struct bridge_state *bst = bm->bst;
525 struct device *dev = dep->dev;
526
527 switch (ev) {
528 case DEV_EVENT_ADD:
529 assert(!bm->present);
530
531 bm->present = true;
532 bst->n_present++;
533
534 if (bst->n_present == 1)
535 device_set_present(&bst->dev, true);
536 fallthrough;
537 case DEV_EVENT_AUTH_UP:
538 if (!bst->dev.active)
539 break;
540
541 if (bridge_enable_member(bm))
542 break;
543
544 /*
545 * Adding a bridge member can overwrite the bridge mtu
546 * in the kernel, apply the bridge settings in case the
547 * bridge mtu is set
548 */
549 system_if_apply_settings(&bst->dev, &bst->dev.settings,
550 DEV_OPT_MTU | DEV_OPT_MTU6);
551 break;
552 case DEV_EVENT_LINK_UP:
553 if (bst->has_vlans)
554 uloop_timeout_set(&bm->check_timer, 1000);
555 break;
556 case DEV_EVENT_LINK_DOWN:
557 if (!dev->settings.auth)
558 break;
559
560 bridge_disable_member(bm, true);
561 break;
562 case DEV_EVENT_REMOVE:
563 if (dep->hotplug) {
564 vlist_delete(&bst->members, &bm->node);
565 return;
566 }
567
568 if (bm->present)
569 bridge_remove_member(bm);
570
571 break;
572 default:
573 return;
574 }
575 }
576
577 static int
578 bridge_set_down(struct bridge_state *bst)
579 {
580 struct bridge_member *bm;
581
582 bst->set_state(&bst->dev, false);
583
584 vlist_for_each_element(&bst->members, bm, node)
585 bridge_disable_member(bm, false);
586
587 bridge_disable_interface(bst);
588
589 return 0;
590 }
591
592 static int
593 bridge_set_up(struct bridge_state *bst)
594 {
595 struct bridge_member *bm;
596 int ret;
597
598 bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
599 if (!bst->n_present) {
600 if (!bst->force_active)
601 return -ENOENT;
602
603 ret = bridge_enable_interface(bst);
604 if (ret)
605 return ret;
606 }
607
608 bst->n_failed = 0;
609 vlist_for_each_element(&bst->members, bm, node)
610 bridge_enable_member(bm);
611 bridge_check_retry(bst);
612
613 if (!bst->force_active && !bst->n_present) {
614 /* initialization of all member interfaces failed */
615 bridge_disable_interface(bst);
616 device_set_present(&bst->dev, false);
617 return -ENOENT;
618 }
619
620 bridge_reset_primary(bst);
621 ret = bst->set_state(&bst->dev, true);
622 if (ret < 0)
623 bridge_set_down(bst);
624
625 return ret;
626 }
627
628 static int
629 bridge_set_state(struct device *dev, bool up)
630 {
631 struct bridge_state *bst;
632
633 bst = container_of(dev, struct bridge_state, dev);
634
635 if (up)
636 return bridge_set_up(bst);
637 else
638 return bridge_set_down(bst);
639 }
640
641 static struct bridge_member *
642 bridge_create_member(struct bridge_state *bst, const char *name,
643 struct device *dev, bool hotplug)
644 {
645 struct bridge_member *bm;
646
647 bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
648 if (!bm)
649 return NULL;
650
651 bm->bst = bst;
652 bm->dev.cb = bridge_member_cb;
653 bm->dev.hotplug = hotplug;
654 bm->check_timer.cb = bridge_member_check_cb;
655 strcpy(bm->name, name);
656 bm->dev.dev = dev;
657 vlist_add(&bst->members, &bm->node, bm->name);
658 /*
659 * Need to look up the bridge member again as the above
660 * created pointer will be freed in case the bridge member
661 * already existed
662 */
663 bm = vlist_find(&bst->members, name, bm, node);
664 if (hotplug && bm)
665 bm->node.version = -1;
666
667 return bm;
668 }
669
670 static void
671 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
672 struct vlist_node *node_old)
673 {
674 struct bridge_member *bm;
675 struct device *dev;
676
677 if (node_new) {
678 bm = container_of(node_new, struct bridge_member, node);
679
680 if (node_old) {
681 free(bm);
682 return;
683 }
684
685 dev = bm->dev.dev;
686 bm->dev.dev = NULL;
687 device_add_user(&bm->dev, dev);
688 }
689
690
691 if (node_old) {
692 bm = container_of(node_old, struct bridge_member, node);
693 bridge_free_member(bm);
694 }
695 }
696
697
698 static void
699 bridge_add_member(struct bridge_state *bst, const char *name)
700 {
701 struct device *dev;
702
703 dev = device_get(name, true);
704 if (!dev)
705 return;
706
707 bridge_create_member(bst, name, dev, false);
708 }
709
710 static struct bridge_vlan *
711 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid)
712 {
713 struct bridge_vlan *vlan;
714
715 vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
716 if (vlan)
717 return vlan;
718
719 vlan = calloc(1, sizeof(*vlan));
720 vlan->vid = vid;
721 vlan->local = true;
722 INIT_LIST_HEAD(&vlan->hotplug_ports);
723 vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
724 vlan->node.version = -1;
725
726 return vlan;
727 }
728
729 static struct bridge_vlan_hotplug_port *
730 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
731 {
732 struct bridge_vlan_hotplug_port *port;
733
734 list_for_each_entry(port, &vlan->hotplug_ports, list)
735 if (!strcmp(port->port.ifname, ifname))
736 return port;
737
738 return NULL;
739 }
740
741 static void
742 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
743 const char *ifname, struct bridge_member *bm, bool add)
744 {
745 struct bridge_vlan *vlan;
746 struct blob_attr *cur;
747 int rem;
748
749 if (!vlans)
750 return;
751
752 blobmsg_for_each_attr(cur, vlans, rem) {
753 struct bridge_vlan_hotplug_port *port;
754 uint16_t flags = BRVLAN_F_UNTAGGED;
755 char *name_buf;
756 unsigned int vid;
757 char *end;
758
759 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
760 continue;
761
762 vid = strtoul(blobmsg_get_string(cur), &end, 0);
763 if (!vid || vid > 4095)
764 continue;
765
766 vlan = bridge_hotplug_get_vlan(bst, vid);
767 if (!vlan)
768 continue;
769
770 if (vlan->pending) {
771 vlan->pending = false;
772 bridge_set_vlan_state(bst, vlan, true);
773 }
774
775 if (end && *end) {
776 if (*end != ':')
777 continue;
778
779 for (end++; *end; end++) {
780 switch (*end) {
781 case 't':
782 flags &= ~BRVLAN_F_UNTAGGED;
783 break;
784 case '*':
785 flags |= BRVLAN_F_PVID;
786 break;
787 }
788 }
789 }
790
791 port = bridge_hotplug_get_vlan_port(vlan, ifname);
792 if (!add) {
793 if (!port)
794 continue;
795
796 __bridge_set_member_vlan(bm, vlan, &port->port, false);
797 list_del(&port->list);
798 free(port);
799 continue;
800 }
801
802 if (port) {
803 if (port->port.flags == flags)
804 continue;
805
806 __bridge_set_member_vlan(bm, vlan, &port->port, false);
807 port->port.flags = flags;
808 __bridge_set_member_vlan(bm, vlan, &port->port, true);
809 continue;
810 }
811
812 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
813 if (!port)
814 continue;
815
816 port->port.flags = flags;
817 port->port.ifname = strcpy(name_buf, ifname);
818 list_add_tail(&port->list, &vlan->hotplug_ports);
819
820 if (!bm)
821 continue;
822
823 __bridge_set_member_vlan(bm, vlan, &port->port, true);
824 }
825 }
826
827 static int
828 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
829 {
830 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
831 struct bridge_member *bm;
832
833 bm = vlist_find(&bst->members, member->ifname, bm, node);
834 bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, true);
835 if (!bm)
836 bridge_create_member(bst, member->ifname, member, true);
837
838 return 0;
839 }
840
841 static int
842 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
843 {
844 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
845 struct bridge_member *bm;
846
847 bm = vlist_find(&bst->members, member->ifname, bm, node);
848 if (!bm)
849 return UBUS_STATUS_NOT_FOUND;
850
851 bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, false);
852 if (!bm->dev.hotplug)
853 return 0;
854
855 vlist_delete(&bst->members, &bm->node);
856 return 0;
857 }
858
859 static int
860 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
861 {
862 struct bridge_state *bst;
863
864 if (bridge_dev)
865 *bridge_dev = dev;
866
867 bst = container_of(dev, struct bridge_state, dev);
868 bst->force_active = true;
869 device_set_present(&bst->dev, true);
870
871 return 0;
872 }
873
874 static const struct device_hotplug_ops bridge_ops = {
875 .prepare = bridge_hotplug_prepare,
876 .add = bridge_hotplug_add,
877 .del = bridge_hotplug_del
878 };
879
880 static void
881 bridge_free(struct device *dev)
882 {
883 struct bridge_state *bst;
884
885 bst = container_of(dev, struct bridge_state, dev);
886 vlist_flush_all(&bst->members);
887 vlist_flush_all(&dev->vlans);
888 kvlist_free(&dev->vlan_aliases);
889 free(bst->config_data);
890 free(bst);
891 }
892
893 static void
894 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
895 {
896 bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
897 bool pvid = (port->flags & BRVLAN_F_PVID);
898
899 blobmsg_printf(b, "%s%s%s%s\n", port->ifname,
900 tagged || pvid ? ":" : "",
901 tagged ? "t" : "",
902 pvid ? "*" : "");
903 }
904
905 static void
906 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
907 {
908 struct bridge_vlan_hotplug_port *port;
909 void *c, *p;
910 int i;
911
912 c = blobmsg_open_table(b, NULL);
913
914 blobmsg_add_u32(b, "id", vlan->vid);
915 blobmsg_add_u8(b, "local", vlan->local);
916
917 p = blobmsg_open_array(b, "ports");
918
919 for (i = 0; i < vlan->n_ports; i++)
920 bridge_dump_port(b, &vlan->ports[i]);
921
922 list_for_each_entry(port, &vlan->hotplug_ports, list)
923 bridge_dump_port(b, &port->port);
924
925 blobmsg_close_array(b, p);
926
927 blobmsg_close_table(b, c);
928 }
929
930 static void
931 bridge_dump_info(struct device *dev, struct blob_buf *b)
932 {
933 struct bridge_state *bst;
934 struct bridge_member *bm;
935 struct bridge_vlan *vlan;
936 void *list;
937
938 bst = container_of(dev, struct bridge_state, dev);
939
940 system_if_dump_info(dev, b);
941 list = blobmsg_open_array(b, "bridge-members");
942
943 vlist_for_each_element(&bst->members, bm, node) {
944 if (bm->dev.dev->hidden)
945 continue;
946
947 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
948 }
949
950 blobmsg_close_array(b, list);
951
952 if (avl_is_empty(&dev->vlans.avl))
953 return;
954
955 list = blobmsg_open_array(b, "bridge-vlans");
956
957 vlist_for_each_element(&bst->dev.vlans, vlan, node)
958 bridge_dump_vlan(b, vlan);
959
960 blobmsg_close_array(b, list);
961 }
962
963 static void
964 bridge_config_init(struct device *dev)
965 {
966 struct bridge_state *bst;
967 struct bridge_vlan *vlan;
968 struct blob_attr *cur;
969 int i, rem;
970
971 bst = container_of(dev, struct bridge_state, dev);
972
973 if (bst->config.bridge_empty) {
974 bst->force_active = true;
975 device_set_present(&bst->dev, true);
976 }
977
978 bst->n_failed = 0;
979 vlist_update(&bst->members);
980 if (bst->ports) {
981 blobmsg_for_each_attr(cur, bst->ports, rem) {
982 bridge_add_member(bst, blobmsg_data(cur));
983 }
984 }
985
986 vlist_for_each_element(&bst->dev.vlans, vlan, node)
987 for (i = 0; i < vlan->n_ports; i++)
988 bridge_add_member(bst, vlan->ports[i].ifname);
989
990 vlist_flush(&bst->members);
991 bridge_check_retry(bst);
992 }
993
994 static void
995 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
996 {
997 struct bridge_config *cfg = &bst->config;
998 struct blob_attr *cur;
999
1000 /* defaults */
1001 memset(cfg, 0, sizeof(*cfg));
1002 cfg->stp = false;
1003 cfg->forward_delay = 2;
1004 cfg->robustness = 2;
1005 cfg->igmp_snoop = false;
1006 cfg->multicast_querier = false;
1007 cfg->query_interval = 12500;
1008 cfg->query_response_interval = 1000;
1009 cfg->last_member_interval = 100;
1010 cfg->hash_max = 512;
1011 cfg->bridge_empty = false;
1012 cfg->priority = 0x7FFF;
1013 cfg->vlan_filtering = false;
1014
1015 if ((cur = tb[BRIDGE_ATTR_STP]))
1016 cfg->stp = blobmsg_get_bool(cur);
1017
1018 if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1019 cfg->forward_delay = blobmsg_get_u32(cur);
1020
1021 if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1022 cfg->priority = blobmsg_get_u32(cur);
1023
1024 if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1025 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1026
1027 if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1028 cfg->multicast_querier = blobmsg_get_bool(cur);
1029
1030 if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1031 cfg->hash_max = blobmsg_get_u32(cur);
1032
1033 if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1034 cfg->robustness = blobmsg_get_u32(cur);
1035 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1036 }
1037
1038 if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1039 cfg->query_interval = blobmsg_get_u32(cur);
1040 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1041 }
1042
1043 if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1044 cfg->query_response_interval = blobmsg_get_u32(cur);
1045 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1046 }
1047
1048 if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1049 cfg->last_member_interval = blobmsg_get_u32(cur);
1050 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1051 }
1052
1053 if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1054 cfg->ageing_time = blobmsg_get_u32(cur);
1055 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1056 }
1057
1058 if ((cur = tb[BRIDGE_ATTR_HELLO_TIME])) {
1059 cfg->hello_time = blobmsg_get_u32(cur);
1060 cfg->flags |= BRIDGE_OPT_HELLO_TIME;
1061 }
1062
1063 if ((cur = tb[BRIDGE_ATTR_MAX_AGE])) {
1064 cfg->max_age = blobmsg_get_u32(cur);
1065 cfg->flags |= BRIDGE_OPT_MAX_AGE;
1066 }
1067
1068 if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1069 cfg->bridge_empty = blobmsg_get_bool(cur);
1070
1071 if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1072 cfg->vlan_filtering = blobmsg_get_bool(cur);
1073 }
1074
1075 static enum dev_change_type
1076 bridge_reload(struct device *dev, struct blob_attr *attr)
1077 {
1078 struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1079 struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1080 enum dev_change_type ret = DEV_CONFIG_APPLIED;
1081 unsigned long diff;
1082 struct bridge_state *bst;
1083
1084 BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / 8);
1085 BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / 8);
1086
1087 bst = container_of(dev, struct bridge_state, dev);
1088 attr = blob_memdup(attr);
1089
1090 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1091 blob_data(attr), blob_len(attr));
1092 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1093 blob_data(attr), blob_len(attr));
1094
1095 if (tb_dev[DEV_ATTR_MACADDR])
1096 bst->primary_port = NULL;
1097
1098 bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1099 device_init_settings(dev, tb_dev);
1100 bridge_apply_settings(bst, tb_br);
1101
1102 if (bst->config_data) {
1103 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1104 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1105
1106 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1107 blob_data(bst->config_data), blob_len(bst->config_data));
1108
1109 diff = 0;
1110 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, &diff);
1111 if (diff)
1112 ret = DEV_CONFIG_RESTART;
1113
1114 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1115 blob_data(bst->config_data), blob_len(bst->config_data));
1116
1117 diff = 0;
1118 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, &diff);
1119 if (diff & ~(1 << BRIDGE_ATTR_PORTS))
1120 ret = DEV_CONFIG_RESTART;
1121
1122 bridge_config_init(dev);
1123 }
1124
1125 free(bst->config_data);
1126 bst->config_data = attr;
1127 return ret;
1128 }
1129
1130 static void
1131 bridge_retry_members(struct uloop_timeout *timeout)
1132 {
1133 struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1134 struct bridge_member *bm;
1135
1136 bst->n_failed = 0;
1137 vlist_for_each_element(&bst->members, bm, node) {
1138 if (bm->present)
1139 continue;
1140
1141 if (!bm->dev.dev->present)
1142 continue;
1143
1144 bm->present = true;
1145 bst->n_present++;
1146 bridge_enable_member(bm);
1147 }
1148 }
1149
1150 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1151 {
1152 const uint16_t *i1 = k1, *i2 = k2;
1153
1154 return *i1 - *i2;
1155 }
1156
1157 static bool
1158 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1159 {
1160 int i;
1161
1162 if (v1->n_ports != v2->n_ports)
1163 return false;
1164
1165 for (i = 0; i < v1->n_ports; i++)
1166 if (v1->ports[i].flags != v2->ports[i].flags ||
1167 strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1168 return false;
1169
1170 return true;
1171 }
1172
1173 static void
1174 bridge_vlan_free(struct bridge_vlan *vlan)
1175 {
1176 struct bridge_vlan_hotplug_port *port, *tmp;
1177
1178 if (!vlan)
1179 return;
1180
1181 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1182 free(port);
1183
1184 free(vlan);
1185 }
1186
1187 static void
1188 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1189 struct vlist_node *node_old)
1190 {
1191 struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1192 struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1193
1194 if (!bst->has_vlans || !bst->active)
1195 goto out;
1196
1197 if (node_old)
1198 vlan_old = container_of(node_old, struct bridge_vlan, node);
1199 if (node_new)
1200 vlan_new = container_of(node_new, struct bridge_vlan, node);
1201
1202 if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1203 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1204 goto out;
1205 }
1206
1207 if (node_old)
1208 bridge_set_vlan_state(bst, vlan_old, false);
1209
1210 if (node_old && node_new)
1211 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1212
1213 if (node_new)
1214 vlan_new->pending = true;
1215
1216 bst->dev.config_pending = true;
1217
1218 out:
1219 bridge_vlan_free(vlan_old);
1220 }
1221
1222 static void
1223 bridge_dev_vlan_update(struct device *dev)
1224 {
1225 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1226 struct bridge_vlan *vlan;
1227
1228 vlist_for_each_element(&dev->vlans, vlan, node) {
1229 if (!vlan->pending)
1230 continue;
1231
1232 vlan->pending = false;
1233 bridge_set_vlan_state(bst, vlan, true);
1234 }
1235 }
1236
1237 static struct device *
1238 bridge_create(const char *name, struct device_type *devtype,
1239 struct blob_attr *attr)
1240 {
1241 struct bridge_state *bst;
1242 struct device *dev = NULL;
1243
1244 bst = calloc(1, sizeof(*bst));
1245 if (!bst)
1246 return NULL;
1247
1248 dev = &bst->dev;
1249
1250 if (device_init(dev, devtype, name) < 0) {
1251 device_cleanup(dev);
1252 free(bst);
1253 return NULL;
1254 }
1255
1256 dev->config_pending = true;
1257 bst->retry.cb = bridge_retry_members;
1258
1259 bst->set_state = dev->set_state;
1260 dev->set_state = bridge_set_state;
1261
1262 dev->hotplug_ops = &bridge_ops;
1263
1264 vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1265 bst->members.keep_old = true;
1266
1267 vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1268
1269 bridge_reload(dev, attr);
1270
1271 return dev;
1272 }
1273
1274 static void __init bridge_device_type_init(void)
1275 {
1276 device_type_add(&bridge_device_type);
1277 }