bridge: check bridge port vlan membership on link-up events
[project/netifd.git] / bridge.c
1 /*
2 * netifd - network interface daemon
3 * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
4 *
5 * This program is free software; you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 2
7 * as published by the Free Software Foundation
8 *
9 * This program is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details.
13 */
14 #include <string.h>
15 #include <stdlib.h>
16 #include <stdio.h>
17 #include <assert.h>
18 #include <errno.h>
19
20 #include "netifd.h"
21 #include "device.h"
22 #include "interface.h"
23 #include "system.h"
24
25 enum {
26 BRIDGE_ATTR_PORTS,
27 BRIDGE_ATTR_STP,
28 BRIDGE_ATTR_FORWARD_DELAY,
29 BRIDGE_ATTR_PRIORITY,
30 BRIDGE_ATTR_IGMP_SNOOP,
31 BRIDGE_ATTR_AGEING_TIME,
32 BRIDGE_ATTR_HELLO_TIME,
33 BRIDGE_ATTR_MAX_AGE,
34 BRIDGE_ATTR_BRIDGE_EMPTY,
35 BRIDGE_ATTR_MULTICAST_QUERIER,
36 BRIDGE_ATTR_HASH_MAX,
37 BRIDGE_ATTR_ROBUSTNESS,
38 BRIDGE_ATTR_QUERY_INTERVAL,
39 BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
40 BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
41 BRIDGE_ATTR_VLAN_FILTERING,
42 BRIDGE_ATTR_HAS_VLANS,
43 __BRIDGE_ATTR_MAX
44 };
45
46 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
47 [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
48 [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
49 [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
50 [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
51 [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
52 [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
53 [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
54 [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
55 [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
56 [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
57 [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
58 [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
59 [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
60 [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
61 [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
62 [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
63 [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
64 };
65
66 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
67 [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
68 };
69
70 static const struct uci_blob_param_list bridge_attr_list = {
71 .n_params = __BRIDGE_ATTR_MAX,
72 .params = bridge_attrs,
73 .info = bridge_attr_info,
74
75 .n_next = 1,
76 .next = { &device_attr_list },
77 };
78
79 static struct device *bridge_create(const char *name, struct device_type *devtype,
80 struct blob_attr *attr);
81 static void bridge_config_init(struct device *dev);
82 static void bridge_dev_vlan_update(struct device *dev);
83 static void bridge_free(struct device *dev);
84 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
85 static enum dev_change_type
86 bridge_reload(struct device *dev, struct blob_attr *attr);
87
88 static struct device_type bridge_device_type = {
89 .name = "bridge",
90 .config_params = &bridge_attr_list,
91
92 .bridge_capability = true,
93 .name_prefix = "br",
94
95 .create = bridge_create,
96 .config_init = bridge_config_init,
97 .vlan_update = bridge_dev_vlan_update,
98 .reload = bridge_reload,
99 .free = bridge_free,
100 .dump_info = bridge_dump_info,
101 };
102
103 struct bridge_state {
104 struct device dev;
105 device_state_cb set_state;
106
107 struct blob_attr *config_data;
108 struct bridge_config config;
109 struct blob_attr *ports;
110 bool active;
111 bool force_active;
112 bool has_vlans;
113
114 struct uloop_timeout retry;
115 struct bridge_member *primary_port;
116 struct vlist_tree members;
117 int n_present;
118 int n_failed;
119 };
120
121 struct bridge_member {
122 struct vlist_node node;
123 struct bridge_state *bst;
124 struct device_user dev;
125 struct uloop_timeout check_timer;
126 uint16_t pvid;
127 bool present;
128 bool active;
129 char name[];
130 };
131
132 static void
133 bridge_reset_primary(struct bridge_state *bst)
134 {
135 struct bridge_member *bm;
136
137 if (!bst->primary_port &&
138 (bst->dev.settings.flags & DEV_OPT_MACADDR))
139 return;
140
141 bst->primary_port = NULL;
142 bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
143 vlist_for_each_element(&bst->members, bm, node) {
144 uint8_t *macaddr;
145
146 if (!bm->present)
147 continue;
148
149 bst->primary_port = bm;
150 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
151 macaddr = bm->dev.dev->settings.macaddr;
152 else
153 macaddr = bm->dev.dev->orig_settings.macaddr;
154 memcpy(bst->dev.settings.macaddr, macaddr, 6);
155 bst->dev.settings.flags |= DEV_OPT_MACADDR;
156 return;
157 }
158 }
159
160 static struct bridge_vlan_port *
161 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
162 {
163 struct bridge_vlan_hotplug_port *port;
164 const char *ifname = bm->dev.dev->ifname;
165 int i;
166
167 for (i = 0; i < vlan->n_ports; i++) {
168 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
169 continue;
170
171 return &vlan->ports[i];
172 }
173
174 list_for_each_entry(port, &vlan->hotplug_ports, list) {
175 if (strcmp(port->port.ifname, ifname) != 0)
176 continue;
177
178 return &port->port;
179 }
180
181 return NULL;
182 }
183
184 static bool
185 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
186 {
187 return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
188 (port->flags & BRVLAN_F_PVID);
189 }
190
191 static void
192 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
193 struct bridge_vlan_port *port, bool add)
194 {
195 uint16_t flags;
196
197 flags = port->flags;
198 if (bm->pvid == vlan->vid)
199 flags |= BRVLAN_F_PVID;
200
201 system_bridge_vlan(port->ifname, vlan->vid, add, flags);
202 }
203
204 static void
205 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
206 {
207 struct bridge_vlan_port *port;
208
209 if (!bm->present)
210 return;
211
212 port = bridge_find_vlan_member_port(bm, vlan);
213 if (!port)
214 return;
215
216 if (bridge_member_vlan_is_pvid(bm, port))
217 bm->pvid = vlan->vid;
218
219 __bridge_set_member_vlan(bm, vlan, port, add);
220 }
221
222 static void
223 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
224 {
225 if (!vlan->local && add)
226 return;
227
228 system_bridge_vlan(bst->dev.ifname, vlan->vid, add, BRVLAN_F_SELF);
229 }
230
231 static void
232 bridge_set_local_vlans(struct bridge_state *bst, bool add)
233 {
234 struct bridge_vlan *vlan;
235
236 vlist_for_each_element(&bst->dev.vlans, vlan, node)
237 bridge_set_local_vlan(bst, vlan, add);
238 }
239
240 static struct bridge_vlan *
241 bridge_recalc_member_pvid(struct bridge_member *bm)
242 {
243 struct bridge_state *bst = bm->bst;
244 struct bridge_vlan_port *port;
245 struct bridge_vlan *vlan, *ret = NULL;
246
247 vlist_for_each_element(&bst->dev.vlans, vlan, node) {
248 port = bridge_find_vlan_member_port(bm, vlan);
249 if (!port)
250 continue;
251
252 if (!bridge_member_vlan_is_pvid(bm, port))
253 continue;
254
255 ret = vlan;
256 if (port->flags & BRVLAN_F_PVID)
257 break;
258 }
259
260 return ret;
261 }
262
263 static void
264 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
265 {
266 struct bridge_member *bm;
267 struct bridge_vlan *vlan2;
268
269 bridge_set_local_vlan(bst, vlan, add);
270
271 vlist_for_each_element(&bst->members, bm, node) {
272 struct bridge_vlan_port *port;
273 int new_pvid = -1;
274
275 port = bridge_find_vlan_member_port(bm, vlan);
276 if (!port)
277 continue;
278
279 if (add) {
280 if (bridge_member_vlan_is_pvid(bm, port))
281 bm->pvid = vlan->vid;
282 } else if (bm->pvid == vlan->vid) {
283 vlan2 = bridge_recalc_member_pvid(bm);
284 if (vlan2 && vlan2->vid != vlan->vid) {
285 bridge_set_member_vlan(bm, vlan2, false);
286 bridge_set_member_vlan(bm, vlan2, true);
287 }
288 new_pvid = vlan2 ? vlan2->vid : 0;
289 }
290
291 if (!bm->present)
292 continue;
293
294 __bridge_set_member_vlan(bm, vlan, port, add);
295 if (new_pvid >= 0)
296 bm->pvid = new_pvid;
297 }
298 }
299
300 static int
301 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
302 {
303 struct bridge_state *bst = bm->bst;
304 struct bridge_vlan *vlan;
305
306 if (!bm->present || !bm->active)
307 return 0;
308
309 bm->active = false;
310 vlist_for_each_element(&bst->dev.vlans, vlan, node)
311 bridge_set_member_vlan(bm, vlan, false);
312
313 system_bridge_delif(&bst->dev, bm->dev.dev);
314 if (!keep_dev)
315 device_release(&bm->dev);
316
317 device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
318
319 return 0;
320 }
321
322 static int
323 bridge_enable_interface(struct bridge_state *bst)
324 {
325 int ret;
326
327 if (bst->active)
328 return 0;
329
330 ret = system_bridge_addbr(&bst->dev, &bst->config);
331 if (ret < 0)
332 return ret;
333
334 if (bst->has_vlans) {
335 /* delete default VLAN 1 */
336 system_bridge_vlan(bst->dev.ifname, 1, false, BRVLAN_F_SELF);
337
338 bridge_set_local_vlans(bst, true);
339 }
340
341 bst->active = true;
342 return 0;
343 }
344
345 static void
346 bridge_disable_interface(struct bridge_state *bst)
347 {
348 if (!bst->active)
349 return;
350
351 system_bridge_delbr(&bst->dev);
352 bst->active = false;
353 }
354
355 static int
356 bridge_enable_member(struct bridge_member *bm)
357 {
358 struct bridge_state *bst = bm->bst;
359 struct bridge_vlan *vlan;
360 struct device *dev;
361 int ret;
362
363 if (!bm->present)
364 return 0;
365
366 ret = bridge_enable_interface(bst);
367 if (ret)
368 goto error;
369
370 /* Disable IPv6 for bridge members */
371 if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
372 bm->dev.dev->settings.ipv6 = 0;
373 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
374 }
375
376 ret = device_claim(&bm->dev);
377 if (ret < 0)
378 goto error;
379
380 dev = bm->dev.dev;
381 if (dev->settings.auth && !dev->auth_status)
382 return -1;
383
384 if (bm->active)
385 return 0;
386
387 ret = system_bridge_addif(&bst->dev, bm->dev.dev);
388 if (ret < 0) {
389 D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
390 goto error;
391 }
392
393 bm->active = true;
394 if (bst->has_vlans) {
395 /* delete default VLAN 1 */
396 system_bridge_vlan(bm->dev.dev->ifname, 1, false, 0);
397
398 vlist_for_each_element(&bst->dev.vlans, vlan, node)
399 bridge_set_member_vlan(bm, vlan, true);
400 }
401
402 device_set_present(&bst->dev, true);
403 device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
404
405 return 0;
406
407 error:
408 bst->n_failed++;
409 bm->present = false;
410 bst->n_present--;
411 device_release(&bm->dev);
412
413 return ret;
414 }
415
416 static void
417 bridge_remove_member(struct bridge_member *bm)
418 {
419 struct bridge_state *bst = bm->bst;
420
421 if (!bm->present)
422 return;
423
424 if (bst->dev.active)
425 bridge_disable_member(bm, false);
426
427 bm->present = false;
428 bm->bst->n_present--;
429
430 if (bm == bst->primary_port)
431 bridge_reset_primary(bst);
432
433 if (bst->config.bridge_empty)
434 return;
435
436 bst->force_active = false;
437 if (bst->n_present == 0)
438 device_set_present(&bst->dev, false);
439 }
440
441 static void
442 bridge_free_member(struct bridge_member *bm)
443 {
444 struct bridge_state *bst = bm->bst;
445 struct device *dev = bm->dev.dev;
446 const char *ifname = dev->ifname;
447 struct bridge_vlan *vlan;
448
449 bridge_remove_member(bm);
450
451 restart:
452 vlist_for_each_element(&bst->dev.vlans, vlan, node) {
453 struct bridge_vlan_hotplug_port *port, *tmp;
454 bool free_port = false;
455
456 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
457 if (strcmp(port->port.ifname, ifname) != 0)
458 continue;
459
460 list_del(&port->list);
461 free(port);
462 free_port = true;
463 }
464
465 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
466 vlan->n_ports || vlan->node.version != -1)
467 continue;
468
469 vlist_delete(&bst->dev.vlans, &vlan->node);
470 goto restart;
471 }
472
473 device_lock();
474
475 device_remove_user(&bm->dev);
476 uloop_timeout_cancel(&bm->check_timer);
477
478 /*
479 * When reloading the config and moving a device from one bridge to
480 * another, the other bridge may have tried to claim this device
481 * before it was removed here.
482 * Ensure that claiming the device is retried by toggling its present
483 * state
484 */
485 if (dev->present) {
486 device_set_present(dev, false);
487 device_set_present(dev, true);
488 }
489
490 device_unlock();
491
492 free(bm);
493 }
494
495 static void
496 bridge_check_retry(struct bridge_state *bst)
497 {
498 if (!bst->n_failed)
499 return;
500
501 uloop_timeout_set(&bst->retry, 100);
502 }
503
504 static void
505 bridge_member_check_cb(struct uloop_timeout *t)
506 {
507 struct bridge_member *bm;
508 struct bridge_state *bst;
509
510 bm = container_of(t, struct bridge_member, check_timer);
511 bst = bm->bst;
512
513 if (!system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname))
514 return;
515
516 bridge_disable_member(bm, true);
517 bridge_enable_member(bm);
518 }
519
520 static void
521 bridge_member_cb(struct device_user *dep, enum device_event ev)
522 {
523 struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
524 struct bridge_state *bst = bm->bst;
525 struct device *dev = dep->dev;
526
527 switch (ev) {
528 case DEV_EVENT_ADD:
529 assert(!bm->present);
530
531 bm->present = true;
532 bst->n_present++;
533
534 if (bst->n_present == 1)
535 device_set_present(&bst->dev, true);
536 fallthrough;
537 case DEV_EVENT_LINK_UP:
538 uloop_timeout_set(&bm->check_timer, 1000);
539 break;
540 case DEV_EVENT_AUTH_UP:
541 if (!bst->dev.active)
542 break;
543
544 if (bridge_enable_member(bm))
545 break;
546
547 /*
548 * Adding a bridge member can overwrite the bridge mtu
549 * in the kernel, apply the bridge settings in case the
550 * bridge mtu is set
551 */
552 system_if_apply_settings(&bst->dev, &bst->dev.settings,
553 DEV_OPT_MTU | DEV_OPT_MTU6);
554 break;
555 case DEV_EVENT_LINK_DOWN:
556 if (!dev->settings.auth)
557 break;
558
559 bridge_disable_member(bm, true);
560 break;
561 case DEV_EVENT_REMOVE:
562 if (dep->hotplug) {
563 vlist_delete(&bst->members, &bm->node);
564 return;
565 }
566
567 if (bm->present)
568 bridge_remove_member(bm);
569
570 break;
571 default:
572 return;
573 }
574 }
575
576 static int
577 bridge_set_down(struct bridge_state *bst)
578 {
579 struct bridge_member *bm;
580
581 bst->set_state(&bst->dev, false);
582
583 vlist_for_each_element(&bst->members, bm, node)
584 bridge_disable_member(bm, false);
585
586 bridge_disable_interface(bst);
587
588 return 0;
589 }
590
591 static int
592 bridge_set_up(struct bridge_state *bst)
593 {
594 struct bridge_member *bm;
595 int ret;
596
597 bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
598 if (!bst->n_present) {
599 if (!bst->force_active)
600 return -ENOENT;
601
602 ret = bridge_enable_interface(bst);
603 if (ret)
604 return ret;
605 }
606
607 bst->n_failed = 0;
608 vlist_for_each_element(&bst->members, bm, node)
609 bridge_enable_member(bm);
610 bridge_check_retry(bst);
611
612 if (!bst->force_active && !bst->n_present) {
613 /* initialization of all member interfaces failed */
614 bridge_disable_interface(bst);
615 device_set_present(&bst->dev, false);
616 return -ENOENT;
617 }
618
619 bridge_reset_primary(bst);
620 ret = bst->set_state(&bst->dev, true);
621 if (ret < 0)
622 bridge_set_down(bst);
623
624 return ret;
625 }
626
627 static int
628 bridge_set_state(struct device *dev, bool up)
629 {
630 struct bridge_state *bst;
631
632 bst = container_of(dev, struct bridge_state, dev);
633
634 if (up)
635 return bridge_set_up(bst);
636 else
637 return bridge_set_down(bst);
638 }
639
640 static struct bridge_member *
641 bridge_create_member(struct bridge_state *bst, const char *name,
642 struct device *dev, bool hotplug)
643 {
644 struct bridge_member *bm;
645
646 bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
647 if (!bm)
648 return NULL;
649
650 bm->bst = bst;
651 bm->dev.cb = bridge_member_cb;
652 bm->dev.hotplug = hotplug;
653 bm->check_timer.cb = bridge_member_check_cb;
654 strcpy(bm->name, name);
655 bm->dev.dev = dev;
656 vlist_add(&bst->members, &bm->node, bm->name);
657 /*
658 * Need to look up the bridge member again as the above
659 * created pointer will be freed in case the bridge member
660 * already existed
661 */
662 bm = vlist_find(&bst->members, name, bm, node);
663 if (hotplug && bm)
664 bm->node.version = -1;
665
666 return bm;
667 }
668
669 static void
670 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
671 struct vlist_node *node_old)
672 {
673 struct bridge_member *bm;
674 struct device *dev;
675
676 if (node_new) {
677 bm = container_of(node_new, struct bridge_member, node);
678
679 if (node_old) {
680 free(bm);
681 return;
682 }
683
684 dev = bm->dev.dev;
685 bm->dev.dev = NULL;
686 device_add_user(&bm->dev, dev);
687 }
688
689
690 if (node_old) {
691 bm = container_of(node_old, struct bridge_member, node);
692 bridge_free_member(bm);
693 }
694 }
695
696
697 static void
698 bridge_add_member(struct bridge_state *bst, const char *name)
699 {
700 struct device *dev;
701
702 dev = device_get(name, true);
703 if (!dev)
704 return;
705
706 bridge_create_member(bst, name, dev, false);
707 }
708
709 static struct bridge_vlan *
710 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid)
711 {
712 struct bridge_vlan *vlan;
713
714 vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
715 if (vlan)
716 return vlan;
717
718 vlan = calloc(1, sizeof(*vlan));
719 vlan->vid = vid;
720 vlan->local = true;
721 INIT_LIST_HEAD(&vlan->hotplug_ports);
722 vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
723 vlan->node.version = -1;
724
725 return vlan;
726 }
727
728 static struct bridge_vlan_hotplug_port *
729 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
730 {
731 struct bridge_vlan_hotplug_port *port;
732
733 list_for_each_entry(port, &vlan->hotplug_ports, list)
734 if (!strcmp(port->port.ifname, ifname))
735 return port;
736
737 return NULL;
738 }
739
740 static void
741 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
742 const char *ifname, struct bridge_member *bm, bool add)
743 {
744 struct bridge_vlan *vlan;
745 struct blob_attr *cur;
746 int rem;
747
748 if (!vlans)
749 return;
750
751 blobmsg_for_each_attr(cur, vlans, rem) {
752 struct bridge_vlan_hotplug_port *port;
753 uint16_t flags = BRVLAN_F_UNTAGGED;
754 char *name_buf;
755 unsigned int vid;
756 char *end;
757
758 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
759 continue;
760
761 vid = strtoul(blobmsg_get_string(cur), &end, 0);
762 if (!vid || vid > 4095)
763 continue;
764
765 vlan = bridge_hotplug_get_vlan(bst, vid);
766 if (!vlan)
767 continue;
768
769 if (vlan->pending) {
770 vlan->pending = false;
771 bridge_set_vlan_state(bst, vlan, true);
772 }
773
774 if (end && *end) {
775 if (*end != ':')
776 continue;
777
778 for (end++; *end; end++) {
779 switch (*end) {
780 case 't':
781 flags &= ~BRVLAN_F_UNTAGGED;
782 break;
783 case '*':
784 flags |= BRVLAN_F_PVID;
785 break;
786 }
787 }
788 }
789
790 port = bridge_hotplug_get_vlan_port(vlan, ifname);
791 if (!add) {
792 if (!port)
793 continue;
794
795 __bridge_set_member_vlan(bm, vlan, &port->port, false);
796 list_del(&port->list);
797 free(port);
798 continue;
799 }
800
801 if (port) {
802 if (port->port.flags == flags)
803 continue;
804
805 __bridge_set_member_vlan(bm, vlan, &port->port, false);
806 port->port.flags = flags;
807 __bridge_set_member_vlan(bm, vlan, &port->port, true);
808 continue;
809 }
810
811 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
812 if (!port)
813 continue;
814
815 port->port.flags = flags;
816 port->port.ifname = strcpy(name_buf, ifname);
817 list_add_tail(&port->list, &vlan->hotplug_ports);
818
819 if (!bm)
820 continue;
821
822 __bridge_set_member_vlan(bm, vlan, &port->port, true);
823 }
824 }
825
826 static int
827 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
828 {
829 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
830 struct bridge_member *bm;
831
832 bm = vlist_find(&bst->members, member->ifname, bm, node);
833 bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, true);
834 if (!bm)
835 bridge_create_member(bst, member->ifname, member, true);
836
837 return 0;
838 }
839
840 static int
841 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
842 {
843 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
844 struct bridge_member *bm;
845
846 bm = vlist_find(&bst->members, member->ifname, bm, node);
847 if (!bm)
848 return UBUS_STATUS_NOT_FOUND;
849
850 bridge_hotplug_set_member_vlans(bst, vlan, member->ifname, bm, false);
851 if (!bm->dev.hotplug)
852 return 0;
853
854 vlist_delete(&bst->members, &bm->node);
855 return 0;
856 }
857
858 static int
859 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
860 {
861 struct bridge_state *bst;
862
863 if (bridge_dev)
864 *bridge_dev = dev;
865
866 bst = container_of(dev, struct bridge_state, dev);
867 bst->force_active = true;
868 device_set_present(&bst->dev, true);
869
870 return 0;
871 }
872
873 static const struct device_hotplug_ops bridge_ops = {
874 .prepare = bridge_hotplug_prepare,
875 .add = bridge_hotplug_add,
876 .del = bridge_hotplug_del
877 };
878
879 static void
880 bridge_free(struct device *dev)
881 {
882 struct bridge_state *bst;
883
884 bst = container_of(dev, struct bridge_state, dev);
885 vlist_flush_all(&bst->members);
886 vlist_flush_all(&dev->vlans);
887 kvlist_free(&dev->vlan_aliases);
888 free(bst->config_data);
889 free(bst);
890 }
891
892 static void
893 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
894 {
895 bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
896 bool pvid = (port->flags & BRVLAN_F_PVID);
897
898 blobmsg_printf(b, "%s%s%s%s\n", port->ifname,
899 tagged || pvid ? ":" : "",
900 tagged ? "t" : "",
901 pvid ? "*" : "");
902 }
903
904 static void
905 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
906 {
907 struct bridge_vlan_hotplug_port *port;
908 void *c, *p;
909 int i;
910
911 c = blobmsg_open_table(b, NULL);
912
913 blobmsg_add_u32(b, "id", vlan->vid);
914 blobmsg_add_u8(b, "local", vlan->local);
915
916 p = blobmsg_open_array(b, "ports");
917
918 for (i = 0; i < vlan->n_ports; i++)
919 bridge_dump_port(b, &vlan->ports[i]);
920
921 list_for_each_entry(port, &vlan->hotplug_ports, list)
922 bridge_dump_port(b, &port->port);
923
924 blobmsg_close_array(b, p);
925
926 blobmsg_close_table(b, c);
927 }
928
929 static void
930 bridge_dump_info(struct device *dev, struct blob_buf *b)
931 {
932 struct bridge_state *bst;
933 struct bridge_member *bm;
934 struct bridge_vlan *vlan;
935 void *list;
936
937 bst = container_of(dev, struct bridge_state, dev);
938
939 system_if_dump_info(dev, b);
940 list = blobmsg_open_array(b, "bridge-members");
941
942 vlist_for_each_element(&bst->members, bm, node) {
943 if (bm->dev.dev->hidden)
944 continue;
945
946 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
947 }
948
949 blobmsg_close_array(b, list);
950
951 if (avl_is_empty(&dev->vlans.avl))
952 return;
953
954 list = blobmsg_open_array(b, "bridge-vlans");
955
956 vlist_for_each_element(&bst->dev.vlans, vlan, node)
957 bridge_dump_vlan(b, vlan);
958
959 blobmsg_close_array(b, list);
960 }
961
962 static void
963 bridge_config_init(struct device *dev)
964 {
965 struct bridge_state *bst;
966 struct bridge_vlan *vlan;
967 struct blob_attr *cur;
968 int i, rem;
969
970 bst = container_of(dev, struct bridge_state, dev);
971
972 if (bst->config.bridge_empty) {
973 bst->force_active = true;
974 device_set_present(&bst->dev, true);
975 }
976
977 bst->n_failed = 0;
978 vlist_update(&bst->members);
979 if (bst->ports) {
980 blobmsg_for_each_attr(cur, bst->ports, rem) {
981 bridge_add_member(bst, blobmsg_data(cur));
982 }
983 }
984
985 vlist_for_each_element(&bst->dev.vlans, vlan, node)
986 for (i = 0; i < vlan->n_ports; i++)
987 bridge_add_member(bst, vlan->ports[i].ifname);
988
989 vlist_flush(&bst->members);
990 bridge_check_retry(bst);
991 }
992
993 static void
994 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
995 {
996 struct bridge_config *cfg = &bst->config;
997 struct blob_attr *cur;
998
999 /* defaults */
1000 cfg->stp = false;
1001 cfg->forward_delay = 2;
1002 cfg->robustness = 2;
1003 cfg->igmp_snoop = false;
1004 cfg->multicast_querier = false;
1005 cfg->query_interval = 12500;
1006 cfg->query_response_interval = 1000;
1007 cfg->last_member_interval = 100;
1008 cfg->hash_max = 512;
1009 cfg->bridge_empty = false;
1010 cfg->priority = 0x7FFF;
1011 cfg->vlan_filtering = false;
1012
1013 if ((cur = tb[BRIDGE_ATTR_STP]))
1014 cfg->stp = blobmsg_get_bool(cur);
1015
1016 if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1017 cfg->forward_delay = blobmsg_get_u32(cur);
1018
1019 if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1020 cfg->priority = blobmsg_get_u32(cur);
1021
1022 if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1023 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1024
1025 if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1026 cfg->multicast_querier = blobmsg_get_bool(cur);
1027
1028 if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1029 cfg->hash_max = blobmsg_get_u32(cur);
1030
1031 if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1032 cfg->robustness = blobmsg_get_u32(cur);
1033 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1034 }
1035
1036 if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1037 cfg->query_interval = blobmsg_get_u32(cur);
1038 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1039 }
1040
1041 if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1042 cfg->query_response_interval = blobmsg_get_u32(cur);
1043 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1044 }
1045
1046 if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1047 cfg->last_member_interval = blobmsg_get_u32(cur);
1048 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1049 }
1050
1051 if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1052 cfg->ageing_time = blobmsg_get_u32(cur);
1053 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1054 }
1055
1056 if ((cur = tb[BRIDGE_ATTR_HELLO_TIME])) {
1057 cfg->hello_time = blobmsg_get_u32(cur);
1058 cfg->flags |= BRIDGE_OPT_HELLO_TIME;
1059 }
1060
1061 if ((cur = tb[BRIDGE_ATTR_MAX_AGE])) {
1062 cfg->max_age = blobmsg_get_u32(cur);
1063 cfg->flags |= BRIDGE_OPT_MAX_AGE;
1064 }
1065
1066 if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1067 cfg->bridge_empty = blobmsg_get_bool(cur);
1068
1069 if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1070 cfg->vlan_filtering = blobmsg_get_bool(cur);
1071 }
1072
1073 static enum dev_change_type
1074 bridge_reload(struct device *dev, struct blob_attr *attr)
1075 {
1076 struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1077 struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1078 enum dev_change_type ret = DEV_CONFIG_APPLIED;
1079 unsigned long diff;
1080 struct bridge_state *bst;
1081
1082 BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / 8);
1083 BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / 8);
1084
1085 bst = container_of(dev, struct bridge_state, dev);
1086 attr = blob_memdup(attr);
1087
1088 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1089 blob_data(attr), blob_len(attr));
1090 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1091 blob_data(attr), blob_len(attr));
1092
1093 if (tb_dev[DEV_ATTR_MACADDR])
1094 bst->primary_port = NULL;
1095
1096 bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1097 device_init_settings(dev, tb_dev);
1098 bridge_apply_settings(bst, tb_br);
1099
1100 if (bst->config_data) {
1101 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1102 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1103
1104 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1105 blob_data(bst->config_data), blob_len(bst->config_data));
1106
1107 diff = 0;
1108 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, &diff);
1109 if (diff)
1110 ret = DEV_CONFIG_RESTART;
1111
1112 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1113 blob_data(bst->config_data), blob_len(bst->config_data));
1114
1115 diff = 0;
1116 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, &diff);
1117 if (diff & ~(1 << BRIDGE_ATTR_PORTS))
1118 ret = DEV_CONFIG_RESTART;
1119
1120 bridge_config_init(dev);
1121 }
1122
1123 free(bst->config_data);
1124 bst->config_data = attr;
1125 return ret;
1126 }
1127
1128 static void
1129 bridge_retry_members(struct uloop_timeout *timeout)
1130 {
1131 struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1132 struct bridge_member *bm;
1133
1134 bst->n_failed = 0;
1135 vlist_for_each_element(&bst->members, bm, node) {
1136 if (bm->present)
1137 continue;
1138
1139 if (!bm->dev.dev->present)
1140 continue;
1141
1142 bm->present = true;
1143 bst->n_present++;
1144 bridge_enable_member(bm);
1145 }
1146 }
1147
1148 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1149 {
1150 const uint16_t *i1 = k1, *i2 = k2;
1151
1152 return *i1 - *i2;
1153 }
1154
1155 static bool
1156 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1157 {
1158 int i;
1159
1160 if (v1->n_ports != v2->n_ports)
1161 return false;
1162
1163 for (i = 0; i < v1->n_ports; i++)
1164 if (v1->ports[i].flags != v2->ports[i].flags ||
1165 strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1166 return false;
1167
1168 return true;
1169 }
1170
1171 static void
1172 bridge_vlan_free(struct bridge_vlan *vlan)
1173 {
1174 struct bridge_vlan_hotplug_port *port, *tmp;
1175
1176 if (!vlan)
1177 return;
1178
1179 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1180 free(port);
1181
1182 free(vlan);
1183 }
1184
1185 static void
1186 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1187 struct vlist_node *node_old)
1188 {
1189 struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1190 struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1191
1192 if (!bst->has_vlans || !bst->active)
1193 goto out;
1194
1195 if (node_old)
1196 vlan_old = container_of(node_old, struct bridge_vlan, node);
1197 if (node_new)
1198 vlan_new = container_of(node_new, struct bridge_vlan, node);
1199
1200 if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1201 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1202 goto out;
1203 }
1204
1205 if (node_old)
1206 bridge_set_vlan_state(bst, vlan_old, false);
1207
1208 if (node_old && node_new)
1209 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1210
1211 if (node_new)
1212 vlan_new->pending = true;
1213
1214 bst->dev.config_pending = true;
1215
1216 out:
1217 bridge_vlan_free(vlan_old);
1218 }
1219
1220 static void
1221 bridge_dev_vlan_update(struct device *dev)
1222 {
1223 struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1224 struct bridge_vlan *vlan;
1225
1226 vlist_for_each_element(&dev->vlans, vlan, node) {
1227 if (!vlan->pending)
1228 continue;
1229
1230 vlan->pending = false;
1231 bridge_set_vlan_state(bst, vlan, true);
1232 }
1233 }
1234
1235 static struct device *
1236 bridge_create(const char *name, struct device_type *devtype,
1237 struct blob_attr *attr)
1238 {
1239 struct bridge_state *bst;
1240 struct device *dev = NULL;
1241
1242 bst = calloc(1, sizeof(*bst));
1243 if (!bst)
1244 return NULL;
1245
1246 dev = &bst->dev;
1247
1248 if (device_init(dev, devtype, name) < 0) {
1249 device_cleanup(dev);
1250 free(bst);
1251 return NULL;
1252 }
1253
1254 dev->config_pending = true;
1255 bst->retry.cb = bridge_retry_members;
1256
1257 bst->set_state = dev->set_state;
1258 dev->set_state = bridge_set_state;
1259
1260 dev->hotplug_ops = &bridge_ops;
1261
1262 vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1263 bst->members.keep_old = true;
1264
1265 vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1266
1267 bridge_reload(dev, attr);
1268
1269 return dev;
1270 }
1271
1272 static void __init bridge_device_type_init(void)
1273 {
1274 device_type_add(&bridge_device_type);
1275 }