firmware-utils: mkfwimage: fix memcpy and strncpy usage wip/firmware-utils-fixes
authorPetr Štetiar <ynezz@true.cz>
Fri, 26 Jul 2019 12:45:32 +0000 (14:45 +0200)
committerPetr Štetiar <ynezz@true.cz>
Fri, 26 Jul 2019 13:11:17 +0000 (15:11 +0200)
commitc61a7abacb5e36e05b5ffb15db9231ef8db52bd5
treee8db80d6ba3889b06f142dd792faa983beb172cc
parent25f897ae1020c542ec7bfa9032f1f2034b640cdd
firmware-utils: mkfwimage: fix memcpy and strncpy usage

Firmware is binary blob, so there are barely any NULL terminated strings
expected, so we should probably convert all chars into u8 types, and
after that it's clear, that using strcpy doesn't make sense anymore.

This is rather theoretical stuff, but `uint8_t name[PART_NAME_LENGTH]`
means, that you can supply PART_NAME_LENGTH sized name, not
PART_NAME_LENGTH-1 name when NULL terminated.

Ref: https://github.com/openwrt/openwrt/pull/2274
Signed-off-by: Petr Štetiar <ynezz@true.cz>
tools/firmware-utils/src/fw.h
tools/firmware-utils/src/mkfwimage.c
tools/firmware-utils/src/utils.h [new file with mode: 0644]