libs/dahdi-linux/patches/201-dahdi-fix-always-true-compilation-warning.patch

   1 From eea6daaa4cae1ddcd8e32c8b9e4273ba3244838c Mon Sep 17 00:00:00 2001
   2 From: Christian Marangi <ansuelsmth@gmail.com>
   3 Date: Fri, 12 May 2023 20:19:04 +0200
   4 Subject: [PATCH 2/6] dahdi: fix always true compilation warning
   5
   6 Fix always true compilation warning on statically allocated array. Check
   7 content of the array instead.
   8
   9 Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
  10 ---
  11  drivers/dahdi/dahdi-base.c          | 6 +++---
  12  drivers/dahdi/dahdi_dynamic_ethmf.c | 2 +-
  13  drivers/dahdi/xpp/xbus-core.c       | 2 +-
  14  3 files changed, 5 insertions(+), 5 deletions(-)
  15
  16 --- a/drivers/dahdi/dahdi-base.c
  17 +++ b/drivers/dahdi/dahdi-base.c
  18 @@ -923,9 +923,9 @@ static int dahdi_seq_show(struct seq_fil
  19         if (!s)
  20                 return -ENODEV;
  21
  22 -       if (s->name)
  23 +       if (*(s->name))
  24                 seq_printf(sfile, "Span %d: %s ", s->spanno, s->name);
  25 -       if (s->desc)
  26 +       if (*(s->desc))
  27                 seq_printf(sfile, "\"%s\"", s->desc);
  28         else
  29                 seq_printf(sfile, "\"\"");
  30 @@ -964,7 +964,7 @@ static int dahdi_seq_show(struct seq_fil
  31         for (x = 0; x < s->channels; x++) {
  32                 struct dahdi_chan *chan = s->chans[x];
  33
  34 -               if (chan->name)
  35 +               if (*(chan->name))
  36                         seq_printf(sfile, "\t%4d %s ", chan->channo,
  37                                         chan->name);
  38
  39 --- a/drivers/dahdi/dahdi_dynamic_ethmf.c
  40 +++ b/drivers/dahdi/dahdi_dynamic_ethmf.c
  41 @@ -535,7 +535,7 @@ static void ztdethmf_destroy(struct dahd
  42                 kfree(z->msgbuf);
  43                 kfree(z);
  44         } else {
  45 -               if (z && z->span && z->span->name) {
  46 +               if (z && z->span && *(z->span->name)) {
  47                         printk(KERN_ERR "Cannot find interface for %s\n",
  48                                 z->span->name);
  49                 }
  50 --- a/drivers/dahdi/xpp/xbus-core.c
  51 +++ b/drivers/dahdi/xpp/xbus-core.c
  52 @@ -120,7 +120,7 @@ int xbus_check_unique(xbus_t *xbus)
  53  {
  54         if (!xbus)
  55                 return -ENOENT;
  56 -       if (xbus->label && *(xbus->label)) {
  57 +       if (*(xbus->label)) {
  58                 xbus_t *xbus_old;
  59
  60                 XBUS_DBG(DEVICES, xbus, "Checking LABEL='%s'\n", xbus->label);