bridge.c

   1 /*
   2  * netifd - network interface daemon
   3  * Copyright (C) 2012 Felix Fietkau <nbd@openwrt.org>
   4  *
   5  * This program is free software; you can redistribute it and/or modify
   6  * it under the terms of the GNU General Public License version 2
   7  * as published by the Free Software Foundation
   8  *
   9  * This program is distributed in the hope that it will be useful,
  10  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  11  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  12  * GNU General Public License for more details.
  13  */
  14 #include <string.h>
  15 #include <stdlib.h>
  16 #include <stdio.h>
  17 #include <assert.h>
  18 #include <errno.h>
  19
  20 #include "netifd.h"
  21 #include "device.h"
  22 #include "interface.h"
  23 #include "system.h"
  24 #include "ubus.h"
  25
  26 enum {
  27         BRIDGE_ATTR_PORTS,
  28         BRIDGE_ATTR_STP,
  29         BRIDGE_ATTR_FORWARD_DELAY,
  30         BRIDGE_ATTR_PRIORITY,
  31         BRIDGE_ATTR_IGMP_SNOOP,
  32         BRIDGE_ATTR_AGEING_TIME,
  33         BRIDGE_ATTR_HELLO_TIME,
  34         BRIDGE_ATTR_MAX_AGE,
  35         BRIDGE_ATTR_BRIDGE_EMPTY,
  36         BRIDGE_ATTR_MULTICAST_QUERIER,
  37         BRIDGE_ATTR_HASH_MAX,
  38         BRIDGE_ATTR_ROBUSTNESS,
  39         BRIDGE_ATTR_QUERY_INTERVAL,
  40         BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL,
  41         BRIDGE_ATTR_LAST_MEMBER_INTERVAL,
  42         BRIDGE_ATTR_VLAN_FILTERING,
  43         BRIDGE_ATTR_HAS_VLANS,
  44         BRIDGE_ATTR_STP_KERNEL,
  45         BRIDGE_ATTR_STP_PROTO,
  46         __BRIDGE_ATTR_MAX
  47 };
  48
  49 static const struct blobmsg_policy bridge_attrs[__BRIDGE_ATTR_MAX] = {
  50         [BRIDGE_ATTR_PORTS] = { "ports", BLOBMSG_TYPE_ARRAY },
  51         [BRIDGE_ATTR_STP] = { "stp", BLOBMSG_TYPE_BOOL },
  52         [BRIDGE_ATTR_FORWARD_DELAY] = { "forward_delay", BLOBMSG_TYPE_INT32 },
  53         [BRIDGE_ATTR_PRIORITY] = { "priority", BLOBMSG_TYPE_INT32 },
  54         [BRIDGE_ATTR_AGEING_TIME] = { "ageing_time", BLOBMSG_TYPE_INT32 },
  55         [BRIDGE_ATTR_HELLO_TIME] = { "hello_time", BLOBMSG_TYPE_INT32 },
  56         [BRIDGE_ATTR_MAX_AGE] = { "max_age", BLOBMSG_TYPE_INT32 },
  57         [BRIDGE_ATTR_IGMP_SNOOP] = { "igmp_snooping", BLOBMSG_TYPE_BOOL },
  58         [BRIDGE_ATTR_BRIDGE_EMPTY] = { "bridge_empty", BLOBMSG_TYPE_BOOL },
  59         [BRIDGE_ATTR_MULTICAST_QUERIER] = { "multicast_querier", BLOBMSG_TYPE_BOOL },
  60         [BRIDGE_ATTR_HASH_MAX] = { "hash_max", BLOBMSG_TYPE_INT32 },
  61         [BRIDGE_ATTR_ROBUSTNESS] = { "robustness", BLOBMSG_TYPE_INT32 },
  62         [BRIDGE_ATTR_QUERY_INTERVAL] = { "query_interval", BLOBMSG_TYPE_INT32 },
  63         [BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL] = { "query_response_interval", BLOBMSG_TYPE_INT32 },
  64         [BRIDGE_ATTR_LAST_MEMBER_INTERVAL] = { "last_member_interval", BLOBMSG_TYPE_INT32 },
  65         [BRIDGE_ATTR_VLAN_FILTERING] = { "vlan_filtering", BLOBMSG_TYPE_BOOL },
  66         [BRIDGE_ATTR_HAS_VLANS] = { "__has_vlans", BLOBMSG_TYPE_BOOL }, /* internal */
  67         [BRIDGE_ATTR_STP_KERNEL] = { "stp_kernel", BLOBMSG_TYPE_BOOL },
  68         [BRIDGE_ATTR_STP_PROTO] = { "stp_proto", BLOBMSG_TYPE_STRING },
  69 };
  70
  71 static const struct uci_blob_param_info bridge_attr_info[__BRIDGE_ATTR_MAX] = {
  72         [BRIDGE_ATTR_PORTS] = { .type = BLOBMSG_TYPE_STRING },
  73 };
  74
  75 static const struct uci_blob_param_list bridge_attr_list = {
  76         .n_params = __BRIDGE_ATTR_MAX,
  77         .params = bridge_attrs,
  78         .info = bridge_attr_info,
  79
  80         .n_next = 1,
  81         .next = { &device_attr_list },
  82 };
  83
  84 static struct blob_buf b;
  85 static struct device *bridge_create(const char *name, struct device_type *devtype,
  86         struct blob_attr *attr);
  87 static void bridge_config_init(struct device *dev);
  88 static void bridge_dev_vlan_update(struct device *dev);
  89 static void bridge_free(struct device *dev);
  90 static void bridge_stp_init(struct device *dev);
  91 static void bridge_dump_info(struct device *dev, struct blob_buf *b);
  92 static enum dev_change_type
  93 bridge_reload(struct device *dev, struct blob_attr *attr);
  94
  95 static struct device_type bridge_device_type = {
  96         .name = "bridge",
  97         .config_params = &bridge_attr_list,
  98
  99         .bridge_capability = true,
 100         .name_prefix = "br",
 101
 102         .create = bridge_create,
 103         .config_init = bridge_config_init,
 104         .vlan_update = bridge_dev_vlan_update,
 105         .reload = bridge_reload,
 106         .free = bridge_free,
 107         .dump_info = bridge_dump_info,
 108         .stp_init = bridge_stp_init,
 109 };
 110
 111 struct bridge_state {
 112         struct device dev;
 113         device_state_cb set_state;
 114
 115         struct blob_attr *config_data;
 116         struct bridge_config config;
 117         struct blob_attr *ports;
 118         bool active;
 119         bool force_active;
 120         bool has_vlans;
 121
 122         struct uloop_timeout retry;
 123         struct bridge_member *primary_port;
 124         struct vlist_tree members;
 125         int n_present;
 126         int n_failed;
 127 };
 128
 129 struct bridge_member {
 130         struct vlist_node node;
 131         struct bridge_state *bst;
 132         struct device_user dev;
 133         struct uloop_timeout check_timer;
 134         struct device_vlan_range *extra_vlan;
 135         int n_extra_vlan;
 136         uint16_t pvid;
 137         bool present;
 138         bool active;
 139         char name[];
 140 };
 141
 142 static void
 143 bridge_reset_primary(struct bridge_state *bst)
 144 {
 145         struct bridge_member *bm;
 146
 147         if (!bst->primary_port &&
 148             (bst->dev.settings.flags & DEV_OPT_MACADDR))
 149                 return;
 150
 151         bst->primary_port = NULL;
 152         bst->dev.settings.flags &= ~DEV_OPT_MACADDR;
 153         vlist_for_each_element(&bst->members, bm, node) {
 154                 uint8_t *macaddr;
 155
 156                 if (!bm->present)
 157                         continue;
 158
 159                 bst->primary_port = bm;
 160                 if (bm->dev.dev->settings.flags & DEV_OPT_MACADDR)
 161                         macaddr = bm->dev.dev->settings.macaddr;
 162                 else
 163                         macaddr = bm->dev.dev->orig_settings.macaddr;
 164                 memcpy(bst->dev.settings.macaddr, macaddr, 6);
 165                 bst->dev.settings.flags |= DEV_OPT_MACADDR;
 166                 return;
 167         }
 168 }
 169
 170 static struct bridge_vlan_port *
 171 bridge_find_vlan_member_port(struct bridge_member *bm, struct bridge_vlan *vlan)
 172 {
 173         struct bridge_vlan_hotplug_port *port;
 174         const char *ifname = bm->dev.dev->ifname;
 175         int i;
 176
 177         for (i = 0; i < vlan->n_ports; i++) {
 178                 if (strcmp(vlan->ports[i].ifname, ifname) != 0)
 179                         continue;
 180
 181                 return &vlan->ports[i];
 182         }
 183
 184         list_for_each_entry(port, &vlan->hotplug_ports, list) {
 185                 if (strcmp(port->port.ifname, ifname) != 0)
 186                         continue;
 187
 188                 return &port->port;
 189         }
 190
 191         return NULL;
 192 }
 193
 194 static bool
 195 bridge_member_vlan_is_pvid(struct bridge_member *bm, struct bridge_vlan_port *port)
 196 {
 197         return (!bm->pvid && (port->flags & BRVLAN_F_UNTAGGED)) ||
 198                (port->flags & BRVLAN_F_PVID);
 199 }
 200
 201 static void
 202 __bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan,
 203                          struct bridge_vlan_port *port, bool add)
 204 {
 205         uint16_t flags;
 206
 207         flags = port->flags;
 208         if (bm->pvid == vlan->vid)
 209                 flags |= BRVLAN_F_PVID;
 210
 211         system_bridge_vlan(port->ifname, vlan->vid, -1, add, flags);
 212 }
 213
 214 static void
 215 bridge_set_member_vlan(struct bridge_member *bm, struct bridge_vlan *vlan, bool add)
 216 {
 217         struct bridge_vlan_port *port;
 218
 219         if (!bm->present)
 220                 return;
 221
 222         port = bridge_find_vlan_member_port(bm, vlan);
 223         if (!port)
 224                 return;
 225
 226         if (bridge_member_vlan_is_pvid(bm, port))
 227                 bm->pvid = vlan->vid;
 228
 229         __bridge_set_member_vlan(bm, vlan, port, add);
 230 }
 231
 232 static void
 233 bridge_set_local_vlan(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 234 {
 235         if (!vlan->local && add)
 236                 return;
 237
 238         system_bridge_vlan(bst->dev.ifname, vlan->vid, -1, add, BRVLAN_F_SELF);
 239 }
 240
 241 static void
 242 bridge_set_local_vlans(struct bridge_state *bst, bool add)
 243 {
 244         struct bridge_vlan *vlan;
 245
 246         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 247                 bridge_set_local_vlan(bst, vlan, add);
 248 }
 249
 250 static struct bridge_vlan *
 251 bridge_recalc_member_pvid(struct bridge_member *bm)
 252 {
 253         struct bridge_state *bst = bm->bst;
 254         struct bridge_vlan_port *port;
 255         struct bridge_vlan *vlan, *ret = NULL;
 256
 257         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 258                 port = bridge_find_vlan_member_port(bm, vlan);
 259                 if (!port)
 260                         continue;
 261
 262                 if (!bridge_member_vlan_is_pvid(bm, port))
 263                         continue;
 264
 265                 ret = vlan;
 266                 if (port->flags & BRVLAN_F_PVID)
 267                         break;
 268         }
 269
 270         return ret;
 271 }
 272
 273 static void
 274 bridge_set_vlan_state(struct bridge_state *bst, struct bridge_vlan *vlan, bool add)
 275 {
 276         struct bridge_member *bm;
 277         struct bridge_vlan *vlan2;
 278
 279         bridge_set_local_vlan(bst, vlan, add);
 280
 281         vlist_for_each_element(&bst->members, bm, node) {
 282                 struct bridge_vlan_port *port;
 283                 int new_pvid = -1;
 284
 285                 port = bridge_find_vlan_member_port(bm, vlan);
 286                 if (!port)
 287                         continue;
 288
 289                 if (add) {
 290                         if (bridge_member_vlan_is_pvid(bm, port))
 291                                 bm->pvid = vlan->vid;
 292                 } else if (bm->pvid == vlan->vid) {
 293                         vlan2 = bridge_recalc_member_pvid(bm);
 294                         if (vlan2 && vlan2->vid != vlan->vid) {
 295                                 bridge_set_member_vlan(bm, vlan2, false);
 296                                 bridge_set_member_vlan(bm, vlan2, true);
 297                         }
 298                         new_pvid = vlan2 ? vlan2->vid : 0;
 299                 }
 300
 301                 if (!bm->present)
 302                         continue;
 303
 304                 __bridge_set_member_vlan(bm, vlan, port, add);
 305                 if (new_pvid >= 0)
 306                         bm->pvid = new_pvid;
 307         }
 308 }
 309
 310 static int
 311 bridge_disable_member(struct bridge_member *bm, bool keep_dev)
 312 {
 313         struct bridge_state *bst = bm->bst;
 314         struct bridge_vlan *vlan;
 315
 316         if (!bm->present || !bm->active)
 317                 return 0;
 318
 319         bm->active = false;
 320         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 321                 bridge_set_member_vlan(bm, vlan, false);
 322
 323         system_bridge_delif(&bst->dev, bm->dev.dev);
 324         if (!keep_dev)
 325                 device_release(&bm->dev);
 326
 327         device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 328
 329         return 0;
 330 }
 331
 332 static void bridge_stp_notify(struct bridge_state *bst)
 333 {
 334         struct bridge_config *cfg = &bst->config;
 335
 336         if (!cfg->stp || cfg->stp_kernel)
 337                 return;
 338
 339         blob_buf_init(&b, 0);
 340         blobmsg_add_string(&b, "name", bst->dev.ifname);
 341         if (cfg->stp_proto)
 342                 blobmsg_add_string(&b, "proto", cfg->stp_proto);
 343         blobmsg_add_u32(&b, "forward_delay", cfg->forward_delay);
 344         blobmsg_add_u32(&b, "hello_time", cfg->hello_time);
 345         blobmsg_add_u32(&b, "max_age", cfg->max_age);
 346         if (cfg->flags & BRIDGE_OPT_AGEING_TIME)
 347                 blobmsg_add_u32(&b, "ageing_time", cfg->ageing_time);
 348         netifd_ubus_device_notify("stp_init", b.head, 1000);
 349 }
 350
 351 static int
 352 bridge_enable_interface(struct bridge_state *bst)
 353 {
 354         struct device *dev = &bst->dev;
 355         int i, ret;
 356
 357         if (bst->active)
 358                 return 0;
 359
 360         bridge_stp_notify(bst);
 361         ret = system_bridge_addbr(dev, &bst->config);
 362         if (ret < 0)
 363                 return ret;
 364
 365         if (bst->has_vlans) {
 366                 /* delete default VLAN 1 */
 367                 system_bridge_vlan(bst->dev.ifname, 1, -1, false, BRVLAN_F_SELF);
 368
 369                 bridge_set_local_vlans(bst, true);
 370         }
 371
 372         for (i = 0; i < dev->n_extra_vlan; i++)
 373                 system_bridge_vlan(dev->ifname, dev->extra_vlan[i].start,
 374                                    dev->extra_vlan[i].end, true, BRVLAN_F_SELF);
 375
 376         bst->active = true;
 377         return 0;
 378 }
 379
 380 static void
 381 bridge_stp_init(struct device *dev)
 382 {
 383         struct bridge_state *bst;
 384
 385         bst = container_of(dev, struct bridge_state, dev);
 386         if (!bst->config.stp || !bst->active)
 387                 return;
 388
 389         bridge_stp_notify(bst);
 390         system_bridge_set_stp_state(&bst->dev, false);
 391         system_bridge_set_stp_state(&bst->dev, true);
 392 }
 393
 394 static void
 395 bridge_disable_interface(struct bridge_state *bst)
 396 {
 397         if (!bst->active)
 398                 return;
 399
 400         system_bridge_delbr(&bst->dev);
 401         bst->active = false;
 402 }
 403
 404 static struct bridge_vlan *
 405 bridge_hotplug_get_vlan(struct bridge_state *bst, uint16_t vid, bool create)
 406 {
 407         struct bridge_vlan *vlan;
 408
 409         vlan = vlist_find(&bst->dev.vlans, &vid, vlan, node);
 410         if (vlan || !create)
 411                 return vlan;
 412
 413         vlan = calloc(1, sizeof(*vlan));
 414         vlan->vid = vid;
 415         vlan->local = true;
 416         INIT_LIST_HEAD(&vlan->hotplug_ports);
 417         vlist_add(&bst->dev.vlans, &vlan->node, &vlan->vid);
 418         vlan->node.version = -1;
 419
 420         return vlan;
 421 }
 422
 423 static struct bridge_vlan_hotplug_port *
 424 bridge_hotplug_get_vlan_port(struct bridge_vlan *vlan, const char *ifname)
 425 {
 426         struct bridge_vlan_hotplug_port *port;
 427
 428         list_for_each_entry(port, &vlan->hotplug_ports, list)
 429                 if (!strcmp(port->port.ifname, ifname))
 430                         return port;
 431
 432         return NULL;
 433 }
 434
 435 static void
 436 bridge_hotplug_set_member_vlans(struct bridge_state *bst, struct blob_attr *vlans,
 437                                 struct bridge_member *bm, bool add, bool untracked)
 438 {
 439         const char *ifname = bm->name;
 440         struct device_vlan_range *r;
 441         struct bridge_vlan *vlan;
 442         struct blob_attr *cur;
 443         int n_vlans;
 444         size_t rem;
 445
 446         if (!vlans)
 447                 return;
 448
 449         if (add) {
 450                 bm->n_extra_vlan = 0;
 451                 n_vlans = blobmsg_check_array(vlans, BLOBMSG_TYPE_STRING);
 452                 if (n_vlans < 1)
 453                         return;
 454
 455                 bm->extra_vlan = realloc(bm->extra_vlan, n_vlans * sizeof(*bm->extra_vlan));
 456         }
 457
 458         blobmsg_for_each_attr(cur, vlans, rem) {
 459                 struct bridge_vlan_hotplug_port *port;
 460                 unsigned int vid, vid_end;
 461                 uint16_t flags = 0;
 462                 char *name_buf;
 463                 char *end;
 464
 465                 if (blobmsg_type(cur) != BLOBMSG_TYPE_STRING)
 466                         continue;
 467
 468                 vid = strtoul(blobmsg_get_string(cur), &end, 0);
 469                 vid_end = vid;
 470                 if (!vid || vid > 4095)
 471                         continue;
 472
 473                 if (*end == '-') {
 474                         vid_end = strtoul(end + 1, &end, 0);
 475                         if (vid_end < vid)
 476                                 continue;
 477                 }
 478
 479                 if (end && *end) {
 480                         if (*end != ':')
 481                                 continue;
 482
 483                         for (end++; *end; end++) {
 484                                 switch (*end) {
 485                                 case 'u':
 486                                         flags |= BRVLAN_F_UNTAGGED;
 487                                         fallthrough;
 488                                 case '*':
 489                                         flags |= BRVLAN_F_PVID;
 490                                         break;
 491                                 }
 492                         }
 493                 }
 494
 495                 vlan = bridge_hotplug_get_vlan(bst, vid, !!flags);
 496                 if (!vlan || vid_end > vid || untracked) {
 497                         if (add) {
 498                                 if (!untracked) {
 499                                         r = &bm->extra_vlan[bm->n_extra_vlan++];
 500                                         r->start = vid;
 501                                         r->end = vid_end;
 502                                 }
 503                                 if (bm->active)
 504                                         system_bridge_vlan(ifname, vid, vid_end, true, flags);
 505                         } else if (bm->active) {
 506                                 system_bridge_vlan(ifname, vid, vid_end, false, 0);
 507                         }
 508                         continue;
 509                 }
 510
 511                 if (vlan->pending) {
 512                         vlan->pending = false;
 513                         bridge_set_vlan_state(bst, vlan, true);
 514                 }
 515
 516                 port = bridge_hotplug_get_vlan_port(vlan, ifname);
 517                 if (!add) {
 518                         if (!port)
 519                                 continue;
 520
 521                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 522                         list_del(&port->list);
 523                         free(port);
 524                         continue;
 525                 }
 526
 527                 if (port) {
 528                         if (port->port.flags == flags)
 529                                 continue;
 530
 531                         __bridge_set_member_vlan(bm, vlan, &port->port, false);
 532                         port->port.flags = flags;
 533                         __bridge_set_member_vlan(bm, vlan, &port->port, true);
 534                         continue;
 535                 }
 536
 537                 port = calloc_a(sizeof(*port), &name_buf, strlen(ifname) + 1);
 538                 if (!port)
 539                         continue;
 540
 541                 port->port.flags = flags;
 542                 port->port.ifname = strcpy(name_buf, ifname);
 543                 list_add_tail(&port->list, &vlan->hotplug_ports);
 544
 545                 if (!bm)
 546                         continue;
 547
 548                 __bridge_set_member_vlan(bm, vlan, &port->port, true);
 549         }
 550 }
 551
 552
 553 static void
 554 bridge_member_add_extra_vlans(struct bridge_member *bm)
 555 {
 556         struct device *dev = bm->dev.dev;
 557         int i;
 558
 559         for (i = 0; i < dev->n_extra_vlan; i++)
 560                 system_bridge_vlan(dev->ifname, dev->extra_vlan[i].start,
 561                                    dev->extra_vlan[i].end, true, 0);
 562         for (i = 0; i < bm->n_extra_vlan; i++)
 563                 system_bridge_vlan(dev->ifname, bm->extra_vlan[i].start,
 564                                    bm->extra_vlan[i].end, true, 0);
 565 }
 566
 567 static void
 568 bridge_member_enable_vlans(struct bridge_member *bm)
 569 {
 570         struct bridge_state *bst = bm->bst;
 571         struct device *dev = bm->dev.dev;
 572         struct bridge_vlan *vlan;
 573
 574         if (dev->settings.auth) {
 575                 bridge_hotplug_set_member_vlans(bst, dev->config_auth_vlans, bm,
 576                                                 !dev->auth_status, true);
 577                 bridge_hotplug_set_member_vlans(bst, dev->auth_vlans, bm,
 578                                                 dev->auth_status, true);
 579         }
 580
 581         if (dev->settings.auth && !dev->auth_status)
 582                 return;
 583
 584         bridge_member_add_extra_vlans(bm);
 585         vlist_for_each_element(&bst->dev.vlans, vlan, node)
 586                 bridge_set_member_vlan(bm, vlan, true);
 587 }
 588
 589 static int
 590 bridge_enable_member(struct bridge_member *bm)
 591 {
 592         struct bridge_state *bst = bm->bst;
 593         struct device *dev;
 594         int ret;
 595
 596         if (!bm->present)
 597                 return 0;
 598
 599         ret = bridge_enable_interface(bst);
 600         if (ret)
 601                 goto error;
 602
 603         /* Disable IPv6 for bridge members */
 604         if (!(bm->dev.dev->settings.flags & DEV_OPT_IPV6)) {
 605                 bm->dev.dev->settings.ipv6 = 0;
 606                 bm->dev.dev->settings.flags |= DEV_OPT_IPV6;
 607         }
 608
 609         ret = device_claim(&bm->dev);
 610         if (ret < 0)
 611                 goto error;
 612
 613         dev = bm->dev.dev;
 614         if (dev->settings.auth && !bst->has_vlans && !dev->auth_status)
 615                 return -1;
 616
 617         if (!bm->active) {
 618                 ret = system_bridge_addif(&bst->dev, bm->dev.dev);
 619                 if (ret < 0) {
 620                         D(DEVICE, "Bridge device %s could not be added\n", bm->dev.dev->ifname);
 621                         goto error;
 622                 }
 623
 624                 bm->active = true;
 625         }
 626
 627         if (bst->has_vlans) {
 628                 /* delete default VLAN 1 */
 629                 system_bridge_vlan(bm->dev.dev->ifname, 1, -1, false, 0);
 630
 631                 bridge_member_enable_vlans(bm);
 632         }
 633
 634         device_set_present(&bst->dev, true);
 635         if (!dev->settings.auth || dev->auth_status)
 636                 device_broadcast_event(&bst->dev, DEV_EVENT_TOPO_CHANGE);
 637
 638         return 0;
 639
 640 error:
 641         bst->n_failed++;
 642         bm->present = false;
 643         bst->n_present--;
 644         device_release(&bm->dev);
 645
 646         return ret;
 647 }
 648
 649 static void
 650 bridge_remove_member(struct bridge_member *bm)
 651 {
 652         struct bridge_state *bst = bm->bst;
 653
 654         if (!bm->present)
 655                 return;
 656
 657         if (bst->dev.active)
 658                 bridge_disable_member(bm, false);
 659
 660         bm->present = false;
 661         bm->bst->n_present--;
 662
 663         if (bm == bst->primary_port)
 664                 bridge_reset_primary(bst);
 665
 666         if (bst->config.bridge_empty)
 667                 return;
 668
 669         bst->force_active = false;
 670         if (bst->n_present == 0)
 671                 device_set_present(&bst->dev, false);
 672 }
 673
 674 static void
 675 bridge_free_member(struct bridge_member *bm)
 676 {
 677         struct bridge_state *bst = bm->bst;
 678         struct device *dev = bm->dev.dev;
 679         const char *ifname = dev->ifname;
 680         struct bridge_vlan *vlan;
 681
 682         bridge_remove_member(bm);
 683
 684 restart:
 685         vlist_for_each_element(&bst->dev.vlans, vlan, node) {
 686                 struct bridge_vlan_hotplug_port *port, *tmp;
 687                 bool free_port = false;
 688
 689                 list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list) {
 690                         if (strcmp(port->port.ifname, ifname) != 0)
 691                                 continue;
 692
 693                         list_del(&port->list);
 694                         free(port);
 695                         free_port = true;
 696                 }
 697
 698                 if (!free_port || !list_empty(&vlan->hotplug_ports) ||
 699                     vlan->n_ports || vlan->node.version != -1)
 700                         continue;
 701
 702                 vlist_delete(&bst->dev.vlans, &vlan->node);
 703                 goto restart;
 704         }
 705
 706         device_remove_user(&bm->dev);
 707         uloop_timeout_cancel(&bm->check_timer);
 708
 709         /*
 710          * When reloading the config and moving a device from one bridge to
 711          * another, the other bridge may have tried to claim this device
 712          * before it was removed here.
 713          * Ensure that claiming the device is retried by toggling its present
 714          * state
 715          */
 716         if (dev->present) {
 717                 device_set_present(dev, false);
 718                 device_set_present(dev, true);
 719         }
 720
 721         free(bm);
 722 }
 723
 724 static void
 725 bridge_check_retry(struct bridge_state *bst)
 726 {
 727         if (!bst->n_failed)
 728                 return;
 729
 730         uloop_timeout_set(&bst->retry, 100);
 731 }
 732
 733 static void
 734 bridge_member_check_cb(struct uloop_timeout *t)
 735 {
 736         struct bridge_member *bm;
 737         struct bridge_state *bst;
 738
 739         bm = container_of(t, struct bridge_member, check_timer);
 740         bst = bm->bst;
 741
 742         if (system_bridge_vlan_check(&bst->dev, bm->dev.dev->ifname) <= 0)
 743                 return;
 744
 745         bridge_disable_member(bm, true);
 746         bridge_enable_member(bm);
 747 }
 748
 749 static void
 750 bridge_member_cb(struct device_user *dep, enum device_event ev)
 751 {
 752         struct bridge_member *bm = container_of(dep, struct bridge_member, dev);
 753         struct bridge_state *bst = bm->bst;
 754         struct device *dev = dep->dev;
 755
 756         switch (ev) {
 757         case DEV_EVENT_ADD:
 758                 assert(!bm->present);
 759
 760                 bm->present = true;
 761                 bst->n_present++;
 762
 763                 if (bst->n_present == 1)
 764                         device_set_present(&bst->dev, true);
 765                 fallthrough;
 766         case DEV_EVENT_AUTH_UP:
 767                 if (!bst->dev.active)
 768                         break;
 769
 770                 if (bridge_enable_member(bm))
 771                         break;
 772
 773                 /*
 774                  * Adding a bridge member can overwrite the bridge mtu
 775                  * in the kernel, apply the bridge settings in case the
 776                  * bridge mtu is set
 777                  */
 778                 system_if_apply_settings(&bst->dev, &bst->dev.settings,
 779                                          DEV_OPT_MTU | DEV_OPT_MTU6);
 780                 break;
 781         case DEV_EVENT_LINK_UP:
 782                 if (!bst->has_vlans)
 783                         break;
 784
 785                 if (dev->settings.auth)
 786                         bridge_enable_member(bm);
 787
 788                 uloop_timeout_set(&bm->check_timer, 1000);
 789                 break;
 790         case DEV_EVENT_LINK_DOWN:
 791                 if (!dev->settings.auth)
 792                         break;
 793
 794                 bridge_disable_member(bm, true);
 795                 break;
 796         case DEV_EVENT_REMOVE:
 797                 if (dep->hotplug) {
 798                         vlist_delete(&bst->members, &bm->node);
 799                         return;
 800                 }
 801
 802                 if (bm->present)
 803                         bridge_remove_member(bm);
 804
 805                 break;
 806         default:
 807                 return;
 808         }
 809 }
 810
 811 static int
 812 bridge_set_down(struct bridge_state *bst)
 813 {
 814         struct bridge_member *bm;
 815
 816         bst->set_state(&bst->dev, false);
 817
 818         vlist_for_each_element(&bst->members, bm, node)
 819                 bridge_disable_member(bm, false);
 820
 821         bridge_disable_interface(bst);
 822
 823         return 0;
 824 }
 825
 826 static int
 827 bridge_set_up(struct bridge_state *bst)
 828 {
 829         struct bridge_member *bm;
 830         int ret;
 831
 832         bst->has_vlans = !avl_is_empty(&bst->dev.vlans.avl);
 833         if (!bst->n_present) {
 834                 if (!bst->force_active)
 835                         return -ENOENT;
 836
 837                 ret = bridge_enable_interface(bst);
 838                 if (ret)
 839                         return ret;
 840         }
 841
 842         bst->n_failed = 0;
 843         vlist_for_each_element(&bst->members, bm, node)
 844                 bridge_enable_member(bm);
 845         bridge_check_retry(bst);
 846
 847         if (!bst->force_active && !bst->n_present) {
 848                 /* initialization of all member interfaces failed */
 849                 bridge_disable_interface(bst);
 850                 device_set_present(&bst->dev, false);
 851                 return -ENOENT;
 852         }
 853
 854         bridge_reset_primary(bst);
 855         ret = bst->set_state(&bst->dev, true);
 856         if (ret < 0)
 857                 bridge_set_down(bst);
 858
 859         return ret;
 860 }
 861
 862 static int
 863 bridge_set_state(struct device *dev, bool up)
 864 {
 865         struct bridge_state *bst;
 866
 867         bst = container_of(dev, struct bridge_state, dev);
 868
 869         if (up)
 870                 return bridge_set_up(bst);
 871         else
 872                 return bridge_set_down(bst);
 873 }
 874
 875 static struct bridge_member *
 876 bridge_alloc_member(struct bridge_state *bst, const char *name,
 877                     struct device *dev, bool hotplug)
 878 {
 879         struct bridge_member *bm;
 880
 881         bm = calloc(1, sizeof(*bm) + strlen(name) + 1);
 882         if (!bm)
 883                 return NULL;
 884
 885         bm->bst = bst;
 886         bm->dev.cb = bridge_member_cb;
 887         bm->dev.hotplug = hotplug;
 888         bm->check_timer.cb = bridge_member_check_cb;
 889         strcpy(bm->name, name);
 890         bm->dev.dev = dev;
 891
 892         return bm;
 893 }
 894
 895 static void bridge_insert_member(struct bridge_member *bm, const char *name)
 896 {
 897         struct bridge_state *bst = bm->bst;
 898         bool hotplug = bm->dev.hotplug;
 899
 900         vlist_add(&bst->members, &bm->node, bm->name);
 901         /*
 902          * Need to look up the bridge member again as the above
 903          * created pointer will be freed in case the bridge member
 904          * already existed
 905          */
 906         bm = vlist_find(&bst->members, name, bm, node);
 907         if (hotplug && bm)
 908                 bm->node.version = -1;
 909 }
 910
 911 static void
 912 bridge_create_member(struct bridge_state *bst, const char *name,
 913                      struct device *dev, bool hotplug)
 914 {
 915         struct bridge_member *bm;
 916
 917         bm = bridge_alloc_member(bst, name, dev, hotplug);
 918         if (bm)
 919                 bridge_insert_member(bm, name);
 920 }
 921
 922 static void
 923 bridge_member_update(struct vlist_tree *tree, struct vlist_node *node_new,
 924                      struct vlist_node *node_old)
 925 {
 926         struct bridge_member *bm;
 927         struct device *dev;
 928
 929         if (node_new) {
 930                 bm = container_of(node_new, struct bridge_member, node);
 931
 932                 if (node_old) {
 933                         free(bm);
 934                         return;
 935                 }
 936
 937                 dev = bm->dev.dev;
 938                 bm->dev.dev = NULL;
 939                 device_add_user(&bm->dev, dev);
 940         }
 941
 942
 943         if (node_old) {
 944                 bm = container_of(node_old, struct bridge_member, node);
 945                 bridge_free_member(bm);
 946         }
 947 }
 948
 949
 950 static void
 951 bridge_add_member(struct bridge_state *bst, const char *name)
 952 {
 953         struct device *dev;
 954
 955         dev = device_get(name, true);
 956         if (!dev)
 957                 return;
 958
 959         bridge_create_member(bst, name, dev, false);
 960 }
 961
 962 static int
 963 bridge_hotplug_add(struct device *dev, struct device *member, struct blob_attr *vlan)
 964 {
 965         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 966         struct bridge_member *bm;
 967         bool new_entry = false;
 968
 969         bm = vlist_find(&bst->members, member->ifname, bm, node);
 970         if (!bm) {
 971             new_entry = true;
 972             bm = bridge_alloc_member(bst, member->ifname, member, true);
 973         }
 974         bridge_hotplug_set_member_vlans(bst, vlan, bm, true, false);
 975         if (new_entry)
 976                 bridge_insert_member(bm, member->ifname);
 977
 978         return 0;
 979 }
 980
 981 static int
 982 bridge_hotplug_del(struct device *dev, struct device *member, struct blob_attr *vlan)
 983 {
 984         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
 985         struct bridge_member *bm;
 986
 987         bm = vlist_find(&bst->members, member->ifname, bm, node);
 988         if (!bm)
 989                 return UBUS_STATUS_NOT_FOUND;
 990
 991         bridge_hotplug_set_member_vlans(bst, vlan, bm, false, false);
 992         if (!bm->dev.hotplug)
 993                 return 0;
 994
 995         vlist_delete(&bst->members, &bm->node);
 996         return 0;
 997 }
 998
 999 static int
1000 bridge_hotplug_prepare(struct device *dev, struct device **bridge_dev)
1001 {
1002         struct bridge_state *bst;
1003
1004         if (bridge_dev)
1005                 *bridge_dev = dev;
1006
1007         bst = container_of(dev, struct bridge_state, dev);
1008         bst->force_active = true;
1009         device_set_present(&bst->dev, true);
1010
1011         return 0;
1012 }
1013
1014 static const struct device_hotplug_ops bridge_ops = {
1015         .prepare = bridge_hotplug_prepare,
1016         .add = bridge_hotplug_add,
1017         .del = bridge_hotplug_del
1018 };
1019
1020 static void
1021 bridge_free(struct device *dev)
1022 {
1023         struct bridge_state *bst;
1024
1025         bst = container_of(dev, struct bridge_state, dev);
1026         vlist_flush_all(&bst->members);
1027         vlist_flush_all(&dev->vlans);
1028         kvlist_free(&dev->vlan_aliases);
1029         free(bst->config_data);
1030         free(bst);
1031 }
1032
1033 static void
1034 bridge_dump_port(struct blob_buf *b, struct bridge_vlan_port *port)
1035 {
1036         bool tagged = !(port->flags & BRVLAN_F_UNTAGGED);
1037         bool pvid = (port->flags & BRVLAN_F_PVID);
1038
1039         blobmsg_printf(b, NULL, "%s%s%s%s", port->ifname,
1040                 tagged || pvid ? ":" : "",
1041                 tagged ? "t" : "",
1042                 pvid ? "*" : "");
1043 }
1044
1045 static void
1046 bridge_dump_vlan(struct blob_buf *b, struct bridge_vlan *vlan)
1047 {
1048         struct bridge_vlan_hotplug_port *port;
1049         void *c, *p;
1050         int i;
1051
1052         c = blobmsg_open_table(b, NULL);
1053
1054         blobmsg_add_u32(b, "id", vlan->vid);
1055         blobmsg_add_u8(b, "local", vlan->local);
1056
1057         p = blobmsg_open_array(b, "ports");
1058
1059         for (i = 0; i < vlan->n_ports; i++)
1060             bridge_dump_port(b, &vlan->ports[i]);
1061
1062         list_for_each_entry(port, &vlan->hotplug_ports, list)
1063                 bridge_dump_port(b, &port->port);
1064
1065         blobmsg_close_array(b, p);
1066
1067         blobmsg_close_table(b, c);
1068 }
1069
1070 static void
1071 bridge_dump_info(struct device *dev, struct blob_buf *b)
1072 {
1073         struct bridge_config *cfg;
1074         struct bridge_state *bst;
1075         struct bridge_member *bm;
1076         struct bridge_vlan *vlan;
1077         void *list;
1078         void *c;
1079
1080         bst = container_of(dev, struct bridge_state, dev);
1081         cfg = &bst->config;
1082
1083         system_if_dump_info(dev, b);
1084         list = blobmsg_open_array(b, "bridge-members");
1085
1086         vlist_for_each_element(&bst->members, bm, node) {
1087                 if (bm->dev.dev->hidden)
1088                         continue;
1089
1090                 blobmsg_add_string(b, NULL, bm->dev.dev->ifname);
1091         }
1092
1093         blobmsg_close_array(b, list);
1094
1095         c = blobmsg_open_table(b, "bridge-attributes");
1096
1097         blobmsg_add_u8(b, "stp", cfg->stp);
1098         blobmsg_add_u32(b, "forward_delay", cfg->forward_delay);
1099         blobmsg_add_u32(b, "priority", cfg->priority);
1100         blobmsg_add_u32(b, "ageing_time", cfg->ageing_time);
1101         blobmsg_add_u32(b, "hello_time", cfg->hello_time);
1102         blobmsg_add_u32(b, "max_age", cfg->max_age);
1103         blobmsg_add_u8(b, "igmp_snooping", cfg->igmp_snoop);
1104         blobmsg_add_u8(b, "bridge_empty", cfg->bridge_empty);
1105         blobmsg_add_u8(b, "multicast_querier", cfg->multicast_querier);
1106         blobmsg_add_u32(b, "hash_max", cfg->hash_max);
1107         blobmsg_add_u32(b, "robustness", cfg->robustness);
1108         blobmsg_add_u32(b, "query_interval", cfg->query_interval);
1109         blobmsg_add_u32(b, "query_response_interval", cfg->query_response_interval);
1110         blobmsg_add_u32(b, "last_member_interval", cfg->last_member_interval);
1111         blobmsg_add_u8(b, "vlan_filtering", cfg->vlan_filtering);
1112         blobmsg_add_u8(b, "stp_kernel", cfg->stp_kernel);
1113         if (cfg->stp_proto)
1114                 blobmsg_add_string(b, "stp_proto", cfg->stp_proto);
1115
1116         blobmsg_close_table(b, c);
1117
1118         if (avl_is_empty(&dev->vlans.avl))
1119                 return;
1120
1121         list = blobmsg_open_array(b, "bridge-vlans");
1122
1123         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1124                 bridge_dump_vlan(b, vlan);
1125
1126         blobmsg_close_array(b, list);
1127 }
1128
1129 static void
1130 bridge_config_init(struct device *dev)
1131 {
1132         struct bridge_state *bst;
1133         struct bridge_vlan *vlan;
1134         struct blob_attr *cur;
1135         size_t rem;
1136         int i;
1137
1138         bst = container_of(dev, struct bridge_state, dev);
1139
1140         if (bst->config.bridge_empty) {
1141                 bst->force_active = true;
1142                 device_set_present(&bst->dev, true);
1143         }
1144
1145         bst->n_failed = 0;
1146         vlist_update(&bst->members);
1147         if (bst->ports) {
1148                 blobmsg_for_each_attr(cur, bst->ports, rem) {
1149                         bridge_add_member(bst, blobmsg_data(cur));
1150                 }
1151         }
1152
1153         vlist_for_each_element(&bst->dev.vlans, vlan, node)
1154                 for (i = 0; i < vlan->n_ports; i++)
1155                         bridge_add_member(bst, vlan->ports[i].ifname);
1156
1157         vlist_flush(&bst->members);
1158         bridge_check_retry(bst);
1159 }
1160
1161 static void
1162 bridge_apply_settings(struct bridge_state *bst, struct blob_attr **tb)
1163 {
1164         struct bridge_config *cfg = &bst->config;
1165         struct blob_attr *cur;
1166
1167         /* defaults */
1168         memset(cfg, 0, sizeof(*cfg));
1169         cfg->stp = false;
1170         cfg->stp_kernel = false;
1171         cfg->robustness = 2;
1172         cfg->igmp_snoop = false;
1173         cfg->multicast_querier = false;
1174         cfg->query_interval = 12500;
1175         cfg->query_response_interval = 1000;
1176         cfg->last_member_interval = 100;
1177         cfg->hash_max = 512;
1178         cfg->bridge_empty = false;
1179         cfg->priority = 0x7FFF;
1180         cfg->vlan_filtering = false;
1181
1182         cfg->forward_delay = 8;
1183         cfg->max_age = 10;
1184         cfg->hello_time = 1;
1185
1186         if ((cur = tb[BRIDGE_ATTR_STP]))
1187                 cfg->stp = blobmsg_get_bool(cur);
1188
1189         if ((cur = tb[BRIDGE_ATTR_STP_KERNEL]))
1190                 cfg->stp = blobmsg_get_bool(cur);
1191
1192         if ((cur = tb[BRIDGE_ATTR_STP_PROTO]))
1193                 cfg->stp_proto = blobmsg_get_string(cur);
1194
1195         if ((cur = tb[BRIDGE_ATTR_FORWARD_DELAY]))
1196                 cfg->forward_delay = blobmsg_get_u32(cur);
1197
1198         if ((cur = tb[BRIDGE_ATTR_PRIORITY]))
1199                 cfg->priority = blobmsg_get_u32(cur);
1200
1201         if ((cur = tb[BRIDGE_ATTR_IGMP_SNOOP]))
1202                 cfg->multicast_querier = cfg->igmp_snoop = blobmsg_get_bool(cur);
1203
1204         if ((cur = tb[BRIDGE_ATTR_MULTICAST_QUERIER]))
1205                 cfg->multicast_querier = blobmsg_get_bool(cur);
1206
1207         if ((cur = tb[BRIDGE_ATTR_HASH_MAX]))
1208                 cfg->hash_max = blobmsg_get_u32(cur);
1209
1210         if ((cur = tb[BRIDGE_ATTR_ROBUSTNESS])) {
1211                 cfg->robustness = blobmsg_get_u32(cur);
1212                 cfg->flags |= BRIDGE_OPT_ROBUSTNESS;
1213         }
1214
1215         if ((cur = tb[BRIDGE_ATTR_QUERY_INTERVAL])) {
1216                 cfg->query_interval = blobmsg_get_u32(cur);
1217                 cfg->flags |= BRIDGE_OPT_QUERY_INTERVAL;
1218         }
1219
1220         if ((cur = tb[BRIDGE_ATTR_QUERY_RESPONSE_INTERVAL])) {
1221                 cfg->query_response_interval = blobmsg_get_u32(cur);
1222                 cfg->flags |= BRIDGE_OPT_QUERY_RESPONSE_INTERVAL;
1223         }
1224
1225         if ((cur = tb[BRIDGE_ATTR_LAST_MEMBER_INTERVAL])) {
1226                 cfg->last_member_interval = blobmsg_get_u32(cur);
1227                 cfg->flags |= BRIDGE_OPT_LAST_MEMBER_INTERVAL;
1228         }
1229
1230         if ((cur = tb[BRIDGE_ATTR_AGEING_TIME])) {
1231                 cfg->ageing_time = blobmsg_get_u32(cur);
1232                 cfg->flags |= BRIDGE_OPT_AGEING_TIME;
1233         }
1234
1235         if ((cur = tb[BRIDGE_ATTR_HELLO_TIME]))
1236                 cfg->hello_time = blobmsg_get_u32(cur);
1237
1238         if ((cur = tb[BRIDGE_ATTR_MAX_AGE]))
1239                 cfg->max_age = blobmsg_get_u32(cur);
1240
1241         if ((cur = tb[BRIDGE_ATTR_BRIDGE_EMPTY]))
1242                 cfg->bridge_empty = blobmsg_get_bool(cur);
1243
1244         if ((cur = tb[BRIDGE_ATTR_VLAN_FILTERING]))
1245                 cfg->vlan_filtering = blobmsg_get_bool(cur);
1246 }
1247
1248 static enum dev_change_type
1249 bridge_reload(struct device *dev, struct blob_attr *attr)
1250 {
1251         struct blob_attr *tb_dev[__DEV_ATTR_MAX];
1252         struct blob_attr *tb_br[__BRIDGE_ATTR_MAX];
1253         enum dev_change_type ret = DEV_CONFIG_APPLIED;
1254         struct bridge_state *bst;
1255         unsigned long diff[2] = {};
1256
1257         BUILD_BUG_ON(sizeof(diff) < __BRIDGE_ATTR_MAX / BITS_PER_LONG);
1258         BUILD_BUG_ON(sizeof(diff) < __DEV_ATTR_MAX / BITS_PER_LONG);
1259
1260         bst = container_of(dev, struct bridge_state, dev);
1261         attr = blob_memdup(attr);
1262
1263         blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, tb_dev,
1264                 blob_data(attr), blob_len(attr));
1265         blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, tb_br,
1266                 blob_data(attr), blob_len(attr));
1267
1268         if (tb_dev[DEV_ATTR_MACADDR])
1269                 bst->primary_port = NULL;
1270
1271         bst->ports = tb_br[BRIDGE_ATTR_PORTS];
1272         device_init_settings(dev, tb_dev);
1273         bridge_apply_settings(bst, tb_br);
1274
1275         if (bst->config_data) {
1276                 struct blob_attr *otb_dev[__DEV_ATTR_MAX];
1277                 struct blob_attr *otb_br[__BRIDGE_ATTR_MAX];
1278
1279                 blobmsg_parse(device_attr_list.params, __DEV_ATTR_MAX, otb_dev,
1280                         blob_data(bst->config_data), blob_len(bst->config_data));
1281
1282                 uci_blob_diff(tb_dev, otb_dev, &device_attr_list, diff);
1283                 if (diff[0] | diff[1]) {
1284                         ret = DEV_CONFIG_RESTART;
1285                         D(DEVICE, "Bridge %s device attributes have changed, diff=[%lx %lx]\n",
1286                           dev->ifname, diff[1], diff[0]);
1287                 }
1288
1289                 blobmsg_parse(bridge_attrs, __BRIDGE_ATTR_MAX, otb_br,
1290                         blob_data(bst->config_data), blob_len(bst->config_data));
1291
1292                 diff[0] = diff[1] = 0;
1293                 uci_blob_diff(tb_br, otb_br, &bridge_attr_list, diff);
1294                 if (diff[0] & ~(1 << BRIDGE_ATTR_PORTS)) {
1295                         ret = DEV_CONFIG_RESTART;
1296                         D(DEVICE, "Bridge %s attributes have changed, diff=[%lx %lx]\n",
1297                           dev->ifname, diff[1], diff[0]);
1298                 }
1299
1300                 bridge_config_init(dev);
1301         }
1302
1303         free(bst->config_data);
1304         bst->config_data = attr;
1305         return ret;
1306 }
1307
1308 static void
1309 bridge_retry_members(struct uloop_timeout *timeout)
1310 {
1311         struct bridge_state *bst = container_of(timeout, struct bridge_state, retry);
1312         struct bridge_member *bm;
1313
1314         bst->n_failed = 0;
1315         vlist_for_each_element(&bst->members, bm, node) {
1316                 if (bm->present)
1317                         continue;
1318
1319                 if (!bm->dev.dev->present)
1320                         continue;
1321
1322                 bm->present = true;
1323                 bst->n_present++;
1324                 bridge_enable_member(bm);
1325         }
1326 }
1327
1328 static int bridge_avl_cmp_u16(const void *k1, const void *k2, void *ptr)
1329 {
1330         const uint16_t *i1 = k1, *i2 = k2;
1331
1332         return *i1 - *i2;
1333 }
1334
1335 static bool
1336 bridge_vlan_equal(struct bridge_vlan *v1, struct bridge_vlan *v2)
1337 {
1338         int i;
1339
1340         if (v1->n_ports != v2->n_ports)
1341                 return false;
1342
1343         for (i = 0; i < v1->n_ports; i++)
1344                 if (v1->ports[i].flags != v2->ports[i].flags ||
1345                     strcmp(v1->ports[i].ifname, v2->ports[i].ifname) != 0)
1346                         return false;
1347
1348         return true;
1349 }
1350
1351 static void
1352 bridge_vlan_free(struct bridge_vlan *vlan)
1353 {
1354         struct bridge_vlan_hotplug_port *port, *tmp;
1355
1356         if (!vlan)
1357                 return;
1358
1359         list_for_each_entry_safe(port, tmp, &vlan->hotplug_ports, list)
1360                 free(port);
1361
1362         free(vlan);
1363 }
1364
1365 static void
1366 bridge_vlan_update(struct vlist_tree *tree, struct vlist_node *node_new,
1367                    struct vlist_node *node_old)
1368 {
1369         struct bridge_state *bst = container_of(tree, struct bridge_state, dev.vlans);
1370         struct bridge_vlan *vlan_new = NULL, *vlan_old = NULL;
1371
1372         if (!bst->has_vlans || !bst->active)
1373                 goto out;
1374
1375         if (node_old)
1376                 vlan_old = container_of(node_old, struct bridge_vlan, node);
1377         if (node_new)
1378                 vlan_new = container_of(node_new, struct bridge_vlan, node);
1379
1380         if (node_new && node_old && bridge_vlan_equal(vlan_old, vlan_new)) {
1381                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1382                 goto out;
1383         }
1384
1385         if (node_old)
1386                 bridge_set_vlan_state(bst, vlan_old, false);
1387
1388         if (node_old && node_new)
1389                 list_splice_init(&vlan_old->hotplug_ports, &vlan_new->hotplug_ports);
1390
1391         if (node_new)
1392                 vlan_new->pending = true;
1393
1394         bst->dev.config_pending = true;
1395
1396 out:
1397         bridge_vlan_free(vlan_old);
1398 }
1399
1400 static void
1401 bridge_dev_vlan_update(struct device *dev)
1402 {
1403         struct bridge_state *bst = container_of(dev, struct bridge_state, dev);
1404         struct bridge_vlan *vlan;
1405
1406         vlist_for_each_element(&dev->vlans, vlan, node) {
1407                 if (!vlan->pending)
1408                         continue;
1409
1410                 vlan->pending = false;
1411                 bridge_set_vlan_state(bst, vlan, true);
1412         }
1413 }
1414
1415 static struct device *
1416 bridge_create(const char *name, struct device_type *devtype,
1417         struct blob_attr *attr)
1418 {
1419         struct bridge_state *bst;
1420         struct device *dev = NULL;
1421
1422         bst = calloc(1, sizeof(*bst));
1423         if (!bst)
1424                 return NULL;
1425
1426         dev = &bst->dev;
1427
1428         if (device_init(dev, devtype, name) < 0) {
1429                 device_cleanup(dev);
1430                 free(bst);
1431                 return NULL;
1432         }
1433
1434         dev->config_pending = true;
1435         bst->retry.cb = bridge_retry_members;
1436
1437         bst->set_state = dev->set_state;
1438         dev->set_state = bridge_set_state;
1439
1440         dev->hotplug_ops = &bridge_ops;
1441
1442         vlist_init(&bst->members, avl_strcmp, bridge_member_update);
1443         bst->members.keep_old = true;
1444
1445         vlist_init(&dev->vlans, bridge_avl_cmp_u16, bridge_vlan_update);
1446
1447         bridge_reload(dev, attr);
1448
1449         return dev;
1450 }
1451
1452 static void __init bridge_device_type_init(void)
1453 {
1454         device_type_add(&bridge_device_type);
1455 }