mount: change mount_dev_del() argument to struct mount *
authorRafał Miłecki <rafal@milecki.pl>
Fri, 9 Feb 2018 15:21:49 +0000 (16:21 +0100)
committerRafał Miłecki <rafal@milecki.pl>
Mon, 12 Feb 2018 09:52:16 +0000 (10:52 +0100)
Caller of mount_dev_del() already has struct mount * so there is no
point in passing matchin device and then looking for struct mount *
again.

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
mount.c

diff --git a/mount.c b/mount.c
index f995745eb2c07b51de7ebae21812370f67caaeec..646cc30fedc506b965c693fea64566fa7d128b8f 100644 (file)
--- a/mount.c
+++ b/mount.c
@@ -567,23 +567,19 @@ static void mount_dev_add(char *dev)
        }
 }
 
-static void mount_dev_del(char *dev)
+static void mount_dev_del(struct mount *mount)
 {
-       struct mount *mount = mount_find(0, dev);
        char tmp[256];
-       if(mount)
-       {
-               if(mount->mounted)
-               {
-                       snprintf(tmp, 256, "%s%s", "/tmp/run/mountd/", mount->name);
-                       log_printf("%s has dissappeared ... unmounting\n", tmp);
-                       snprintf(tmp, 256, "%s%s", "/tmp/run/mountd/", mount->dev);
-                       system_printf("/bin/umount %s", tmp);
-                       rmdir(tmp);
-                       snprintf(tmp, 64, "%s%s", uci_path, mount->name);
-                       unlink(tmp);
-                       mount_dump_uci_state();
-               }
+
+       if (mount->mounted) {
+               snprintf(tmp, 256, "%s%s", "/tmp/run/mountd/", mount->name);
+               log_printf("%s has dissappeared ... unmounting\n", tmp);
+               snprintf(tmp, 256, "%s%s", "/tmp/run/mountd/", mount->dev);
+               system_printf("/bin/umount %s", tmp);
+               rmdir(tmp);
+               snprintf(tmp, 64, "%s%s", uci_path, mount->name);
+               unlink(tmp);
+               mount_dump_uci_state();
        }
 }
 
@@ -748,7 +744,7 @@ static void mount_enum_drives(void)
                }
                if(!check_block(q->dev)||del)
                {
-                       mount_dev_del(q->dev);
+                       mount_dev_del(q);
                        p->prev->next = p->next;
                        p->next->prev = p->prev;
                        p = p->next;