utils: replace sprintf use with snprintf to avoid overflows

[project/firewall3.git] / forwards.c

diff --git a/forwards.c b/forwards.c
index 6f950520fd37f0f3d004a766e8a9878415ba697f..997c30712614373ae3b8f9fd94b02cdc2f8ebc2a 100644 (file)
--- a/forwards.c
+++ b/forwards.c
@@ -83,21 +83,18 @@ fw3_load_forwards(struct fw3_state *state, struct uci_package *p)
                        continue;
                }
 
+               list_add_tail(&forward->list, &state->forwards);
+               continue;
+       }
+
+       list_for_each_entry(forward, &state->forwards, list)
+       {
                /* NB: forward family... */
                if (forward->_dest)
                {
                        fw3_setbit(forward->_dest->flags[0], FW3_FLAG_ACCEPT);
                        fw3_setbit(forward->_dest->flags[1], FW3_FLAG_ACCEPT);
-
-                       if (forward->_src &&
-                           (forward->_src->conntrack || forward->_dest->conntrack))
-                       {
-                               forward->_src->conntrack = forward->_dest->conntrack = true;
-                       }
                }
-
-               list_add_tail(&forward->list, &state->forwards);
-               continue;
        }
 }