From: Alexander Couzens Date: Sun, 11 Jun 2017 11:43:55 +0000 (+0200) Subject: ar71xx/ar93xx_wmac_otp_read_word: fix wrongly used sizeof(*u) X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fstaging%2Fdedeckeh.git;a=commitdiff_plain;h=ab116180016dff282e5ad8104b859cc2bca3d5e0 ar71xx/ar93xx_wmac_otp_read_word: fix wrongly used sizeof(*u) Found-by: Coverity Scan #1330474 Signed-off-by: Alexander Couzens --- diff --git a/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch b/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch index 6778183f78..fa5681b746 100644 --- a/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch +++ b/target/linux/ar71xx/patches-4.4/523-MIPS-ath79-OTP-support.patch @@ -111,8 +111,8 @@ + + BUG_ON(!soc_is_ar933x() && !soc_is_ar934x()); + base = ioremap_nocache(AR93XX_WMAC_BASE, AR93XX_WMAC_SIZE); -+ while (addr > sizeof(hdr)) { -+ if (!ar93xx_wmac_otp_read(base, addr, hdr, sizeof(hdr))) ++ while (addr > sizeof(hdr_u32)) { ++ if (!ar93xx_wmac_otp_read(base, addr, hdr, sizeof(hdr_u32))) + break; + + if (hdr_u32 == 0 || hdr_u32 == ~0)