From: Sergey Ryazanov Date: Tue, 6 Jun 2017 22:25:32 +0000 (+0300) Subject: ip17xx: correct aneg_done return value X-Git-Tag: v17.01.5~210 X-Git-Url: http://git.openwrt.org/?p=openwrt%2Fopenwrt.git;a=commitdiff_plain;h=13a5568d6edc15338d20e279eaf7dfb271cd73b0 ip17xx: correct aneg_done return value PHY core treats any positive return value as the auto-negotiation done indication. Since we do not actually check any device register in this callback then update it to return positive value with a neutral meaning instead of the register flag to avoid confusing for future readers. Signed-off-by: Sergey Ryazanov (cherry picked from commit 2cc61e6e8e951b1480a024fdb66bc539aa163bbc) --- diff --git a/target/linux/generic/files/drivers/net/phy/ip17xx.c b/target/linux/generic/files/drivers/net/phy/ip17xx.c index a4fe53dc5b..dbb867e30e 100644 --- a/target/linux/generic/files/drivers/net/phy/ip17xx.c +++ b/target/linux/generic/files/drivers/net/phy/ip17xx.c @@ -1334,7 +1334,7 @@ static int ip17xx_config_aneg(struct phy_device *pdev) static int ip17xx_aneg_done(struct phy_device *pdev) { - return BMSR_ANEGCOMPLETE; + return 1; /* Return any positive value */ } static int ip17xx_update_link(struct phy_device *pdev)