From: Olliver Schinagl Date: Wed, 31 Aug 2022 15:20:52 +0000 (+0200) Subject: realtek: rtl838x: Fix ethernet polling timeout on probe X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=c4d030f24cff34737d7cf1f116022b8dbe45f5be;p=openwrt%2Fstaging%2Fjow.git realtek: rtl838x: Fix ethernet polling timeout on probe Due to an oversight we accidentally inverted the timeout check. This patch corrects this. Fixes: 9cec4a0ea45b ("realtek: Use built-in functionality for timeout loop") Signed-off-by: Olliver Schinagl [ wrap poll_timeout line to 80 char ] Signed-off-by: Christian Marangi --- diff --git a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c index f56901d707..76b6cde7be 100644 --- a/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c +++ b/target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/rtl838x.c @@ -1809,7 +1809,8 @@ int rtl838x_smi_wait_op(int timeout) int ret = 0; u32 val; - ret = readx_poll_timeout(sw_r32, RTL838X_SMI_ACCESS_PHY_CTRL_1, val, val & 0x1, 20, timeout); + ret = readx_poll_timeout(sw_r32, RTL838X_SMI_ACCESS_PHY_CTRL_1, + val, !(val & 0x1), 20, timeout); if (ret) pr_err("%s: timeout\n", __func__);