From: Petr Štetiar <ynezz@true.cz>
Date: Tue, 8 Dec 2020 16:41:44 +0000 (+0100)
Subject: uclient: fix initialized but never read variable
X-Git-Url: http://git.openwrt.org/?a=commitdiff_plain;h=158dd9dd289ca3fe1feb1c580ab2a8014d2ffb78;hp=66b4420856a7eb2c5a9f9a7acdb7e796ed807b17;p=project%2Fuclient.git

uclient: fix initialized but never read variable

Fixes following issue reported by clang-12 static analyzer:

 uclient.c:290:22: warning: Value stored to 'url' during its initialization is never read [deadcode.DeadStores]
         struct uclient_url *url = cl->url;
                             ^~~   ~~~~~~~

Signed-off-by: Petr Štetiar <ynezz@true.cz>
---

diff --git a/uclient.c b/uclient.c
index 95e4585..a372d4a 100644
--- a/uclient.c
+++ b/uclient.c
@@ -287,7 +287,7 @@ int uclient_set_proxy_url(struct uclient *cl, const char *url_str, const char *a
 int uclient_set_url(struct uclient *cl, const char *url_str, const char *auth_str)
 {
 	const struct uclient_backend *backend = cl->backend;
-	struct uclient_url *url = cl->url;
+	struct uclient_url *url;
 
 	url = uclient_get_url(url_str, auth_str);
 	if (!url)