kernel: ar8216: remove soft_reset
authorDavid Bauer <mail@david-bauer.net>
Wed, 2 Jun 2021 21:46:06 +0000 (23:46 +0200)
committerDavid Bauer <mail@david-bauer.net>
Wed, 2 Jun 2021 22:00:55 +0000 (00:00 +0200)
ar8xxx_soft_reset is effectively a NOP function. In the PHY state
machine, the availability and result of a soft_reset function
makes no difference for the code flow.

Thus, we can safely remove this method.

Signed-off-by: David Bauer <mail@david-bauer.net>
target/linux/generic/files/drivers/net/phy/ar8216.c

index dbcb1c41c414029f91c5673d0af1105832eea0d8..11cb18e4f3c76a1b7f50db4e6ac1d75ae284c1e9 100644 (file)
@@ -2731,13 +2731,6 @@ ar8xxx_phy_remove(struct phy_device *phydev)
        ar8xxx_free(priv);
 }
 
-static int
-ar8xxx_phy_soft_reset(struct phy_device *phydev)
-{
-       /* we don't need an extra reset */
-       return 0;
-}
-
 static struct phy_driver ar8xxx_phy_driver[] = {
        {
                .phy_id         = 0x004d0000,
@@ -2749,7 +2742,6 @@ static struct phy_driver ar8xxx_phy_driver[] = {
                .config_init    = ar8xxx_phy_config_init,
                .config_aneg    = ar8xxx_phy_config_aneg,
                .read_status    = ar8xxx_phy_read_status,
-               .soft_reset     = ar8xxx_phy_soft_reset,
                .get_features   = ar8xxx_get_features,
        }
 };