mariadb: Add shellcheck disable into init script
authorMichal Hrusecky <michal.hrusecky@turris.com>
Fri, 2 Oct 2020 08:34:21 +0000 (10:34 +0200)
committerMichal Hrusecky <michal.hrusecky@turris.com>
Fri, 2 Oct 2020 08:36:47 +0000 (10:36 +0200)
On few places, shellcheck gets confused by how some OpenWrt functions
work - especially load ones. Also on few places there are $options
variables that need not to be globbed. Could be rewritten better not to
need them, but I'll do major rewrites later in separate pull request.

Signed-off-by: Michal Hrusecky <michal.hrusecky@turris.com>
utils/mariadb/files/mysqld.init

index 54fe53389e5c2bfe41a03fa8f66cb690d002d776..3e35389073f9b0c867cb6a11550bee3e81bf072c 100644 (file)
@@ -1,7 +1,9 @@
 #!/bin/sh /etc/rc.common
 # Copyright (C) 2010-2018 OpenWrt.org
 
+# shellcheck disable=SC2034
 START=95
+# shellcheck disable=SC2034
 STOP=10
 
 NAME=mysqld
@@ -78,6 +80,7 @@ start() {
        config_load "$NAME"
 
        config_get_bool enabled general enabled 0
+       # shellcheck disable=SC2154
        if [ "$enabled" -eq 0 ]; then
                $LOGGER "service not enabled in /etc/config/$NAME"
                exit 1
@@ -123,11 +126,12 @@ start() {
                                if [ "$i" = "$rundir" ]; then
                                        opts=
                                fi
+                               # shellcheck disable=SC2086
                                mkdir -p $opts "$i"
                                [ -d "$i" ] && chown mariadb:mariadb "$i"
                        fi
                done
-
+               # shellcheck disable=SC2154,SC2086
                "$MYSQLDSAFE" $options >/dev/null 2>&1 &
        fi
 }