realtek: simplify log messages in rtl83xx_mdio_probe
authorJan Hoffmann <jan@3e8.eu>
Sat, 17 Dec 2022 20:45:41 +0000 (21:45 +0100)
committerSander Vanheule <sander@svanheule.net>
Tue, 27 Dec 2022 15:29:57 +0000 (16:29 +0100)
This function currently prints three messages for every switch port at
KERN_INFO level. This takes a considerable amount of time during bootup
and can even trigger an external watchdog.

Replace these log messages by a single one at KERN_DEBUG level.

Signed-off-by: Jan Hoffmann <jan@3e8.eu>
target/linux/realtek/files-5.10/drivers/net/dsa/rtl83xx/common.c
target/linux/realtek/files-5.15/drivers/net/dsa/rtl83xx/common.c

index e86ff9ccdfed066733807312cf8e17c43cbe5e23..63c024c81e826216688d739b812c94e6d970c38d 100644 (file)
@@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
                if (of_property_read_u32(dn, "reg", &pn))
                        continue;
 
-               pr_info("%s found port %d\n", __func__, pn);
                phy_node = of_parse_phandle(dn, "phy-handle", 0);
                if (!phy_node) {
                        if (pn != priv->cpu_port)
@@ -331,14 +330,9 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
                        continue;
                }
 
-               pr_info("%s port %d has phandle\n", __func__, pn);
                if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num))
                        priv->ports[pn].sds_num = -1;
-               else {
-                       pr_info("%s sds port %d is %d\n", __func__, pn,
-                               priv->ports[pn].sds_num);
-               }
-               pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num);
+               pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num);
 
                if (of_get_phy_mode(dn, &interface))
                        interface = PHY_INTERFACE_MODE_NA;
index b5afed0ef5531ad3a0791050a7bfdf04f89356a4..8b0b55d891998ec8c33de55a87538061bcf58820 100644 (file)
@@ -323,7 +323,6 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
                if (of_property_read_u32(dn, "reg", &pn))
                        continue;
 
-               pr_info("%s found port %d\n", __func__, pn);
                phy_node = of_parse_phandle(dn, "phy-handle", 0);
                if (!phy_node) {
                        if (pn != priv->cpu_port)
@@ -331,14 +330,9 @@ static int __init rtl83xx_mdio_probe(struct rtl838x_switch_priv *priv)
                        continue;
                }
 
-               pr_info("%s port %d has phandle\n", __func__, pn);
                if (of_property_read_u32(phy_node, "sds", &priv->ports[pn].sds_num))
                        priv->ports[pn].sds_num = -1;
-               else {
-                       pr_info("%s sds port %d is %d\n", __func__, pn,
-                               priv->ports[pn].sds_num);
-               }
-               pr_info("%s port %d has SDS\n", __func__, priv->ports[pn].sds_num);
+               pr_debug("%s port %d has SDS %d\n", __func__, pn, priv->ports[pn].sds_num);
 
                if (of_get_phy_mode(dn, &interface))
                        interface = PHY_INTERFACE_MODE_NA;