lantiq: unify Fritz!Box LED mappings
authorDavid Bauer <mail@david-bauer.net>
Sun, 11 Aug 2019 21:37:24 +0000 (23:37 +0200)
committerDavid Bauer <mail@david-bauer.net>
Thu, 15 Aug 2019 12:25:51 +0000 (14:25 +0200)
This commit unifies the LED mapping of the AVM Fritz!Box routers, which
have a combined Power/DSL LED.

With the stock firmware, the Power LED has the following
characteristics:

 - Blink when DSL sync is being established
 - Solid when DSL sync is present

We can't completely resemble this behavior in OpenWrt. Currently, the
Power LED is completely off, when DSL sync is missing. This is not
really helpful, as a user might have the impression, that he bricked his
device.

Instead, map the Info-LED to the state of the DSL connection.
There is no consistent behavior for the Info-LED in the stock
firmware, as the user can set it's function by himself. The DSL
connection state is one possible option for the Info LED there.

Also use the red Power LED to indicate a running upgrade, in case the
board has a two-color Power LED.

Signed-off-by: David Bauer <mail@david-bauer.net>
target/linux/lantiq/files/arch/mips/boot/dts/FRITZ3370-REV2.dtsi
target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7312.dts
target/linux/lantiq/files/arch/mips/boot/dts/FRITZ7320.dts
target/linux/lantiq/files/arch/mips/boot/dts/FRITZ736X.dtsi

index f23d2d2cf5f3444ff49be46b82cd2042b5aa017a..02e95899697edf3ddd2b1de2e5ddc82f9ac71c76 100644 (file)
@@ -15,7 +15,7 @@
                led-boot = &power_green;
                led-failsafe = &power_red;
                led-running = &power_green;
-               led-upgrade = &power_green;
+               led-upgrade = &power_red;
 
                led-dsl = &dsl;
                led-internet = &info_green;
index 811f78f93465877560a058879bb8eabc08bbdfec..0190dd2f01aa999195165efef3a13ed182c5c60d 100644 (file)
@@ -18,8 +18,7 @@
                led-running = &power;
                led-upgrade = &power;
 
-               led-internet = &info_green;
-               led-dsl = &power;
+               led-dsl = &info_green;
                led-wifi = &wlan;
        };
 
index 40348b1d59fc8369591432bd56d8c51a12c90b8a..6c0dad873f80af9012b2f38f75dd429e026aced2 100644 (file)
@@ -18,8 +18,7 @@
                led-running = &power;
                led-upgrade = &power;
 
-               led-internet = &info_green;
-               led-dsl = &power;
+               led-dsl = &info_green;
                led-wifi = &wlan;
        };
 
index 82546a35724c498429868388bbcea6df76a2ccbc..57033eb4a92a34bc000a27d897c1192d33efd83f 100644 (file)
@@ -17,7 +17,8 @@
                led-boot = &power_green;
                led-failsafe = &power_red;
                led-running = &power_green;
-               led-upgrade = &power_green;
+               led-upgrade = &power_red;
+
                led-dsl = &info_green;
                led-wifi = &wifi;
        };