ola: fix build (linking issue TCPSocket::ReadDescriptor() const) 2127/head
authorAlexandru Ardelean <ardeleanalex@gmail.com>
Mon, 14 Dec 2015 21:58:19 +0000 (23:58 +0200)
committerAlexandru Ardelean <ardeleanalex@gmail.com>
Mon, 14 Dec 2015 22:03:20 +0000 (00:03 +0200)
Reported buildbot issue is:
/store/buildbot/slave/ar71xx/build/build_dir/target-mips_34kc_musl-1.1.11/ola-0.9.7/plugins/openpixelcontrol/.libs/libolaopenpixelcontrol.so: undefined reference to `ola::network::TCPSocket::ReadDescriptor() const'
collect2: error: ld returned 1 exit status

There's also a discussion (attempt) to fix this on the buildroot project:
  https://patchwork.ozlabs.org/patch/503884/

This bug has been reported (from the buildroot project), here:
  https://github.com/OpenLightingProject/ola/issues/880

This commit introduced the issue:
  https://github.com/OpenLightingProject/ola/commit/bfc1d99055980dfac5c959a7210257d1939803ec
specifically the `-fvisibility-inlines-hidden` switch.

So, until, the upstream project (ola) fixes this, this fix
looks like the quickest/simplest workaround to have this package build.

Signed-off-by: Alexandru Ardelean <ardeleanalex@gmail.com>
net/ola/patches/002-remove-visibility-inlines-hidden-flag.patch [new file with mode: 0644]

diff --git a/net/ola/patches/002-remove-visibility-inlines-hidden-flag.patch b/net/ola/patches/002-remove-visibility-inlines-hidden-flag.patch
new file mode 100644 (file)
index 0000000..fe1acdf
--- /dev/null
@@ -0,0 +1,13 @@
+diff --git a/Makefile.am b/Makefile.am
+index 22647be..7dcf0de 100644
+--- a/Makefile.am
++++ b/Makefile.am
+@@ -32,7 +32,7 @@ AM_DISTCHECK_CONFIGURE_FLAGS = --enable-python-libs
+ COMMON_CXXFLAGS_ONLY_WARNINGS = \
+     -I$(top_srcdir)/include \
+     -I$(top_builddir)/include \
+-    -Wall -Wformat -W -fvisibility-inlines-hidden \
++    -Wall -Wformat -W \
+     $(libprotobuf_CFLAGS)
+ COMMON_CXXFLAGS = $(COMMON_CXXFLAGS_ONLY_WARNINGS)