treewide: fix places where $(FPIC) is unquoted 15169/head
authorPhilip Prindeville <philipp@redfish-solutions.com>
Fri, 19 Mar 2021 22:26:31 +0000 (16:26 -0600)
committerPhilip Prindeville <philipp@redfish-solutions.com>
Fri, 19 Mar 2021 22:38:43 +0000 (16:38 -0600)
Fixes part of issue #14921.

When $(FPIC) gets added to TARGET_CFLAGS (for instance), we can
count on $(TARGET_CFLAGS) in turn being quoted when it gets
expanded.  But there are a few places where $(FPIC) gets
expanded directly into environment variables passed on the
command line, such as when setting lt_cv_* variables as in this
case.

It's wrong to assume that the expansion of $(FPIC) won't require
quoting (such as it containing spaces) if it has multiple compiler
flags.

Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
libs/libredblack/Makefile
sound/madplay/Makefile

index 2e3f020b6e3a3360f47979ad2b149576518cd0cd..5f1bcc7eae5d71991d1124d0afba0cad4449ec8b 100644 (file)
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=libredblack
 PKG_VERSION:=1.3
-PKG_RELEASE:=3
+PKG_RELEASE:=4
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 PKG_SOURCE_URL:=@SF/libredblack
@@ -38,7 +38,7 @@ define Package/libredblack/description
 endef
 
 CONFIGURE_ARGS += --without-rbgen
-CONFIGURE_VARS += lt_cv_prog_cc_pic=$(FPIC)
+CONFIGURE_VARS += lt_cv_prog_cc_pic="$(FPIC)"
 MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"
 
 define Build/InstallDev
index d3a80fc54bfbc637676087341bbe75f9818f3950..5c8c3ab88fccb04289eaaa2a948f3d7ac2eeb3d5 100644 (file)
@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk
 
 PKG_NAME:=madplay
 PKG_VERSION:=0.15.2b
-PKG_RELEASE:=9
+PKG_RELEASE:=10
 
 PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
 PKG_SOURCE_URL:=@SF/mad \
@@ -51,7 +51,7 @@ CONFIGURE_ARGS += \
        --with-alsa
 
 CONFIGURE_VARS += \
-       lt_prog_compiler_pic=$(FPIC)
+       lt_prog_compiler_pic="$(FPIC)"
 
 MAKE_FLAGS += CFLAGS="$(TARGET_CFLAGS)"