X-Git-Url: http://git.openwrt.org/?a=blobdiff_plain;f=CONTRIBUTING.md;h=4cfaef151ffd2c2e0b577649f365b611288f84ab;hb=df72a84986b08bca33d7a3be79c10a9de70f5173;hp=29ba5dbaa9eab437bce9db6f4314486f08fbb1bd;hpb=31b70f938ffc5f84353d0085e565bd1c59f0dbee;p=feed%2Fpackages.git diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 29ba5dbaa9..4cfaef151f 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -22,6 +22,7 @@ All packages you commit or submit by pull-request should follow these simple gui * An optional PKG_LICENSE_FILES tag including the filenames of the license-files in the source-package. (E.g.: PKG_LICENSE_FILES:=COPYING) * PKG_RELEASE should be initially set to 1 or reset to 1 if the software version is changed. You should increment it if the package itself has changed. For example, modifying a support script, changing configure options like --disable* or --enable* switches, or if you changed something in the package which causes the resulting binaries to be different. Changes like correcting md5sums, changing mirror URLs, adding a maintainer field or updating a comment or copyright year in a Makefile do not require a change to PKG_RELEASE. +* Avoid reuse of PKG_NAME in call, define and eval lines to improve readability. #### Commits in your pull-requests should: