wireless: only enable proxyarp/isolate for AP vifs
[project/netifd.git] / system-linux.c
index 993320175c6c8db1ece3a049a07d6986b3a70e96..62038d7f41fef01a03e920d8e7cc6c60b8344958 100644 (file)
@@ -5,6 +5,7 @@
  * Copyright (C) 2013 Steven Barth <steven@midlink.org>
  * Copyright (C) 2014 Gioacchino Mazzurco <gio@eigenlab.org>
  * Copyright (C) 2017 Matthias Schiffer <mschiffer@universe-factory.net>
+ * Copyright (C) 2018 Hans Dedecker <dedeckeh@gmail.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 2
 #include <net/if.h>
 #include <net/if_arp.h>
 
+#include <limits.h>
 #include <arpa/inet.h>
-#include <netinet/ether.h>
 #include <netinet/in.h>
+#include <netinet/ether.h>
 
 #include <linux/rtnetlink.h>
+#include <linux/neighbour.h>
 #include <linux/sockios.h>
 #include <linux/ip.h>
 #include <linux/if_addr.h>
@@ -43,6 +46,8 @@
 #include <linux/veth.h>
 #include <linux/version.h>
 
+#include <sched.h>
+
 #ifndef RTN_FAILED_POLICY
 #define RTN_FAILED_POLICY 12
 #endif
@@ -69,6 +74,7 @@
 #include "netifd.h"
 #include "device.h"
 #include "system.h"
+#include "utils.h"
 
 struct event_socket {
        struct uloop_fd uloop;
@@ -86,6 +92,8 @@ static int system_add_proto_tunnel(const char *name, const uint8_t proto,
 static int __system_del_ip_tunnel(const char *name, struct blob_attr **tb);
 
 static char dev_buf[256];
+static const char *proc_path = "/proc";
+static const char *sysfs_path = "/sys";
 
 static void
 handler_nl_event(struct uloop_fd *u, unsigned int events)
@@ -104,12 +112,12 @@ handler_nl_event(struct uloop_fd *u, unsigned int events)
 
        switch(err) {
        case ENOBUFS:
-               // Increase rx buffer size on netlink socket
+               /* Increase rx buffer size on netlink socket */
                ev->bufsize *= 2;
                if (nl_socket_set_buffer_size(ev->sock, ev->bufsize, 0))
                        goto abort;
 
-               // Request full dump since some info got dropped
+               /* Request full dump since some info got dropped */
                struct rtgenmsg msg = { .rtgen_family = AF_UNSPEC };
                nl_send_simple(ev->sock, RTM_GETLINK, NLM_F_DUMP, &msg, sizeof(msg));
                break;
@@ -137,8 +145,10 @@ create_socket(int protocol, int groups)
        if (groups)
                nl_join_groups(sock, groups);
 
-       if (nl_connect(sock, protocol))
+       if (nl_connect(sock, protocol)) {
+               nl_socket_free(sock);
                return NULL;
+       }
 
        return sock;
 }
@@ -166,13 +176,28 @@ create_event_socket(struct event_socket *ev, int protocol,
        if (!create_raw_event_socket(ev, protocol, 0, handler_nl_event, ULOOP_ERROR_CB))
                return false;
 
-       // Install the valid custom callback handler
+       /* Install the valid custom callback handler */
        nl_socket_modify_cb(ev->sock, NL_CB_VALID, NL_CB_CUSTOM, cb, NULL);
 
-       // Disable sequence number checking on event sockets
+       /* Disable sequence number checking on event sockets */
        nl_socket_disable_seq_check(ev->sock);
 
-       // Increase rx buffer size to 65K on event sockets
+       /* Increase rx buffer size to 65K on event sockets */
+       ev->bufsize = 65535;
+       if (nl_socket_set_buffer_size(ev->sock, ev->bufsize, 0))
+               return false;
+
+       return true;
+}
+
+static bool
+create_hotplug_event_socket(struct event_socket *ev, int protocol,
+                           void (*cb)(struct uloop_fd *u, unsigned int events))
+{
+       if (!create_raw_event_socket(ev, protocol, 1, cb, ULOOP_ERROR_CB))
+               return false;
+
+       /* Increase rx buffer size to 65K on event sockets */
        ev->bufsize = 65535;
        if (nl_socket_set_buffer_size(ev->sock, ev->bufsize, 0))
                return false;
@@ -240,7 +265,7 @@ int system_init(void)
        sock_ioctl = socket(AF_LOCAL, SOCK_DGRAM, 0);
        system_fd_set_cloexec(sock_ioctl);
 
-       // Prepare socket for routing / address control
+       /* Prepare socket for routing / address control */
        sock_rtnl = create_socket(NETLINK_ROUTE, 0);
        if (!sock_rtnl)
                return -1;
@@ -248,17 +273,17 @@ int system_init(void)
        if (!create_event_socket(&rtnl_event, NETLINK_ROUTE, cb_rtnl_event))
                return -1;
 
-       if (!create_raw_event_socket(&hotplug_event, NETLINK_KOBJECT_UEVENT, 1,
-                                       handle_hotplug_event, 0))
+       if (!create_hotplug_event_socket(&hotplug_event, NETLINK_KOBJECT_UEVENT,
+                                        handle_hotplug_event))
                return -1;
 
-       // Receive network link events form kernel
+       /* Receive network link events form kernel */
        nl_socket_add_membership(rtnl_event.sock, RTNLGRP_LINK);
 
        return 0;
 }
 
-static void system_set_sysctl(const char *path, const char *val)
+static void write_file(const char *path, const char *val)
 {
        int fd;
 
@@ -270,254 +295,410 @@ static void system_set_sysctl(const char *path, const char *val)
        close(fd);
 }
 
-static void system_set_dev_sysctl(const char *path, const char *device, const char *val)
+static int read_file(const char *path, char *buf, const size_t buf_sz)
+{
+       int fd = -1, ret = -1;
+
+       fd = open(path, O_RDONLY);
+       if (fd < 0)
+               goto out;
+
+       ssize_t len = read(fd, buf, buf_sz - 1);
+       if (len < 0)
+               goto out;
+
+       ret = buf[len] = 0;
+
+out:
+       if (fd >= 0)
+               close(fd);
+
+       return ret;
+}
+
+
+static const char *
+dev_sysctl_path(const char *prefix, const char *ifname, const char *file)
+{
+       snprintf(dev_buf, sizeof(dev_buf), "%s/sys/net/%s/%s/%s", proc_path, prefix, ifname, file);
+
+       return dev_buf;
+}
+
+static const char *
+dev_sysfs_path(const char *ifname, const char *file)
+{
+       snprintf(dev_buf, sizeof(dev_buf), "%s/class/net/%s/%s", sysfs_path, ifname, file);
+
+       return dev_buf;
+}
+
+static void
+system_set_dev_sysctl(const char *prefix, const char *file, const char *ifname,
+                     const char *val)
+{
+       write_file(dev_sysctl_path(prefix, ifname, file), val);
+}
+
+static int
+system_get_dev_sysctl(const char *prefix, const char *file, const char *ifname,
+                     char *buf, size_t buf_sz)
+{
+       return read_file(dev_sysctl_path(prefix, ifname, file), buf, buf_sz);
+}
+
+static void
+system_set_dev_sysfs(const char *file, const char *ifname, const char *val)
+{
+       if (!val)
+               return;
+
+       write_file(dev_sysfs_path(ifname, file), val);
+}
+
+static void
+system_set_dev_sysfs_int(const char *file, const char *ifname, int val)
 {
-       snprintf(dev_buf, sizeof(dev_buf), path, device);
-       system_set_sysctl(dev_buf, val);
+       char buf[16];
+
+       snprintf(buf, sizeof(buf), "%d", val);
+       system_set_dev_sysfs(file, ifname, buf);
+}
+
+static int
+system_get_dev_sysfs(const char *file, const char *ifname, char *buf, size_t buf_sz)
+{
+       return read_file(dev_sysfs_path(ifname, file), buf, buf_sz);
 }
 
 static void system_set_disable_ipv6(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv6/conf/%s/disable_ipv6", dev->ifname, val);
+       system_set_dev_sysctl("ipv6/conf", "disable_ipv6", dev->ifname, val);
+}
+
+static void system_set_ip6segmentrouting(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv6/conf", "seg6_enabled", dev->ifname, val);
 }
 
 static void system_set_rpfilter(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/conf/%s/rp_filter", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/conf", "rp_filter", dev->ifname, val);
 }
 
 static void system_set_acceptlocal(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/conf/%s/accept_local", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/conf", "accept_local", dev->ifname, val);
 }
 
 static void system_set_igmpversion(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/conf/%s/force_igmp_version", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/conf", "force_igmp_version", dev->ifname, val);
 }
 
 static void system_set_mldversion(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv6/conf/%s/force_mld_version", dev->ifname, val);
+       system_set_dev_sysctl("ipv6/conf", "force_mld_version", dev->ifname, val);
 }
 
 static void system_set_neigh4reachabletime(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/base_reachable_time_ms", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/neigh", "base_reachable_time_ms", dev->ifname, val);
 }
 
 static void system_set_neigh6reachabletime(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv6/neigh/%s/base_reachable_time_ms", dev->ifname, val);
+       system_set_dev_sysctl("ipv6/neigh", "base_reachable_time_ms", dev->ifname, val);
 }
 
 static void system_set_neigh4gcstaletime(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/gc_stale_time", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/neigh", "gc_stale_time", dev->ifname, val);
 }
 
 static void system_set_neigh6gcstaletime(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv6/neigh/%s/gc_stale_time", dev->ifname, val);
+       system_set_dev_sysctl("ipv6/neigh", "gc_stale_time", dev->ifname, val);
 }
 
 static void system_set_neigh4locktime(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/locktime", dev->ifname, val);
+       system_set_dev_sysctl("ipv4/neigh", "locktime", dev->ifname, val);
 }
 
 static void system_set_dadtransmits(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv6/conf/%s/dad_transmits", dev->ifname, val);
+       system_set_dev_sysctl("ipv6/conf", "dad_transmits", dev->ifname, val);
+}
+
+static void system_set_sendredirects(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv4/conf", "send_redirects", dev->ifname, val);
+}
+
+static void system_set_drop_v4_unicast_in_l2_multicast(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv4/conf", "drop_unicast_in_l2_multicast", dev->ifname, val);
+}
+
+static void system_set_drop_v6_unicast_in_l2_multicast(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv6/conf", "drop_unicast_in_l2_multicast", dev->ifname, val);
+}
+
+static void system_set_drop_gratuitous_arp(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv4/conf", "drop_gratuitous_arp", dev->ifname, val);
+}
+
+static void system_set_drop_unsolicited_na(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv6/conf", "drop_unsolicited_na", dev->ifname, val);
+}
+
+static void system_set_arp_accept(struct device *dev, const char *val)
+{
+       system_set_dev_sysctl("ipv4/conf", "arp_accept", dev->ifname, val);
 }
 
 static void system_bridge_set_multicast_to_unicast(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/multicast_to_unicast", dev->ifname, val);
+       system_set_dev_sysfs("brport/multicast_to_unicast", dev->ifname, val);
 }
 
 static void system_bridge_set_multicast_fast_leave(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/multicast_fast_leave", dev->ifname, val);
+       system_set_dev_sysfs("brport/multicast_fast_leave", dev->ifname, val);
 }
 
 static void system_bridge_set_hairpin_mode(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/hairpin_mode", dev->ifname, val);
+       system_set_dev_sysfs("brport/hairpin_mode", dev->ifname, val);
 }
 
-static void system_bridge_set_isolate_mode(struct device *dev, const char *val)
+static void system_bridge_set_proxyarp_wifi(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/isolate_mode", dev->ifname, val);
+       system_set_dev_sysfs("brport/proxyarp_wifi", dev->ifname, val);
+}
+
+static void system_bridge_set_bpdu_filter(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("brport/bpdu_filter", dev->ifname, val);
+}
+
+static void system_bridge_set_isolated(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("brport/isolated", dev->ifname, val);
 }
 
 static void system_bridge_set_multicast_router(struct device *dev, const char *val, bool bridge)
 {
-       system_set_dev_sysctl(bridge ? "/sys/class/net/%s/bridge/multicast_router" :
-                                      "/sys/class/net/%s/brport/multicast_router",
+       system_set_dev_sysfs(bridge ? "bridge/multicast_router" :
+                                     "brport/multicast_router",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_robustness(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_startup_query_count",
+       system_set_dev_sysfs("bridge/multicast_startup_query_count",
                              dev->ifname, val);
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_last_member_count",
+       system_set_dev_sysfs("bridge/multicast_last_member_count",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_query_interval(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_query_interval",
+       system_set_dev_sysfs("bridge/multicast_query_interval",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_query_response_interval(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_query_response_interval",
+       system_set_dev_sysfs("bridge/multicast_query_response_interval",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_last_member_interval(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_last_member_interval",
+       system_set_dev_sysfs("bridge/multicast_last_member_interval",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_membership_interval(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_membership_interval",
+       system_set_dev_sysfs("bridge/multicast_membership_interval",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_other_querier_timeout(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_querier_interval",
+       system_set_dev_sysfs("bridge/multicast_querier_interval",
                              dev->ifname, val);
 }
 
 static void system_bridge_set_startup_query_interval(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_startup_query_interval",
+       system_set_dev_sysfs("bridge/multicast_startup_query_interval",
                              dev->ifname, val);
 }
 
-static void system_bridge_set_learning(struct device *dev, const char *val)
+void system_bridge_set_stp_state(struct device *dev, bool val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/learning", dev->ifname, val);
+       const char *valstr = val ? "1" : "0";
+
+       system_set_dev_sysfs("bridge/stp_state", dev->ifname, valstr);
 }
 
-static void system_bridge_set_unicast_flood(struct device *dev, const char *val)
+static void system_bridge_set_forward_delay(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/sys/class/net/%s/brport/unicast_flood", dev->ifname, val);
+       system_set_dev_sysfs("bridge/forward_delay", dev->ifname, val);
 }
 
-static void system_set_sendredirects(struct device *dev, const char *val)
+static void system_bridge_set_priority(struct device *dev, const char *val)
 {
-       system_set_dev_sysctl("/proc/sys/net/ipv4/conf/%s/send_redirects", dev->ifname, val);
+       system_set_dev_sysfs("bridge/priority", dev->ifname, val);
 }
 
-static int system_get_sysctl(const char *path, char *buf, const size_t buf_sz)
+static void system_bridge_set_ageing_time(struct device *dev, const char *val)
 {
-       int fd = -1, ret = -1;
-
-       fd = open(path, O_RDONLY);
-       if (fd < 0)
-               goto out;
+       system_set_dev_sysfs("bridge/ageing_time", dev->ifname, val);
+}
 
-       ssize_t len = read(fd, buf, buf_sz - 1);
-       if (len < 0)
-               goto out;
+static void system_bridge_set_hello_time(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("bridge/hello_time", dev->ifname, val);
+}
 
-       ret = buf[len] = 0;
+static void system_bridge_set_max_age(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("bridge/max_age", dev->ifname, val);
+}
 
-out:
-       if (fd >= 0)
-               close(fd);
+static void system_bridge_set_learning(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("brport/learning", dev->ifname, val);
+}
 
-       return ret;
+static void system_bridge_set_unicast_flood(struct device *dev, const char *val)
+{
+       system_set_dev_sysfs("brport/unicast_flood", dev->ifname, val);
 }
 
-static int
-system_get_dev_sysctl(const char *path, const char *device, char *buf, const size_t buf_sz)
+static void system_bridge_set_vlan_filtering(struct device *dev, const char *val)
 {
-       snprintf(dev_buf, sizeof(dev_buf), path, device);
-       return system_get_sysctl(dev_buf, buf, buf_sz);
+       system_set_dev_sysfs("bridge/vlan_filtering", dev->ifname, val);
 }
 
 static int system_get_disable_ipv6(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv6/conf/%s/disable_ipv6",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv6/conf", "disable_ipv6",
+                                    dev->ifname, buf, buf_sz);
+}
+
+static int system_get_ip6segmentrouting(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv6/conf", "seg6_enabled",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_rpfilter(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/conf/%s/rp_filter",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv4/conf", "rp_filter",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_acceptlocal(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/conf/%s/accept_local",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv4/conf", "accept_local",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_igmpversion(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/conf/%s/force_igmp_version",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv4/conf", "force_igmp_version",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_mldversion(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv6/conf/%s/force_mld_version",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv6/conf", "force_mld_version",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_neigh4reachabletime(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/base_reachable_time_ms",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv4/neigh", "base_reachable_time_ms",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_neigh6reachabletime(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv6/neigh/%s/base_reachable_time_ms",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv6/neigh", "base_reachable_time_ms",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_neigh4gcstaletime(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/gc_stale_time",
-                       dev->ifname, buf, buf_sz);
+       return system_get_dev_sysctl("ipv4/neigh", "gc_stale_time",
+                                    dev->ifname, buf, buf_sz);
 }
 
 static int system_get_neigh6gcstaletime(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv6/neigh/%s/gc_stale_time",
+       return system_get_dev_sysctl("ipv6/neigh", "gc_stale_time",
                        dev->ifname, buf, buf_sz);
 }
 
 static int system_get_neigh4locktime(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/neigh/%s/locktime",
+       return system_get_dev_sysctl("ipv4/neigh", "locktime",
                        dev->ifname, buf, buf_sz);
 }
 
 static int system_get_dadtransmits(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv6/conf/%s/dad_transmits",
+       return system_get_dev_sysctl("ipv6/conf", "dad_transmits",
                        dev->ifname, buf, buf_sz);
 }
 
 static int system_get_sendredirects(struct device *dev, char *buf, const size_t buf_sz)
 {
-       return system_get_dev_sysctl("/proc/sys/net/ipv4/conf/%s/send_redirects",
+       return system_get_dev_sysctl("ipv4/conf", "send_redirects",
+                       dev->ifname, buf, buf_sz);
+}
+
+
+static int system_get_drop_v4_unicast_in_l2_multicast(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv4/conf", "drop_unicast_in_l2_multicast",
+                       dev->ifname, buf, buf_sz);
+}
+
+static int system_get_drop_v6_unicast_in_l2_multicast(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv6/conf", "drop_unicast_in_l2_multicast",
                        dev->ifname, buf, buf_sz);
 }
 
-// Evaluate netlink messages
+static int system_get_drop_gratuitous_arp(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv4/conf", "drop_gratuitous_arp",
+                       dev->ifname, buf, buf_sz);
+}
+
+static int system_get_drop_unsolicited_na(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv6/conf", "drop_unsolicited_na",
+                       dev->ifname, buf, buf_sz);
+}
+
+static int system_get_arp_accept(struct device *dev, char *buf, const size_t buf_sz)
+{
+       return system_get_dev_sysctl("ipv4/conf", "arp_accept",
+                       dev->ifname, buf, buf_sz);
+}
+
+/* Evaluate netlink messages */
 static int cb_rtnl_event(struct nl_msg *msg, void *arg)
 {
        struct nlmsghdr *nh = nlmsg_hdr(msg);
@@ -536,9 +717,12 @@ static int cb_rtnl_event(struct nl_msg *msg, void *arg)
        if (!dev)
                goto out;
 
-       if (!system_get_dev_sysctl("/sys/class/net/%s/carrier", dev->ifname, buf, sizeof(buf)))
+       if (!system_get_dev_sysfs("carrier", dev->ifname, buf, sizeof(buf)))
                link_state = strtoul(buf, NULL, 0);
 
+       if (dev->type == &simple_device_type)
+               device_set_present(dev, true);
+
        device_set_link(dev, link_state ? true : false);
 
 out:
@@ -550,18 +734,13 @@ handle_hotplug_msg(char *data, int size)
 {
        const char *subsystem = NULL, *interface = NULL, *interface_old = NULL;
        char *cur, *end, *sep;
-       struct device *dev;
        int skip;
-       bool add, move = false;
+       bool add;
 
-       if (!strncmp(data, "add@", 4))
+       if (!strncmp(data, "add@", 4) || !strncmp(data, "move@", 5))
                add = true;
        else if (!strncmp(data, "remove@", 7))
                add = false;
-       else if (!strncmp(data, "move@", 5)) {
-               add = true;
-               move = true;
-       }
        else
                return;
 
@@ -589,37 +768,13 @@ handle_hotplug_msg(char *data, int size)
                }
        }
 
-       if (subsystem && interface) {
-               if (move && interface_old)
-                       goto move;
-               else
-                       goto found;
-       }
-
-       return;
-
-move:
-       dev = device_find(interface_old);
-       if (!dev)
-               goto found;
-
-       if (dev->type != &simple_device_type)
-               goto found;
-
-       device_set_present(dev, false);
-
-found:
-       dev = device_find(interface);
-       if (!dev)
-               return;
-
-       if (dev->type != &simple_device_type)
+       if (!subsystem || !interface)
                return;
 
-       if (add && system_if_force_external(dev->ifname))
-               return;
+       if (interface_old)
+               device_hotplug_event(interface_old, false);
 
-       device_set_present(dev, add);
+       device_hotplug_event(interface, add);
 }
 
 static void
@@ -629,13 +784,39 @@ handle_hotplug_event(struct uloop_fd *u, unsigned int events)
        struct sockaddr_nl nla;
        unsigned char *buf = NULL;
        int size;
+       int err;
+       socklen_t errlen = sizeof(err);
 
-       while ((size = nl_recv(ev->sock, &nla, &buf, NULL)) > 0) {
-               if (nla.nl_pid == 0)
-                       handle_hotplug_msg((char *) buf, size);
+       if (!u->error) {
+               while ((size = nl_recv(ev->sock, &nla, &buf, NULL)) > 0) {
+                       if (nla.nl_pid == 0)
+                               handle_hotplug_msg((char *) buf, size);
 
-               free(buf);
+                       free(buf);
+               }
+               return;
+       }
+
+       if (getsockopt(u->fd, SOL_SOCKET, SO_ERROR, (void *)&err, &errlen))
+               goto abort;
+
+       switch(err) {
+       case ENOBUFS:
+               /* Increase rx buffer size on netlink socket */
+               ev->bufsize *= 2;
+               if (nl_socket_set_buffer_size(ev->sock, ev->bufsize, 0))
+                       goto abort;
+               break;
+
+       default:
+               goto abort;
        }
+       u->error = false;
+       return;
+
+abort:
+       uloop_fd_delete(&ev->uloop);
+       return;
 }
 
 static int system_rtnl_call(struct nl_msg *msg)
@@ -665,19 +846,15 @@ static int system_bridge_if(const char *bridge, struct device *dev, int cmd, voi
                ifr.ifr_ifindex = dev->ifindex;
        else
                ifr.ifr_data = data;
-       strncpy(ifr.ifr_name, bridge, sizeof(ifr.ifr_name));
+       strncpy(ifr.ifr_name, bridge, sizeof(ifr.ifr_name) - 1);
        return ioctl(sock_ioctl, cmd, &ifr);
 }
 
-static bool system_is_bridge(const char *name, char *buf, int buflen)
+static bool system_is_bridge(const char *name)
 {
        struct stat st;
 
-       snprintf(buf, buflen, "/sys/devices/virtual/net/%s/bridge", name);
-       if (stat(buf, &st) < 0)
-               return false;
-
-       return true;
+       return stat(dev_sysfs_path(name, "bridge"), &st) >= 0;
 }
 
 static char *system_get_bridge(const char *name, char *buf, int buflen)
@@ -686,7 +863,7 @@ static char *system_get_bridge(const char *name, char *buf, int buflen)
        ssize_t len = -1;
        glob_t gl;
 
-       snprintf(buf, buflen, "/sys/devices/virtual/net/*/brif/%s/bridge", name);
+       snprintf(buf, buflen, "%s/devices/virtual/net/*/brif/%s/bridge", sysfs_path, name);
        if (glob(buf, GLOB_NOSORT, NULL, &gl) < 0)
                return NULL;
 
@@ -710,28 +887,39 @@ static void
 system_bridge_set_wireless(struct device *bridge, struct device *dev)
 {
        bool mcast_to_ucast = dev->wireless_ap;
-       bool hairpin = true;
+       bool hairpin;
 
        if (bridge->settings.flags & DEV_OPT_MULTICAST_TO_UNICAST &&
            !bridge->settings.multicast_to_unicast)
                mcast_to_ucast = false;
 
-       if (!mcast_to_ucast || dev->wireless_isolate)
+       hairpin = mcast_to_ucast || dev->wireless_proxyarp;
+       if (dev->wireless_isolate)
                hairpin = false;
 
        system_bridge_set_multicast_to_unicast(dev, mcast_to_ucast ? "1" : "0");
        system_bridge_set_hairpin_mode(dev, hairpin ? "1" : "0");
+       system_bridge_set_proxyarp_wifi(dev, dev->wireless_proxyarp ? "1" : "0");
 }
 
 int system_bridge_addif(struct device *bridge, struct device *dev)
 {
        char buf[64];
        char *oldbr;
-       int ret = 0;
+       int tries = 0;
+       int ret;
 
+retry:
+       ret = 0;
        oldbr = system_get_bridge(dev->ifname, dev_buf, sizeof(dev_buf));
-       if (!oldbr || strcmp(oldbr, bridge->ifname) != 0)
+       if (!oldbr || strcmp(oldbr, bridge->ifname) != 0) {
                ret = system_bridge_if(bridge->ifname, dev, SIOCBRADDIF, NULL);
+               tries++;
+               D(SYSTEM, "Failed to add device '%s' to bridge '%s' (tries=%d): %s\n",
+                 dev->ifname, bridge->ifname, tries, strerror(errno));
+               if (tries <= 3)
+                       goto retry;
+       }
 
        if (dev->wireless)
                system_bridge_set_wireless(bridge, dev);
@@ -755,7 +943,10 @@ int system_bridge_addif(struct device *bridge, struct device *dev)
 
        if (dev->settings.flags & DEV_OPT_ISOLATE &&
            dev->settings.isolate)
-               system_bridge_set_isolate_mode(dev, "1");
+               system_bridge_set_isolated(dev, "1");
+
+       if (dev->bpdu_filter)
+               system_bridge_set_bpdu_filter(dev, dev->bpdu_filter ? "1" : "0");
 
        return ret;
 }
@@ -765,10 +956,144 @@ int system_bridge_delif(struct device *bridge, struct device *dev)
        return system_bridge_if(bridge->ifname, dev, SIOCBRDELIF, NULL);
 }
 
+int system_bridge_vlan(const char *iface, uint16_t vid, bool add, unsigned int vflags)
+{
+       struct ifinfomsg ifi = { .ifi_family = PF_BRIDGE, };
+       struct bridge_vlan_info vinfo = { .vid = vid, };
+       unsigned short flags = 0;
+       struct nlattr *afspec;
+       struct nl_msg *nlm;
+       int ret = 0;
+
+       ifi.ifi_index = if_nametoindex(iface);
+       if (!ifi.ifi_index)
+               return -1;
+
+       nlm = nlmsg_alloc_simple(add ? RTM_SETLINK : RTM_DELLINK, NLM_F_REQUEST);
+       if (!nlm)
+               return -1;
+
+       nlmsg_append(nlm, &ifi, sizeof(ifi), 0);
+
+       if (vflags & BRVLAN_F_SELF)
+               flags |= BRIDGE_FLAGS_SELF;
+
+       if (vflags & BRVLAN_F_PVID)
+               vinfo.flags |= BRIDGE_VLAN_INFO_PVID;
+
+       if (vflags & BRVLAN_F_UNTAGGED)
+               vinfo.flags |= BRIDGE_VLAN_INFO_UNTAGGED;
+
+       afspec = nla_nest_start(nlm, IFLA_AF_SPEC);
+       if (!afspec) {
+               ret = -ENOMEM;
+               goto failure;
+       }
+
+       if (flags)
+               nla_put_u16(nlm, IFLA_BRIDGE_FLAGS, flags);
+
+       nla_put(nlm, IFLA_BRIDGE_VLAN_INFO, sizeof(vinfo), &vinfo);
+       nla_nest_end(nlm, afspec);
+
+       return system_rtnl_call(nlm);
+
+failure:
+       nlmsg_free(nlm);
+       return ret;
+}
+
+int system_bonding_set_device(struct device *dev, struct bonding_config *cfg)
+{
+       const char *ifname = dev->ifname;
+       struct blob_attr *cur;
+       char op = cfg ? '+' : '-';
+       char buf[64];
+       int rem;
+
+       snprintf(dev_buf, sizeof(dev_buf), "%s/class/net/bonding_masters", sysfs_path);
+       snprintf(buf, sizeof(buf), "%c%s", op, ifname);
+       write_file(dev_buf, buf);
+
+       if (!cfg)
+               return 0;
+
+       system_set_dev_sysfs("bonding/mode", ifname, bonding_policy_str[cfg->policy]);
+
+       system_set_dev_sysfs_int("bonding/all_ports_active", ifname, cfg->all_ports_active);
+
+       if (cfg->policy == BONDING_MODE_BALANCE_XOR ||
+           cfg->policy == BONDING_MODE_BALANCE_TLB ||
+           cfg->policy == BONDING_MODE_8023AD)
+               system_set_dev_sysfs("bonding/xmit_hash_policy", ifname, cfg->xmit_hash_policy);
+
+       if (cfg->policy == BONDING_MODE_8023AD) {
+               system_set_dev_sysfs("bonding/ad_actor_system", ifname, cfg->ad_actor_system);
+               system_set_dev_sysfs_int("bonding/ad_actor_sys_prio", ifname, cfg->ad_actor_sys_prio);
+               system_set_dev_sysfs("bonding/ad_select", ifname, cfg->ad_select);
+               system_set_dev_sysfs("bonding/lacp_rate", ifname, cfg->lacp_rate);
+               system_set_dev_sysfs_int("bonding/min_links", ifname, cfg->min_links);
+       }
+
+       if (cfg->policy == BONDING_MODE_BALANCE_RR)
+               system_set_dev_sysfs_int("bonding/packets_per_slave", ifname, cfg->packets_per_port);
+
+       if (cfg->policy == BONDING_MODE_BALANCE_TLB ||
+           cfg->policy == BONDING_MODE_BALANCE_ALB)
+               system_set_dev_sysfs_int("bonding/lp_interval", ifname, cfg->lp_interval);
+
+       if (cfg->policy == BONDING_MODE_BALANCE_TLB)
+               system_set_dev_sysfs_int("bonding/tlb_dynamic_lb", ifname, cfg->dynamic_lb);
+       system_set_dev_sysfs_int("bonding/resend_igmp", ifname, cfg->resend_igmp);
+       system_set_dev_sysfs_int("bonding/num_grat_arp", ifname, cfg->num_peer_notif);
+       system_set_dev_sysfs("bonding/primary_reselect", ifname, cfg->primary_reselect);
+       system_set_dev_sysfs("bonding/fail_over_mac", ifname, cfg->failover_mac);
+
+       system_set_dev_sysfs_int((cfg->monitor_arp ?
+                                 "bonding/arp_interval" :
+                                 "bonding/miimon"), ifname, cfg->monitor_interval);
+
+       blobmsg_for_each_attr(cur, cfg->arp_target, rem) {
+               snprintf(buf, sizeof(buf), "+%s", blobmsg_get_string(cur));
+               system_set_dev_sysfs("bonding/arp_ip_target", ifname, buf);
+       }
+
+       system_set_dev_sysfs_int("bonding/arp_all_targets", ifname, cfg->arp_all_targets);
+       if (cfg->policy < BONDING_MODE_8023AD)
+               system_set_dev_sysfs("bonding/arp_validate", ifname, cfg->arp_validate);
+       system_set_dev_sysfs_int("bonding/use_carrier", ifname, cfg->use_carrier);
+       if (!cfg->monitor_arp && cfg->monitor_interval) {
+               system_set_dev_sysfs_int("bonding/updelay", ifname, cfg->updelay);
+               system_set_dev_sysfs_int("bonding/downdelay", ifname, cfg->downdelay);
+       }
+
+       return 0;
+}
+
+int system_bonding_set_port(struct device *dev, struct device *port, bool add, bool primary)
+{
+       const char *port_name = port->ifname;
+       const char op_ch = add ? '+' : '-';
+       char buf[IFNAMSIZ + 2];
+
+       snprintf(buf, sizeof(buf), "%c%s", op_ch, port_name);
+       system_if_down(port);
+       system_set_dev_sysfs("bonding/slaves", dev->ifname, buf);
+       system_if_up(port);
+
+       if (primary)
+               system_set_dev_sysfs("bonding/primary", dev->ifname,
+                                    add ? port_name : "");
+
+       return 0;
+}
+
 int system_if_resolve(struct device *dev)
 {
        struct ifreq ifr;
-       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
+
+       memset(&ifr, 0, sizeof(ifr));
+       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name) - 1);
        if (!ioctl(sock_ioctl, SIOCGIFINDEX, &ifr))
                return ifr.ifr_ifindex;
        else
@@ -780,8 +1105,10 @@ static int system_if_flags(const char *ifname, unsigned add, unsigned rem)
        struct ifreq ifr;
 
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name));
-       ioctl(sock_ioctl, SIOCGIFFLAGS, &ifr);
+       strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name) - 1);
+       if (ioctl(sock_ioctl, SIOCGIFFLAGS, &ifr) < 0)
+               return -1;
+
        ifr.ifr_flags |= add;
        ifr.ifr_flags &= ~rem;
        return ioctl(sock_ioctl, SIOCSIFFLAGS, &ifr);
@@ -829,7 +1156,7 @@ static int cb_clear_event(struct nl_msg *msg, void *arg)
        struct clear_data *clr = arg;
        struct nlmsghdr *hdr = nlmsg_hdr(msg);
        bool (*cb)(struct nlmsghdr *, int ifindex);
-       int type;
+       int type, ret;
 
        switch(clr->type) {
        case RTM_GETADDR:
@@ -866,13 +1193,23 @@ static int cb_clear_event(struct nl_msg *msg, void *arg)
                D(SYSTEM, "Remove %s from device %s\n",
                  type == RTM_DELADDR ? "an address" : "a route",
                  clr->dev->ifname);
+
        memcpy(nlmsg_hdr(clr->msg), hdr, hdr->nlmsg_len);
        hdr = nlmsg_hdr(clr->msg);
        hdr->nlmsg_type = type;
        hdr->nlmsg_flags = NLM_F_REQUEST;
 
        nl_socket_disable_auto_ack(sock_rtnl);
-       nl_send_auto_complete(sock_rtnl, clr->msg);
+       ret = nl_send_auto_complete(sock_rtnl, clr->msg);
+       if (ret < 0) {
+               if (type == RTM_DELRULE)
+                       D(SYSTEM, "Error deleting a rule: %d\n", ret);
+               else
+                       D(SYSTEM, "Error deleting %s from device '%s': %d\n",
+                               type == RTM_DELADDR ? "an address" : "a route",
+                               clr->dev->ifname, ret);
+       }
+
        nl_socket_enable_auto_ack(sock_rtnl);
 
        return NL_SKIP;
@@ -898,7 +1235,7 @@ static void
 system_if_clear_entries(struct device *dev, int type, int af)
 {
        struct clear_data clr;
-       struct nl_cb *cb = nl_cb_alloc(NL_CB_DEFAULT);
+       struct nl_cb *cb;
        struct rtmsg rtm = {
                .rtm_family = af,
                .rtm_flags = RTM_F_CLONED,
@@ -921,6 +1258,7 @@ system_if_clear_entries(struct device *dev, int type, int af)
                return;
        }
 
+       cb = nl_cb_alloc(NL_CB_DEFAULT);
        if (!cb)
                return;
 
@@ -933,10 +1271,13 @@ system_if_clear_entries(struct device *dev, int type, int af)
        nl_cb_set(cb, NL_CB_FINISH, NL_CB_CUSTOM, cb_finish_event, &pending);
        nl_cb_err(cb, NL_CB_CUSTOM, error_handler, &pending);
 
-       nl_send_auto_complete(sock_rtnl, clr.msg);
+       if (nl_send_auto_complete(sock_rtnl, clr.msg) < 0)
+               goto free;
+
        while (pending > 0)
                nl_recvmsgs(sock_rtnl, cb);
 
+free:
        nlmsg_free(clr.msg);
 out:
        nl_cb_put(cb);
@@ -949,14 +1290,14 @@ void system_if_clear_state(struct device *dev)
 {
        static char buf[256];
        char *bridge;
-
        device_set_ifindex(dev, system_if_resolve(dev));
+
        if (dev->external || !dev->ifindex)
                return;
 
        system_if_flags(dev->ifname, 0, IFF_UP);
 
-       if (system_is_bridge(dev->ifname, buf, sizeof(buf))) {
+       if (system_is_bridge(dev->ifname)) {
                D(SYSTEM, "Delete existing bridge named '%s'\n", dev->ifname);
                system_bridge_delbr(dev);
                return;
@@ -972,6 +1313,8 @@ void system_if_clear_state(struct device *dev)
        system_if_clear_entries(dev, RTM_GETADDR, AF_INET);
        system_if_clear_entries(dev, RTM_GETROUTE, AF_INET6);
        system_if_clear_entries(dev, RTM_GETADDR, AF_INET6);
+       system_if_clear_entries(dev, RTM_GETNEIGH, AF_INET);
+       system_if_clear_entries(dev, RTM_GETNEIGH, AF_INET6);
        system_set_disable_ipv6(dev, "0");
 }
 
@@ -1017,14 +1360,14 @@ static void system_bridge_conf_multicast(struct device *bridge,
                                         char *buf,
                                         int buf_len)
 {
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_snooping",
+       system_set_dev_sysfs("bridge/multicast_snooping",
                bridge->ifname, cfg->igmp_snoop ? "1" : "0");
 
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/multicast_querier",
+       system_set_dev_sysfs("bridge/multicast_querier",
                bridge->ifname, cfg->multicast_querier ? "1" : "0");
 
        snprintf(buf, buf_len, "%i", cfg->hash_max);
-       system_set_dev_sysctl("/sys/devices/virtual/net/%s/bridge/hash_max",
+       system_set_dev_sysfs("/bridge/hash_max",
                bridge->ifname, buf);
 
        if (bridge->settings.flags & DEV_OPT_MULTICAST_ROUTER) {
@@ -1058,41 +1401,30 @@ static void system_bridge_conf_multicast(struct device *bridge,
 int system_bridge_addbr(struct device *bridge, struct bridge_config *cfg)
 {
        char buf[64];
-       unsigned long args[4] = {};
 
        if (ioctl(sock_ioctl, SIOCBRADDBR, bridge->ifname) < 0)
                return -1;
 
-       args[0] = BRCTL_SET_BRIDGE_STP_STATE;
-       args[1] = !!cfg->stp;
-       system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
+       system_bridge_set_stp_state(bridge, cfg->stp);
 
-       args[0] = BRCTL_SET_BRIDGE_FORWARD_DELAY;
-       args[1] = sec_to_jiffies(cfg->forward_delay);
-       system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
+       snprintf(buf, sizeof(buf), "%lu", sec_to_jiffies(cfg->forward_delay));
+       system_bridge_set_forward_delay(bridge, buf);
 
        system_bridge_conf_multicast(bridge, cfg, buf, sizeof(buf));
+       system_bridge_set_vlan_filtering(bridge, cfg->vlan_filtering ? "1" : "0");
 
-       args[0] = BRCTL_SET_BRIDGE_PRIORITY;
-       args[1] = cfg->priority;
-       system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
+       snprintf(buf, sizeof(buf), "%d", cfg->priority);
+       system_bridge_set_priority(bridge, buf);
 
-       if (cfg->flags & BRIDGE_OPT_AGEING_TIME) {
-               args[0] = BRCTL_SET_AGEING_TIME;
-               args[1] = sec_to_jiffies(cfg->ageing_time);
-               system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
-       }
+       snprintf(buf, sizeof(buf), "%lu", sec_to_jiffies(cfg->hello_time));
+       system_bridge_set_hello_time(bridge, buf);
 
-       if (cfg->flags & BRIDGE_OPT_HELLO_TIME) {
-               args[0] = BRCTL_SET_BRIDGE_HELLO_TIME;
-               args[1] = sec_to_jiffies(cfg->hello_time);
-               system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
-       }
+       snprintf(buf, sizeof(buf), "%lu", sec_to_jiffies(cfg->max_age));
+       system_bridge_set_max_age(bridge, buf);
 
-       if (cfg->flags & BRIDGE_OPT_MAX_AGE) {
-               args[0] = BRCTL_SET_BRIDGE_MAX_AGE;
-               args[1] = sec_to_jiffies(cfg->max_age);
-               system_bridge_if(bridge->ifname, NULL, SIOCDEVPRIVATE, &args);
+       if (cfg->flags & BRIDGE_OPT_AGEING_TIME) {
+               snprintf(buf, sizeof(buf), "%lu", sec_to_jiffies(cfg->ageing_time));
+               system_bridge_set_ageing_time(bridge, buf);
        }
 
        return 0;
@@ -1158,6 +1490,30 @@ nla_put_failure:
        return -ENOMEM;
 }
 
+int system_link_netns_move(struct device *dev, int netns_fd, const char *target_ifname)
+{
+       struct nl_msg *msg;
+       struct ifinfomsg iim = {
+               .ifi_family = AF_UNSPEC,
+       };
+
+       if (!dev)
+               return -1;
+
+       iim.ifi_index = system_if_resolve(dev);
+       msg = nlmsg_alloc_simple(RTM_NEWLINK, NLM_F_REQUEST);
+
+       if (!msg)
+               return -1;
+
+       nlmsg_append(msg, &iim, sizeof(iim), 0);
+       if (target_ifname)
+               nla_put_string(msg, IFLA_IFNAME, target_ifname);
+
+       nla_put_u32(msg, IFLA_NET_NS_FD, netns_fd);
+       return system_rtnl_call(msg);
+}
+
 static int system_link_del(const char *ifname)
 {
        struct nl_msg *msg;
@@ -1181,6 +1537,20 @@ int system_macvlan_del(struct device *macvlan)
        return system_link_del(macvlan->ifname);
 }
 
+int system_netns_open(const pid_t target_ns)
+{
+       char pid_net_path[PATH_MAX];
+
+       snprintf(pid_net_path, sizeof(pid_net_path), "/proc/%u/ns/net", target_ns);
+
+       return open(pid_net_path, O_RDONLY);
+}
+
+int system_netns_set(int netns_fd)
+{
+       return setns(netns_fd, CLONE_NEWNET);
+}
+
 int system_veth_add(struct device *veth, struct veth_config *cfg)
 {
        struct nl_msg *msg;
@@ -1248,7 +1618,8 @@ static int system_vlan(struct device *dev, int id)
                .u.name_type = VLAN_NAME_TYPE_RAW_PLUS_VID_NO_PAD,
        };
 
-       ioctl(sock_ioctl, SIOCSIFVLAN, &ifr);
+       if (ioctl(sock_ioctl, SIOCSIFVLAN, &ifr) < 0)
+               return -1;
 
        if (id < 0) {
                ifr.cmd = DEL_VLAN_CMD;
@@ -1274,8 +1645,10 @@ int system_vlan_del(struct device *dev)
 int system_vlandev_add(struct device *vlandev, struct device *dev, struct vlandev_config *cfg)
 {
        struct nl_msg *msg;
-       struct nlattr *linkinfo, *data;
+       struct nlattr *linkinfo, *data, *qos;
        struct ifinfomsg iim = { .ifi_family = AF_UNSPEC };
+       struct vlan_qos_mapping *elem;
+       struct ifla_vlan_qos_mapping nl_qos_map;
        int rv;
 
        msg = nlmsg_alloc_simple(RTM_NEWLINK, NLM_F_REQUEST | NLM_F_CREATE | NLM_F_EXCL);
@@ -1304,6 +1677,26 @@ int system_vlandev_add(struct device *vlandev, struct device *dev, struct vlande
                netifd_log_message(L_WARNING, "%s Your kernel is older than linux 3.10.0, 802.1ad is not supported defaulting to 802.1q", vlandev->type->name);
 #endif
 
+       if (!(qos = nla_nest_start(msg, IFLA_VLAN_INGRESS_QOS)))
+               goto nla_put_failure;
+
+       vlist_simple_for_each_element(&cfg->ingress_qos_mapping_list, elem, node) {
+               nl_qos_map.from = elem->from;
+               nl_qos_map.to = elem->to;
+               nla_put(msg, IFLA_VLAN_QOS_MAPPING, sizeof(nl_qos_map), &nl_qos_map);
+       }
+       nla_nest_end(msg, qos);
+
+       if (!(qos = nla_nest_start(msg, IFLA_VLAN_EGRESS_QOS)))
+               goto nla_put_failure;
+
+       vlist_simple_for_each_element(&cfg->egress_qos_mapping_list, elem, node) {
+               nl_qos_map.from = elem->from;
+               nl_qos_map.to = elem->to;
+               nla_put(msg, IFLA_VLAN_QOS_MAPPING, sizeof(nl_qos_map), &nl_qos_map);
+       }
+       nla_nest_end(msg, qos);
+
        nla_nest_end(msg, data);
        nla_nest_end(msg, linkinfo);
 
@@ -1313,14 +1706,65 @@ int system_vlandev_add(struct device *vlandev, struct device *dev, struct vlande
 
        return rv;
 
-nla_put_failure:
-       nlmsg_free(msg);
-       return -ENOMEM;
-}
+nla_put_failure:
+       nlmsg_free(msg);
+       return -ENOMEM;
+}
+
+int system_vlandev_del(struct device *vlandev)
+{
+       return system_link_del(vlandev->ifname);
+}
+
+static void
+system_set_ethtool_settings(struct device *dev, struct device_settings *s)
+{
+       struct ethtool_cmd ecmd = {
+               .cmd = ETHTOOL_GSET,
+       };
+       struct ifreq ifr = {
+               .ifr_data = (caddr_t)&ecmd,
+       };
+       static const struct {
+               int speed;
+               uint8_t bit_half;
+               uint8_t bit_full;
+       } speed_mask[] = {
+               { 10, ETHTOOL_LINK_MODE_10baseT_Half_BIT, ETHTOOL_LINK_MODE_10baseT_Full_BIT },
+               { 100, ETHTOOL_LINK_MODE_100baseT_Half_BIT, ETHTOOL_LINK_MODE_100baseT_Full_BIT },
+               { 1000, ETHTOOL_LINK_MODE_1000baseT_Half_BIT, ETHTOOL_LINK_MODE_1000baseT_Full_BIT },
+       };
+       uint32_t adv;
+       int i;
+
+       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name) - 1);
+
+       if (ioctl(sock_ioctl, SIOCETHTOOL, &ifr) != 0)
+               return;
+
+       adv = ecmd.supported;
+       for (i = 0; i < ARRAY_SIZE(speed_mask); i++) {
+               if (s->flags & DEV_OPT_DUPLEX) {
+                       int bit = s->duplex ? speed_mask[i].bit_half : speed_mask[i].bit_full;
+                       adv &= ~(1 << bit);
+               }
+
+               if (!(s->flags & DEV_OPT_SPEED) ||
+                   s->speed == speed_mask[i].speed)
+                       continue;
+
+               adv &= ~(1 << speed_mask[i].bit_full);
+               adv &= ~(1 << speed_mask[i].bit_half);
+       }
+
+
+       if (ecmd.autoneg && ecmd.advertising == adv)
+               return;
 
-int system_vlandev_del(struct device *vlandev)
-{
-       return system_link_del(vlandev->ifname);
+       ecmd.autoneg = 1;
+       ecmd.advertising = adv;
+       ecmd.cmd = ETHTOOL_SSET;
+       ioctl(sock_ioctl, SIOCETHTOOL, &ifr);
 }
 
 void
@@ -1330,7 +1774,7 @@ system_if_get_settings(struct device *dev, struct device_settings *s)
        char buf[10];
 
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
+       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name) - 1);
 
        if (ioctl(sock_ioctl, SIOCGIFMTU, &ifr) == 0) {
                s->mtu = ifr.ifr_mtu;
@@ -1356,6 +1800,11 @@ system_if_get_settings(struct device *dev, struct device_settings *s)
                s->flags |= DEV_OPT_IPV6;
        }
 
+       if (!system_get_ip6segmentrouting(dev, buf, sizeof(buf))) {
+               s->ip6segmentrouting = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_IP6SEGMENTROUTING;
+       }
+
        if (ioctl(sock_ioctl, SIOCGIFFLAGS, &ifr) == 0) {
                s->promisc = ifr.ifr_flags & IFF_PROMISC;
                s->flags |= DEV_OPT_PROMISC;
@@ -1418,100 +1867,140 @@ system_if_get_settings(struct device *dev, struct device_settings *s)
                s->sendredirects = strtoul(buf, NULL, 0);
                s->flags |= DEV_OPT_SENDREDIRECTS;
        }
+
+       if (!system_get_drop_v4_unicast_in_l2_multicast(dev, buf, sizeof(buf))) {
+               s->drop_v4_unicast_in_l2_multicast = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_DROP_V4_UNICAST_IN_L2_MULTICAST;
+       }
+
+       if (!system_get_drop_v6_unicast_in_l2_multicast(dev, buf, sizeof(buf))) {
+               s->drop_v6_unicast_in_l2_multicast = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_DROP_V6_UNICAST_IN_L2_MULTICAST;
+       }
+
+       if (!system_get_drop_gratuitous_arp(dev, buf, sizeof(buf))) {
+               s->drop_gratuitous_arp = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_DROP_GRATUITOUS_ARP;
+       }
+
+       if (!system_get_drop_unsolicited_na(dev, buf, sizeof(buf))) {
+               s->drop_unsolicited_na = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_DROP_UNSOLICITED_NA;
+       }
+
+       if (!system_get_arp_accept(dev, buf, sizeof(buf))) {
+               s->arp_accept = strtoul(buf, NULL, 0);
+               s->flags |= DEV_OPT_ARP_ACCEPT;
+       }
 }
 
 void
-system_if_apply_settings(struct device *dev, struct device_settings *s, unsigned int apply_mask)
+system_if_apply_settings(struct device *dev, struct device_settings *s, uint64_t apply_mask)
 {
        struct ifreq ifr;
        char buf[12];
 
+       apply_mask &= s->flags;
+
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
-       if (s->flags & DEV_OPT_MTU & apply_mask) {
+       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name) - 1);
+       if (apply_mask & DEV_OPT_MTU) {
                ifr.ifr_mtu = s->mtu;
                if (ioctl(sock_ioctl, SIOCSIFMTU, &ifr) < 0)
                        s->flags &= ~DEV_OPT_MTU;
        }
-       if (s->flags & DEV_OPT_MTU6 & apply_mask) {
+       if (apply_mask & DEV_OPT_MTU6) {
                system_update_ipv6_mtu(dev, s->mtu6);
        }
-       if (s->flags & DEV_OPT_TXQUEUELEN & apply_mask) {
+       if (apply_mask & DEV_OPT_TXQUEUELEN) {
                ifr.ifr_qlen = s->txqueuelen;
                if (ioctl(sock_ioctl, SIOCSIFTXQLEN, &ifr) < 0)
                        s->flags &= ~DEV_OPT_TXQUEUELEN;
        }
-       if ((s->flags & DEV_OPT_MACADDR & apply_mask) && !dev->external) {
+       if ((apply_mask & (DEV_OPT_MACADDR | DEV_OPT_DEFAULT_MACADDR)) && !dev->external) {
                ifr.ifr_hwaddr.sa_family = ARPHRD_ETHER;
                memcpy(&ifr.ifr_hwaddr.sa_data, s->macaddr, sizeof(s->macaddr));
                if (ioctl(sock_ioctl, SIOCSIFHWADDR, &ifr) < 0)
                        s->flags &= ~DEV_OPT_MACADDR;
        }
-       if (s->flags & DEV_OPT_IPV6 & apply_mask)
+       if (apply_mask & DEV_OPT_IPV6)
                system_set_disable_ipv6(dev, s->ipv6 ? "0" : "1");
-       if (s->flags & DEV_OPT_PROMISC & apply_mask) {
+       if (s->flags & DEV_OPT_IP6SEGMENTROUTING & apply_mask) {
+               struct device dummy = {
+                       .ifname = "all",
+               };
+               bool ip6segmentrouting = device_check_ip6segmentrouting();
+
+               system_set_ip6segmentrouting(dev, s->ip6segmentrouting ? "1" : "0");
+               system_set_ip6segmentrouting(&dummy, ip6segmentrouting ? "1" : "0");
+       }
+       if (apply_mask & DEV_OPT_PROMISC) {
                if (system_if_flags(dev->ifname, s->promisc ? IFF_PROMISC : 0,
                                    !s->promisc ? IFF_PROMISC : 0) < 0)
                        s->flags &= ~DEV_OPT_PROMISC;
        }
-       if (s->flags & DEV_OPT_RPFILTER & apply_mask) {
+       if (apply_mask & DEV_OPT_RPFILTER) {
                snprintf(buf, sizeof(buf), "%u", s->rpfilter);
                system_set_rpfilter(dev, buf);
        }
-       if (s->flags & DEV_OPT_ACCEPTLOCAL & apply_mask)
+       if (apply_mask & DEV_OPT_ACCEPTLOCAL)
                system_set_acceptlocal(dev, s->acceptlocal ? "1" : "0");
-       if (s->flags & DEV_OPT_IGMPVERSION & apply_mask) {
+       if (apply_mask & DEV_OPT_IGMPVERSION) {
                snprintf(buf, sizeof(buf), "%u", s->igmpversion);
                system_set_igmpversion(dev, buf);
        }
-       if (s->flags & DEV_OPT_MLDVERSION & apply_mask) {
+       if (apply_mask & DEV_OPT_MLDVERSION) {
                snprintf(buf, sizeof(buf), "%u", s->mldversion);
                system_set_mldversion(dev, buf);
        }
-       if (s->flags & DEV_OPT_NEIGHREACHABLETIME & apply_mask) {
+       if (apply_mask & DEV_OPT_NEIGHREACHABLETIME) {
                snprintf(buf, sizeof(buf), "%u", s->neigh4reachabletime);
                system_set_neigh4reachabletime(dev, buf);
                snprintf(buf, sizeof(buf), "%u", s->neigh6reachabletime);
                system_set_neigh6reachabletime(dev, buf);
        }
-       if (s->flags & DEV_OPT_NEIGHLOCKTIME & apply_mask) {
+       if (apply_mask & DEV_OPT_NEIGHLOCKTIME) {
                snprintf(buf, sizeof(buf), "%d", s->neigh4locktime);
                system_set_neigh4locktime(dev, buf);
        }
-       if (s->flags & DEV_OPT_NEIGHGCSTALETIME & apply_mask) {
+       if (apply_mask & DEV_OPT_NEIGHGCSTALETIME) {
                snprintf(buf, sizeof(buf), "%u", s->neigh4gcstaletime);
                system_set_neigh4gcstaletime(dev, buf);
                snprintf(buf, sizeof(buf), "%u", s->neigh6gcstaletime);
                system_set_neigh6gcstaletime(dev, buf);
        }
-       if (s->flags & DEV_OPT_DADTRANSMITS & apply_mask) {
+       if (apply_mask & DEV_OPT_DADTRANSMITS) {
                snprintf(buf, sizeof(buf), "%u", s->dadtransmits);
                system_set_dadtransmits(dev, buf);
        }
-       if (s->flags & DEV_OPT_MULTICAST & apply_mask) {
+       if (apply_mask & DEV_OPT_MULTICAST) {
                if (system_if_flags(dev->ifname, s->multicast ? IFF_MULTICAST : 0,
                                    !s->multicast ? IFF_MULTICAST : 0) < 0)
                        s->flags &= ~DEV_OPT_MULTICAST;
        }
-       if (s->flags & DEV_OPT_SENDREDIRECTS & apply_mask)
+       if (apply_mask & DEV_OPT_SENDREDIRECTS)
                system_set_sendredirects(dev, s->sendredirects ? "1" : "0");
+       if (apply_mask & DEV_OPT_DROP_V4_UNICAST_IN_L2_MULTICAST)
+               system_set_drop_v4_unicast_in_l2_multicast(dev, s->drop_v4_unicast_in_l2_multicast ? "1" : "0");
+       if (apply_mask & DEV_OPT_DROP_V6_UNICAST_IN_L2_MULTICAST)
+               system_set_drop_v6_unicast_in_l2_multicast(dev, s->drop_v6_unicast_in_l2_multicast ? "1" : "0");
+       if (apply_mask & DEV_OPT_DROP_GRATUITOUS_ARP)
+               system_set_drop_gratuitous_arp(dev, s->drop_gratuitous_arp ? "1" : "0");
+       if (apply_mask & DEV_OPT_DROP_UNSOLICITED_NA)
+               system_set_drop_unsolicited_na(dev, s->drop_unsolicited_na ? "1" : "0");
+       if (apply_mask & DEV_OPT_ARP_ACCEPT)
+               system_set_arp_accept(dev, s->arp_accept ? "1" : "0");
+       system_set_ethtool_settings(dev, s);
 }
 
 int system_if_up(struct device *dev)
 {
-       system_if_get_settings(dev, &dev->orig_settings);
-       /* Only keep orig settings based on what needs to be set */
-       dev->orig_settings.valid_flags = dev->orig_settings.flags;
-       dev->orig_settings.flags &= dev->settings.flags;
-       system_if_apply_settings(dev, &dev->settings, dev->settings.flags);
        return system_if_flags(dev->ifname, IFF_UP, 0);
 }
 
 int system_if_down(struct device *dev)
 {
-       int ret = system_if_flags(dev->ifname, 0, IFF_UP);
-       system_if_apply_settings(dev, &dev->orig_settings, dev->orig_settings.flags);
-       return ret;
+       return system_if_flags(dev->ifname, 0, IFF_UP);
 }
 
 struct if_check_data {
@@ -1533,7 +2022,8 @@ static int cb_if_check_valid(struct nl_msg *msg, void *arg)
        if (nh->nlmsg_type != RTM_NEWLINK)
                return NL_SKIP;
 
-       device_set_present(chk->dev, ifi->ifi_index > 0 ? true : false);
+       if (chk->dev->type == &simple_device_type)
+               device_set_present(chk->dev, ifi->ifi_index > 0 ? true : false);
        device_set_link(chk->dev, ifi->ifi_flags & IFF_LOWER_UP ? true : false);
 
        return NL_OK;
@@ -1550,13 +2040,205 @@ static int cb_if_check_error(struct sockaddr_nl *nla, struct nlmsgerr *err, void
 {
        struct if_check_data *chk = (struct if_check_data *)arg;
 
-       device_set_present(chk->dev, false);
+       if (chk->dev->type == &simple_device_type)
+               device_set_present(chk->dev, false);
        device_set_link(chk->dev, false);
        chk->pending = err->error;
 
        return NL_STOP;
 }
 
+struct bridge_vlan_check_data {
+       struct device *check_dev;
+       int ifindex;
+       int ret;
+       bool pending;
+};
+
+static void bridge_vlan_check_port(struct bridge_vlan_check_data *data,
+                                  struct bridge_vlan_port *port,
+                                  struct bridge_vlan_info *vinfo)
+{
+       uint16_t flags = 0, diff, mask;
+
+       if (port->flags & BRVLAN_F_PVID)
+               flags |= BRIDGE_VLAN_INFO_PVID;
+       if (port->flags & BRVLAN_F_UNTAGGED)
+               flags |= BRIDGE_VLAN_INFO_UNTAGGED;
+
+       diff = vinfo->flags ^ flags;
+       mask = BRVLAN_F_UNTAGGED | (flags & BRIDGE_VLAN_INFO_PVID);
+       if (diff & mask) {
+               data->ret = 1;
+               data->pending = false;
+       }
+
+       port->check = 1;
+}
+
+static void bridge_vlan_check_attr(struct bridge_vlan_check_data *data,
+                                  struct rtattr *attr)
+{
+       struct bridge_vlan_hotplug_port *port;
+       struct bridge_vlan_info *vinfo;
+       struct bridge_vlan *vlan;
+       struct rtattr *cur;
+       int rem = RTA_PAYLOAD(attr);
+       int i;
+
+       for (cur = RTA_DATA(attr); RTA_OK(cur, rem); cur = RTA_NEXT(cur, rem)) {
+               if (cur->rta_type != IFLA_BRIDGE_VLAN_INFO)
+                       continue;
+
+               vinfo = RTA_DATA(cur);
+               vlan = vlist_find(&data->check_dev->vlans, &vinfo->vid, vlan, node);
+               if (!vlan) {
+                       data->ret = 1;
+                       data->pending = false;
+                       return;
+               }
+
+               for (i = 0; i < vlan->n_ports; i++)
+                       if (!vlan->ports[i].check)
+                               bridge_vlan_check_port(data, &vlan->ports[i], vinfo);
+
+               list_for_each_entry(port, &vlan->hotplug_ports, list)
+                       if (!port->port.check)
+                               bridge_vlan_check_port(data, &port->port, vinfo);
+       }
+}
+
+static int bridge_vlan_check_cb(struct nl_msg *msg, void *arg)
+{
+       struct bridge_vlan_check_data *data = arg;
+       struct nlmsghdr *nh = nlmsg_hdr(msg);
+       struct ifinfomsg *ifi = NLMSG_DATA(nh);
+       struct rtattr *attr;
+       int rem;
+
+       if (nh->nlmsg_type != RTM_NEWLINK)
+               return NL_SKIP;
+
+       if (ifi->ifi_family != AF_BRIDGE)
+               return NL_SKIP;
+
+       if (ifi->ifi_index != data->ifindex)
+               return NL_SKIP;
+
+       attr = IFLA_RTA(ifi);
+       rem = nh->nlmsg_len - NLMSG_LENGTH(sizeof(*ifi));
+       while (RTA_OK(attr, rem)) {
+               if (attr->rta_type == IFLA_AF_SPEC)
+                       bridge_vlan_check_attr(data, attr);
+
+               attr = RTA_NEXT(attr, rem);
+       }
+
+       return NL_SKIP;
+}
+
+static int bridge_vlan_ack_cb(struct nl_msg *msg, void *arg)
+{
+       struct bridge_vlan_check_data *data = arg;
+       data->pending = false;
+       return NL_STOP;
+}
+
+static int bridge_vlan_error_cb(struct sockaddr_nl *nla, struct nlmsgerr *err, void *arg)
+{
+       struct bridge_vlan_check_data *data = arg;
+       data->pending = false;
+       return NL_STOP;
+}
+
+int system_bridge_vlan_check(struct device *dev, char *ifname)
+{
+       struct bridge_vlan_check_data data = {
+               .check_dev = dev,
+               .ifindex = if_nametoindex(ifname),
+               .ret = -1,
+               .pending = true,
+       };
+       static struct ifinfomsg ifi = {
+               .ifi_family = AF_BRIDGE
+       };
+       static struct rtattr ext_req = {
+               .rta_type = IFLA_EXT_MASK,
+               .rta_len = RTA_LENGTH(sizeof(uint32_t)),
+       };
+       uint32_t filter = RTEXT_FILTER_BRVLAN;
+       struct nl_cb *cb = nl_cb_alloc(NL_CB_DEFAULT);
+       struct bridge_vlan *vlan;
+       struct nl_msg *msg;
+       int i;
+
+       if (!data.ifindex)
+               return 0;
+
+       msg = nlmsg_alloc_simple(RTM_GETLINK, NLM_F_DUMP);
+
+       if (nlmsg_append(msg, &ifi, sizeof(ifi), 0) ||
+               nlmsg_append(msg, &ext_req, sizeof(ext_req), NLMSG_ALIGNTO) ||
+               nlmsg_append(msg, &filter, sizeof(filter), 0))
+               goto free;
+
+       vlist_for_each_element(&dev->vlans, vlan, node) {
+               struct bridge_vlan_hotplug_port *port;
+
+               for (i = 0; i < vlan->n_ports; i++) {
+                       if (!strcmp(vlan->ports[i].ifname, ifname))
+                               vlan->ports[i].check = 0;
+                       else
+                               vlan->ports[i].check = -1;
+               }
+
+               list_for_each_entry(port, &vlan->hotplug_ports, list) {
+                       if (!strcmp(port->port.ifname, ifname))
+                               port->port.check = 0;
+                       else
+                               port->port.check = -1;
+               }
+       }
+
+       nl_cb_set(cb, NL_CB_VALID, NL_CB_CUSTOM, bridge_vlan_check_cb, &data);
+       nl_cb_set(cb, NL_CB_FINISH, NL_CB_CUSTOM, bridge_vlan_ack_cb, &data);
+       nl_cb_set(cb, NL_CB_ACK, NL_CB_CUSTOM, bridge_vlan_ack_cb, &data);
+       nl_cb_err(cb, NL_CB_CUSTOM, bridge_vlan_error_cb, &data);
+
+       if (nl_send_auto_complete(sock_rtnl, msg) < 0)
+               goto free;
+
+       data.ret = 0;
+       while (data.pending)
+               nl_recvmsgs(sock_rtnl, cb);
+
+       vlist_for_each_element(&dev->vlans, vlan, node) {
+               struct bridge_vlan_hotplug_port *port;
+
+               for (i = 0; i < vlan->n_ports; i++) {
+                       if (!vlan->ports[i].check) {
+                               data.ret = 1;
+                               break;
+                       }
+               }
+
+               list_for_each_entry(port, &vlan->hotplug_ports, list) {
+                       if (!port->port.check) {
+                               data.ret = 1;
+                               break;
+                       }
+               }
+       }
+
+       goto out;
+
+free:
+       nlmsg_free(msg);
+out:
+       nl_cb_put(cb);
+       return data.ret;
+}
+
 int system_if_check(struct device *dev)
 {
        struct nl_cb *cb = nl_cb_alloc(NL_CB_DEFAULT);
@@ -1586,7 +2268,10 @@ int system_if_check(struct device *dev)
        nl_cb_set(cb, NL_CB_ACK, NL_CB_CUSTOM, cb_if_check_ack, &chk);
        nl_cb_err(cb, NL_CB_CUSTOM, cb_if_check_error, &chk);
 
-       nl_send_auto_complete(sock_rtnl, msg);
+       ret = nl_send_auto_complete(sock_rtnl, msg);
+       if (ret < 0)
+               goto free;
+
        while (chk.pending > 0)
                nl_recvmsgs(sock_rtnl, cb);
 
@@ -1603,21 +2288,11 @@ struct device *
 system_if_get_parent(struct device *dev)
 {
        char buf[64], *devname;
-       int ifindex, iflink, len;
-       FILE *f;
-
-       snprintf(buf, sizeof(buf), "/sys/class/net/%s/iflink", dev->ifname);
-       f = fopen(buf, "r");
-       if (!f)
-               return NULL;
-
-       len = fread(buf, 1, sizeof(buf) - 1, f);
-       fclose(f);
+       int ifindex, iflink;
 
-       if (len <= 0)
+       if (system_get_dev_sysfs("iflink", dev->ifname, buf, sizeof(buf)) < 0)
                return NULL;
 
-       buf[len] = 0;
        iflink = strtoul(buf, NULL, 0);
        ifindex = system_if_resolve(dev);
        if (!iflink || iflink == ifindex)
@@ -1679,12 +2354,29 @@ static const struct {
        uint32_t mask;
        const char *name;
 } ethtool_link_modes[] = {
-       { ADVERTISED_10baseT_Half, "10H" },
-       { ADVERTISED_10baseT_Full, "10F" },
-       { ADVERTISED_100baseT_Half, "100H" },
-       { ADVERTISED_100baseT_Full, "100F" },
-       { ADVERTISED_1000baseT_Half, "1000H" },
-       { ADVERTISED_1000baseT_Full, "1000F" },
+       { ADVERTISED_10baseT_Half, "10baseT-H" },
+       { ADVERTISED_10baseT_Full, "10baseT-F" },
+       { ADVERTISED_100baseT_Half, "100baseT-H" },
+       { ADVERTISED_100baseT_Full, "100baseT-F" },
+       { ADVERTISED_1000baseT_Half, "1000baseT-H" },
+       { ADVERTISED_1000baseT_Full, "1000baseT-F" },
+       { ADVERTISED_1000baseKX_Full, "1000baseKX-F" },
+       { ADVERTISED_2500baseX_Full, "2500baseX-F" },
+       { ADVERTISED_10000baseT_Full, "10000baseT-F" },
+       { ADVERTISED_10000baseKX4_Full, "10000baseKX4-F" },
+       { ADVERTISED_10000baseKR_Full, "10000baseKR-F" },
+       { ADVERTISED_20000baseMLD2_Full, "20000baseMLD2-F" },
+       { ADVERTISED_20000baseKR2_Full, "20000baseKR2-F" },
+       { ADVERTISED_40000baseKR4_Full, "40000baseKR4-F" },
+       { ADVERTISED_40000baseCR4_Full, "40000baseCR4-F" },
+       { ADVERTISED_40000baseSR4_Full, "40000baseSR4-F" },
+       { ADVERTISED_40000baseLR4_Full, "40000baseLR4-F" },
+#ifdef ADVERTISED_56000baseKR4_Full
+       { ADVERTISED_56000baseKR4_Full, "56000baseKR4-F" },
+       { ADVERTISED_56000baseCR4_Full, "56000baseCR4-F" },
+       { ADVERTISED_56000baseSR4_Full, "56000baseSR4-F" },
+       { ADVERTISED_56000baseLR4_Full, "56000baseLR4-F" },
+#endif
 };
 
 static void system_add_link_modes(struct blob_buf *b, __u32 mask)
@@ -1699,11 +2391,9 @@ static void system_add_link_modes(struct blob_buf *b, __u32 mask)
 bool
 system_if_force_external(const char *ifname)
 {
-       char buf[64];
        struct stat s;
 
-       snprintf(buf, sizeof(buf), "/sys/class/net/%s/phy80211", ifname);
-       return stat(buf, &s) == 0;
+       return stat(dev_sysfs_path(ifname, "phy80211"), &s) == 0;
 }
 
 int
@@ -1716,7 +2406,7 @@ system_if_dump_info(struct device *dev, struct blob_buf *b)
 
        memset(&ecmd, 0, sizeof(ecmd));
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name));
+       strncpy(ifr.ifr_name, dev->ifname, sizeof(ifr.ifr_name) - 1);
        ifr.ifr_data = (caddr_t) &ecmd;
        ecmd.cmd = ETHTOOL_GSET;
 
@@ -1725,6 +2415,10 @@ system_if_dump_info(struct device *dev, struct blob_buf *b)
                system_add_link_modes(b, ecmd.advertising);
                blobmsg_close_array(b, c);
 
+               c = blobmsg_open_array(b, "link-partner-advertising");
+               system_add_link_modes(b, ecmd.lp_advertising);
+               blobmsg_close_array(b, c);
+
                c = blobmsg_open_array(b, "link-supported");
                system_add_link_modes(b, ecmd.supported);
                blobmsg_close_array(b, c);
@@ -1733,6 +2427,8 @@ system_if_dump_info(struct device *dev, struct blob_buf *b)
                snprintf(s, 8, "%d%c", ethtool_cmd_speed(&ecmd),
                        ecmd.duplex == DUPLEX_HALF ? 'H' : 'F');
                blobmsg_add_string_buffer(b);
+
+               blobmsg_add_u8(b, "autoneg", !!ecmd.autoneg);
        }
 
        return 0;
@@ -1751,13 +2447,11 @@ system_if_dump_stats(struct device *dev, struct blob_buf *b)
                "rx_errors",      "tx_bytes",          "tx_window_errors",
                "rx_fifo_errors", "tx_carrier_errors",
        };
-       char buf[64];
        int stats_dir;
        int i;
        uint64_t val = 0;
 
-       snprintf(buf, sizeof(buf), "/sys/class/net/%s/statistics", dev->ifname);
-       stats_dir = open(buf, O_DIRECTORY);
+       stats_dir = open(dev_sysfs_path(dev->ifname, "statistics"), O_DIRECTORY);
        if (stats_dir < 0)
                return -1;
 
@@ -1840,6 +2534,46 @@ int system_del_address(struct device *dev, struct device_addr *addr)
        return system_addr(dev, addr, RTM_DELADDR);
 }
 
+static int system_neigh(struct device *dev, struct device_neighbor *neighbor, int cmd)
+{
+       int alen = ((neighbor->flags & DEVADDR_FAMILY) == DEVADDR_INET4) ? 4 : 16;
+       unsigned int flags = 0;
+       struct ndmsg ndm = {
+               .ndm_family = (alen == 4) ? AF_INET : AF_INET6,
+               .ndm_ifindex = dev->ifindex,
+               .ndm_state = NUD_PERMANENT,
+               .ndm_flags = (neighbor->proxy ? NTF_PROXY : 0) | (neighbor->router ? NTF_ROUTER : 0),
+       };
+       struct nl_msg *msg;
+
+       if (cmd == RTM_NEWNEIGH)
+               flags |= NLM_F_CREATE | NLM_F_REPLACE;
+
+       msg = nlmsg_alloc_simple(cmd, flags);
+
+       if (!msg)
+               return -1;
+
+       nlmsg_append(msg, &ndm, sizeof(ndm), 0);
+
+       nla_put(msg, NDA_DST, alen, &neighbor->addr);
+       if (neighbor->flags & DEVNEIGH_MAC)
+               nla_put(msg, NDA_LLADDR, sizeof(neighbor->macaddr), &neighbor->macaddr);
+
+
+       return system_rtnl_call(msg);
+}
+
+int system_add_neighbor(struct device *dev, struct device_neighbor *neighbor)
+{
+       return system_neigh(dev, neighbor, RTM_NEWNEIGH);
+}
+
+int system_del_neighbor(struct device *dev, struct device_neighbor *neighbor)
+{
+       return system_neigh(dev, neighbor, RTM_DELNEIGH);
+}
+
 static int system_rt(struct device *dev, struct device_route *route, int cmd)
 {
        int alen = ((route->flags & DEVADDR_FAMILY) == DEVADDR_INET4) ? 4 : 16;
@@ -1872,7 +2606,7 @@ static int system_rt(struct device *dev, struct device_route *route, int cmd)
        if (cmd == RTM_NEWROUTE) {
                flags |= NLM_F_CREATE | NLM_F_REPLACE;
 
-               if (!dev) { // Add null-route
+               if (!dev) { /* Add null-route */
                        rtm.rtm_scope = RT_SCOPE_UNIVERSE;
                        rtm.rtm_type = RTN_UNREACHABLE;
                }
@@ -1959,14 +2693,12 @@ int system_del_route(struct device *dev, struct device_route *route)
 
 int system_flush_routes(void)
 {
-       const char *names[] = {
-               "/proc/sys/net/ipv4/route/flush",
-               "/proc/sys/net/ipv6/route/flush"
-       };
+       const char *names[] = { "ipv4", "ipv6" };
        int fd, i;
 
        for (i = 0; i < ARRAY_SIZE(names); i++) {
-               fd = open(names[i], O_WRONLY);
+               snprintf(dev_buf, sizeof(dev_buf), "%s/sys/net/%s/route/flush", proc_path, names[i]);
+               fd = open(dev_buf, O_WRONLY);
                if (fd < 0)
                        continue;
 
@@ -2234,7 +2966,7 @@ time_t system_get_rtime(void)
        struct timespec ts;
        struct timeval tv;
 
-       if (syscall(__NR_clock_gettime, CLOCK_MONOTONIC, &ts) == 0)
+       if (clock_gettime(CLOCK_MONOTONIC, &ts) == 0)
                return ts.tv_sec;
 
        if (gettimeofday(&tv, NULL) == 0)
@@ -2252,7 +2984,7 @@ static int tunnel_ioctl(const char *name, int cmd, void *p)
        struct ifreq ifr;
 
        memset(&ifr, 0, sizeof(ifr));
-       strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name));
+       strncpy(ifr.ifr_name, name, sizeof(ifr.ifr_name) - 1);
        ifr.ifr_ifru.ifru_data = p;
        return ioctl(sock_ioctl, cmd, &ifr);
 }
@@ -2297,7 +3029,6 @@ static int system_add_ip6_tunnel(const char *name, const unsigned int link,
 
        nla_put_u8(nlm, IFLA_IPTUN_PROTO, IPPROTO_IPIP);
        nla_put_u8(nlm, IFLA_IPTUN_TTL, (ttl) ? ttl : 64);
-       nla_put_u8(nlm, IFLA_IPTUN_ENCAP_LIMIT, 4);
 
        struct in6_addr in6buf;
        if ((cur = tb[TUNNEL_ATTR_LOCAL])) {
@@ -2316,26 +3047,42 @@ static int system_add_ip6_tunnel(const char *name, const unsigned int link,
                nla_put(nlm, IFLA_IPTUN_REMOTE, sizeof(in6buf), &in6buf);
        }
 
-#ifdef IFLA_IPTUN_FMR_MAX
        if ((cur = tb[TUNNEL_ATTR_DATA])) {
-               struct blob_attr *dcur;
-               unsigned drem, fmrcnt = 0;
-               struct nlattr *fmrs = nla_nest_start(nlm, IFLA_IPTUN_FMRS);
+               struct blob_attr *tb_data[__IPIP6_DATA_ATTR_MAX];
+               uint32_t tun_flags = IP6_TNL_F_IGN_ENCAP_LIMIT;
 
-               if (!fmrs) {
-                       ret = -ENOMEM;
-                       goto failure;
-               }
+               blobmsg_parse(ipip6_data_attr_list.params, __IPIP6_DATA_ATTR_MAX, tb_data,
+                       blobmsg_data(cur), blobmsg_len(cur));
 
-               blobmsg_for_each_attr(dcur, cur, drem) {
-                       if (blobmsg_type(dcur) != BLOBMSG_TYPE_ARRAY ||
-                                       strcmp(blobmsg_name(dcur), "fmrs") ||
-                                       blobmsg_check_array(dcur, BLOBMSG_TYPE_UNSPEC) <= 0)
-                               continue;
+               if ((cur = tb_data[IPIP6_DATA_ENCAPLIMIT])) {
+                       char *str = blobmsg_get_string(cur);
+
+                       if (strcmp(str, "ignore")) {
+                               char *e;
+                               unsigned encap_limit = strtoul(str, &e, 0);
 
+                               if (e == str || *e || encap_limit > 255) {
+                                       ret = -EINVAL;
+                                       goto failure;
+                               }
+
+                               nla_put_u8(nlm, IFLA_IPTUN_ENCAP_LIMIT, encap_limit);
+                               tun_flags &= ~IP6_TNL_F_IGN_ENCAP_LIMIT;
+                       }
+               }
+
+#ifdef IFLA_IPTUN_FMR_MAX
+               if ((cur = tb_data[IPIP6_DATA_FMRS])) {
                        struct blob_attr *rcur;
-                       unsigned rrem;
-                       blobmsg_for_each_attr(rcur, dcur, rrem) {
+                       unsigned rrem, fmrcnt = 0;
+                       struct nlattr *fmrs = nla_nest_start(nlm, IFLA_IPTUN_FMRS);
+
+                       if (!fmrs) {
+                               ret = -ENOMEM;
+                               goto failure;
+                       }
+
+                       blobmsg_for_each_attr(rcur, cur, rrem) {
                                struct blob_attr *tb_fmr[__FMR_DATA_ATTR_MAX], *tb_cur;
                                struct in6_addr ip6prefix;
                                struct in_addr ip4prefix;
@@ -2387,10 +3134,13 @@ static int system_add_ip6_tunnel(const char *name, const unsigned int link,
 
                                nla_nest_end(nlm, rule);
                        }
+
+                       nla_nest_end(nlm, fmrs);
                }
-               nla_nest_end(nlm, fmrs);
-       }
 #endif
+               if (tun_flags)
+                       nla_put_u32(nlm, IFLA_IPTUN_FLAGS, tun_flags);
+       }
 
        nla_nest_end(nlm, infodata);
        nla_nest_end(nlm, linkinfo);
@@ -2411,10 +3161,11 @@ static int system_add_gre_tunnel(const char *name, const char *kind,
        struct nl_msg *nlm;
        struct ifinfomsg ifi = { .ifi_family = AF_UNSPEC, };
        struct blob_attr *cur;
-       uint32_t ikey = 0, okey = 0, flags = 0, flowinfo = 0;
+       uint32_t ikey = 0, okey = 0, flowinfo = 0, flags6 = IP6_TNL_F_IGN_ENCAP_LIMIT;
        uint16_t iflags = 0, oflags = 0;
        uint8_t tos = 0;
        int ret = 0, ttl = 0;
+       unsigned encap_limit = 0;
 
        nlm = nlmsg_alloc_simple(RTM_NEWLINK, NLM_F_REQUEST | NLM_F_REPLACE | NLM_F_CREATE);
        if (!nlm)
@@ -2458,7 +3209,7 @@ static int system_add_gre_tunnel(const char *name, const char *kind,
                                tos = uval;
                } else {
                        if (v6)
-                               flags |= IP6_TNL_F_USE_ORIG_TCLASS;
+                               flags6 |= IP6_TNL_F_USE_ORIG_TCLASS;
                        else
                                tos = 1;
                }
@@ -2495,10 +3246,27 @@ static int system_add_gre_tunnel(const char *name, const char *kind,
                                iflags |= GRE_SEQ;
                }
 
-               if ((cur = tb[GRE_DATA_OSEQNO])) {
+               if ((cur = tb_data[GRE_DATA_OSEQNO])) {
                        if (blobmsg_get_bool(cur))
                                oflags |= GRE_SEQ;
                }
+
+               if ((cur = tb_data[GRE_DATA_ENCAPLIMIT])) {
+                       char *str = blobmsg_get_string(cur);
+
+                       if (strcmp(str, "ignore")) {
+                               char *e;
+
+                               encap_limit = strtoul(str, &e, 0);
+
+                               if (e == str || *e || encap_limit > 255) {
+                                       ret = -EINVAL;
+                                       goto failure;
+                               }
+
+                               flags6 &= ~IP6_TNL_F_IGN_ENCAP_LIMIT;
+                       }
+               }
        }
 
        if (v6) {
@@ -2518,13 +3286,15 @@ static int system_add_gre_tunnel(const char *name, const char *kind,
                        }
                        nla_put(nlm, IFLA_GRE_REMOTE, sizeof(in6buf), &in6buf);
                }
-               nla_put_u8(nlm, IFLA_GRE_ENCAP_LIMIT, 4);
+
+               if (!(flags6 & IP6_TNL_F_IGN_ENCAP_LIMIT))
+                       nla_put_u8(nlm, IFLA_GRE_ENCAP_LIMIT, encap_limit);
 
                if (flowinfo)
                        nla_put_u32(nlm, IFLA_GRE_FLOWINFO, flowinfo);
 
-               if (flags)
-                       nla_put_u32(nlm, IFLA_GRE_FLAGS, flags);
+               if (flags6)
+                       nla_put_u32(nlm, IFLA_GRE_FLAGS, flags6);
 
                if (!ttl)
                        ttl = 64;
@@ -2703,7 +3473,79 @@ failure:
 }
 #endif
 
+#ifdef IFLA_XFRM_MAX
+static int system_add_xfrm_tunnel(const char *name, const char *kind,
+                                const unsigned int link, struct blob_attr **tb)
+{
+       struct nl_msg *nlm;
+       struct ifinfomsg ifi = { .ifi_family = AF_UNSPEC, };
+       struct blob_attr *cur;
+       int ret = 0;
+
+       nlm = nlmsg_alloc_simple(RTM_NEWLINK, NLM_F_REQUEST | NLM_F_REPLACE | NLM_F_CREATE);
+       if (!nlm)
+               return -1;
+
+       nlmsg_append(nlm, &ifi, sizeof(ifi), 0);
+       nla_put_string(nlm, IFLA_IFNAME, name);
+
+       struct nlattr *linkinfo = nla_nest_start(nlm, IFLA_LINKINFO);
+       if (!linkinfo) {
+               ret = -ENOMEM;
+               goto failure;
+       }
+
+       nla_put_string(nlm, IFLA_INFO_KIND, kind);
+       struct nlattr *infodata = nla_nest_start(nlm, IFLA_INFO_DATA);
+       if (!infodata) {
+               ret = -ENOMEM;
+               goto failure;
+       }
+
+       if (link)
+               nla_put_u32(nlm, IFLA_XFRM_LINK, link);
+
+       if ((cur = tb[TUNNEL_ATTR_DATA])) {
+               struct blob_attr *tb_data[__XFRM_DATA_ATTR_MAX];
+               uint32_t if_id = 0;
+
+               blobmsg_parse(xfrm_data_attr_list.params, __XFRM_DATA_ATTR_MAX, tb_data,
+                       blobmsg_data(cur), blobmsg_len(cur));
+
+               if ((cur = tb_data[XFRM_DATA_IF_ID])) {
+                       if ((if_id = blobmsg_get_u32(cur)))
+                               nla_put_u32(nlm, IFLA_XFRM_IF_ID, if_id);
+               }
+
+       }
+
+       nla_nest_end(nlm, infodata);
+       nla_nest_end(nlm, linkinfo);
+
+       return system_rtnl_call(nlm);
+
+failure:
+       nlmsg_free(nlm);
+       return ret;
+}
+#endif
+
 #ifdef IFLA_VXLAN_MAX
+static void system_vxlan_map_bool_attr(struct nl_msg *msg, struct blob_attr **tb_data, int attrtype, int vxlandatatype, bool invert) {
+       struct blob_attr *cur;
+       if ((cur = tb_data[vxlandatatype])) {
+               bool val = blobmsg_get_bool(cur);
+               if (invert)
+                       val = !val;
+
+               if ((attrtype == IFLA_VXLAN_GBP) && val)
+                       nla_put_flag(msg, attrtype);
+               else 
+                       nla_put_u8(msg, attrtype, val);
+
+       }
+}
+
 static int system_add_vxlan(const char *name, const unsigned int link, struct blob_attr **tb, bool v6)
 {
        struct blob_attr *tb_data[__VXLAN_DATA_ATTR_MAX];
@@ -2815,15 +3657,50 @@ static int system_add_vxlan(const char *name, const unsigned int link, struct bl
        }
        nla_put_u16(msg, IFLA_VXLAN_PORT, htons(port));
 
-       if ((cur = tb_data[VXLAN_DATA_ATTR_RXCSUM])) {
-               bool rxcsum = blobmsg_get_bool(cur);
-               nla_put_u8(msg, IFLA_VXLAN_UDP_ZERO_CSUM6_RX, !rxcsum);
+       if ((cur = tb_data[VXLAN_DATA_ATTR_SRCPORTMIN])) {
+               struct ifla_vxlan_port_range srcports = {0,0};
+
+               uint32_t low = blobmsg_get_u32(cur);
+               if (low < 1 || low > 65535 - 1) {
+                       ret = -EINVAL;
+                       goto failure;
+               }
+
+               srcports.low = htons((uint16_t) low);
+               srcports.high = htons((uint16_t) (low+1));
+
+               if ((cur = tb_data[VXLAN_DATA_ATTR_SRCPORTMAX])) {
+                       uint32_t high = blobmsg_get_u32(cur);
+                       if (high < 1 || high > 65535) {
+                               ret = -EINVAL;
+                               goto failure;
+                       }
+
+                       if (high > low)
+                               srcports.high = htons((uint16_t) high);
+               }
+
+               nla_put(msg, IFLA_VXLAN_PORT_RANGE, sizeof(srcports), &srcports);
+       }
+
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_UDP_CSUM, VXLAN_DATA_ATTR_TXCSUM, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_UDP_ZERO_CSUM6_RX, VXLAN_DATA_ATTR_RXCSUM, true);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_UDP_ZERO_CSUM6_TX, VXLAN_DATA_ATTR_TXCSUM, true);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_LEARNING, VXLAN_DATA_ATTR_LEARNING, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_RSC , VXLAN_DATA_ATTR_RSC, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_PROXY , VXLAN_DATA_ATTR_PROXY, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_L2MISS , VXLAN_DATA_ATTR_L2MISS, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_L3MISS , VXLAN_DATA_ATTR_L3MISS, false);
+       system_vxlan_map_bool_attr(msg, tb_data, IFLA_VXLAN_GBP , VXLAN_DATA_ATTR_GBP, false);
+
+       if ((cur = tb_data[VXLAN_DATA_ATTR_AGEING])) {
+               uint32_t ageing = blobmsg_get_u32(cur);
+               nla_put_u32(msg, IFLA_VXLAN_AGEING, ageing);
        }
 
-       if ((cur = tb_data[VXLAN_DATA_ATTR_TXCSUM])) {
-               bool txcsum = blobmsg_get_bool(cur);
-               nla_put_u8(msg, IFLA_VXLAN_UDP_CSUM, txcsum);
-               nla_put_u8(msg, IFLA_VXLAN_UDP_ZERO_CSUM6_TX, !txcsum);
+       if ((cur = tb_data[VXLAN_DATA_ATTR_LIMIT])) {
+               uint32_t maxaddress = blobmsg_get_u32(cur);
+               nla_put_u32(msg, IFLA_VXLAN_LIMIT, maxaddress);
        }
 
        if ((cur = tb[TUNNEL_ATTR_TOS])) {
@@ -2963,7 +3840,7 @@ static int system_add_proto_tunnel(const char *name, const uint8_t proto, const
        if (p.iph.ttl && p.iph.frag_off == 0)
                return -EINVAL;
 
-       strncpy(p.name, name, sizeof(p.name));
+       strncpy(p.name, name, sizeof(p.name) - 1);
 
        switch (p.iph.protocol) {
        case IPPROTO_IPIP:
@@ -2988,7 +3865,8 @@ static int __system_del_ip_tunnel(const char *name, struct blob_attr **tb)
        if (!strcmp(str, "greip") || !strcmp(str, "gretapip") ||
            !strcmp(str, "greip6") || !strcmp(str, "gretapip6") ||
            !strcmp(str, "vtiip") || !strcmp(str, "vtiip6") ||
-           !strcmp(str, "vxlan") || !strcmp(str, "vxlan6"))
+           !strcmp(str, "vxlan") || !strcmp(str, "vxlan6") ||
+           !strcmp(str, "xfrm"))
                return system_link_del(name);
        else
                return tunnel_ioctl(name, SIOCDELTUNNEL, NULL);
@@ -3010,10 +3888,7 @@ int system_update_ipv6_mtu(struct device *dev, int mtu)
        char buf[64];
        int fd;
 
-       snprintf(buf, sizeof(buf), "/proc/sys/net/ipv6/conf/%s/mtu",
-                       dev->ifname);
-
-       fd = open(buf, O_RDWR);
+       fd = open(dev_sysctl_path("ipv6/conf", dev->ifname, "mtu"), O_RDWR);
        if (fd < 0)
                return ret;
 
@@ -3085,6 +3960,10 @@ int system_add_ip_tunnel(const char *name, struct blob_attr *attr)
        } else if (!strcmp(str, "vtiip6")) {
                return system_add_vti_tunnel(name, "vti6", link, tb, true);
 #endif
+#ifdef IFLA_XFRM_MAX
+       } else if (!strcmp(str, "xfrm")) {
+               return system_add_xfrm_tunnel(name, "xfrm", link, tb);
+#endif
 #ifdef IFLA_VXLAN_MAX
        } else if(!strcmp(str, "vxlan")) {
                return system_add_vxlan(name, link, tb, false);