config: set RFC defaults for preferred lifetime
[project/odhcpd.git] / src / ubus.c
index 6af591185de511a58a237d76214d6dce062d94cd..45b29a4e6459d86d46a6d6f2cd7961ab552fcd51 100644 (file)
@@ -4,6 +4,8 @@
 #include <netinet/in.h>
 #include <arpa/inet.h>
 
+#include <libubox/utils.h>
+
 #include "odhcpd.h"
 #include "dhcpv6.h"
 #include "dhcpv4.h"
@@ -26,14 +28,14 @@ static int handle_dhcpv4_leases(struct ubus_context *ctx, _unused struct ubus_ob
        blob_buf_init(&b, 0);
        a = blobmsg_open_table(&b, "device");
 
-       list_for_each_entry(iface, &interfaces, head) {
-               if (iface->dhcpv4 != MODE_SERVER || iface->dhcpv4_assignments.next == NULL)
+       avl_for_each_element(&interfaces, iface, avl) {
+               if (iface->dhcpv4 != MODE_SERVER)
                        continue;
 
                void *i = blobmsg_open_table(&b, iface->ifname);
                void *j = blobmsg_open_array(&b, "leases");
 
-               struct dhcpv4_assignment *c;
+               struct dhcp_assignment *c;
                list_for_each_entry(c, &iface->dhcpv4_assignments, head) {
                        if (!INFINITE_VALID(c->valid_until) && c->valid_until < now)
                                continue;
@@ -47,15 +49,28 @@ static int handle_dhcpv4_leases(struct ubus_context *ctx, _unused struct ubus_ob
                        blobmsg_add_string(&b, "hostname", (c->hostname) ? c->hostname : "");
                        blobmsg_add_u8(&b, "accept-reconf-nonce", c->accept_fr_nonce);
 
+                       if (c->reqopts) {
+                               int opt = 0;
+                               int chars = 0;
+                               buf = blobmsg_alloc_string_buffer(&b, "reqopts", strlen(c->reqopts) * 4 + 1);
+                               for(; c->reqopts[opt]; opt++)
+                                       chars += snprintf(buf + chars, 6, "%u,", (uint8_t)c->reqopts[opt]);
+                               buf[chars - 1] = '\0';
+                               blobmsg_add_string_buffer(&b);
+                       }
+
                        m = blobmsg_open_array(&b, "flags");
                        if (c->flags & OAF_BOUND)
                                blobmsg_add_string(&b, NULL, "bound");
 
                        if (c->flags & OAF_STATIC)
                                blobmsg_add_string(&b, NULL, "static");
+
+                       if (c->flags & OAF_BROKEN_HOSTNAME)
+                               blobmsg_add_string(&b, NULL, "broken-hostname");
                        blobmsg_close_array(&b, m);
 
-                       buf = blobmsg_alloc_string_buffer(&b, "ip", INET_ADDRSTRLEN);
+                       buf = blobmsg_alloc_string_buffer(&b, "address", INET_ADDRSTRLEN);
                        struct in_addr addr = {.s_addr = c->addr};
                        inet_ntop(AF_INET, &addr, buf, INET_ADDRSTRLEN);
                        blobmsg_add_string_buffer(&b);
@@ -80,7 +95,7 @@ static void dhcpv6_blobmsg_ia_addr(struct in6_addr *addr, int prefix, uint32_t p
                                        uint32_t valid, _unused void *arg)
 {
        void *a = blobmsg_open_table(&b, NULL);
-       char *buf = blobmsg_alloc_string_buffer(&b, NULL, INET6_ADDRSTRLEN);
+       char *buf = blobmsg_alloc_string_buffer(&b, "address", INET6_ADDRSTRLEN);
 
        inet_ntop(AF_INET6, addr, buf, INET6_ADDRSTRLEN);
        blobmsg_add_string_buffer(&b);
@@ -106,15 +121,15 @@ static int handle_dhcpv6_leases(_unused struct ubus_context *ctx, _unused struct
        blob_buf_init(&b, 0);
        a = blobmsg_open_table(&b, "device");
 
-       list_for_each_entry(iface, &interfaces, head) {
-               if (iface->dhcpv6 != MODE_SERVER || iface->ia_assignments.next == NULL)
+       avl_for_each_element(&interfaces, iface, avl) {
+               if (iface->dhcpv6 != MODE_SERVER)
                        continue;
 
                void *i = blobmsg_open_table(&b, iface->ifname);
                void *j = blobmsg_open_array(&b, "leases");
 
-               struct dhcpv6_assignment *a, *border = list_last_entry(
-                               &iface->ia_assignments, struct dhcpv6_assignment, head);
+               struct dhcp_assignment *a, *border = list_last_entry(
+                               &iface->ia_assignments, struct dhcp_assignment, head);
 
                list_for_each_entry(a, &iface->ia_assignments, head) {
                        if (a == border || (!INFINITE_VALID(a->valid_until) &&
@@ -130,7 +145,10 @@ static int handle_dhcpv6_leases(_unused struct ubus_context *ctx, _unused struct
                        blobmsg_add_u32(&b, "iaid", ntohl(a->iaid));
                        blobmsg_add_string(&b, "hostname", (a->hostname) ? a->hostname : "");
                        blobmsg_add_u8(&b, "accept-reconf", a->accept_reconf);
-                       blobmsg_add_u32(&b, "assigned", a->assigned);
+                       if (a->flags & OAF_DHCPV6_NA)
+                               blobmsg_add_u64(&b, "assigned", a->assigned_host_id);
+                       else
+                               blobmsg_add_u16(&b, "assigned", a->assigned_subnet_id);
 
                        m = blobmsg_open_array(&b, "flags");
                        if (a->flags & OAF_BOUND)
@@ -140,8 +158,8 @@ static int handle_dhcpv6_leases(_unused struct ubus_context *ctx, _unused struct
                                blobmsg_add_string(&b, NULL, "static");
                        blobmsg_close_array(&b, m);
 
-                       m = blobmsg_open_array(&b, a->length == 128 ? "ipv6-addr": "ipv6-prefix");
-                       dhcpv6_enum_ia_addrs(iface, a, now, dhcpv6_blobmsg_ia_addr, NULL);
+                       m = blobmsg_open_array(&b, a->flags & OAF_DHCPV6_NA ? "ipv6-addr": "ipv6-prefix");
+                       dhcpv6_ia_enum_addrs(iface, a, now, dhcpv6_blobmsg_ia_addr, NULL);
                        blobmsg_close_table(&b, m);
 
                        blobmsg_add_u32(&b, "valid", INFINITE_VALID(a->valid_until) ?
@@ -159,10 +177,20 @@ static int handle_dhcpv6_leases(_unused struct ubus_context *ctx, _unused struct
        return 0;
 }
 
+static int handle_add_lease(_unused struct ubus_context *ctx, _unused struct ubus_object *obj,
+               _unused struct ubus_request_data *req, _unused const char *method,
+               struct blob_attr *msg)
+{
+       if (!set_lease_from_blobmsg(msg))
+               return UBUS_STATUS_OK;
+
+       return UBUS_STATUS_INVALID_ARGUMENT;
+}
 
 static struct ubus_method main_object_methods[] = {
        {.name = "ipv4leases", .handler = handle_dhcpv4_leases},
        {.name = "ipv6leases", .handler = handle_dhcpv6_leases},
+       UBUS_METHOD("add_lease", handle_add_lease, lease_attrs),
 };
 
 static struct ubus_object_type main_object_type =
@@ -225,7 +253,9 @@ static void update_netifd(bool subscribe)
                ubus_subscribe(ubus, &netifd, objid);
 
        ubus_abort_request(ubus, &req_dump);
-       if (!ubus_invoke_async(ubus, objid, "dump", NULL, &req_dump)) {
+       blob_buf_init(&b, 0);
+
+       if (!ubus_invoke_async(ubus, objid, "dump", b.head, &req_dump)) {
                req_dump.data_cb = handle_dump;
                ubus_complete_request_async(ubus, &req_dump);
        }
@@ -237,22 +267,23 @@ static int handle_update(_unused struct ubus_context *ctx, _unused struct ubus_o
                struct blob_attr *msg)
 {
        struct blob_attr *tb[IFACE_ATTR_MAX];
-       blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, blob_data(msg), blob_len(msg));
+       struct interface *c;
+       bool update = true;
 
+       blobmsg_parse(iface_attrs, IFACE_ATTR_MAX, tb, blob_data(msg), blob_len(msg));
        const char *interface = (tb[IFACE_ATTR_INTERFACE]) ?
                        blobmsg_get_string(tb[IFACE_ATTR_INTERFACE]) : "";
-       const char *ifname = (tb[IFACE_ATTR_IFNAME]) ?
-                       blobmsg_get_string(tb[IFACE_ATTR_IFNAME]) : "";
 
-       struct interface *c, *iface = NULL;
-       list_for_each_entry(c, &interfaces, head)
-               if (!strcmp(interface, c->name) || !strcmp(ifname, c->ifname))
-                       iface = c;
+       avl_for_each_element(&interfaces, c, avl) {
+               if (!strcmp(interface, c->name) && c->ignore) {
+                       update = false;
+                       break;
+               }
+       }
 
-       if (iface && iface->ignore)
-               return 0;
+       if (update)
+               update_netifd(false);
 
-       update_netifd(false);
        return 0;
 }
 
@@ -274,15 +305,13 @@ void ubus_apply_network(void)
 
                const char *interface = (tb[IFACE_ATTR_INTERFACE]) ?
                                blobmsg_get_string(tb[IFACE_ATTR_INTERFACE]) : "";
-               const char *ifname = (tb[IFACE_ATTR_IFNAME]) ?
-                               blobmsg_get_string(tb[IFACE_ATTR_IFNAME]) : "";
 
                bool matched = false;
-               struct interface *c, *n;
-               list_for_each_entry_safe(c, n, &interfaces, head) {
+               struct interface *c, *tmp;
+               avl_for_each_element_safe(&interfaces, c, avl, tmp) {
                        char *f = memmem(c->upstream, c->upstream_len,
                                        interface, strlen(interface) + 1);
-                       bool cmatched = !strcmp(interface, c->name) || !strcmp(ifname, c->ifname);
+                       bool cmatched = !strcmp(interface, c->name);
                        matched |= cmatched;
 
                        if (!cmatched && (!c->upstream_len || !f || (f != c->upstream && f[-1] != 0)))