ra: align ifindex resolving
[project/odhcp6c.git] / src / ra.c
index 299762e57bcb0247fe88bf1baa6f755c84f37962..32a30973736b032ec258be75234352a18130836f 100644 (file)
--- a/src/ra.c
+++ b/src/ra.c
@@ -13,6 +13,7 @@
  *
  */
 
+#include <errno.h>
 #include <fcntl.h>
 #include <stdio.h>
 #include <signal.h>
@@ -26,6 +27,7 @@
 
 #include <net/if.h>
 #include <arpa/inet.h>
+#include <sys/ioctl.h>
 #include <sys/socket.h>
 #include <sys/types.h>
 #include <netinet/in.h>
@@ -57,6 +59,10 @@ static volatile int rs_attempt = 0;
 static struct in6_addr lladdr = IN6ADDR_ANY_INIT;
 static unsigned int ra_options = 0;
 static unsigned int ra_holdoff_interval = 0;
+static int ra_hoplimit = 0;
+static int ra_mtu = 0;
+static int ra_reachable = 0;
+static int ra_retransmit = 0;
 
 struct {
        struct icmp6_hdr hdr;
@@ -71,33 +77,41 @@ static void ra_send_rs(int signal __attribute__((unused)));
 int ra_init(const char *ifname, const struct in6_addr *ifid,
                unsigned int options, unsigned int holdoff_interval)
 {
+       struct ifreq ifr;
+
        ra_options = options;
        ra_holdoff_interval = holdoff_interval;
 
        const pid_t ourpid = getpid();
        sock = socket(AF_INET6, SOCK_RAW | SOCK_CLOEXEC, IPPROTO_ICMPV6);
        if (sock < 0)
-               return -1;
+               goto failure;
 
-       if_index = if_nametoindex(ifname);
-       if (!if_index)
-               return -1;
+       memset(&ifr, 0, sizeof(ifr));
+       strncpy(ifr.ifr_name, ifname, sizeof(ifr.ifr_name) - 1);
+       if (ioctl(sock, SIOCGIFINDEX, &ifr) < 0)
+               goto failure;
 
-       strncpy(if_name, ifname, sizeof(if_name) - 1);
+       if_index = ifr.ifr_ifindex;
        lladdr = *ifid;
 
        rtnl = socket(AF_NETLINK, SOCK_DGRAM | SOCK_CLOEXEC, NETLINK_ROUTE);
        if (rtnl < 0)
-               return -1;
+               goto failure;
 
        struct sockaddr_nl rtnl_kernel = { .nl_family = AF_NETLINK };
        if (connect(rtnl, (const struct sockaddr*)&rtnl_kernel, sizeof(rtnl_kernel)) < 0)
-               return -1;
+               goto failure;
 
        int val = RTNLGRP_LINK;
-       setsockopt(rtnl, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &val, sizeof(val));
-       fcntl(rtnl, F_SETOWN, ourpid);
-       fcntl(rtnl, F_SETFL, fcntl(sock, F_GETFL) | O_ASYNC);
+       if (setsockopt(rtnl, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &val, sizeof(val)) < 0)
+               goto failure;
+
+       if (fcntl(rtnl, F_SETOWN, ourpid) < 0)
+               goto failure;
+
+       if (fcntl(rtnl, F_SETFL, fcntl(sock, F_GETFL) | O_ASYNC) < 0)
+               goto failure;
 
        struct {
                struct nlmsghdr hdr;
@@ -106,43 +120,67 @@ int ra_init(const char *ifname, const struct in6_addr *ifid,
                .hdr = {sizeof(req), RTM_GETLINK, NLM_F_REQUEST, 1, 0},
                .ifi = {.ifi_index = if_index}
        };
-       send(rtnl, &req, sizeof(req), 0);
+       if (send(rtnl, &req, sizeof(req), 0) < 0)
+               goto failure;
+
        ra_link_up();
 
        // Filter ICMPv6 package types
        struct icmp6_filter filt;
        ICMP6_FILTER_SETBLOCKALL(&filt);
        ICMP6_FILTER_SETPASS(ND_ROUTER_ADVERT, &filt);
-       setsockopt(sock, IPPROTO_ICMPV6, ICMP6_FILTER, &filt, sizeof(filt));
+       if (setsockopt(sock, IPPROTO_ICMPV6, ICMP6_FILTER, &filt, sizeof(filt)) < 0)
+               goto failure;
 
        // Bind to all-nodes
        struct ipv6_mreq an = {ALL_IPV6_NODES, if_index};
-       setsockopt(sock, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &an, sizeof(an));
+       if (setsockopt(sock, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &an, sizeof(an)) < 0)
+               goto failure;
 
        // Let the kernel compute our checksums
        val = 2;
-       setsockopt(sock, IPPROTO_RAW, IPV6_CHECKSUM, &val, sizeof(val));
+       if (setsockopt(sock, IPPROTO_RAW, IPV6_CHECKSUM, &val, sizeof(val)) < 0)
+               goto failure;
 
        // This is required by RFC 4861
        val = 255;
-       setsockopt(sock, IPPROTO_IPV6, IPV6_MULTICAST_HOPS, &val, sizeof(val));
+       if (setsockopt(sock, IPPROTO_IPV6, IPV6_MULTICAST_HOPS, &val, sizeof(val)) < 0)
+               goto failure;
 
        // Receive multicast hops
        val = 1;
-       setsockopt(sock, IPPROTO_IPV6, IPV6_RECVHOPLIMIT, &val, sizeof(val));
+       if (setsockopt(sock, IPPROTO_IPV6, IPV6_RECVHOPLIMIT, &val, sizeof(val)) < 0)
+               goto failure;
 
        // Bind to one device
-       setsockopt(sock, SOL_SOCKET, SO_BINDTODEVICE, ifname, strlen(ifname));
+       if (setsockopt(sock, SOL_SOCKET, SO_BINDTODEVICE, ifname, strlen(ifname)) < 0)
+               goto failure;
 
        // Add async-mode
-       fcntl(sock, F_SETOWN, ourpid);
-       fcntl(sock, F_SETFL, fcntl(sock, F_GETFL) | O_ASYNC);
+       if (fcntl(sock, F_SETOWN, ourpid) < 0)
+               goto failure;
+
+       val = fcntl(sock, F_GETFL);
+       if (val < 0)
+               goto failure;
+
+       if (fcntl(sock, F_SETFL, val | O_ASYNC) < 0)
+               goto failure;
 
        // Send RS
        signal(SIGALRM, ra_send_rs);
        ra_send_rs(SIGALRM);
 
        return 0;
+
+failure:
+       if (sock >= 0)
+               close(sock);
+
+       if (rtnl >= 0)
+               close(rtnl);
+
+       return -1;
 }
 
 static void ra_send_rs(int signal __attribute__((unused)))
@@ -156,7 +194,8 @@ static void ra_send_rs(int signal __attribute__((unused)))
        else
                len = sizeof(struct icmp6_hdr);
 
-       sendto(sock, &rs, len, MSG_DONTWAIT, (struct sockaddr*)&dest, sizeof(dest));
+       if (sendto(sock, &rs, len, MSG_DONTWAIT, (struct sockaddr*)&dest, sizeof(dest)) < 0)
+               syslog(LOG_ERR, "Failed to send RS (%s)",  strerror(errno));
 
        if (++rs_attempt <= 3)
                alarm(4);
@@ -241,44 +280,64 @@ static bool ra_icmpv6_valid(struct sockaddr_in6 *source, int hlim, uint8_t *data
        return opt == end;
 }
 
-int ra_conf_hoplimit(int newvalue)
+static bool ra_set_hoplimit(int val)
 {
-       static int value = 0;
-
-       if (newvalue > 0)
-               value = newvalue;
+       if (val > 0 && val != ra_hoplimit) {
+               ra_hoplimit = val;
+               return true;
+       }
 
-       return value;
+       return false;
 }
 
-int ra_conf_mtu(int newvalue)
+static bool ra_set_mtu(int val)
 {
-       static int value = 0;
+       if (val >= 1280 && val <= 65535 && ra_mtu != val) {
+               ra_mtu = val;
+               return true;
+       }
+
+       return false;
+}
 
-       if (newvalue >= 1280 && newvalue <= 65535)
-               value = newvalue;
+static bool ra_set_reachable(int val)
+{
+       if (val > 0 && val <= 3600000 && ra_reachable != val) {
+               ra_reachable = val;
+               return true;
+       }
 
-       return value;
+       return false;
 }
 
-int ra_conf_reachable(int newvalue)
+static bool ra_set_retransmit(int val)
 {
-       static int value = 0;
+       if (val > 0 && val <= 60000 && ra_retransmit != val) {
+               ra_retransmit = val;
+               return true;
+       }
 
-       if (newvalue > 0 && newvalue <= 3600000)
-               value = newvalue;
+       return false;
+}
 
-       return value;
+int ra_get_hoplimit(void)
+{
+       return ra_hoplimit;
 }
 
-int ra_conf_retransmit(int newvalue)
+int ra_get_mtu(void)
 {
-       static int value = 0;
+       return ra_mtu;
+}
 
-       if (newvalue > 0 && newvalue <= 60000)
-               value = newvalue;
+int ra_get_reachable(void)
+{
+       return ra_reachable;
+}
 
-       return value;
+int ra_get_retransmit(void)
+{
+       return ra_retransmit;
 }
 
 bool ra_process(void)
@@ -301,11 +360,13 @@ bool ra_process(void)
                socklen_t alen = sizeof(addr);
                int sock = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6);
 
-               if (!connect(sock, (struct sockaddr*)&addr, sizeof(addr)) &&
-                               !getsockname(sock, (struct sockaddr*)&addr, &alen))
-                       lladdr = addr.sin6_addr;
+               if (sock >= 0) {
+                       if (!connect(sock, (struct sockaddr*)&addr, sizeof(addr)) &&
+                                       !getsockname(sock, (struct sockaddr*)&addr, &alen))
+                               lladdr = addr.sin6_addr;
 
-               close(sock);
+                       close(sock);
+               }
        }
 
        while (true) {
@@ -320,6 +381,9 @@ bool ra_process(void)
                        .msg_controllen = sizeof(cmsg_buf),
                        .msg_flags = 0
                };
+               struct icmpv6_opt *opt;
+               uint32_t router_valid;
+               int hlim = 0;
 
                ssize_t len = recvmsg(sock, &msg, MSG_DONTWAIT);
                if (len <= 0)
@@ -328,7 +392,6 @@ bool ra_process(void)
                if (IN6_IS_ADDR_UNSPECIFIED(&lladdr))
                        continue;
 
-               int hlim = 0;
                for (struct cmsghdr *ch = CMSG_FIRSTHDR(&msg); ch != NULL;
                                ch = CMSG_NXTHDR(&msg, ch))
                        if (ch->cmsg_level == IPPROTO_IPV6 &&
@@ -338,17 +401,24 @@ bool ra_process(void)
                if (!ra_icmpv6_valid(&from, hlim, buf, len))
                        continue;
 
-               // Stop sending solicits
-               if (rs_attempt > 0) {
-                       alarm(0);
-                       rs_attempt = 0;
-               }
-
                if (!found) {
                        odhcp6c_expire();
                        found = true;
                }
-               uint32_t router_valid = ntohs(adv->nd_ra_router_lifetime);
+
+               router_valid = ntohs(adv->nd_ra_router_lifetime);
+
+               /* RFC4861 ยง6.3.7
+                * Once the host sends a Router Solicitation, and receives a valid
+                * Router Advertisement with a non-zero Router Lifetime, the host MUST
+                * desist from sending additional solicitations on that interface
+                * Moreover, a host SHOULD send at least one solicitation in the case
+                * where an advertisement is received prior to having sent a solicitation.
+                */
+               if (rs_attempt > 0 && router_valid > 0) {
+                       alarm(0);
+                       rs_attempt = 0;
+               }
 
                // Parse default route
                entry->target = any;
@@ -364,28 +434,38 @@ bool ra_process(void)
                                                0, ra_holdoff_interval);
 
                // Parse hoplimit
-               ra_conf_hoplimit(adv->nd_ra_curhoplimit);
+               changed |= ra_set_hoplimit(adv->nd_ra_curhoplimit);
 
                // Parse ND parameters
-               ra_conf_reachable(ntohl(adv->nd_ra_reachable));
-               ra_conf_retransmit(ntohl(adv->nd_ra_retransmit));
+               changed |= ra_set_reachable(ntohl(adv->nd_ra_reachable));
+               changed |= ra_set_retransmit(ntohl(adv->nd_ra_retransmit));
 
                // Evaluate options
-               struct icmpv6_opt *opt;
                icmpv6_for_each_option(opt, &adv[1], &buf[len]) {
                        if (opt->type == ND_OPT_MTU) {
                                uint32_t *mtu = (uint32_t*)&opt->data[2];
-                               ra_conf_mtu(ntohl(*mtu));
+                               changed |= ra_set_mtu(ntohl(*mtu));
                        } else if (opt->type == ND_OPT_ROUTE_INFORMATION && opt->len <= 3) {
+                               struct icmpv6_opt_route_info *ri = (struct icmpv6_opt_route_info *)opt;
+
+                               if (ri->prefix_len > 128) {
+                                       continue;
+                               } else if (ri->prefix_len > 64) {
+                                       if (ri->len < 2)
+                                               continue;
+                               } else if (ri->prefix_len > 0) {
+                                       if (ri->len < 1)
+                                               continue;
+                               }
+
                                entry->router = from.sin6_addr;
                                entry->target = any;
-                               entry->priority = pref_to_priority(opt->data[1]);
-                               entry->length = opt->data[0];
-                               uint32_t *valid = (uint32_t*)&opt->data[2];
-                               entry->valid = ntohl(*valid);
-                               memcpy(&entry->target, &opt->data[6], (opt->len - 1) * 8);
+                               entry->priority = pref_to_priority(ri->flags);
+                               entry->length = ri->prefix_len;
+                               entry->valid = ntohl(ri->lifetime);
+                               memcpy(&entry->target, ri->prefix, (ri->len - 1) * 8);
 
-                               if (entry->length > 128 || IN6_IS_ADDR_LINKLOCAL(&entry->target)
+                               if (IN6_IS_ADDR_LINKLOCAL(&entry->target)
                                                || IN6_IS_ADDR_LOOPBACK(&entry->target)
                                                || IN6_IS_ADDR_MULTICAST(&entry->target))
                                        continue;