ubusd: fix tx_queue linked list usage

[project/ubus.git] / libubus-req.c

diff --git a/libubus-req.c b/libubus-req.c
index 4eda383e90e850259fdc86e459d48f46f307d086..ae9d1925ecdf1845f5d536b50240216f9ef56fb4 100644 (file)
--- a/libubus-req.c
+++ b/libubus-req.c
@@ -31,7 +31,7 @@ static void req_data_cb(struct ubus_request *req, int type, struct blob_attr *da
        if (!req->data_cb)
                return;
 
-       attr = ubus_parse_msg(data);
+       attr = ubus_parse_msg(data, blob_raw_len(data));
        if (!attr[UBUS_ATTR_DATA])
                return;
 
@@ -40,11 +40,9 @@ static void req_data_cb(struct ubus_request *req, int type, struct blob_attr *da
 
 static void __ubus_process_req_data(struct ubus_request *req)
 {
-       struct ubus_pending_data *data;
+       struct ubus_pending_data *data, *tmp;
 
-       while (!list_empty(&req->pending)) {
-               data = list_first_entry(&req->pending,
-                       struct ubus_pending_data, list);
+       list_for_each_entry_safe(data, tmp, &req->pending, list) {
                list_del(&data->list);
                if (!req->cancelled)
                        req_data_cb(req, data->type, data->data);
@@ -196,6 +194,14 @@ void ubus_complete_deferred_request(struct ubus_context *ctx, struct ubus_reques
        ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_STATUS, req->peer, req->fd);
 }
 
+static void ubus_put_data(struct blob_buf *buf, struct blob_attr *msg)
+{
+       if (msg)
+               blob_put(buf, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
+       else
+               blob_put(buf, UBUS_ATTR_DATA, NULL, 0);
+}
+
 int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
                    struct blob_attr *msg)
 {
@@ -203,7 +209,7 @@ int ubus_send_reply(struct ubus_context *ctx, struct ubus_request_data *req,
 
        blob_buf_init(&b, 0);
        blob_put_int32(&b, UBUS_ATTR_OBJID, req->object);
-       blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
+       ubus_put_data(&b, msg);
        ret = ubus_send_msg(ctx, req->seq, b.head, UBUS_MSG_DATA, req->peer, -1);
        if (ret < 0)
                return UBUS_STATUS_NO_DATA;
@@ -218,8 +224,7 @@ int ubus_invoke_async_fd(struct ubus_context *ctx, uint32_t obj,
        blob_buf_init(&b, 0);
        blob_put_int32(&b, UBUS_ATTR_OBJID, obj);
        blob_put_string(&b, UBUS_ATTR_METHOD, method);
-       if (msg)
-               blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
+       ubus_put_data(&b, msg);
 
        memset(req, 0, sizeof(*req));
        req->fd = fd;
@@ -278,13 +283,11 @@ __ubus_notify_async(struct ubus_context *ctx, struct ubus_object *obj,
        blob_buf_init(&b, 0);
        blob_put_int32(&b, UBUS_ATTR_OBJID, obj->id);
        blob_put_string(&b, UBUS_ATTR_METHOD, type);
+       ubus_put_data(&b, msg);
 
        if (!reply)
                blob_put_int8(&b, UBUS_ATTR_NO_REPLY, true);
 
-       if (msg)
-               blob_put(&b, UBUS_ATTR_DATA, blob_data(msg), blob_len(msg));
-
        if (ubus_start_request(ctx, &req->req, b.head, UBUS_MSG_NOTIFY, obj->id) < 0)
                return UBUS_STATUS_INVALID_ARGUMENT;
 
@@ -325,7 +328,7 @@ int ubus_notify(struct ubus_context *ctx, struct ubus_object *obj,
 
 static bool ubus_get_status(struct ubus_msghdr_buf *buf, int *ret)
 {
-       struct blob_attr **attrbuf = ubus_parse_msg(buf->data);
+       struct blob_attr **attrbuf = ubus_parse_msg(buf->data, blob_raw_len(buf->data));
 
        if (!attrbuf[UBUS_ATTR_STATUS])
                return false;
@@ -423,7 +426,8 @@ static void ubus_process_notify_status(struct ubus_request *req, int id, struct
        struct ubus_notify_request *nreq;
        struct blob_attr **tb;
        struct blob_attr *cur;
-       int rem, idx = 1;
+       size_t rem;
+       int idx = 1;
        int ret = 0;
 
        nreq = container_of(req, struct ubus_notify_request, req);
@@ -431,7 +435,7 @@ static void ubus_process_notify_status(struct ubus_request *req, int id, struct
 
        if (!id) {
                /* first id: ubusd's status message with a list of ids */
-               tb = ubus_parse_msg(buf->data);
+               tb = ubus_parse_msg(buf->data, blob_raw_len(buf->data));
                if (tb[UBUS_ATTR_SUBSCRIBERS]) {
                        blob_for_each_attr(cur, tb[UBUS_ATTR_SUBSCRIBERS], rem) {
                                if (!blob_check_type(blob_data(cur), blob_len(cur), BLOB_ATTR_INT32))