target/linux/generic/backport-5.15/791-v6.2-02-net-phy-fix-yt8521-duplicated-argument-to-or.patch

   1 From 4e0243e7128c9b25ea2739136076a95d6adaba5e Mon Sep 17 00:00:00 2001
   2 From: Frank <Frank.Sae@motor-comm.com>
   3 Date: Fri, 4 Nov 2022 16:44:41 +0800
   4 Subject: [PATCH] net: phy: fix yt8521 duplicated argument to & or |
   5
   6 cocci warnings: (new ones prefixed by >>)
   7 >> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or |
   8   drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or |
   9   drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or |
  10   drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or |
  11
  12  The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx.
  13
  14 Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy")
  15 Reported-by: kernel test robot <lkp@intel.com>
  16 Reported-by: Julia Lawall <julia.lawall@lip6.fr>
  17 Signed-off-by: Frank <Frank.Sae@motor-comm.com>
  18 Reviewed-by: Andrew Lunn <andrew@lunn.ch>
  19 Signed-off-by: David S. Miller <davem@davemloft.net>
  20 ---
  21  drivers/net/phy/motorcomm.c | 8 ++++----
  22  1 file changed, 4 insertions(+), 4 deletions(-)
  23
  24 --- a/drivers/net/phy/motorcomm.c
  25 +++ b/drivers/net/phy/motorcomm.c
  26 @@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy
  27
  28         switch (phydev->interface) {
  29         case PHY_INTERFACE_MODE_RGMII:
  30 -               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
  31 +               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
  32                 val |= YT8521_RC1R_RX_DELAY_DIS;
  33                 break;
  34         case PHY_INTERFACE_MODE_RGMII_RXID:
  35 -               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
  36 +               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
  37                 val |= YT8521_RC1R_RX_DELAY_EN;
  38                 break;
  39         case PHY_INTERFACE_MODE_RGMII_TXID:
  40 -               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
  41 +               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
  42                 val |= YT8521_RC1R_RX_DELAY_DIS;
  43                 break;
  44         case PHY_INTERFACE_MODE_RGMII_ID:
  45 -               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
  46 +               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
  47                 val |= YT8521_RC1R_RX_DELAY_EN;
  48                 break;
  49         case PHY_INTERFACE_MODE_SGMII: