ath9k: fix several issues in the tx queueing rework
[openwrt/openwrt.git] / package / kernel / mac80211 / patches / 571-ath9k_tid_fairness.patch
1 --- a/drivers/net/wireless/ath/ath9k/xmit.c
2 +++ b/drivers/net/wireless/ath/ath9k/xmit.c
3 @@ -1317,8 +1317,8 @@ ath_tx_form_burst(struct ath_softc *sc,
4 } while (1);
5 }
6
7 -static void ath_tx_sched_aggr(struct ath_softc *sc, struct ath_txq *txq,
8 - struct ath_atx_tid *tid)
9 +static bool ath_tx_sched_aggr(struct ath_softc *sc, struct ath_txq *txq,
10 + struct ath_atx_tid *tid, bool *stop)
11 {
12 struct ath_buf *bf;
13 struct ieee80211_tx_info *tx_info;
14 @@ -1327,40 +1327,39 @@ static void ath_tx_sched_aggr(struct ath
15 int aggr_len = 0;
16 bool aggr, last = true;
17
18 - do {
19 - if (!ath_tid_has_buffered(tid))
20 - return;
21 -
22 - INIT_LIST_HEAD(&bf_q);
23 -
24 - bf = ath_tx_get_tid_subframe(sc, txq, tid, &tid_q);
25 - if (!bf)
26 - break;
27 + if (!ath_tid_has_buffered(tid))
28 + return false;
29
30 - tx_info = IEEE80211_SKB_CB(bf->bf_mpdu);
31 - aggr = !!(tx_info->flags & IEEE80211_TX_CTL_AMPDU);
32 - if ((aggr && txq->axq_ampdu_depth >= ATH_AGGR_MIN_QDEPTH) ||
33 - (!aggr && txq->axq_depth >= ATH_NON_AGGR_MIN_QDEPTH))
34 - break;
35 + INIT_LIST_HEAD(&bf_q);
36
37 - ath_set_rates(tid->an->vif, tid->an->sta, bf);
38 - if (aggr)
39 - last = ath_tx_form_aggr(sc, txq, tid, &bf_q, bf,
40 - tid_q, &aggr_len);
41 - else
42 - ath_tx_form_burst(sc, txq, tid, &bf_q, bf, tid_q);
43 + bf = ath_tx_get_tid_subframe(sc, txq, tid, &tid_q);
44 + if (!bf)
45 + return false;
46 +
47 + tx_info = IEEE80211_SKB_CB(bf->bf_mpdu);
48 + aggr = !!(tx_info->flags & IEEE80211_TX_CTL_AMPDU);
49 + if ((aggr && txq->axq_ampdu_depth >= ATH_AGGR_MIN_QDEPTH) ||
50 + (!aggr && txq->axq_depth >= ATH_NON_AGGR_MIN_QDEPTH))
51 + return false;
52 +
53 + ath_set_rates(tid->an->vif, tid->an->sta, bf);
54 + if (aggr)
55 + last = ath_tx_form_aggr(sc, txq, tid, &bf_q, bf,
56 + tid_q, &aggr_len);
57 + else
58 + ath_tx_form_burst(sc, txq, tid, &bf_q, bf, tid_q);
59
60 - if (list_empty(&bf_q))
61 - return;
62 + if (list_empty(&bf_q))
63 + return false;
64
65 - if (tid->ac->clear_ps_filter) {
66 - tid->ac->clear_ps_filter = false;
67 - tx_info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
68 - }
69 + if (tid->ac->clear_ps_filter) {
70 + tid->ac->clear_ps_filter = false;
71 + tx_info->flags |= IEEE80211_TX_CTL_CLEAR_PS_FILT;
72 + }
73
74 - ath_tx_fill_desc(sc, bf, txq, aggr_len);
75 - ath_tx_txqaddbuf(sc, txq, &bf_q, false);
76 - } while (!last);
77 + ath_tx_fill_desc(sc, bf, txq, aggr_len);
78 + ath_tx_txqaddbuf(sc, txq, &bf_q, false);
79 + return true;
80 }
81
82 int ath_tx_aggr_start(struct ath_softc *sc, struct ieee80211_sta *sta,
83 @@ -1796,8 +1795,9 @@ void ath_tx_cleanupq(struct ath_softc *s
84 */
85 void ath_txq_schedule(struct ath_softc *sc, struct ath_txq *txq)
86 {
87 - struct ath_atx_ac *ac, *ac_tmp, *last_ac;
88 + struct ath_atx_ac *ac, *last_ac;
89 struct ath_atx_tid *tid, *last_tid;
90 + bool sent = false;
91
92 if (test_bit(SC_OP_HW_RESET, &sc->sc_flags) ||
93 list_empty(&txq->axq_acq) ||
94 @@ -1806,15 +1806,17 @@ void ath_txq_schedule(struct ath_softc *
95
96 rcu_read_lock();
97
98 - ac = list_first_entry(&txq->axq_acq, struct ath_atx_ac, list);
99 last_ac = list_entry(txq->axq_acq.prev, struct ath_atx_ac, list);
100 + while (!list_empty(&txq->axq_acq)) {
101 + bool stop = false;
102
103 - list_for_each_entry_safe(ac, ac_tmp, &txq->axq_acq, list) {
104 + ac = list_first_entry(&txq->axq_acq, struct ath_atx_ac, list);
105 last_tid = list_entry(ac->tid_q.prev, struct ath_atx_tid, list);
106 list_del(&ac->list);
107 ac->sched = false;
108
109 while (!list_empty(&ac->tid_q)) {
110 +
111 tid = list_first_entry(&ac->tid_q, struct ath_atx_tid,
112 list);
113 list_del(&tid->list);
114 @@ -1823,7 +1825,8 @@ void ath_txq_schedule(struct ath_softc *
115 if (tid->paused)
116 continue;
117
118 - ath_tx_sched_aggr(sc, txq, tid);
119 + if (ath_tx_sched_aggr(sc, txq, tid, &stop))
120 + sent = true;
121
122 /*
123 * add tid to round-robin queue if more frames
124 @@ -1832,8 +1835,7 @@ void ath_txq_schedule(struct ath_softc *
125 if (ath_tid_has_buffered(tid))
126 ath_tx_queue_tid(txq, tid);
127
128 - if (tid == last_tid ||
129 - txq->axq_ampdu_depth >= ATH_AGGR_MIN_QDEPTH)
130 + if (stop || tid == last_tid)
131 break;
132 }
133
134 @@ -1842,9 +1844,17 @@ void ath_txq_schedule(struct ath_softc *
135 list_add_tail(&ac->list, &txq->axq_acq);
136 }
137
138 - if (ac == last_ac ||
139 - txq->axq_ampdu_depth >= ATH_AGGR_MIN_QDEPTH)
140 + if (stop)
141 break;
142 +
143 + if (ac == last_ac) {
144 + if (!sent)
145 + break;
146 +
147 + sent = false;
148 + last_ac = list_entry(txq->axq_acq.prev,
149 + struct ath_atx_ac, list);
150 + }
151 }
152
153 rcu_read_unlock();