From 1fa034c65cb64deba51f0be993e5d3194ce4b0fc Mon Sep 17 00:00:00 2001 From: =?utf8?q?Petr=20=C5=A0tetiar?= Date: Tue, 13 Oct 2020 15:18:44 +0200 Subject: [PATCH] interface: fix value stored to 'fd' is never read MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes following issue reported by clang-12 static analyzer: mdnsd/interface.c:360:3: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ mdnsd/interface.c:394:3: warning: Value stored to 'fd' is never read fd = -1; ^ ~~ Original author most likely wanted to assing -1 to the original interface filedescriptor. Signed-off-by: Petr Å tetiar --- interface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/interface.c b/interface.c index d3f2ad3..690e857 100644 --- a/interface.c +++ b/interface.c @@ -357,7 +357,7 @@ interface_mcast_setup4(struct interface *iface) if (setsockopt(fd, IPPROTO_IP, IP_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); - fd = -1; + iface->fd.fd = -1; return -1; } @@ -391,7 +391,7 @@ interface_socket_setup6(struct interface *iface) if (setsockopt(fd, IPPROTO_IPV6, IPV6_ADD_MEMBERSHIP, &mreq, sizeof(mreq)) < 0) { fprintf(stderr, "failed to join multicast group: %m\n"); close(fd); - fd = -1; + iface->fd.fd = -1; return -1; } -- 2.30.2