From f73d42f0e951e71eae12ecac29b75b05ac543f5e Mon Sep 17 00:00:00 2001 From: Baptiste Jonglez Date: Tue, 25 Aug 2020 01:00:31 +0200 Subject: [PATCH] download: purge cached packages that have incorrect checksum Before using a package from the cache, verify its size and checksum against a package index, and delete the package from the cache if they don't match. The install process will then proceed to download the "fixed" package as usual. This allows to cope with remote packages that are rebuilt while keeping the same version number as packages in the local cache. With this change, any outdated package in the local cache will be purged and the new version will be downloaded instead. This is mostly useful when running opkg on the host (e.g. in the imagebuilder). When running on a device, no cache is configured by default, so this change does nothing in that case. Fixes: FS#2690 Signed-off-by: Baptiste Jonglez --- libopkg/opkg_download.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/libopkg/opkg_download.c b/libopkg/opkg_download.c index cfe8e68..59123d2 100644 --- a/libopkg/opkg_download.c +++ b/libopkg/opkg_download.c @@ -263,6 +263,8 @@ int opkg_download_pkg(pkg_t * pkg, const char *dir) char *stripped_filename; char *urlencoded_path; char *filename; + char *cache_name; + char *cache_location; if (pkg->src == NULL) { opkg_msg(ERROR, @@ -296,6 +298,23 @@ int opkg_download_pkg(pkg_t * pkg, const char *dir) sprintf_alloc(&local_filename, "%s/%s", dir, stripped_filename); pkg_set_string(pkg, PKG_LOCAL_FILENAME, local_filename); + /* Invalidate/remove cached package if it has an incorrect checksum. */ + if (conf->cache) { + cache_name = get_cache_filename(local_filename); + sprintf_alloc(&cache_location, "%s/%s", conf->cache, cache_name); + free(cache_name); + if (file_exists(cache_location)) { + err = opkg_verify_integrity(pkg, cache_location); + if (err) { + opkg_msg(NOTICE, + "Removing %s from cache because it has incorrect checksum.\n", + pkg->name); + unlink(cache_location); + } + } + free(cache_location); + } + err = opkg_download_cache(url, local_filename); free(url); -- 2.30.2