From: Paul Donald <newtwen+github@gmail.com>
Date: Sun, 7 Apr 2024 01:30:56 +0000 (+0200)
Subject: luci-mod-network: follow-up fix for 723507231566b61750e32284b49acdae0d0162d3
X-Git-Url: http://git.openwrt.org/openwrt/feeds.git?a=commitdiff_plain;h=7fa789a13a4b834b86c32eff108819aa336446e1;p=project%2Fluci.git

luci-mod-network: follow-up fix for 723507231566b61750e32284b49acdae0d0162d3

add a null-check before parsing networks
loop through available networks on all interfaces except loopback

Closes #7047

Signed-off-by: Paul Donald <newtwen+github@gmail.com>
---

diff --git a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
index b826ccb094..8825b5201c 100644
--- a/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
+++ b/modules/luci-mod-network/htdocs/luci-static/resources/view/network/interfaces.js
@@ -996,15 +996,19 @@ return view.extend({
 					for(var x of uci.get('system', 'ntp', 'server') || '') {
 						so.value(x);
 					}
-					var lan_net = this.networks.filter(function(n) { return n.getName() == 'lan' })[0];
-					// If ntpd is set up, suggest our IP(v6) also
-					if(uci.get('system', 'ntp', 'enable_server')) {
-						lan_net.getIPAddrs().forEach(function(i4) {
-							so.value(i4.split('/')[0]);
-						});
-						lan_net.getIP6Addrs().forEach(function(i6) {
-							so.value(i6.split('/')[0]);
-						});
+					var local_nets = this.networks.filter(function(n) { return n.getName() != 'loopback' });
+					if(local_nets) {
+						// If ntpd is set up, suggest our IP(v6) also
+						if(uci.get('system', 'ntp', 'enable_server')) {
+							local_nets.forEach(function(n){
+								n.getIPAddrs().forEach(function(i4) {
+									so.value(i4.split('/')[0]);
+								});
+								n.getIP6Addrs().forEach(function(i6) {
+									so.value(i6.split('/')[0]);
+								});
+							});
+						}
 					}
 					so.optional = true;
 					so.rmempty = true;