.github/pull_request_template.md

   1 <!--
   2
   3 Thank you for your contribution to the luci repository.
   4
   5 Please read this before creating your PR.
   6
   7 Review https://github.com/openwrt/luci/blob/master/CONTRIBUTING.md
   8 especially if this is your first time to contribute to this repo.
   9
  10 MUST NOT:
  11 - add a PR from your *main* branch - put it on a separate branch
  12 - add merge commits to your PR: rebase locally and force-push
  13
  14 MUST:
  15 - increment any PKG_VERSION in the affected Makefile
  16 - set to draft if this PR depends on other PRs to e.g. openwrt/openwrt
  17 - each commit subject line starts with '<package name>: title'
  18 - each commit has a valid `Signed-off-by: ` (S.O.B.) with a reachable email
  19         * Forgot? `git commit --amend ; git push -f`
  20         * Tip: use `git commit --signoff`
  21
  22 MAY:
  23 - your S.O.B. *may* be a nickname
  24 - delete the below *optional* entries that do not apply
  25 - skip a `<package name>: title` first line subject if the commit is house-keeping or chore
  26
  27 -->
  28
  29 - [ ] This PR is not from my *main* or *master* branch :poop:, but a *separate* branch :white_check_mark:
  30 - [ ] Each commit has a valid :black_nib: `Signed-off-by: <my@email.address>` row (via `git commit --signoff`)
  31 - [ ] Each commit and PR title has a valid :memo: `<package name>: title` first line subject for packages
  32 - [ ] Incremented :up: any `PKG_VERSION` in the Makefile
  33 - [ ] Tested on: (architecture, openwrt version, browser) :white_check_mark:
  34 - [ ] \( Preferred ) Mention: @ the original code author for feedback
  35 - [ ] \( Preferred ) Screenshot or mp4 of changes:
  36 - [ ] \( Optional ) Closes: e.g. openwrt/luci#issue-number
  37 - [ ] \( Optional ) Depends on: e.g. openwrt/packages#pr-number in sister repo
  38 - [ ] Description: (describe the changes proposed in this PR)